- 19 Aug, 2019 40 commits
-
-
Francois Doray authored
The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1679434 was reverted because of failures on test end on Mac OS 10.11. This CL simply disables that check on Mac, so we can benefit from process priority check on other platforms ASAP. See diff: https://chromium-review.googlesource.com/c/chromium/src/+/1760873/2..3/base/test/test_suite.cc This CL verifies that a test process is not backgrounded when it is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931721). Bug: 931721 Change-Id: Ib60d728c960f84026c84f24395d38847c1941573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760873Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688201}
-
Yaron Friedman authored
Bo knows this code and the only client is content/renderer/input. Input folks ought to be better reviewers Change-Id: Ie5b0042378eb38cb08e7f29a6ec4c20f2f4cc3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758657 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688200}
-
Anna Malova authored
Bug: 994758 Change-Id: Ic4d82f03ec8b0cb7cc19b4e5981f154d19c37334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758082Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#688199}
-
Xi Han authored
This is a follow up CL for https://crrev.com/c/1758500. In this CL, caching the native flags is called when native is loaded in ServiceManager only mode, including: - ServiceManagerForDownload - ServiceManagerForBackgroundPrefetch Bug: 984559,995355 Change-Id: I51b00b3be048dc6ec377eeef0f81bbc0ce4e9023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759682 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688198}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8133374cb7fe..4935770daa8e git log 8133374cb7fe..4935770daa8e --date=short --no-merges --format='%ad %ae %s' 2019-08-19 tsepez@chromium.org Initialize widget handlers from topmost fpdfsdk. 2019-08-19 tsepez@chromium.org Avoid casting to CPDFXFA_Context just to get form type. Created with: gclient setdep -r src/third_party/pdfium@4935770daa8e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I8bd5c37c009f066f76e1d50c714f56964372c6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688197}
-
Ben Mason authored
This reverts commit 2b751bd7. Reason for revert: Crash on launch Original change's description: > JNI refactor: @NativeMethods conversion (//chrome/android/features). > > To create this change: > * cd chrome/android/features > * base/android/jni_generator/jni_refactorer.py -R --nonstatic > * base/android/jni_generator/jni_refactorer.py -R > * Change the native side of VrShellDelegateJni#recordVrStartAction > to not pass the Java object > > Bug: 929661 > Change-Id: I1d2c57e0f7a30a8b7e50e9e3ce905172cbb761cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749737 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687674} TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 929661 Change-Id: I60ffe465a69470b20d5785b291a13a0819bb2a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759892 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#688196}
-
Alex Keng authored
This CL enables <input type=radio/checkbox> to render high contrast colors when high contrast mode is enabled. A test is added in fast/forms/controls-new-ui-high-contrast. Note the test is verifying if we are correctly using system colors in high contrast mode and since we don't really change system setting for HC in webtests, the results colors are still black/grey/white (in higher contrast) instead of black/white/green. Bug: 994219 Change-Id: Ia798503ff040ce6b479a2845797118f7869c7ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756209 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688195}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=dtrainor@chromium.org, jshin@chromium.org, pmonette@chromium.org NOTRY=true Bug: 977050 Change-Id: I1bf790cf0957c912382787dec1b100651ff6b0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699950Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688194}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3f7932e73316..8566dda51b42 git log 3f7932e73316..8566dda51b42 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 958fec279ed5..d931999c3afd (1 commits) 2019-08-19 egdaniel@google.com Remove some unused GrPixelConfig functions. Created with: gclient setdep -r src/third_party/skia@8566dda51b42 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None Change-Id: I63baa0d8436797a464ad063b4d4288d01aaed70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761001Reviewed-by:
-
Gabriel Charette authored
Per https://chromium-review.googlesource.com/c/chromium/src/+/1756247/2/chrome/browser/metrics/perf/heap_collector_unittest.cc#695 this is migrated on its own because of the non-trivial requirement to avoid formatting away intentional trailing whitespaces. Edit: Turns out trailing whitespace formatting was my editor's fault not git cl format. Simple one-line migration in latest patch set. R=gmx@chromium.org Bug: 992483 Change-Id: I8f6331ce2c187b41f1f541fbe03884a9138cfff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759145 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688192}
-
Fred Mello authored
Implemented Strategy Pattern so that the class can be tested more easily. Moved all external dependencies into an injectable class (SplitCompatStrategy). Removed "spying" from unit tests. Bug: 949729 Change-Id: If35af947f207a429e1d9badeb5b1b1fdb978e5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752504Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#688191}
-
Dirk Pranke authored
run_web_tests supported the --gtest_repeat, --gtest_also_run_disabled_tests, and --gtest_filter flags for compatibility with FindIt; however FindIt eventually moved to using the --isolated-script-test flags instead, and these flags should no longer be used or needed, so this CL removes them. This is a prelude to cleaning up and implementing proper support for multiple --isolated-script-test-filter args. Bug: 893235, 994943 Change-Id: Id7a8ef5f43855b54eeb76193ceca45310b426890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759138Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688190}
-
Tibor Goldschwendt authored
Change-Id: If4da40d267aeb4a4ee8d099a95d502952abf6dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761005 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#688189}
-
Ian Kilpatrick authored
This also removes LayoutBox from the code, instead preferring NGLayoutInputNode. There should be no behaviour change. Bug: 726125 Change-Id: I532c5078806151f6336523f742bf62e76a374bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761067Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688188}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I963720b3c1e18eee0dfe29e3ff856e4dc1a906ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760998Reviewed-by:
-
Krishna Govind authored
This reverts commit 8fb37f86. Reason for revert: Browser crash, bug 995264 Original change's description: > [BackgroundTaskScheduler] TaskInfo refactoring > > The BackgroundTaskScheduler does not offer at the moment the possibility of scheduling a task at an exact moment. In preparation for this feature, the existing code is going to be updated first. > > This CL refactors the way in which specific task information is kept. A more object-oriented approach is implemented, based on the discussion in this Design doc: https://docs.google.com/document/d/1o9BS5qwv10QVN3Df6W2m4QKjSo1DXdGIgLf8p2l0PYc/edit?usp=sharing. Changes have been made only in the way timing info for a task is kept and not in the way pre-requisites information is kept. Updates have also been added to the test files. > > This change does not affect the interface exposed by the TaskInfo class. > > TBR=rouslan@chromium.org > > Bug: 970160 > Change-Id: I2985ca68da4e6db18f47e0fd1769db3138850cb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707365 > Commit-Queue: Richard Knoll <knollr@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687603} TBR=nyquist@chromium.org,nator@chromium.org,knollr@chromium.org,ioanastefan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 970160 Change-Id: I199f9c5245ac659c733599cec3558d780f21be19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761050Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#688186}
-
Victor Fei authored
This is a reland of 0297659d The change was reverted because newly added unittest AutofillPopupControllerA11yUnitTest::FireControlsChanged fails on linux with Control Flow Integrity (CFI) turned on. The reason it fails CFI is because on tear down of the test, AutofillPopupControllerImpl::Hide() performs a static cast of AutofillDriver to ContentAutofillDriver. Since the MockAutofillDriver used in the a11y unittests does not derive from ContentAutofillDriver, with CFI turned on, an exception is caused at this cast. The fix for this is for MockAutofillDriver in AutofillPopupControllerUnitTest to be derived from ContentAutofillDriver. Original change's description: > Stablizing Mac autofill accessibility when popup show/hides > > This is a follow up change of CL:1667787, which introduced > AutofillPopupControllerImpl::FireControlsChangedEvent for autofill > popup accessibility. > > On Mac and potentially other platforms, when accessibility is > enabled, upon invoking autofill popup and FireControlsChangedEvent > we end up dereferencing a nullptr of AxPlatformNode due to > Mac does not have a complete implementation of AxPlatformNode yet. > > This CL fixes the above by adding a check for AxPlatformNode in > FireControlsChangedEvent. > > Changes: > 1. Introduced a check for invalid AxPlatformNode in > AutofillPopupControllerImpl::FireControlsChangedEvent to return > early from firing event. > 2. Added associated unit tests for FireControlsChangedEvent. > 3. Exposed GetWebContentsPopupControllerAxId virtual to > AutofillPopupDelegate.. > > Bug: 986587 > Change-Id: I9a6ed49330a9ea9d7d4e5483c3ee06d5675919ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714297 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686461} Bug: 986587 Change-Id: I8e7772743d713329e871f8e130010cd7af321463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752687Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688185}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a65b81326a8a..4dfd57b8be2c Created with: gclient setdep -r src-internal@4dfd57b8be2c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:b/139144240,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:994067,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:b/139144240 Change-Id: I135646b29268c34858fee42bbf14d6754dff485c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761009Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688184}
-
Xida Chen authored
This CL moves filter-interpolation-*.html from animations/interpolation to external/wpt/css/filter-effects/animation. Some of the test cases in animations/interpolation/ already exist in css/filter-effects/animation/, and hence they are not added again. We only add the ones that aren't there yet. Bug: 900581 Change-Id: I34b93a035885c9de12b86c22e508039bd47d0d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760726Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688183}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/185243b33522..fdf38802a684 git log 185243b33522..fdf38802a684 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 hofbauer@webrtc.org Make "WebRTC-BweAllocProbingOnlyInAlr/Enabled/" default and remove key. 2019-08-19 sprang@webrtc.org Remove usage of RtpRtcp::SetSSRC() in video/ Created with: gclient setdep -r src/third_party/webrtc@fdf38802a684 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:951299 Change-Id: I801ec8af37871c36038cb685ebd8794d31a4dc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760895Reviewed-by:
-
Anna Malova authored
Bug: 994321 Change-Id: I8d8e40772563e12d986d28b107841e6933c33c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760924Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#688181}
-
Michael Thiessen authored
Bug: 993149 Change-Id: I0d2cb6238d3adf421f074c74124191898f901af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758923 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#688180}
-
Sophie Chang authored
Bug: 969558 Change-Id: I8755c18f37b936663ad3a6df6fb5122397bf1337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756713 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#688179}
-
Sahel Sharify authored
The test was disabled on chromeOS, this cl disables the test on other platforms as well. flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests%20(with%20patch)&tests=SitePerProcessTextInputManagerTest.TrackStateWhenSwitchingFocusedFrames TBR=wjmaclean@chromium.org NOTRY=TRUE Bug: 704994 Change-Id: If7b9f6662d7b35fcfc0b9cacec2d215baccfb928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759686Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688178}
-
Caleb Raitto authored
- Clarify why the read of runnable.mExecutedInline is safe. - Fix bad wrapping in an existing comment. - Clarify why writing "runnable.mCallingThread = null;" is safe. Change-Id: Iefb87004f106e400dfa02a61fa1d6f1120d2fbe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743278Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#688177}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/303ddb5c8807..aad8cfca57fd git log 303ddb5c8807..aad8cfca57fd --date=short --no-merges --format='%ad %ae %s' 2019-08-19 chrisforbes@google.com Add feature support check for VkPhysicalDeviceMultiviewFeatures Created with: gclient setdep -r src/third_party/swiftshader@aad8cfca57fd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139528538 Change-Id: I6e323cb5048ff01f906ef0307a838487dfb49ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761008Reviewed-by:
-
Juan Antonio Navarro Perez authored
Script no longer works as it dependes on the no longer existing WPR implementation in python. Bug: 921000 Change-Id: I160937cfe3734ee950ba95ece2831793c2429ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760216 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688175}
-
Tom McKee authored
The PageLoad.PaintTiming.ParseStartToFirstContentfulPaint histogram was marked as a 'heartbeat' metric in histograms.xml but is not considered a heartbeat metric anymore. This change removes the stale 'heartbeat' designation and also sets an expiry date of about one year. This way, stale histograms get taken out of circulation eventually but not before owners have a chance to review. Bug: 991343 Change-Id: Iaf9b80f834230df7d4a09936150ab487d14bf1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756394Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#688174}
-
A Olsen authored
Only slightly improves success detection at this stage, by adding Azure support - Ping and Okta are still pretty lacking - but makes room in the code for better success detection, and adds a unit test. Bug: 930109 Change-Id: I59a173095301f7c641031f79cb3a6c946c5efc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754013Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688173}
-
Abhishek Bhardwaj authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/bcf5f02a0d0a..d740747810e9 $ git log bcf5f02a0..d74074781 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 apusaka system_api: separate bluetooth constants 2019-06-07 sukhomlinov system_api: request type for vTPM EK certificate 2019-08-06 abhishekbh power: Add minium guaranteed delay timeout to RegisterSuspendDelayReply 2019-07-15 iby crash: Tast test for crash loop reporting 2019-07-16 zuan cryptohome: Add GetLoginStatus to UserDataAuth and proxy 2019-07-25 zuan cryptohome: Add LockToSingleUserMountUntilReboot to UserDataAuth and proxy 2019-07-22 cmtm remove unused scan_vendor_priv flag 2019-08-13 abhishekbh system_api: Add allow_untrusted flag to StartVMRequest 2019-08-13 juwa system_api: vm_tools: add bytes exported to export progress message 2019-07-26 akhouderchah shill: service: Add disconnecting state 2019-08-13 nverne system_api, vm_host_tools: Add OsRelease message to cicerone and tremplin 2019-08-07 lamzin shill, system_api: use Mac instead of MAC in names 2019-07-26 ejcaruso shill: add Metered property to Service 2019-06-14 dtor system_api: fix VmToolsStateChanged message definition Created with: roll-dep src/third_party/cros_system_api Bug:None Test:Compile. Change-Id: If40acdca7f0b9231c815bbce3e81e878b3c0edfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759389Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Chris Morin <cmtm@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688172}
-
Francois Doray authored
Bug: 948455, 982146, 976123 Change-Id: If04b6996437204c6e1cc7d926ea259d46eb108c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757504 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688171}
-
Joe DeBlasio authored
This CL updates the strings for the details/advanced section of the lookalike interstitial to use the friendlier 'details' phrasing. Bug: 987359 Change-Id: Ib010231f79358fc52d85b60ce9913a0fe7e79332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759211 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#688170}
-
kylechar authored
Don't encourage using |my_thread_checker_| as the name. Bug: none Change-Id: I90d7df90131128996e88e2b07f1b3d5f2f51f255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758712 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#688169}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13d55b39e183..82c85d4f089f git log 13d55b39e183..82c85d4f089f --date=short --no-merges --format='%ad %ae %s' 2019-08-19 saklein@chromium.org BinhostService: RegenBuildCache sans git operations. Created with: gclient setdep -r src/third_party/chromite@82c85d4f089f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3f857969aee41789c58e6152aeae6dfc55c800f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760894Reviewed-by:
-
Ian Kilpatrick authored
This was broken in: https://chromium-review.googlesource.com/c/chromium/src/+/1745396 This adds this functionality back in, and performs the data passing via the constraint-space, and layout-result (as opposed to setting this information explicitly on the layout-object classes. Bug: 993306 Change-Id: I5083ad782227657a19301cf61b2867be603f521a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757739Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688167}
-
Alex Khouderchah authored
Bug: chromium:954635 Change-Id: Iacb78c434999fabd1f1fdadc9fdca0d8829cb26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754089 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This reverts commit 3b6a2d96. Reason for revert: MSAN builds are consistently failing(e.g. builds #1361,#1362) because of virtual/controls-refresh/fast/forms/controls-new-ui/color/color-picker-appearance-set-type.html web test which is first added in the original cl. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN Original change's description: > Reland "Implement visual color picker" > > This is a reland of c74afcfa > > Original change's description: > > Implement visual color picker > > > > This CL adds to the implementation of the new color picker to provide > > functionality that allows the user to select colors visually. There > > are a few different components being added to the VisualColorPicker. > > They have been described in the ColorPicker.js file, but their > > description are also being shared herewith for convenience. > > > > EyeDropper: Allows color selection from content outside the color > > picker. (This is currently just a placeholder for a future > > implementation.) > > ColorViewer: Provides a view of the selected color. > > ColorSelectionArea: Base class for ColorWell and HueSlider that > > encapsulates a ColorPalette and a > > ColorSelectionRing. > > ColorPalette: Displays a range of colors. > > ColorSelectionRing: Provides movement and color selection > > functionality to pick colors from a given > > ColorPalette. > > ColorWell: Allows selection from a range of colors, between black and > > white, that have the same hue value. > > HueSlider: Allows selection from a range of colors with distinct hue > > values. > > > > This change includes connecting the existing manual color picker with > > the newly implemented visual color picker. If the user manually enters > > a new color value, it will be reflected visually, and similarly if the > > user visually selects a new color, the manual values will also get > > updated. > > > > Bug: 983311 > > Change-Id: I32f3e647bae5da25a664a1f6cd1dd2462feb3984 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747857 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#687144} > > Bug: 983311 > Change-Id: I35596ee04bd3e3df481e9096f747b07e8413e3c1 > > > TBR'ing original reviewers. Not making any changes to the original patch. It is > suspected that the MSAN test failure that lead to the original patch being > reverted was an unrelated issue. I have been unable to reproduce the failure > locally and this change does not touch C++ code. Per the recommendation here: > https://bugs.chromium.org/p/chromium/issues/detail?id=994447, relanding this > change as is to see if the MSAN failure still occurs. > > TBR: tkent@chromium.org,masonfreed@chromium.org > Change-Id: I35596ee04bd3e3df481e9096f747b07e8413e3c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758705 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#688011} TBR=chrishtr@chromium.org,tkent@chromium.org,masonfreed@chromium.org,sajos@microsoft.com Change-Id: I1461f16f7f40374fa1508b6c8b7802d46cf521ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761015Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72fbaf4d465e..73b9263523ee git log 72fbaf4d465e..73b9263523ee --date=short --no-merges --format='%ad %ae %s' 2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@73b9263523ee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ice637e335c99c01a7f27fd7ebfe11baa782ba94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760539Reviewed-by:
-
Jimmy Gong authored
- Autoconf printers do not have PPDs; therefore, do not have an associated manufacturer and model. - This change hides those fields in the edit dialog for autoconf printers. Bug: 947183 Test: browser test, end to end manual Change-Id: Ibdff515e2ba356a873df6f8cf6326d2a8f1a8735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746628 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#688163}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 990979 Change-Id: Ie198810daeef73289d3ff559735a079b236a1cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755415Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#688162}
-
