- 15 Nov, 2018 40 commits
-
-
bsheedy authored
Adds a test-only UiInputManager that gets swapped with the real one anytime we're using the InputDelegateForTesting. Currently, the only difference is that the testing version always reports that the controller is not in the viewport. This is so that pixel diff tests are not flaky based on the initial orientation of the device - without this, the controller tooltips would remain visible if the device started pointed slightly down even though we lock the head pose forward. Bug: 904012 Change-Id: Ia34944bd9d678c43480ef218b2d740928732f5ae Reviewed-on: https://chromium-review.googlesource.com/c/1334941 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#608545}
-
Tarun Bansal authored
Currently, the pref delegate in network quality estimator (NQE) reads network quality prefs right after startup. However, the underlying pref service factory is initialized asynchronously by the network_context (see the linked bug). This results in pref delegate read at startup returning empty value, irrespective of the actual prefs. This CL fixes the bug by changing pref delegate to read the pref only after the pref service has been initialized. This ensures that when the prefs are read, they actually return what's stored on the disk, instead of empty values. Change-Id: I9791c673c0300d6d896f2d8e556c97f01f7e1f52 Bug: 904465 Reviewed-on: https://chromium-review.googlesource.com/c/1333127 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608544}
-
Samuel Huang authored
For 32-bit ARM LLD builds (LTO and non-LTO), the linker map files can have thousands of symbols with '.L_MergedGlobals' prefix. These symbols obscure shadow symbols with more informative name. This CL fixes the problem by making liner map parser skip symbols with these prefixes. Bug: 905329 Change-Id: I2e72b566e17f025bdf147551bd5b569764e0ec16 Reviewed-on: https://chromium-review.googlesource.com/c/1338227Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608543}
-
Xi Cheng authored
These objects are created to satisfy the interface requirements but have limited and/or reduced functionality. According to naming rules, they should be called fake*. Change-Id: I24fcc274b730305b89a8b1c9d269793dbd448a63 Reviewed-on: https://chromium-review.googlesource.com/c/1338202Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#608542}
-
Erik Luo authored
Switching windows or using the Element picker may focus the DevTools area with relatedTarget=null. In these cases, re-applying node highlight is not needed. Bug: 905252 Change-Id: Ie3ae228c9cc404f16598ff428d9e593bb90e33e5 Reviewed-on: https://chromium-review.googlesource.com/c/1336910 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#608541}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ccf40a90be8..ec3b48cc9484 Created with: gclient setdep -r src-internal@ec3b48cc9484 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id675d990cd19ff8a12927084b8f65a77a95cf6ac Reviewed-on: https://chromium-review.googlesource.com/c/1338152Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608540}
-
Peng Huang authored
We would like to share one ContextState for all raster decoders and display compositor. To do that, we need make ContextState work without a decoder client. Bug: 902904 Change-Id: I0ebabbf084e864f18b5e5e1bc5d069a3d436718e Reviewed-on: https://chromium-review.googlesource.com/c/1338383 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608539}
-
Devlin Cronin authored
Consider the following circumstance: - User installs extension Alpha normally (e.g., through the webstore). Alpha has Manifest::Location INTERNAL. - Corp policy pushes out an update that lists Alpha as a required extension. Currently, this behaves fantastically poorly. We validate that the user is allowed to load an extension on each run of Chrome when loading installed extensions, and UserMayLoad() will return false if the extension is required by corporate policy (in order to prevent users from installing "over" a policy-required extension). This means that the policy-required extension gets disabled with reason DISABLE_BLOCKED_BY_POLICY. Make this slightly less bad by introducing a new policy provider method, UserMayInstall(). This checks whether the user is allowed to install a given extension, rather than whether the user is allowed to load it. For default implementations, UserMayInstall() forwards to UserMayLoad() (since they should be treated equivalently). However, we can now move the check for if a Manifest::INTERNAL extension is required policy to the UserMayInstall() check rather than UserMayLoad(). The effect of this is to allow the user to load an already-installed extension that's required by policy, but not policy-installed itself, while still preventing the user from installing a new copy of that extension. This is not a perfect solution, since the installed version of the extension will still be the Manifest::INTERNAL one. This has a number of implications, including that the extension won't show most policy- installed indications and won't have access to policy-only APIs. In extreme cases, the extensions can also be different versions. In the future, we will need to think about how to handle this scenario more gracefully. Bug: 894184 Change-Id: I83c9c305b56f90ea211e4a9b0120b22d601b4fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1327616 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608538}
-
Mason Freed authored
These should reproduce (at least) these issues: - https://crbug.com/622128 - dark areas brought in from edges - https://crbug.com/632979 - dark areas brought in from edges - https://crbug.com/659501 - menus cause too much filtering - https://crbug.com/767997 - menus cause too much filtering - https://crbug.com/813796 - incorrect border used for filter - https://crbug.com/593307 - incorrect border used for filter Bug: 497522,622128,632979,659501,767997,813796,593307 Change-Id: Iafea2fc8fffba950f74d27f21170df647dc62e29 Reviewed-on: https://chromium-review.googlesource.com/c/1330888 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608537}
-
Dmitry Gozman authored
Instead of exposing internal methods to layout test through TestRunner, we can just emulate user navigating away from the page. Bug: 855189 Change-Id: I4cd08357e7929108ad7c9fe79f7f5eeec13e7888 Reviewed-on: https://chromium-review.googlesource.com/c/1334192Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608536}
-
Scott Chen authored
Tests possible scenarios of the default status response. Bug: 881937 Change-Id: Ic19152b53a81571794fd82f0ce2bd6bed978cf0f Reviewed-on: https://chromium-review.googlesource.com/c/1327525 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#608535}
-
Ella Ge authored
This reverts commit 49c4e756. Reason for revert: 239 LayoutTests failure on Mac10.10 bot https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36316 Original change's description: > Warn in the DevTools console for TLS 1.0 and 1.1. > > TLS 1.0 and 1.1 are deprecated. See: > https://security.googleblog.com/2018/10/modernizing-transport-security.html > https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ > > As part of that deprecation, show a console warning in DevTools and also > add a Blink-level UseCounter. (We typically measure things at the > connection or request level for network features, but since we're > plumbing this in anyway, go ahead and add one.) I mirrored the plumbing > and UseCounters for Symantec certificates. > > Bug: 896013 > Change-Id: I9b45e6264a2119b7b68a5a9f282dfd63a372210a > Reviewed-on: https://chromium-review.googlesource.com/c/1324878 > Commit-Queue: David Benjamin <davidben@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608456} TBR=kinuko@chromium.org,davidben@chromium.org,pfeldman@chromium.org,carlosil@chromium.org Change-Id: I708f0234f09dd8747841b970463728b37a4bdbcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896013 Reviewed-on: https://chromium-review.googlesource.com/c/1338390Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608534}
-
Shakti Sahu authored
Long title text on the video item causes weird shift in the image view and also hides the three dot menu button that is located on the right. Didn't find a way to fix this in GridLayout. Changed this to use LinearLayout which will fix this issue. We also need to do the same fix for in-progress video layout where the cancel button is getting hidden by the long text. Bug: 904979 Change-Id: I1e2974c1772d5745242d106ee8e35fde58b5c1cf Reviewed-on: https://chromium-review.googlesource.com/c/1334828 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#608533}
-
Peter Boström authored
Bug: chromium:905515 Change-Id: I99ee7721c56583b8bf0cdc48a06d05371f8c4c4b Reviewed-on: https://chromium-review.googlesource.com/c/1337828Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608532}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eaddc34b5d48..e69406dde9dd git log eaddc34b5d48..e69406dde9dd --date=short --no-merges --format='%ad %ae %s' 2018-11-15 dtu@chromium.org [pinpoint] Add metric property to Quest. Don't imply GraphJson Quest based on arguments. 2018-11-15 cbruni@chromium.org [telemetry] Log page action names in the ActionRunner Created with: gclient setdep -r src/third_party/catapult@e69406dde9dd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904423 TBR=sullivan@chromium.org Change-Id: Id1e9b66e752cfe0e165bc3547cfac13afc6a734d Reviewed-on: https://chromium-review.googlesource.com/c/1338149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608531}
-
Rune Lillesveen authored
LazyReattachIfAttached() nukes the computed styles synchronously so that we are not able to keep animations alive for the next lifecycle update. Add a bit on Node to say that we need a forced layout tree reattach and trigger the re-attach from style recalc instead. Bug: 900162 Change-Id: I22f51f5e091932fc8a63213af88903c7866abbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1333809Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608530}
-
Ryan Sleevi authored
As documented in the policy notes and past announcements regarding SHA-1 deprecation, the ability to support SHA-1 for local trust anchors is going away in January 2019, which aligns with Chrome 72. This policy was introduced to provide an additional two years for Enterprises to migrate off their SHA-1 leaves and intermediates. Bug: 653687 Change-Id: I924202c7cbc40fc123221d8202886a974979158f Reviewed-on: https://chromium-review.googlesource.com/c/1331146Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608529}
-
Kevin Bailey authored
We added new fields to the Omnibox event protobuf regarding keyword mode. This CL copies the new relevant information from a set of suggestions into that protobuf. Also adds new boolean field to a suggestion. Bug: 837395 Change-Id: I496d5235790a3c3cd1744155fe766b134a366fd5 Reviewed-on: https://chromium-review.googlesource.com/c/1312930Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608528}
-
Chris Lu authored
Bug: 888198 Change-Id: Iefbb8ce1c55480697eaab072f3c408cb1d14f852 Reviewed-on: https://chromium-review.googlesource.com/c/1269945Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#608527}
-
Danyao Wang authored
Bug: 905688 Change-Id: I11f0b6320ba8221139323a285199a5570afab429 Reviewed-on: https://chromium-review.googlesource.com/c/1338308Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608526}
-
siyua authored
1) Add a ManageMigrationUiController above LocalCardMigration(Bubble/Dialog)ControllerImpl to control the entire flow and what ui to show. Also it makes easier to interact with LocalCardMigrationIconView and it keeps ChromeAutofillClient cleaner. 2) Separate LocalCardMigrationFlowStep from LocalCardMigrationDialogState, the previous one is the enum for ManageMigrationUiController to decide what to do while the latter one is a pure view state for dialog. Upload screenshots for what the flow should be like in the bug (comment#15). Bug: 897998 Change-Id: I79f3b491f6ab86b204f05d53cda7fe9bd737d28e Reviewed-on: https://chromium-review.googlesource.com/c/1328146 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#608525}
-
Liquan(Max) Gu authored
Rename PaintTracking flag to FirstContentfulPaintPlusPlus. The flag is meant to serve specifically to FCP++ metrics. So the naming should reflect this goal. This CL renames the PaintTracking flag in runtime_enabled_features. Bug: 869924 Change-Id: Ib3cbd8ac21ab962e87626edf74e13dfc8fde486e Reviewed-on: https://chromium-review.googlesource.com/c/1338237 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608524}
-
David Bertoni authored
Bug: 805600 Change-Id: I5c6f01dce2e93fc2d4a43485b258322d3eb06bae Reviewed-on: https://chromium-review.googlesource.com/c/1300099 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608523}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f0db2e2ef5d2..0462948c9cb9 git log f0db2e2ef5d2..0462948c9cb9 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 jonasolsson@webrtc.org Revert "Add ios bindings for PeerConnectionState." 2018-11-15 terelius@webrtc.org Add version and UTC time fields to RTC event log. Created with: gclient setdep -r src/third_party/webrtc@0462948c9cb9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib2e383aa460bbf0d4aa8ae673bbf8346f0802d2b Reviewed-on: https://chromium-review.googlesource.com/c/1337643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608522}
-
Alexander Timin authored
Fixes required for SequenceManager/ThreadControllerWithMessagePump to work properly on all platforms: Always call MessagePump::ScheduleWork from EnsureWorkScheduled to avoid deadlocks on some platforms. Switch from implicit quit_do_work to quit_pending, which is set to false when the current run loop (and ThreadController::Run) call ends. Improve test coverage. R=alexclarke@chromium.org СС=gab@chromium.org BUG=891670 Change-Id: I9fb554ed91cdca6982e773f4b29055b4ae99dc95 Reviewed-on: https://chromium-review.googlesource.com/c/1337501 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608521}
-
Christian Biesinger authored
If there's a paint fragment, we're using it to paint, so we need to get the ID from that, not from the LayoutObject. Fixes 3 unit tests in paint_layer_painter_test. R=chrishtr@chromium.org, kojii@chromium.org Change-Id: Ieb3066e5a52c8b4ecdda20aa2226f5df6f32e7b4 Reviewed-on: https://chromium-review.googlesource.com/c/1338380 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608520}
-
Christopher Grant authored
This will allow native code to be stripped out of the main library when it moves to a Dynamic Feature Module. For now, the libraries will be identical. BUG=874584 Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913 Reviewed-on: https://chromium-review.googlesource.com/c/1332248Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#608519}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/91de11099dcd..59127a5d3941 git log 91de11099dcd..59127a5d3941 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 ehmaldonado@chromium.org metrics: Spell out PII. Created with: gclient setdep -r src/third_party/depot_tools@59127a5d3941 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I71ccced8500b4fc304c184c41ed3c239804944ef Reviewed-on: https://chromium-review.googlesource.com/c/1338147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608518}
-
Kyle Horimoto authored
The crash was caused by attempting to cancel and/or update the priority of a connection attempt which had not yet started. Starting a connection is posted in an asynchronous task, so it is possible that the connection attempt is canceled before it has been attempted. In this case, we were erroneously assuming that the connection attempt metadata had already been set when it actually had not. This CL fixes this race condition by explicitly checking if the connection has been attempted before performing any operation which touches connection metadata. Bug: 888073 Change-Id: I183202863f8e018b5dfdf77e1b208843217689e7 Reviewed-on: https://chromium-review.googlesource.com/c/1338322Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#608517}
-
Pavel Shmakov authored
The issue is related to the crashes http://crbug/829367 on Samsung (also, Lenovo and Yulong) Marshmallow devices. Because of those crashes we prohibit setting small notification icons as Bitmaps. The icon coming from a web page shown in a TWA comes in a form of a Bitmap, so we can't use that. A reasonable fallback would be to use the icon specified by its resource id in meta-data for TWAService or by extending TWAService. Unfortunately, there is a problem with that fallback as well. For M+ the small icon has to be from the resources of the app whose context is passed to the Notification.Builder constructor. Normally we would use the bitmap decoded (on the client's side) from resource id. But then again, on Samsung M we can't set that bitmap due to the crashes. In this CL we create the context of client's app using Context#createForPackage, pass that into NotificationBuilder, and that way we can use the icon id. Since this approach is quite unusual and seems risky, it is used only in the cases we're fixing, and protected by a feature flag. Bug: 864786 Change-Id: Ia401f56b446e7dcc684697faea77ae2a3a402e67 Reviewed-on: https://chromium-review.googlesource.com/c/1228075 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608516}
-
Kevin Marshall authored
Adds a channel for sending messages to web content. Messages can include MessagePorts to allow for bidirectional message exchange between the FIDL client and web content. Promotes Blink CloneableMessage and TransferableMessage struct traits to "public" so that the messages can be serialized and deserialized by code outside Blink. Bug: 893236 Change-Id: If4e23a65e9d35e1ed2ce80de95e9f2212c55aecf Reviewed-on: https://chromium-review.googlesource.com/c/1318839Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#608515}
-
Ovidio Henriquez authored
This change updates the WebUsbAllowDevicesForUrls policy to use GURL instead of ContentSettingsPattern for allowing devices to origins. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: Idaf4fb27b96fb63d6c182e164fef64b5df2dcf4d Reviewed-on: https://chromium-review.googlesource.com/c/1327805 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#608514}
-
Scott Violet authored
Specifically PasswordManagerInteractiveTest.PromptForXHRWithoutOnSubmit. BUG=905789 TEST=test only change TBR=mukai@chromium.org Change-Id: Ia34a1d2b648964943efd137ab82a7c1082ae940a Reviewed-on: https://chromium-review.googlesource.com/c/1338203Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608513}
-
Jeremy Apthorp authored
menu_model_ refers to the root model, so it was previously checking the enabled state of the wrong menu model. Change-Id: Ia1a3662ea68779cbb86663973ba4599d9fabb054 Reviewed-on: https://chromium-review.googlesource.com/c/1336443Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#608512}
-
Gabriel Charette authored
This is a follow-up to https://chromium-review.googlesource.com/c/1305891 Missed that Mac had its own impl. Example problematic trace because of this http://crash/18c6999290e01f89 Made all impls match waitable_event_win.cc (also ignoring the ScopedEventWaitActivity when idle) R=fdoray@chromium.org Bug: 899897 Change-Id: Ib5aa1cec487f80a6f1d603658279666ee0d1de60 Reviewed-on: https://chromium-review.googlesource.com/c/1336073Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#608511}
-
Lucas Furukawa Gadani authored
This fixes a GC crash. Change-Id: Ie5fcfdee033e8f2b45282bfc88d1210bf3a8d861 Reviewed-on: https://chromium-review.googlesource.com/c/1338335Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608510}
-
Doug Arnett authored
Actually puts top level hint processing and evaluation behind a new Feature that is disabled by default (in case we need to revert hints due to memory footprint or such). Bug: 902802 Change-Id: I03735e1b724bbcdf32f7cf2eb5025978bc657ca9 Reviewed-on: https://chromium-review.googlesource.com/c/1338301Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#608509}
-
Philip Rogers authored
This patch is a followup to https://crrev.com/605470 and removes more cc::Layer hierarchy modifications from GraphicsLayers. We rely on cc::Layers being updated in PaintArtifactCompositor (PAC). Bug: 898668 Change-Id: I021119d3ddd3314bba03614f2fb4ce9f07ea62eb Reviewed-on: https://chromium-review.googlesource.com/c/1337288Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608508}
-
Justin Cohen authored
Followup to crrev.com/c/1335207, which missed some @available calls. Bug: 894099, 826369, 826011 Change-Id: I901cf055264b73ac6c2cebddabb0c050e53d8f0f Reviewed-on: https://chromium-review.googlesource.com/c/1335960 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#608507}
-
Marc Treib authored
syncer::TestSyncService already supports most of the state that's required here, so this lets us remove a bunch of boilerplate. Bug: 859874 Change-Id: I3c45e341f31c199176dd8173b6a858a8c704c15f Reviewed-on: https://chromium-review.googlesource.com/c/1335582 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608506}
-