GitLab

The Ozone GBM platform now directly creates GLSurfaces instead of
creating SurfaceOzoneEGL. The base classes for surfaceless and
framebuffer backed GLSurfaces is moved into //ui/ozone/platform/drm.
The old GbmSurfaceless class is replaced entirely despite retaining the
same name. A new GbmSurface class is added for the framebuffer backed
surface.

Add a new version of ChooseEGLConfig() to egl_util.cc/h that doesn't
rely on any callbacks now that deps problem as been fixed. The old
version will be deleted when this refactor is done as it will be unused.

BUG=611142

Review-Url: https://codereview.chromium.org/2165303002
Cr-Commit-Position: refs/heads/master@{#407574}

Just look at BUILD.gn and SystemInfo_test.mm, everything else is consistent with CL 2094583004 (Initial commit for Chrome meta installer https://codereview.chromium.org/2094583004/)

BUG=

patch from issue 2106523002 at patchset 60001 (http://crrev.com/2106523002#ps60001)

Review-Url: https://codereview.chromium.org/2137743002
Cr-Commit-Position: refs/heads/master@{#407573}

When computing the occlusion from a layer, draw_blend_mode rather than
blend_mode needs to be considered, since draw_blend_mode is what's used
when drawing the layer. However, non-default blend modes currently always
trigger surface creation, and then the blend mode gets applied when
drawing the surface. This means that draw_blend_mode is always SrcOver.
This CL replaces the incorrect use of blend_mode in
OcclusionTracker::MarkOcclusionBehindLayer with a DCHECK that
draw_blend_mode is SrcOver.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2176903002
Cr-Commit-Position: refs/heads/master@{#407572}

https://chromium.googlesource.com/chromium/src/+/706d93d0d

BUG=621772
TBR=agrieve@chromium.org

Review URL: https://codereview.chromium.org/2182753002 .

Cr-Commit-Position: refs/heads/master@{#407571}

This can happen in a clean build if the clean_up_old_versions step runs before
bundling, in a parallelized build.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/2184433002 .

Cr-Commit-Position: refs/heads/master@{#407570}

Yes, these three updates are truly interdependent. See
https://crbug.com/629874.

Breakpad was previously on a branch that had cherry-picked 027633792600.
Breakpad 2fcb8afbc807 requires linux-syscall-support 3f6478ac95ed. The
repository for linux-syscall-support has changed locations. Native
Client also depends on linux-syscall-support and must be updated to
412a6e2bb153 for compatibility with this version of
linux-syscall-support.

Update Breakpad to 51db53eec7293a35cb6fc10bd2e333f22dd9d201

220c852dc209 Dump INFO CODE_ID containing Build ID in Linux dump_syms
2fcb8afbc807 linux-syscall-support: pull in latest version
1f7cb2e4c523 Server-side workaround to handle overlapping modules
8c612166fa87 Add a new argument to specify the minidump type to write on
             Windows
2131271ecabd [Android] Guard some NDK workarounds by major version
027633792600 Recover memory mappings before writing dump on ChromeOS
0de9e29cb674 Don't define |r_debug| and |link_map| on Android releases
             21 and later
e55a878d5b74 Add process type to MicroDumpExtraInfo
423e661072aa Add new exception code for OOM generated from Chromium
4dc6be51f90c Revert "Don't define |r_debug| and |link_map| on Android
             releases 21 and later"
51db53eec729 Remove DISALLOW_COPY_AND_ASSIGN from MinidumpStreamInfo

Update linux-syscall-support to 3f6478ac95edf86cd3da300c2c0d34a438f5dbeb

2ce6a9744160 Add codereview.settings for new repo location
cd0177fdded9 Fix VIEW_VC URL in codereview.settings
929203010984 Finally fix VIEW_VC url with proper review
08056836f2b4 migrate site/wiki docs over
348bdf8d32b3 README: clearly document goals/APIs/supported systems
3f6478ac95ed Add s390/s390x support to linux_syscall_support.h

Update Native Client to 412a6e2bb153f39f22b9b3e47bc1ed0abb82df3f

412a6e2bb153 Update linux-syscall-support to 3f6478ac95ed

Update generate_breakpad_symbols.py for Breakpad 220c852dc209.

BUG=629874
TEST=tools/perf/run_tests core.stacktrace_unittest.TabStackTraceTest.

Review-Url: https://codereview.chromium.org/2167703002
Cr-Commit-Position: refs/heads/master@{#407569}

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305

Review-Url: https://codereview.chromium.org/2182663002
Cr-Commit-Position: refs/heads/master@{#407568}

We added a new value for extension bubble actions for dismissing by
deactivation in crrev.com/486b20e7 in
November, but never updated the histogram entry. As a result, the data,
while recording correctly, shows "3" for dismissing by deactivation.
Update the histogram file to correct this.

BUG=None

Review-Url: https://codereview.chromium.org/2174403002
Cr-Commit-Position: refs/heads/master@{#407567}

Implement the following functionality
- Add Gatt service / characteristic / descriptor to Gatt Server
  "Gatt included service" is currently not support in Chrome side.
- Start / Stop Gatt service
- Delete Gatt Service

BUG=629210
TEST=manual test using step below
1. Create custom Gatt server in nrF connect app.
2. Connect minnie to ryu via chrome interface.
3. Ryu can correctly see minnie's Gatt server object.

Review-Url: https://codereview.chromium.org/2104043002
Cr-Commit-Position: refs/heads/master@{#407566}

Comments in CursorDelegateEvdev incorrectly specified thread usage
so update appropriately.

BUG=620927

Review-Url: https://codereview.chromium.org/2179123002
Cr-Commit-Position: refs/heads/master@{#407565}

Updates code to stop using the old mojo::String and mojo::Array types
and instead use the much-cleaner std::string and std::vector types
(a.k.a. the "new" mojo wrapper types for C++ code).

R=imcheng@chromium.org

Review-Url: https://codereview.chromium.org/2173953003
Cr-Commit-Position: refs/heads/master@{#407564}

Don't use the test API to access things that can be directly accessed from
WmShell.

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2183483002
Cr-Commit-Position: refs/heads/master@{#407563}

Added metrics to track which system menu rows are visible in order to
make informed decisions about feature usage.

BUG=620509
TEST=SystemTrayTest.*

Review-Url: https://codereview.chromium.org/2162153002
Cr-Commit-Position: refs/heads/master@{#407562}

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG=618287

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}

Top sites update tasks add noise to these benchmarks.  Disabling
until tasks are converted to use the TaskScheduler APIs.

BUG=588745
BUG=621128

Review-Url: https://codereview.chromium.org/2168313004
Cr-Commit-Position: refs/heads/master@{#407560}

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/2179013002 .

Cr-Commit-Position: refs/heads/master@{#407559}

Modified layout test to make it less sensitive to anti-aliasing/blending
precision issues to prevent bogus flakiness.

BUG=628266

Review-Url: https://codereview.chromium.org/2179913002
Cr-Commit-Position: refs/heads/master@{#407558}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9224f7903b9c..189c4816b033

$ git log 9224f7903..189c4816b --date=short --no-merges --format='%ad %ae %s'

BUG=624164

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2179103002
Cr-Commit-Position: refs/heads/master@{#407557}

- Avoid embedding important logic into the templates.
- Use const for ObjectPaintProperties and paint property node types to
  control mutable accesses to them.

Review-Url: https://codereview.chromium.org/2173363002
Cr-Commit-Position: refs/heads/master@{#407556}

'Cancel' isn't really the right word for what this change does.
In the event of an image decoding failure, ImageResource will
synthesize a call to ResourceLoader::didFinishLoading, killing
the actual network request but reporting it as a successful
completion to the rest of blink. This matches our traditional
behavior of decoding errors looking like a successful
resource load (for the most part).

This requires some plumbing changes to image decoding, because
the decoder selection logic doesn't report why it wasn't able to
create an ImageDecoder. It might be because insufficient data has
been received to sniff the image type, or it may be that we
definitely don't have a valid image type. This change exposes enough
information to tell the difference.

BUG=471272
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2173873003
Cr-Commit-Position: refs/heads/master@{#407555}

* Change HeaderCoalescer::headers() to release_headers() passing ownership of
  SpdyHeaderBlock.
* Change BufferedSpdyFramerVisitorInterface::OnHeaders() and OnPushPromise() to
  take SpdyHeaderBlock by value, allowing for move.
* Plumb move through SpdySession::TryCreatePushStream().
* Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

BUG=621905

Review-Url: https://codereview.chromium.org/2174943002
Cr-Commit-Position: refs/heads/master@{#407554}

Design doc: go/caebn

This does not contain any tool implementations. There are stub tool implementations in https://codereview.chromium.org/2147783002/.

This is used in the palette tray in https://codereview.chromium.org/2148573002/.

BUG=625251

Review-Url: https://codereview.chromium.org/2140343002
Cr-Commit-Position: refs/heads/master@{#407553}

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2181753002
Cr-Commit-Position: refs/heads/master@{#407552}

https://crrev.com/59d3539fc7ce60355ccf52c00733d33dde5e118a stopped collapsing:

       LayoutBlockFlow (anonymous) at (0,0)
          LayoutBlockFlow (anonymous) at (0,0)
            LayoutInline {SPAN} at (0,0)

to

       LayoutBlockFlow (anonymous) at (0,0)
         LayoutInline {SPAN} at (0,0)

Reinstate that behaviour!

BUG=627149

Review-Url: https://codereview.chromium.org/2176043002
Cr-Commit-Position: refs/heads/master@{#407551}

We were tracking size-within-apk, and size-within-apk+extracted size,
but it's also useful to track uncompressed size for things like the
native library & dex file.

BUG=none

Review-Url: https://codereview.chromium.org/2172303002
Cr-Commit-Position: refs/heads/master@{#407550}

We were using HexStringToInt to parse chunk size, which returns a
32-bit int.  This CL switches to using HexStringToInt64, which uses
64-bit ints, so we can now support chunks up to 2^63-1 bytes.

That should be enough for anybody. [Cue dramatic music]

BUG=630680

Review-Url: https://codereview.chromium.org/2170133004
Cr-Commit-Position: refs/heads/master@{#407549}

Previous change: https://codereview.chromium.org/2176663003/

Reason for Reland:
I've added rebaselines to TestExpectations, following:
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations#TOC-How-to-rebaseline

TBR=flackr@chromium.org,asanka@chromium.org,mpearson@chromium.org
BUG=621772

Review-Url: https://codereview.chromium.org/2177963002
Cr-Commit-Position: refs/heads/master@{#407548}

We don't apply surface contents scale for root. We
currently check the transform id to determine if we are at
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2163823003
Cr-Commit-Position: refs/heads/master@{#407547}

This patch adds the mojo definition for Gatt Server API

BUG=629210
TEST=Build

Review-Url: https://codereview.chromium.org/2104023002
Cr-Commit-Position: refs/heads/master@{#407546}

We remove telemetry_perf_unittest suite from Mac10.9 & all dbg bots because we
don't run performance benchmark on those configuration (See attached bug for
more details)

BUG=630765

Review-Url: https://codereview.chromium.org/2175293002
Cr-Commit-Position: refs/heads/master@{#407545}

Due to a bug in how server generated root nodes for autofill wallet metadata
were created, clients can have both an implicitly created root node and an
explicitly (server-side) created root node. This change makes it so we
gracefully handle this by allowing both to live side by side in the
parent_child_index, and ensures new entities don't become invisible.

BUG=630035

Review-Url: https://codereview.chromium.org/2168273002
Cr-Commit-Position: refs/heads/master@{#407544}

Previously WebrtcDataStreamAdapter acted as a factory of MessagePipe
adapters, now it works as an adapter itself. It gets
webrtc::DataChannelInterface in the constructor and the WebrtcTransport
is responsible for creation of the data channels themselves.

Review-Url: https://codereview.chromium.org/2172423002
Cr-Commit-Position: refs/heads/master@{#407543}

Review-Url: https://codereview.chromium.org/2172933003
Cr-Commit-Position: refs/heads/master@{#407542}

Remove ifdefs that assume otherwise.

Review-Url: https://codereview.chromium.org/2174983002
Cr-Commit-Position: refs/heads/master@{#407541}

Review-Url: https://codereview.chromium.org/2180963004
Cr-Commit-Position: refs/heads/master@{#407540}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a6e5346..61e64edd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2179713003
Cr-Commit-Position: refs/heads/master@{#407539}

Which is notified as accelerators are added/removed.

BUG=612331
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2177983002
Cr-Commit-Position: refs/heads/master@{#407538}

Revert of Cast device revocation checking. (patchset #26 id:500001 of https://codereview.chromium.org/2050983002/ )

Reason for revert:
Causes failure on
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/31399
in
components_unittests

failures
VerifyCastDeviceCertTest.ChromecastGen2InvalidTime

VerifyCastDeviceCertTest.ChromecastGen2InvalidTime (run #1):
[ RUN      ] VerifyCastDeviceCertTest.ChromecastGen2InvalidTime
../../components/cast_certificate/cast_cert_validator_unittest.cc:99: Failure
Value of: base::Time::FromUTCExploded(time, &result)
  Actual: false
Expected: true
[  FAILED  ] VerifyCastDeviceCertTest.ChromecastGen2InvalidTime (13 ms)

Original issue's description:
> Cast device revocation checking.
>
> Cast device certificates may be revoked through two ways:
> 1. The hash of the public key.
> 2. A serial number range for an issuer identified by the hash
>    of its public key.
>
> A customized proto is used as the medium for this information.
>
> This change contains the implementation for verifying the custom CRL
> and verifying a certificate's revocation status based on that CRL.
>
> BUG=618463
>
> Committed: https://crrev.com/698608f28ed2df276f920c9691cbfcb8f9069337
> Cr-Commit-Position: refs/heads/master@{#407492}

TBR=sheretov@chromium.org,eroman@chromium.org,asargent@chromium.org,davidben@chromium.org,ryanchung@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618463

Review-Url: https://codereview.chromium.org/2181013002
Cr-Commit-Position: refs/heads/master@{#407537}

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2181693003
Cr-Commit-Position: refs/heads/master@{#407536}

BUG=623016
TBR=rohitrao

Review-Url: https://codereview.chromium.org/2180943002
Cr-Commit-Position: refs/heads/master@{#407535}