- 16 Mar, 2020 40 commits
-
-
kylechar authored
Bug: none Change-Id: I5be6711cbe726abfdc5bf7c21e7ec2e17e35b61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105401Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750604}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9b620aa0c12d..4b2483ee88ab git log 9b620aa0c12d..4b2483ee88ab --date=short --first-parent --format='%ad %ae %s' 2020-03-16 mbechard@users.noreply.github.com Fix #2005. Allow multiple compilation units to declare identical push_constant blocks (#2123) Created with: gclient setdep -r src/third_party/glslang/src@4b2483ee88ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ie9e2fed7147a8549b1cd977f09134c2884dab27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750603}
-
Roman Sorokin authored
Sometimes network is not connected yet when online load is happening. So in case of a network error - try again while within timeout. Fixed: 1061202 Change-Id: Ic5a71eab806bfc48615d6f4c684f90abc1aeef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102491Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750602}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1a56ce54e070..022952303c1a git log 1a56ce54e070..022952303c1a --date=short --first-parent --format='%ad %ae %s' 2020-03-16 thakis@chromium.org Suppress two -Wunreachable-code warnings. Created with: gclient setdep -r src/third_party/dawn@022952303c1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:346399 Tbr: cwallez@google.com Change-Id: Icdb88268a388dfcb4d1f11d2f7f0b44be3b89b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105581Reviewed-by:
-
ckitagawa authored
This CL is intended to integrate the hit tester into the player delegate. Note: it doesn't actually perform navigation or handle overlapping links yet (see crbugs). Bug: 1019883 Change-Id: I490e420ab31b2a828e8aa53779513ea4313c0935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101489Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#750600}
-
James Cook authored
Fix the tests in anticipation of enabling the feature by default. The tricky bit is that UserSelectableType::kApps isn't used on Chrome OS when the feature is enabled, but it is still part of UserSelectableTypeSet::All(). Update the tests to use the registered selectable types, which is closer to what the production code does. Test: components_unittests --enable-features=SplitSettingsSync Bug: 1060289 Change-Id: I16d4f119c1daa1cb51f2b9a35ea247beec75ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101722 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#750599}
-
Side Yilmaz authored
ExploreSitesBackgroundTask. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ExploreSitesBackgroundTask class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I8e6be991e2358fdb2130508c8baf0a46861a3e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095131Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750598}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d1d96d73bff7..a8631f682eb5 git log d1d96d73bff7..a8631f682eb5 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 jmadill@chromium.org Fix running trace tests in non-standard directories. Created with: gclient setdep -r src/third_party/angle@a8631f682eb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: Ia08c531ab4b9f62ab8a4ddd07f2d6f82749326df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105573Reviewed-by:
-
Hailey Wang authored
Add a policy in Performance Manager that will be responsible for background tab loading in replacement of TabLoader class. As of now, this policy consist of loading in a FIFO order with no additional restraint. Bug: 1059341 Change-Id: I1fbbfa096f44f75cad018c81b5ce2f921863503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098743Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#750596}
-
Eugene But authored
I looked at existing Study and the number of entries is too low for statistically significant experiment. We should get more events by disabling the animations even if battery life is higher than 20%, so we can determine if animations affect PLT. This CL raises threshold to 50%, which is arbitrary chosen number. The experiment is only running on dev and canary, and not intended for beta or stable. Bug: 1006431 Change-Id: I8b6f0cb1ba876c7db11ec23169136e41c21b058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096170Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750595}
-
Robbie Gibson authored
Now, the tab helper holds whether the ui is active or not. Besides disabling the Text Zoom menu option when the UI is active, this also allows for better state logic to re-present the bar after a temporary hide. For instance, it is hidden when you begin a side swipe-to-navigate. Before, it wouldn't come back if you interrupted the swipe, but now it does. Fixed: 1056814, 1056821 Change-Id: I59d0b885bb4143c63563569837d1558af0b58024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080413Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#750594}
-
Joe DeBlasio authored
This CL fixes a mistaken NOTREACHED() that was reached when a user opened PageInfo on a page that triggered the (metrics-only) sensitive-keyword heuristic. It also adds a test for such. Fixed: 1061244 Change-Id: I11e6be8c4f75f308cc8f75f48523c4f64a275917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103398Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#750593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/496706c9672e..98b339fb3c01 git log 496706c9672e..98b339fb3c01 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 wolfi@chromium.org New icons for breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@98b339fb3c01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4493d277b78505954032b4c6b8036707790a0957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105574Reviewed-by:
-
Xiaocheng Hu authored
Both call sites of Font::Update() in FontFaceSetDocument are redundant, so this patch removes them. The first call site is redundant as StyleResolver::ComputeFont() will set the underlying Document's FontSelector to the font. The second call site is redundant as it repeatedly sets the Document's FontSelector to the font. This is also preparation for eliminating Font::Update(). Bug: 1049295 Change-Id: I43196beb8c77e420083a125a6050d73d06e7b9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103146Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750591}
-
sczs authored
When attempting to upload saved a card, there's a check where it assumes that the user providing a date expiration value is because the date was expired. This ends up calling LogSaveCardRequestExpirationDateReasonMetric which DCHECKS if the provided date is not expired. After enabling the editing support on the Save Card modal on iOS, users should not be able to send an expired date, but they will provide a date when attempting the upload (even if it is the original the date). Bug: 1029067 Change-Id: I874c8af5f24159e00a6cb3c50d46d988d3f391cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099481 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750590}
-
Yue Zhang authored
Bug: 1057828 Change-Id: I5f2c3e6d24905471d268aec3119d86d1db26fdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095924Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750589}
-
Mitsuru Oshima authored
Bug: b/148977363 Change-Id: I3568916986b9b5b8917e1ca3afa2cb0be126d150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104653Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#750588}
-
Chris Mumford authored
This change shifts from building the SQLite source in Chromium to building the SQLite source which now resides in its own repository. Motivation: now that SQLite has an official Git mirror we can switch from manually maintaining a set of patches to having a Chromium specific set of branches (master and releases). This simplifies the maintenance task and this repository. Bug: 945204 Change-Id: I83febc92d8968a75be69aeb18b352561b8817f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013741Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#750587}
-
Yue Zhang authored
http://crrev.com/c/2023250 assumes that we can get updated parent view height and width by swapping the value when orientation changes, which doesn't hold true for all devices. This CL fixes this issue by dynamically getting the parent view measures instead of using cached values. Also, this CL adds a regression test to make sure that TabGridDialog and selection editor that shows within TabGridDialog always show in the same position with same size. Bug: 1060472 Change-Id: I65dc93ebbbdababfc699671a2339a53a47d6a3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099239Reviewed-by:
-
Gauthier Ambard authored
The NewTab button is now enabled by default. This CL removes the code that is no longer useful. Bug: 974751, 998090 Change-Id: I8eb959753c35b522d58ca8c0626a1d0c7259b42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100851 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#750585}
-
Hongchan Choi authored
BaseAudioContext::decodeAudioData() caches the task runner reference so it can notify when a decoding task is finished. However, if this method gets called after the execution context is thrown away, attempting to access the task runner is invalid. This patch blocks such attempt and exit the function call. Test: Locally confirmed the repro case does not crash. Bug: 1058680 Change-Id: Id25a5bba0e4cf5a366dc1153ce4e6b353fad77ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091226Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750584}
-
Robbie Gibson authored
For unknown reasons, on iOS 13, whenever the user focuses a UITextField, the pasteboard's changeCount is incremented by 2, although the contents don't change. To fix this, if the changeCount is incremented by 2, we fallback and check MD5, because there's no way to know if the difference is because of this bug or because two actual changes occurred. It is possible to focus multiple text fields in between calls to this method (so properly, we should fallback to MD5 any time the change count difference is even), but that occurs much less frequently. The most common time this method is called is on tapping the omnibox, which will trigger the one-focus case. Bug: 1058487 Change-Id: I4d2b831840f98c071cc2dd76af10bd5d4731b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096562Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#750583}
-
Patrick Noland authored
In https://crrev.com/c/2076402/ I removed a call to setTitleToPageTitle in onTabClosed, and inadvertently failed to replace it. Rather than replacing it directly, I think it's better to call onNavigatedToDifferentPage instead. This calls setTitleToPageTitle but also updates the status icon and re-checks the TITLE_ONLY state. For context, the check for getWebContents().isLoadingToDifferentDocument() was introduced to fix a hera (tabs in the Android launcher) bug in this internal cl: https://crrev.com/i/182069 I don't think this is really relevant any longer, since Hera is long gone, but I will happily re-purpose it. Bug: 1061356 Change-Id: I9b3e8ad675a022ba1da2e2409ee6dab96775e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105396Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#750582}
-
Liquan (Max) Gu authored
Change: * Add success test * Add no-service test * Add unresponsive-service test * Remove smoke test Bug: 1057488 Change-Id: I9b3924b437b4f2eaf1fe016cee397bc75ffefc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102109 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750581}
-
David Tseng authored
Test: browser_tests --gtest_filter=ChromeVox*KeyboardHandler*.* Change-Id: Ide1ec47e01e44c8bb635335883e01d68cff50b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104263 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750580}
-
Marc Treib authored
A bunch of passwords/encryption-related helpers existed in passwords_helper/encryption_helper but also had almost-identical copies in single_client_passwords_sync_test. This CL moves all the helpers into passwords/encryption_helper and de-dupes the almost-copies -> less duplication, and they can now be used in additional tests (like PasswordManagerSyncTest). Bug: 1058339 Change-Id: I5bae176053ca6c2a063d09fa3a80efb116df4003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101000 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#750579}
-
Peter Kotwicz authored
This CL changes WebApkActivityTestRule to disable WebAPK updates. BUG=1054718 Change-Id: I193827f09fed1a6d9f7f93d78fc2a37f845df748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098769Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750578}
-
Pâris Meuleman authored
This removes crash expectations that got fixed following the changes in https://crrev.com/c/2074482. Bug: 1040059 Change-Id: I91a9bfa3b49686ec204e5103e6bae369d351fb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096587 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750577}
-
W. James MacLean authored
NavigationPredictorPreconnectClientBrowserTest .PreconnectNotSearchBackgroundForeground is flakey on mac, see bug for details. TBR=ryansturm@chromium.org Bug: 1061932 Change-Id: I23de7d1b8aec2cfa34ae9b2c2d2f6c855a961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105418Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750576}
-
Michael Thiessen authored
This is just a readability improvement, no functional changes. It was confusing that shouldCloseTab appeared to only be used in some cases like actions that result in OVERRIDE_WITH_ASYNC_ACTION, when we were actually just recomputing shouldCloseTab under the assumption that it wouldn't change. Change-Id: I52b16cef1483c328bc595bc329f4a9098b3fc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101311Reviewed-by:
-
arthursonzogni authored
Check the COOP/COEP headers defined in a response from the ServiceWorker are correctly taken into account. This test is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2100790 Bug: 922191 Change-Id: I3cbb577edb5a0fa1527464a57dff2b4863a1bc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102577 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750574}
-
Eric Willigers authored
Various includes of extensions headers from chrome/browser/ui/views are no longer required. Change-Id: I6edd33bcffa8c8b733292220239c70b1de0dc4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104708 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#750573}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I05bece4a4848cf084c65a206c76f8232f4cc7474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105416Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750572}
-
Elly Fong-Jones authored
This document outlines the associated data pattern, and the two most commonly used implementations of it in Chromium: SupportsUserData and KeyedService. Bug: None Change-Id: I45ad8d2961221fd64022168982f454fe655340fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102591 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750571}
-
Peter Wen authored
Turbine: https://github.com/google/turbine Turbine is a library for generating java headers. Java headers are equivalent to interface jars generated by ijar. Basically a .jar file of .class files that have private methods and variables removed, and method bodies removed, so that only the minimal public/package/protected interface of the class are preserved. This allows library A that depends on library B to pass in library B's header in its classpath rather than the full .jar file generated by an invocation of javac. Since turbine runs much faster than javac (3-5x speedup), this allows the libraries to be compiled with javac in parallel more often. The implementation is in a subsequent CL for ease of revert/relands. Bug: 1056299 Change-Id: I515515b874c9897ed38fa68a96cd0cd0dbf5c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090726Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18f1a2797005..71e412b29c10 Created with: gclient setdep -r src-internal@71e412b29c10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia4457b30689acc00e29b982ebfa1d567500193cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750569}
-
Roman Aleksandrov authored
Track review following setup box is checked. Change-Id: I99be8c503159194018e4af1b1f1be91237e5e8f3 Bug: 1056740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095103 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#750568}
-
Rayan Kanso authored
The test has been consistently failing. TBR=sahel@chromium.org Bug: 1061919 Change-Id: I41c50e7ed55bae4207791ac02b5ff362473945a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105434Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#750567}
-
John Budorick authored
This reverts commit 4154e5e3. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061936 Original change's description: > Fix combining characters for c with acute accent > > The table had ´c map to ç instead of ć, imitating GTK from circa 2008. > This was overlooked in the conversion, and left no way for users to > type ć (used in Polish for example). > > I speculate that GTK was imitating the Windows ‘US International’ layout, > which has that mapping. We have a separate section of the combining table > for the Windows-like ‘US International PC’ that does map ´c map to ç, > but this should not still happen for other layouts. > > Bug: 1061753 > Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750545} TBR=kpschoedel@chromium.org,yhanada@chromium.org Change-Id: I9c78d16522887c691e3e6e4cdd7d4979410c5845 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105419Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750566}
-
Gabriel Charette authored
base::ThreadPool:: (API as a destination) is the new desired paradigm. worker_pool:: was already API-as-destination; can remove redundant ThreadPool() trait with new API. R=haraken@chromium.org Bug: 1026641 Change-Id: Ida08feab710143da2308ef1361550a9aced39d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105454 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#750565}
-
