- 23 Dec, 2020 40 commits
-
-
David Bokan authored
There are two methods in this class taking a callback. - StartQueryInfo stores the callback in a queue and then calls them when a system query is done. The callbacks are always cleared after calling so these can be made OnceCallback. - InitializeProvider simply calls the given Closure and the only override in StorageInfoProvider passes it to StorageMonitor::EnsureInitialized which takes it as a OnceClosure so this is also safe to make OnceClosure. And we remove GetStorageFreeSpaceCallback since it's no longer used anywhere. Bug: 1152268 Change-Id: Ifa05987ef60c57046df4f1ee4753957a061e0edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597575Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839117}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c90fb9c33106..61a71c992a5a 2020-12-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I019fc2191913d22429398a920138a04396f94d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839116}
-
adamta authored
Uses Discover feed scroll view to add overscroll menu to refactored NTP. Bug: 1114792 Change-Id: I272d50d6fc80dd50d29a973e6f5682cacc80e886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595615Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#839115}
-
Ella Ge authored
update_state_closure_ and connecting_closure_ Bug: 1152282 Change-Id: Ieef31517ef556e02b016fdbaaaf4436e87d77bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600379Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839114}
-
Sergey Ulanov authored
Previously --enable-scaling-clipped-images switch wasn't applied properly: It was used in GpuImageDecodeCache::IsCompatible(), but not in GpuImageDecodeCache::CreateImageData(). Bug: 1157548 Change-Id: I801e5237042d0ebbc8dc115c0e88f5da9dc5a9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599924 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839113}
-
Ella Ge authored
Bug: 1152282 Change-Id: Ifc9b2fdbb7bed906a2e89d611051ce76f4626ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600029Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83d608e9f563..4121a1f12b0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: Ib99bf00eedeb2b593558efea1b947b90c8a60cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601297Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839111}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Error: "'overlays' used after it was moved". Bug: 1122844 Change-Id: I8eb3ffe4d54bf442ad55c184e47b4b922a6043b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601362Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#839110}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa711c4c756a..4e0e8d4124f5 2020-12-23 kjlubick@google.com [canvaskit] Remove custom_embedded_factory from G3 build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I3ef052a7a5dc765ff0f411be6c801b78541f404a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602218Reviewed-by:
-
Danila Kuzmin authored
Fix initial focus for additional terms of service button on eula screen. And for return focus on exit from System Security setting dialog. Bug: 1154207 Change-Id: Ie9b9d4f4ae89a7861a22ce29db23ecd1adc8b11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593264Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1159899 Change-Id: Idf206aef5e9ac66f6d4045d185b053e1a0772af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566966 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Microsoft Edge is now available for download on macOS: https://www.microsoft.com/en-us/edge Add it to the list of preset browsers, so admins can set AlternativeBrowserPath to ${edge} if they want to bounce users to Edge. Also, fix an issue where Chrome tabs wouldn't close after bouncing to the alternative browser. This affects Linux and macOS only. Bug: 1124758 Change-Id: I71d18edd7dd9cd83fdd5602be2a41eb9d0ae56a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601338Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#839106}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608702533-a7da6674f28d1e7f495e791f9b035771cce0a74c.profdata to chrome-mac-master-1608724675-36d361379e6ecc2792aff1f82c923e32f70d38c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I10ee539cbf2cc5a903f80089eadc529ffd9308e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602220Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608702533-6bb05c116d7cb786381c70818a3924a7c115f4b1.profdata to chrome-linux-master-1608724675-48ba6591ad34bc4b599f70e6d7e6561723f787a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib9449410425f7e898c5f12cebe38644ea205b6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602221Reviewed-by:
-
Fredrik Söderqvist authored
box-shadow-radius-001-ref.html -> box-shadow-radius-000-ref.html Bug: 1159514 Change-Id: I3611c3bf85143b038da652c4f28e66d2378439a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600693Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#839103}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0d94250835f..c90fb9c33106 2020-12-23 yangguo@chromium.org Console: change title for levels menu when disabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43e5ea5a285e8217dbb823b12aabe1ac60e42121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602057Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8c058266055..83d608e9f563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: Ibb368bfc7bf8b180b78bb974016de78570ebf02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602077Reviewed-by:
-
Alice Wang authored
This CL adds a JUnit test WebSigninBridgeTest to test the class WebSigninBridge. Bug: 1161437 Change-Id: Ie659459b323ff9051cb0611b86335529f01c9fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601737Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839100}
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList. Instead of storing in this class the header information as a String, a network::mojom::blink::ContentSecurityPolicyType and a network::mojom::blink::ContentSecurityPolicySource, we store directly the mojo type network::mojom::blink::ContentSecurityPolicyHeader, which encompasses the three of them. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I223dc4d204bc66a1b671248ae4ae7a24af483327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572918 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#839099}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ef082710945..b0d94250835f 2020-12-23 pfaffe@chromium.org [test runner] Allow failing fetches If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f2220d8a6a7f656d65bacf76023dcfc99bbdbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602099Reviewed-by:
-
Alice Wang authored
This CL removes the unused interface method onProfileDataUpdate(email) in the interface ProfileDataSource.Observer and its implementation. Bug: 1151860 Change-Id: I05ef3b43cdad55609a69f3a968eff6b1135e68a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600901Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5af8c738..711cf5ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6df4553d66923112b6554862bdef28537b816a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600975Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839096}
-
Alice Wang authored
This CL breaks the dependency of SigninPromoController on SigninActivityLauncherImpl to facilitate the modularization of SigninPromoController in the future. Bug: 1159833 Change-Id: I68edf1c70326984372ab881cf0f661febc8fe7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600736Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839095}
-
Moja Hsu authored
This CL adds exposureCompensation MediaTrackCapabilities. Bug: b:151048287 Test: Tested on kukui. Change-Id: I3e80d4d953d32f2fe123d02df1383206c964a1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392190 Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839094}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2752abe7e2cd..be9a4317e51d 2020-12-23 ahaas@chromium.org Fix typo and add quotes for better readability If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC matthewdeluca@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: matthewdeluca@google.com Change-Id: I312b98d3dfe8a9111a19bfe65317ca940389a22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600974Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I373c7f57663e3934a7e97787e89b196d8dda699b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600692Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839092}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b91afcfd5f7c..d447829c19fd 2020-12-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 78f4bbcd to a5e4417b (263 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Iea7c9191ad8d8f6b107f5b4ffc6aea9542bf1a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600972Reviewed-by:
-
Jacobo Aragunde Pérez authored
The dialog has the accessible name "accounts and sync". It also has a visible title and subtitle which indicate the user account name and email or login status. Making these title/subtitle part of the accessible name, we expect them to be properly announced when the dialog is open, in particular, on Mac OS X where previous workarounds did not work. We partially undo the previous workaround, with a specific provision for crbug.com/1161166. Still, some double-speech happens due to the existing crbug.com/1161135. Behavior on Mac: * Reads "accounts and sync" plus title and subtitle twice due to crbug.com/1161135. Behavior on Linux: * Reads "accounts and sync" plus title and subtitle once thanks to a workaround for crbug.com/1161166. Behavior on Windows, NVDA: * Reads "accounts and sync" plus title and subtitle once. Behavior on Windows, JAWS: * Reads "accounts and sync" plus title and subtitle once when open, then twice when tabbing into the dialog due to crbug.com/1161135. Bug: 1078580, 1161166 Change-Id: I483645ea482ef5101d8f9515027ea3129f46aad6 AX-relnotes: Mac, accounts & sync: announce dialog title and subtitle. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600976 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#839090}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2ad98d783c8..3ef082710945 2020-12-23 janscheffler@chromium.org [Recorder] Emulate network conditions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156625 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic4a2d1011106fff1cf5e3afa806c91db732ea302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602056Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I82d504df793906faa101e79196364a0c0a98bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601522Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839088}
-
Wolfgang Beyer authored
Bug: 1161439 Frontend CL: https://crrev.com/c/2601966 Change-Id: If5f3a2799981d16d7830bf0508f4af7dba1c1c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601481Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839087}
-
Henrique Ferreiro authored
Because both types are enums, they are used in many places interchangeably. This CL changes incorrect uses to use the appropriate type. Bug: 1093536 Change-Id: I7b4609f70ac0803b78c84354dd51364207dd1e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587741 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08c0b2de4d50..c8c058266055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: vasilii@google.com Change-Id: Ie6b63b19a9e6b05078685f2628c9ea46288c7b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601280Reviewed-by:
-
Bao-Duy Tran authored
In accordance with how InputMethod.ID2 metric is logged [1], the following snippet was used to "autogen" new mapping entries which were then passed through "git cl format" for sorting: std::string prefix = "_comp_ime_jkghodnilhceideoidjikpgommlajknk"; std::string ids[] = { "experimental_...", ... }; for (auto id : ids) { int32_t hash = static_cast<int32_t>(base::PersistentHash(prefix + id)); LOG(ERROR) << "<int value=\"" << hash << "\" label=\"" << id << "\"/>"; } [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_manager_impl.cc;l=995-997;drc=e5caacef0a5d161e83f4eb98ccc5f90457ba84ec Bug: 1159297 Change-Id: I89e12ada6483f0c4e008ef681282edd12b680a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599651Reviewed-by:Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#839084}
-
Alice Wang authored
This CL adds a render test for SigninFragment with child account. Bug: 1045525, 1048254 Change-Id: Ic2d7e3547a66fb16af7aac6074322cc6d2f5b854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550181 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I936ebf3176c78e47dc8c6e71841c615af32c7cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601759Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608669833-81935a5ef3eac5be8a1967fe04891c8cf8108546.profdata to chrome-win64-master-1608692346-a5866de54d0b0b083300633703188b0bd8d56834.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie3349a6d14af6d717f0db5891576ca36d11c6b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600963Reviewed-by:
-
Anastasiia N authored
After we migrated c/b/resources/gaia_auth_host/ to JS modules, webview_saml_injected.js file in saml_handler.js wasn't inlined in "injectedJs" variable anymore. Since "// <include ..." doesn't work for generated files, "addContentScripts" call is updated to load the script from file instead. saml_handler.js is also used in OOBE and in-session password change flow. This CL updates their webui files to include webview_saml_injected.js. Bug: 1160632 Change-Id: I47a5bc0b2119dd0bab9bb492ccd743ce2cd48d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599861Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#839080}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a7dee84857b..c2ad98d783c8 2020-12-23 janscheffler@chromium.org Revert "Add header context menu to data grid" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150793 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I397f957909654cda01f736c6859d92f80c6abf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599355Reviewed-by:
-
Moja Hsu authored
This CL adds iso MediaTrackCapabilities. Bug: b:151048287 Test: Tested on kukui. Change-Id: Icf05d4666f5d6fbe31f1cb768730c9f7e5444a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374467Reviewed-by:
-
