GitLab

This reverts commit 660c9cef.

Reason for revert: AmbientContainerViewTest.MouseClickClosesWidgetAndStopsTimer failing deterministically on several linux-chromeos bots. Please see https://crbug.com/1068745 for more information.

Original change's description:
> ambient: Show lockscreen contents on detecting user interaction.
> 
> In ambient mode, when user interacting with the background image by
> mouse or gesture, lock screen contents (login pod and media control
> view) need be shown on top for users to either do re-authentication,
> or media control.
> 
> This CL implements a prototype of this view transaction by:
> 1. Show the lock screen contents, and
> 2. Fade-out the current shown image.
> 
> Bug: b/149246238
> Test: manually.
> Change-Id: Ie31c666cdfaddefc863ff8173dc185d73ef19178
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110689
> Commit-Queue: Meilin Wang <meilinw@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757120}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org

Change-Id: I395a7c02c6aa292f66ca5d9b4aefa9156e057773
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/149246238, 1068745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139369Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757223}

Now that a large bulk of the VRServiceImpl code has moved from chrome/
to content/ adds entries to the corresponding trybots to also run for
the new content/browser/xr directory

Bug: 1031622
Change-Id: If5af861e97cf5e6f88a3a39f47688e64782f579c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135065Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757222}

Original CL: http://crrev.com/c/2134848
Revert: http://crrev.com/c/2138415

Landed at the same time as another change that affected test
expectations, just needed to be rebaselined and landed again.

This is an issue with AXObjects that are ignored and not
included in the accessibility tree. When we fire an event
on such a node, the serializer owned by
RenderAccessibilityImpl first walks up to find a common
ancestor that is in the tree, and then serializes that
node, even if it was already serialized. It breaks the
mechanism that avoids re-serializing nodes that were
already just serialized.

In extreme circumstances, this led to a bug where the
size of the AXTreeUpdate for a large table grew to 200MB
for one particular website, even though the resulting
AXTree had only around 2MB worth of data.

The fix is simple: when a node changes, only fire a
notification on the nearest ancestor that's in the tree.
That way the serializer can avoid redundantly processing
the same node more than once.

Covered by a new test and a DCHECK that asserts that we
should never get an AXTreeUpdate with more nodes than the
size of the resulting tree. Without the new fix, the test
fails with an AXTreeUpdate containing 1000 nodes with a
tree of size 10.

Bug: 1066880
Tbr: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Tbr: Aaron Leventhal <aleventhal@chromium.org>
Relnotes: N/A
Change-Id: I485e8d98d8fe9638706e26ceff642664a3fa6e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140033Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757221}

Pixel_OffscreenCanvasWebGLPaintAfterResize is set to retry on failure on
Nexus 5X.

Bug: chromium:1068620
Change-Id: Ie65b6038eefd13531457b9dacede01b1a934a265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139357
Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757220}

Rename cache expiry field to be the last fetch
time that we did not hit the cache.

BUG=1053599

Change-Id: I4568e2494b84369430eef436d77bce8a43b260d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137507Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757219}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3863fc52b9e5..48c5c9c50455

git log 3863fc52b9e5..48c5c9c50455 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@48c5c9c50455

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ie6eb4489fd42026bacf94f1e3c27e1820db75b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140517Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757218}

This CL adds <title>, <link rel=help> and <meta name=assert> data to the
test case. Additionally, it moves/renames it to
external/wpt/css/css-flexbox/remove-out-of-flow-child-crash.html

Last, the calls to testRunner.dumpAsText() is dropped.

BUG=1063749
R=smcgruer@chromium.org

Change-Id: I33a81ab8ac0b93c4794e530ca7ea3c56f0b5e41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139902
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757217}

BUG=none
TEST=none

Change-Id: I31c297f61dc5d3526efe7fc3164f30e02c730283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138596
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757216}

https://android.googlesource.com/platform/external/perfetto.git/+log/97d7d4772df7..124f03b3f6f9

git log 97d7d4772df7..124f03b3f6f9 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 treehugger-gerrit@google.com Merge "Read /proc/tid/time_in_state"

Created with:
  gclient setdep -r src/third_party/perfetto@124f03b3f6f9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ie42dba9de42ed5f22bfc9367390155c70344605e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757215}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/203b5f85..4a1f3ae4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie570072d26ef7285071953bb64e1496cb56480d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140413Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757214}

This reverts commit 21274196.

Reason for revert: Mac10.13 Tests trybot failures on CrSettingsPrivacyPageV3Test.PrivacyPageTests for all of the last 3 runs. (all runs since the test was updated in this CL)

Trybot runs: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29
First failed run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17846

Original change's description:
> Ensure cookie_controls_mode is set with block_third_party_cookies
> 
> To ensure that the two related preferences, cookie_controls_mode and
> block_third_party_cookies remain in a consistent state, this CL updates
> the existing block_third_party_cookies toggle located in settings
> to update both preferences.
> 
> Bug: 1068144
> Change-Id: Ia64cb37c766a3143c6ac986efc67e87283852a8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134261
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
> Cr-Commit-Position: refs/heads/master@{#757019}

TBR=dpapad@chromium.org,dullweber@chromium.org,sauski@google.com

Change-Id: I207144aed2d417f7531676db12ad9c6fc7e8e992
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140771Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757213}

This reverts commit eabaf8df.

Reason for revert: WebAudio tests failing. See https://crbug.com/1068735 for more information.

Original change's description:
> Handle k-rate AudioParam inputs for BiquadFilterNode
> 
> In addition to making BiquadFilterNode AudioParams apply the input to
> the param, we also needed to fix an issue in
> CalculateSampleAccurateValues when the param is k-rate.  We would sum
> in all the values for the input instead of just taking one.
> 
> Manually ran the new test case with Chrome stable and all the tests fail
> as expected.
> 
> Bug: 1015760
> Test: k-rate-biquad-connections.html
> 
> Change-Id: I412f9567909d8dd6d4cf00036138b47a454c431c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083224
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757155}

TBR=rtoy@chromium.org,hongchan@chromium.org

Change-Id: I1692cdd5ce1c382d2337a1b7e1393cea9fdc8909
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140609Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757212}

Added new config for the processor builder. Lightweight argument in this
context means the builder is assuming the perf data upload is done on the
processor side.

Bug: chromium:1045256
Change-Id: I21f3fbf57845dc3ab609d3fd1cd1602bf8ca7c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134679Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757211}

With Polymer2, observers may be called with undefined parameters.
updateVpnType_() which predates the migration was assuming that
vpnType_ was defined.

Bug: 1068533
Change-Id: I6583d7ec72b591dcc4dcaa75a922f5de36373655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139442Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757210}

https://chromium.googlesource.com/openscreen.git/+log/9508a74c93b3..7ea440367483

git log 9508a74c93b3..7ea440367483 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 btolsch@chromium.org Add URL class

Created with:
  gclient setdep -r src/third_party/openscreen/src@7ea440367483

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Ie78be6217eed810371354f437d01e55c66f7d240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140515Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757209}

This will allow for us to break unnecessary abstractions between these
two components and collapse duplicate types (e.g. the two separate
RenderFrameObservers).

Followup CLs will remove the test_runner namespace, and move the files
into the //content/shell/renderer/web_test directory.

R=avi@chromium.org

Bug: 866140
Change-Id: If509c311337b94df7085a6f6b115872678d3635d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140301
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757208}

BUG=1068493

Change-Id: I49c6b8fa21b2b35d8f1a95952136ef9b09ad8107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139360
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757207}

https://skia.googlesource.com/skia.git/+log/0999bce974ac..869ec6a5e6a0

git log 0999bce974ac..869ec6a5e6a0 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 mtklein@google.com backup plan for ASAN bots
2020-04-07 reed@google.com approximate sine for skvm
2020-04-07 mtklein@google.com remove SK_USE_SKVM_BLITTER
2020-04-07 jlavrova@google.com Mixed languages text crashes
2020-04-07 reed@google.com remove deprecated concat44 -- use concat
2020-04-07 mtklein@google.com restore debian9 asan jobs
2020-04-07 mtklein@google.com drop luminance parens
2020-04-07 csmartdalton@google.com Reland "Rename instanceAttribSupport -> drawInstancedSupport"

Created with:
  gclient setdep -r src/third_party/skia@869ec6a5e6a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: csmartdalton@google.com
Change-Id: I057bc0f3c99f33045d33803f8208040860f8fc58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140513Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757206}

Create new metrics which enumerate the reasons for connection
failures, breaking down the failure buckets of
Bluetooth.ChromeOS.Pairing.Result and
Bluetooth.ChromeOS.UserInitiatedReconnectionAttempt.Result.

TEST=Manual testing via pairing/reconnection.

Bug: 953149
Change-Id: I901595bc203020c5b35a1f64b56ac717d15d6509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090302Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757205}

This CL adds focus rings that are only used when button row is enabled.

Bug: 1046523
Change-Id: I679cd08c0199eb5de5ac5577a49ef9ce5fdd7b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140309Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757204}

Changed according to UX review.

Bug: 1068664
Change-Id: I24389f36d13b1612c79653525badca4ee6e00e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140304Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Robin Lewis <wrlewis@google.com>
Cr-Commit-Position: refs/heads/master@{#757203}

Link class used to have two focus styles: focus ring and underline. Now
we always use underline focus style. So remove all the code related to
supporting different focus styles.

BUG=none
TEST=nothing should change.

Change-Id: I80b826ff246e0fbfd18c73f79b17f7e34f43a740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138781
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757202}

Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Bug: 1063749
Change-Id: Id406f4df17b8e60e79828f37295d404b49521fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129966
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757201}

The test is still flaky, although less than before.

This CL replaces the default constructor by an explicit one which should
copy the set of URLs and help with the flakiness.

Change-Id: I2205d681a62fb19de5cabe675504503facdf7d2b
Bug: 1065285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136886
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757200}

The pagemap is a file in procfs for each process. It contains
information on every page mapped into that processes virtual
address space. This CL adds a pagemap parser as we will need
one for future CrOS projects, specifically userspace swap.

Bug: 1067833
Change-Id: I31aafcebd5894899f13748d6a3f13f9f1edf375d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138771
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757199}

They do not seem to be currently working on the Chromium project.

Change-Id: I621fb17cd1cff49a7c982771b0746f6b1db87e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140302
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757198}

Instead, use EXPECT_CHECK_DEATH, which checks the right macros to know if it's
supported or not.

Bug: 1068477
Change-Id: I88c56ff59d7cb68c7f74acaa02d0e6fa06376d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140353
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757197}

Bug: webrtc:9547
Change-Id: If65cddb449e32cfce92bc13bf3db167f148c5bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139753
Commit-Queue: Eldar Rello <elrello@microsoft.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757196}

VideoFrameExtractor should not be built when media_use_ffmpeg build
flag is false.

This CL splits ThumbnailMediaParser to an interface and use empty
implementation based on media_use_ffmpeg.

There are other build errors, this CL only fixes the one in
VideoFrameExtractor use case.

Bug: 1066404
Change-Id: Ib856899b4d465a817634b468866d3fb62d7c5053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131036Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757195}

No change to logic. This extends this metric so it can be used as a
proxy for AndroidX (AKA "support library") adoption.

Fixed: 1063900
Test: N/A
Change-Id: Iad348c1707441fde2bb7e28bd113818942f45831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138891Reviewed-by: Laís Minchillo <laisminchillo@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757194}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09fdff26a543..84b79c6d200a


Created with:
  gclient setdep -r src-internal@84b79c6d200a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1026378,chromium:1064181
Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com
Change-Id: I4abb2fec347604aae6468f6ec65d4089d983490a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139592Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757193}

This reverts commit 2c6eb18b.

Reason for revert: Reverting temporarily to confirm effect on metrics

Original change's description:
> Overlay scrollbars work correctly without overflow
> 
> Overlay scrollbars - the type that fade in/out, not overflow: overlay -
> should only ever be visible when the content is scrolling. Therefore, if
> the content cannot scroll, we should never see an overlay scrollbar.
> This is different from classic (i.e. non-overlay) scrollbars. An
> overflow:scroll scroller requires showing a (disabled) scrollbar even
> when there is no overflow. Today, when an overlay scrollbar is created
> we check after-the-fact in UpdateAfterLayout whether there is overflow
> and, if there isn't, we remove overlay scrollbars. This is how the above
> mentioned behavior for |overflow:scroll| overlays is implemented.
> 
> However, this doesn't account for different kinds of updates.
> UpdateAfterStyleChange must also recompute scrollbar states and didn't
> have this no-overflow removal logic. If content caused a style update
> that didn't require a layout, an overlay scrollbar would be attached in
> this case. In the attached bug, the scrollbar is visible because the
> fade out (on the main thread) is controlled by a timer that causes
> scrollbars to be disabled (which causes them not to paint). In addition
> to incorrectly creating the scrollbar, UpdateAfterStyleChange does not
> compute the scrollbar enabled state so it defaults to true. Without
> being able to scroll, the fade out timer is never started.
> 
> This CL fixes the issue by moving the overflow requirement for overlay
> scrollbars into ComputeScrollbarExistence so that we account for it no
> matter the point at which we recompute scrollbar existence. We also
> refactor ComputeScrollbarExistence to make clear the distinction between
> overflow dependent and independent computations.
> 
> A considered alternative was to always create the scrollbar but ensure
> its enabled state is correctly set. This would have unified the
> lifetimes of overlay and non-overlay scrollbars. However, it requires we
> prevent creating composited layers for scrollbars that are overlay but
> have no overflow since the compositor fades all of a scroller's
> scrollbars together so such scrollbars would become visible if the other
> axis is scrollable. We couldn't use the enabled state for this because
> it is flipped every time the scrollbars fade in/out so that would cause
> layers to constanty be created/destroyed so we'd have to introduce more
> complexity to compositing decisions.
> 
> This change caused three tests to break (note: unit tests generally use
> mock overlay scrollbars):
> 
> RepaintScrollableAreaLayersInMainThreadScrolling:
> 
>   A style change like this does not require invalidating paint on
>   overlay scrollbars' compositing layers since the compositor can deal
>   with resizes on its own.  However, this was causing an invalidation
>   because of the bug fixed here: the style change adds a horizontal
>   scrollbar and the layout removes it. Because it isn't composited, it
>   causes the whole PaintLayer to be invalidated[1]. This causes the
>   scrollbar layer to also need a repaint[2]. Since we no longer cause
>   this creation and destruction of the horizontal scrollbar, we don't
>   get this invalidation.
> 
>   This test now resizes the overflow so that the vertical scrollbar
>   needs to be disabled which does cause an invalidation.
> 
> [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc?l=2845&rcl=33a9a3956034a765124f034a8f7d86f19c9c17e6
> [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc?l=2099&rcl=01e24ce806680bf99abf117e77d30d9566c72121
> 
> TraverseNonCompositingDescendantsInPaintOrder:
> 
>   The source of the failure here was that the |overflow:scroll| div no
>   longer has overlay scrollbars after its style is updated (but before
>   it does layout). When it performs PaintLayer::UpdateSelfPaintingLayer
>   it will no longer be self painting[3]. Since it no longer has a self
>   painting layer it will be added to the parent's visual overflow. This
>   larger rect means that during overlap testing, the scroller's sibling
>   (#stacked-child-of-composited-non-stacking-context) and its parent
>   will overlap and so the sibling will require compositing. Finally,
>   because it is now composited, it is now a paint invalidation container
>   and so it won't be invalidated from the container element[5].
> 
>   The fix here is to simply add overflow to the scrolling div so that it
>   continues to cause a self painting layer in [3].
> 
> [3] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer.cc?l=3054&rcl=fa18fef1b31a878fed89e2a543c3be0af2f57623
> [4] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_box.cc?l=5780&rcl=0650ec2415a0f2583db48d11c6d8b6a31ff448c4
> [5] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/object_paint_invalidator.cc?l=70&rcl=d9d7df43f1718c900afc470371b382c8dca085b6
> 
> mock-scrollbars.html:
> 
>   This was failing only on the legacy LayoutNG disabled bot so I didn't
>   dig too deeply into it. The failure here was that the inner box would
>   layout as if the parent had non-overlay scrollbars. I believe this is
>   because the mock scrollbars were being enabled at load, after layout
>   was already completed. I think this used to work because the scrollbar
>   was being added and then removed which would cause a layout
>   invalidation which no longer happens, thus we need to ensure mock
>   scrollbars are enabled before we produce the first layout.
> 
> Bug: 1039501
> Change-Id: Ic68522a4fdba8ffaa2c5ef508736c9a94eac7682
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119933
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754808}

TBR=wangxianzhu@chromium.org,bokan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1039501
Change-Id: Ifa1851da28d080686d7444db56ea660638f469d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140310Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757192}

When background image is selected in the customize dialog, ntp-app shows
the selected image as the background to provide a preview for the user.

Bug: 1032328
Change-Id: I132ab25a7475cd165f3f83e0c7a5370f6f65d51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137482Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757191}

Bug: 1068652
Change-Id: I279118e5f833818c1c87bc5ad0f7a05e1a8db3cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139418Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757190}

This adds a run-clusterfuzz script that can be used to launch
WebKitTestRunner on ClusterFuzz bots. Checking this script into the
repository will make it easier for buildbots to package the script along
with the rest of the build when creating builds for fuzzing.

Bug: 1053304
Change-Id: Ie2e311b862265c008e518b7d00b609265976ec5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140034Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757189}

This reverts commit 1527cb7a.

Reason for revert: TestCases/SpellcheckLanguagePolicyHandlersTest.ApplyPolicySettings fails on win7 bot

See crbug.com/1068703 for more info.

Original change's description:
> Spellcheck: Apply policy for languages that lack Hunspell support
> 
> Spellcheck languages that have Windows platform support but not
> Hunspell support (Arabic, Finnish, ...) cannot be disabled or forced
> enabled by enterprise policy. This is because of the use of
> spellcheck::GetCorrespondingSpellCheckLanguage in
> SpellcheckLanguageBlacklistPolicyHandler::SortBlacklistedLanguages and
> SpellcheckLanguagePolicyHandler::SortForcedLanguages, a method that
> only recognizes Hunspell languages.
> 
> The fix is to instead check if a language with policy being enforced is
> on the list of supported accept languages, as these are what are used
> to populate the language list on the language settings page. Note that
> in the upcoming implementation of support for non-Hunspell languages,
> we will only allow Windows platform spellchecking for these accept
> languages (if they have a Windows spellcheck dictionary).
> 
> Instead of just searching for the accept language within the tag, the
> algorithm first tries for an exact match (so "en-CA" would be found),
> then searches for an exact match for the language without locale
> info, that is, what's to the left of the hyphen in a language tag
> (so "ar" would be found for "ar-SA").
> 
> Also adds unit test coverage for the spellcheck policy handlers, which
> previously had none.
> 
> Note that there is an interplay between forced and blocked languages,
> as well as the spellcheck-enabled policy:
> 
>   1) If a language is both forced and blocked, forced wins.
>   2) If spellcheck is disabled by policy, the forced/blocked languages
>      policy has no effect.
> 
> Test cases cover this interplay.
> 
> Bug: 1056850
> Change-Id: Iec54a851d38f00a7aa7597449f7acc30f3dd2de3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080450
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Bruce Long <brlong@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#757107}

TBR=avi@chromium.org,rouslan@chromium.org,pcupp@microsoft.com,brlong@microsoft.com,gujen@google.com

Change-Id: I4653ecce1cb2b7162d1a3eba5a5e7ef2238943ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1056850, 1068703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140672Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757188}

- Print jobs will be displayed in a reverse chronological order
  (newest at top).

Bug: 1053704
Test: browser_tests
Change-Id: I0551551f5a7761f068e618d3098d803e155ac114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128973
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757187}

BUG: 1068233

Change-Id: I097c23f8e490dfe37fdffe54f83be7b28f52205c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135947
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757186}

These features have already launched, so no need to enable them for
tests.

Bug: 1068182
Change-Id: I86464e0b420b42b5b945e40166276c1dd6c968b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140294Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757185}

Also removed "ViewsLogin" feature making it enabled

Fixed: 987587
Cq-Depend: chromium:2134259, chromium:2122927
Change-Id: I99e50481998e7a5a7a3ff1402ffd96d6bf286c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135693Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757184}