- 26 Feb, 2019 40 commits
-
-
Stepan Khapugin authored
Makes Primary Toolbar contain Location Bar to get the view events at the correct times. Also clears selection when the omnibox is disappearing to prevent the selection handles from showing in the tab grid. Bug: 823423 Change-Id: I848ee9b7ba00bf83614e20fbbd37fe971a92caa7 Reviewed-on: https://chromium-review.googlesource.com/c/1429989 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635609}
-
Ben Pastene authored
Change-Id: I1c2903e46e002a5a0f3bd3507563b56d66b6b7ea Reviewed-on: https://chromium-review.googlesource.com/c/1484589Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#635608}
-
Ehsan Karamad authored
This CL will rework the attaching logic for frame-based MimeHandlerViewGuest. The notable change is the addition of a new public API to RenderFrameHost which will (asynchronously) prepare the FrameTreeNode for attaching an inner WebContents so that its usage with the attaching API, WebContents::AttachToOuterContentsFrame is safe. Previously this was achieved by navigating the current RenderFrameHost to "about:blank" but that proved to have certain issues such as navigation races as well as inefficient handling of the 'beforeunload' handlers (from outside content layer it is nearly impossible to determine whether a beforeunload modal is shown and is blocking the navigation). In summary, with this CL: 1- There is no longer a need for a navigation to about:blank for every embedded PDF. 2- There is no need for adding navigation throttles. 3- beforeunload is properly addressed (an improvement over the previous approach of waiting for a timeout to decide navigation was actually blocked). 4- Less lines of code and a more tractable attaching code. Bug: 659750, 911161 Change-Id: Ib8981744b5683bb1cb8d557322bfc40f08bb4ccb Reviewed-on: https://chromium-review.googlesource.com/c/1407596 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#635607}
-
Hans Wennborg authored
Bug: none Change-Id: I36d0ac15f4852bada843e2bc4e4330f6f4c082d4 Reviewed-on: https://chromium-review.googlesource.com/c/1489240 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635606}
-
Alex Clarke authored
The current check fail message for ~TestBrowserThreadBundle can be augmented by listing all pending tasks. This should make it easier to diagnose flakes. I've seen this happen in ParentAccessServiceTest.NoValidConfigAvailable Bug: 935515 Change-Id: If88ce656091ba4176cfdbf2c7313a7861b64379a Reviewed-on: https://chromium-review.googlesource.com/c/1486352Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635605}
-
Chromium WPT Sync authored
Using wpt-import in Chromium addb1c72. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." 32a115f8 "[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max" ec3bf6e6 "Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Id011535f7d12e4e1cc159c5334c5a63d68e0961a Reviewed-on: https://chromium-review.googlesource.com/c/1488507Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635604}
-
Steven Bennetts authored
Bug: 931156 Change-Id: I5be7fee2867371ef77d300013cf021e8be4e9203 Reviewed-on: https://chromium-review.googlesource.com/c/1488112Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635603}
-
Antonio Gomes authored
This is the second out of two CLs that switch Blink to using downcast helpers (t_p/blink/renderer/platform/wtf/casting.h) instead of the macro-based ToLocalFrame helper. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I19f6196293812b94e123390550b73a63f6d617af Reviewed-on: https://chromium-review.googlesource.com/c/1489211 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#635602}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0bf4c298529b..12ae4f4d50b0 git log 0bf4c298529b..12ae4f4d50b0 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 mbonadei@webrtc.org Introduce possibility to poll stats and notify analyzers. 2019-02-26 danilchap@webrtc.org Test default TaskQueue implementation via TaskQueueBase interface 2019-02-26 phensman@webrtc.org Remove Legacy ADM from AppRTC mobile Created with: gclient setdep -r src/third_party/webrtc@12ae4f4d50b0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iad533d662b420d13bb5442f1931af408d2228b7e Reviewed-on: https://chromium-review.googlesource.com/c/1489066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635601}
-
Suman Kancherla authored
Bug: 935758 Change-Id: Icb10d092a1e7c7849d89646fe5337e7b6efe4449 Reviewed-on: https://chromium-review.googlesource.com/c/1487810 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#635600}
-
Mikhail Khokhlov authored
We generalize CustomizeBrowserOptions() to be able to customize all options. New function will be call CustomizeOptions(). We do it in 3 steps: 1) Add CustomizeOptions() method to Benchmark. 2) Overload it in PerfBenchmark, instead of CustomizeBrowserOptions(). 3) Remove CustomizeBrowserOptions() method from Benchmark. This is step 2. Bug: 801528 Change-Id: Ia1db40a04d5fddf1c634074bbd8f92ba4ccfc6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1479965 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#635599}
-
Bo Liu authored
On platforms like android webview where the decision to enable wide color gamut on a capable device/os is not controlled by chromium, it is important to query Window.isWideColorGamut in order to set the right color space. This is fundamentally incompatible with the rest of chromium platforms where window wide gamut state matches that of the display. It's also more complicated since there can be multiple windows in the same display with different wide gamut state. This is somewhat of a hack to get a "display" from WindowAndroid that has the color space info that matches the window rather than the display. Note wide color gamut is still disabled so this CL by itself should be no-op. Bug: 924588 Change-Id: I80277d1b72538e038d236753e399f048bdaa0aa6 Reviewed-on: https://chromium-review.googlesource.com/c/1484817 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635598}
-
Andrew Xu authored
Test: None Bug: 934344 Change-Id: Ia0ce9b0428f8cff1fca654ee076303402f49bb74 Reviewed-on: https://chromium-review.googlesource.com/c/1487871Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ab2257c7e108..c1b9ea5f3400 git log ab2257c7e108..c1b9ea5f3400 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 fmayer@google.com Merge "Set receive timeout on sockets." 2019-02-26 hjd@google.com Merge "perfetto-ui: Send state updates as patches" Created with: gclient setdep -r src/third_party/perfetto@c1b9ea5f3400 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id72ce0918b7def5ab508e0d1d15156268a384931 Reviewed-on: https://chromium-review.googlesource.com/c/1489253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635596}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/264b7c18a357..c9b534ba2cb9 Created with: gclient setdep -r src-internal@c9b534ba2cb9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifdecb00eceff0a8b0b3f784ca8527241cee8c233 Reviewed-on: https://chromium-review.googlesource.com/c/1489067Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635595}
-
Michael Lippautz authored
Canonical fix: - Model liveness through OscillatorNode (AudioNode), i.e., keep alive listener from there. - Change off-thread handler to use a weak root This works as AudioNode disposes the handler in the pre-finalizer. This fixes webaudio/Oscillator/osc-low-freq.html for unified heap running with leak detection. Bug: 928781, 843903 Change-Id: I58a76bb0d5a47e65e91516cde6c4fe77044cb8ae Reviewed-on: https://chromium-review.googlesource.com/c/1488922 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635594}
-
Josh Nohle authored
Add a convenience method GetKeyBundle() to CryptAuthKeyRegistry that returns a const pointer to the key bundle in the registry if it exists. If no key bundle is found, nullptr is returned. We clean up the unit tests by using this method. Also, we make sure EXPECT_EQ has the form EXPECT_EQ(<expected>, <actual>). Bug: 899080 Change-Id: I7d2ca0d8ccfe0fc2a091a90cba794dbd1ad15780 Reviewed-on: https://chromium-review.googlesource.com/c/1474646 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635593}
-
Josh Nohle authored
Expand CryptAuthEnrollmentResult::ResultCode enum to accommodate more fine-grained error codes as well as error codes relevant to the enrollment manager, such as kErrorGcmRegistrationFailed and kErrorClientAppMetadataFetchFailed. We also overload the << operator for ResultCode printing. Bug: 899080 Change-Id: I69a3e97e6987d4e3e54444febdecde3ef40137c9 Reviewed-on: https://chromium-review.googlesource.com/c/1488116 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635592}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0eaf0e583bffa4a025a354433675b8d2788b17b9 Reviewed-on: https://chromium-review.googlesource.com/c/1489065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635591}
-
Becca Hughes authored
Use media_session::MediaImageManager to rank the images based on the specified minimum and desired sizes. BUG=914430 Change-Id: I10ba6f8743f256f180233b7d65e524ccd12b2c6d Reviewed-on: https://chromium-review.googlesource.com/c/1464963 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635590}
-
Chris Hamilton authored
This moves the implementation of PageAlmostIdle from PageSignal(Generator|Receiver|Observer), to a new "decorator" that runs directly in the graph. BUG=931407 Change-Id: I1e8c86e34f4cdd224cb3b77c7545debcffc820a4 Reviewed-on: https://chromium-review.googlesource.com/c/1471750 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#635589}
-
Xiaocheng Hu authored
[Sheriff] Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-alphabetic-invalid.html as failure on Mac Bug: 935689 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: Iaf8fc68d5fa7aeea1f81cff12ae165d1fe92f206 Reviewed-on: https://chromium-review.googlesource.com/c/1489306Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635588}
-
Owen Min authored
The new policy sources is used by the cloud policies that have high priority than other policies. Also do some other refactor: 1) Move the CloudPolicyOverridesMachinePolicy pref registy to policy component. 2) Delete policy_helper.h/cc because it's empty. 3) Make policy_ui_handler and policy_conversions share the same instance of PolicyStringMap. Bug: 749530 Change-Id: Ie3a9c9ce87bd78bc9159582eae4d463616fd9aeb Reviewed-on: https://chromium-review.googlesource.com/c/1488011Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635587}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/804f17e35b25..0c48681e58d6 git log 804f17e35b25..0c48681e58d6 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 brianosman@google.com Few more particle features and some generalization work Created with: gclient setdep -r src/third_party/skia@0c48681e58d6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3fca99ac14e3911dc3bb88bdcba2cfb9e606213e Reviewed-on: https://chromium-review.googlesource.com/c/1489064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635586}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59fd65cbda8c..f53e1f6e2d49 git log 59fd65cbda8c..f53e1f6e2d49 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 khokhlov@google.com Use JS trace model in memory dump tests 2019-02-26 sadrul@chromium.org speed: Look only for the appropriate devices/browsers. Created with: gclient setdep -r src/third_party/catapult@f53e1f6e2d49 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932409,chromium:935578 TBR=sullivan@chromium.org Change-Id: I06a2f51e6421a89e0ff41caa6775babc712c380a Reviewed-on: https://chromium-review.googlesource.com/c/1489252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635585}
-
Olya Kalitova authored
Add progress reporting for unzipping of downloaded PluginVm image archive. This CL also changes signature of OnProgressUpdated method so this method is consistent with the new OnUnzippingProgressUpdated method and not only fraction complete could be reported, but the number of bytes processed as well. Test: unit_tests --gtest_filter="PluginVmImageManager*" Bug: 904851 Change-Id: I66333f3e31ee339673889e39fab7c5da59303142 Reviewed-on: https://chromium-review.googlesource.com/c/1484097 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635584}
-
Nico Weber authored
TBR=jschuh Bug: 926235 Change-Id: I82aef9e11b7943a0d5fa956d0d7ce41b538b1331 Reviewed-on: https://chromium-review.googlesource.com/c/1489135 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635583}
-
Gang Wu authored
No Sizes info for this DEPs roll since the CL https://chromium-review.googlesource.com/c/chromium/src/+/1478174, the CL using FeedHostServiceFactory in internal page's code, and when compile when the Feed disabled, we got compile error. Change-Id: I5cdea66b8fb4ffdc25ec759c59663e644e51ab30 Reviewed-on: https://chromium-review.googlesource.com/c/1487951 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#635582}
-
Nico Weber authored
Bug: 926235,936004 Change-Id: Ie999c91d5f9aed729ff1c1d412af441f64da8fbe Reviewed-on: https://chromium-review.googlesource.com/c/1489138 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635581}
-
Etienne Bergeron authored
This CL is adding the FROM_HERE location of the call sites to each ScopedBlockingCall. This modification will provide the detailed location to the trace events and allow developpers do understand cause of janks of long tasks. This CL is trying to catch most of the call sites using this pattern: ^(\s*)(base::)?ScopedBlockingCall ([a-zA-Z0-9_]*)\((base::)?BlockingType --> \1\2ScopedBlockingCall \3\(FROM_HERE, \4BlockingType Over every .cc, .h and .mm files under chromium. TBR=gab@chromium.org (mechanical change for //base) Bug: 934302 Change-Id: I9b7a573ab84d81cae1b8fc173b6e8ff96155ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/1483834 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#635580}
-
Tibor Goldschwendt authored
Bug: 935527 Change-Id: Icde2604869ee225853104a3bbe62e5948cb93946 Reviewed-on: https://chromium-review.googlesource.com/c/1486672 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#635579}
-
Jan Krcal authored
This CL adds one missing unit-test for reacting to local changes. Bug: 936013 Change-Id: Ie494115465e0c61fca74a101e64ee801daf48675 Reviewed-on: https://chromium-review.googlesource.com/c/1489244 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#635578}
-
Corentin Wallez authored
use_dawn controls whether Dawn and its dependencies are integrated in Chromium to support WebGPU. It currently defaults to false while we work out the details of the integration of Dawn both code-wise and for the launch. BUG=877147 Change-Id: I31c3780e024f325c6dbcd4b89dd809199de8df0d Reviewed-on: https://chromium-review.googlesource.com/c/1488921Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635577}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/53c8957c337d..024f271ae0c7 git log 53c8957c337d..024f271ae0c7 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 capn@google.com Fix fuzzer build 2019-02-26 capn@google.com Work around x86-64 calling convention bug 2019-02-26 headlessclayton@gmail.com SpirvShader: Decouple SPIR-V type attributes from object representation 2019-02-26 bclayton@google.com Strongly type object / type identifiers. 2019-02-26 chrisforbes@google.com Remove VertexProcessor::multisampling state bit Created with: gclient setdep -r src/third_party/swiftshader@024f271ae0c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126126820 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I221df04b5d938a0c892b89780429ec93a9d540a0 Reviewed-on: https://chromium-review.googlesource.com/c/1488833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635576}
-
David Roger authored
The strategy for reconciliation is to always reconcile, and keep the current default Gaia account if there is one, otherwise the first system account. This strategy can be refined later. Change-Id: Ia1e0e1d08e5f071159b07474ab6d56a169822316 Reviewed-on: https://chromium-review.googlesource.com/c/1475405 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635575}
-
Becca Hughes authored
Add a MediaControllerImageObserver that can observe images of a certain size and type on a media controller. When the controller receives new images from the session it will handle the rank and retrieval so the client does not have to. BUG=914430 Change-Id: Ib6d0fc0b232efc790f3018b6687d969deb7111cd Reviewed-on: https://chromium-review.googlesource.com/c/1464649Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#635574}
-
Juan Antonio Navarro Perez authored
Looking through `git log` it appears these were used in the past for a benchmark that no longer exists. TBR=crouleau@chromium.org Bug: 921000 Change-Id: I8d77e167cf5dc244552bb7ecfdc0f83dadabf9f8 Reviewed-on: https://chromium-review.googlesource.com/c/1489197Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#635573}
-
Tanya Gupta authored
ReceivingUIHandler: Interface that platforms can be implement to update the UI when there is a new or modified share entry. All handlers must be registered through the ReceivingUiHandlerRegistry. ReceivingUiHandlerRegistry: Singleton registry that keeps track of the right handlers for each platform. Called by the SendTabToSelf Client Service. SendTabToClientService: Listens for updates to the SendTabToSelf Model and calls the appropriate handlers to update the UI. Change-Id: I7c366cb42de8f97bb09ca60ca5985af2290fc75f Bug: 901429 Reviewed-on: https://chromium-review.googlesource.com/c/1477754Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#635572}
-
Rune Lillesveen authored
We don't know if there will be any slots added for an attached shadow root. If no slots are added, there will be no slot re-assignment and no other way to inform the shadow host children that their flat tree position changed. LazyReattachLayoutTree will not clear ComputedStyle because it uses true for performing_reattach in AttachContext. Instead call RemovedFromFlatTree which detaches the layout tree and clears the computed style. Bug: 932871 Change-Id: I3dd8f7f3d4b4eb1fb8a745c2849840b1b4c3d89d Reviewed-on: https://chromium-review.googlesource.com/c/1477695Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635571}
-
Matthew Jones authored
This reverts commit 4eb3219b. Reason for revert: Still failing consistently on KitKat Tablet Tester: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Tablet%20Tester Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8920505223364583920/+/steps/chrome_public_test_apk_on_Android_device_Nexus_7__2013_/0/logs/org.chromium.chrome.browser.offlinepages.OfflinePageAutoFetchTest_testAutoFetchRequestRetainedOnOtherTabClosed__status_FAILURE_/0 Original change's description: > Re-enable testAutoFetchRequestRetainedOnOtherTabClosed > > I ran the test 40 times on my local device, and it passed each one. > Hopefully the previous changes to this test file have fixed the flake. > > Bug: 923212 > Change-Id: Ic8b3e6e6b82b60d14bdef9975d5d70e256dcf1b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1470634 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Dan H <harringtond@google.com> > Cr-Commit-Position: refs/heads/master@{#635255} TBR=carlosk@chromium.org,harringtond@google.com Change-Id: I697b84adf6ed3def942aaa0653488d89b8b6107d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923212 Reviewed-on: https://chromium-review.googlesource.com/c/1489095Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635570}
-