GitLab

This commit adds a check to verify that the NEXT_ID, PREV_ID and
PARENT_ID fields of nodes in the database point to the IDs of other
existing nodes.  The syncable::Database code assumes that this invariant
always holds and seems to do a good job of maintaining it.  This change
ensures that the invariant holds at the time the data is loaded from
disk.

There exist some corrupt databases that cause the directory to behave
unpredictably, since the code assumes the databsae is correct when it is
read from disk.  We can't do anything to fix those databases now that
they've been written, but we can detect the corruption and recreate the
affected databases.

This check is implemented using a set of hash maps, so the cost of the
check should scale well with the number of nodes (it's O(n)).  The
per-node cost of this check also seems cheap compared to the disc
access.  In release mode, loading 5000 nodes from a (probably in-cache)
sqlite database took 53ms, while the check took 9 ms.

BUG=101048
TEST=Manual.  Corrupted the database with external sqlite tool, verified
that the database was deleted and re-created next time Chrome was loaded.

Review URL: http://codereview.chromium.org/8475017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8620003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: Ifabfb3a0903358ec36bc2eabcccd6d3129972e7f

R=backer@chromium.org,dnicoara@chromium.org


Review URL: http://codereview.chromium.org/8598018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99665
TEST=everything compiles.


Review URL: http://codereview.chromium.org/8589033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111029 0039d316-1c4b-4281-b951-d872f2087c98

TBR=steveblock

Review URL: http://codereview.chromium.org/8592007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=apatrick,gman
Review URL: http://codereview.chromium.org/8619003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111027 0039d316-1c4b-4281-b951-d872f2087c98

35 tests fail because we are setting the localized text for the string userEmail to the logged in email for a user, but in the test environment there is no logged in user.

BUG=105049
TEST=Various browser tests, including DownloadTest.ChromeURLAfterDownload

Review URL: http://codereview.chromium.org/8624004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8622002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111025 0039d316-1c4b-4281-b951-d872f2087c98

Added an std::max to prevent negative width calculation.

TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
I filed crbug.com/105014 for the placement regression on NTP.

BUG=98323
TEST=The avatar menu bubble works as before.

Review URL: http://codereview.chromium.org/8500004

TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/8621004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104697
TEST=go to chrome://settings/personal. Add a user. Edit the user. The icon of that user should be selected.


Review URL: http://codereview.chromium.org/8598006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111023 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244

Review URL: http://codereview.chromium.org/8609008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111022 0039d316-1c4b-4281-b951-d872f2087c98

- Move showing, dimissing, animation observer, click monitoring code tha into an AppList controller in aura_shell;
- Change ShellDelegate::ShowApps to an inteface to request app list widget and having a callback to notify app list controller when the widget is ready;
- Click outside to dismiss the window.
- Hide default container when app list is visible;

BUG=98308
TEST=Verify click outside applist window to dismiss it. Browser windows should be hidden when app list window is shown and should be visible when app list is gone.


Review URL: http://codereview.chromium.org/8558031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111021 0039d316-1c4b-4281-b951-d872f2087c98

Added an std::max to prevent negative width calculation.

TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
I filed crbug.com/105014 for the placement regression on NTP.

BUG=98323
TEST=The avatar menu bubble works as before.

Review URL: http://codereview.chromium.org/8500004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8624003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111017 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that the position information in an event for a slave device
reported by X is always slightly behind than the actual position. However, it
turns out that the valuators do contain the correct information. So get the
event location from the valuator.

BUG=103981
TEST=manually

Review URL: http://codereview.chromium.org/8568044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111016 0039d316-1c4b-4281-b951-d872f2087c98

Similar to BinScope, checkbins.py will either check for the no SEH bit set in DllCharacteristics or a LOAD_CONFIG entry.

BUG=104188
Review URL: http://codereview.chromium.org/8584009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8629001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: I39b360c5f982e83a1fad3f68f65cc3e88c31cf2a

R=backer@chromium.org,dnicoara@chromium.org,joth@chromium.org,alokp@chromium.org


Review URL: http://codereview.chromium.org/8601005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111013 0039d316-1c4b-4281-b951-d872f2087c98

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115


Review URL: http://codereview.chromium.org/8615002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111012 0039d316-1c4b-4281-b951-d872f2087c98

Modify Heapcheck suppressions for bind changes with SQLitePersistentCookieStore.  Suppression signature changed with bind changes in r110402.

BUG=100608
TEST=Heapcheck bots go green
TBR=groby@chromium.org, thestig@chromium.org

Review URL: http://codereview.chromium.org/8627001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111011 0039d316-1c4b-4281-b951-d872f2087c98

This is largely a port of the existing X window manager's
code for drawing shadows around windows.  It adds an
ImageGrid class for drawing a scaled 3x3 grid of gfx::Images
and a Shadow class (managed by aura_shell::ShadowController)
that uses ImageGrid to draw a shadow.  Shadows can be
disabled via --aura-no-shadows.

BUG=101977
TEST=added unit tests; also manually checked that shadows get drawn

Review URL: http://codereview.chromium.org/8555025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111009 0039d316-1c4b-4281-b951-d872f2087c98

Expands suppression for NSSSSLInitSingleton due to bind changes.

BUG=95718
TEST=Valgrind bot on Mac turns green.
TBR=wtc@chromium.org

Review URL: http://codereview.chromium.org/8616009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111008 0039d316-1c4b-4281-b951-d872f2087c98

In particular, dmichael's comments in http://codereview.chromium.org/8574029.

TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8489002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111007 0039d316-1c4b-4281-b951-d872f2087c98

The tests for StatusAreaView, PowerMenuButton, and
CapsLockMenuButton were crashing when they tried to get the
StatusAreaView from chromeos::BrowserView, which isn't used
in Aura builds.  This change makes them instead get the
status area from the Aura shell.

BUG=103501,103495,104666
TEST=ran tests

Review URL: http://codereview.chromium.org/8591003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111006 0039d316-1c4b-4281-b951-d872f2087c98

This adds or updates entries in the database for the entire chain of text the user typed. For example, if the user types 'goog' and navigates to google.com, this will add or update database entries for 'go' -> google.com, 'goo' -> google.com and 'goog' -> google.com.


BUG=
TEST=


Review URL: http://codereview.chromium.org/8600004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111005 0039d316-1c4b-4281-b951-d872f2087c98

Disables OutOfProcessPPAPITest.Crypto test on ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8618002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111004 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=unittest
TBR=kbr
Review URL: http://codereview.chromium.org/8566057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101972
Review URL: http://codereview.chromium.org/8572048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111001 0039d316-1c4b-4281-b951-d872f2087c98

No longer check for a specific mime-type on appcache manifest files. The spec was recently changed in this way.

BUG=103939
TEST=appcache_update_job_unittest.cc
Review URL: http://codereview.chromium.org/8566020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111000 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8510065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104995
TEST=


Review URL: http://codereview.chromium.org/8592005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8588059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110997 0039d316-1c4b-4281-b951-d872f2087c98

Small tweak to about:profiler -- make the labels for checkboxes clickable (so you have a bigger target to click on than just the tiny checkbox).

Apparently if you surround an <input type=checkbox> within a <label> tag, the text will activate the checkbox.
Review URL: http://codereview.chromium.org/8601003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=clang builder greens

Review URL: http://codereview.chromium.org/8527029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110994 0039d316-1c4b-4281-b951-d872f2087c98

and what type of executable it is, if it is.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8558009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110993 0039d316-1c4b-4281-b951-d872f2087c98

isUnique is the new name for isEmpty.

Review URL: http://codereview.chromium.org/8604008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110992 0039d316-1c4b-4281-b951-d872f2087c98

Adds leaks suppression for MimeTypeTests on Mac.

BUG=105022
TEST=Valgrind goes green on Mac Webkit bot
TBR=abarth@chromium.org

Review URL: http://codereview.chromium.org/8504002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110991 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jbates@chromium.org

Review URL: http://codereview.chromium.org/8562009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110990 0039d316-1c4b-4281-b951-d872f2087c98