- 10 Sep, 2020 40 commits
-
-
Kenichi Ishibashi authored
We still want to see the number. Bug: 1125764 Change-Id: I711c13c386f9beefcf1c269055a1ca8e8a5da399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396197Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805607}
-
Rachel Carpenter authored
Bug: b/156308432 Change-Id: I8634b4dcffe616f9ce950a6d9500e957f4e83867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400587 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805606}
-
Min Qin authored
This CL fixes an issue in DownloadFileWithError that when injecting an error on a write offset, we should check if the offset is overwritten by a write operation, rather than just the beginning offset. And then we use this fix to fix the flaky MiddleSliceDelayedError as the same offset will be overwritten twice by 2 streams. BUG=1105429, 1106059 Change-Id: Iff9b9d796ed5d86c68b24667096e2089564c4c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401312Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805605}
-
Findit authored
This reverts commit 4ccb6508. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 805598 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjY2I2NTA4MDBjZDdkZTgzYWUzY2RiNzFkMzNiZmQ5N2NmZTBkOWYM Sample Failed Build: https://ci.chromium.org/b/8869579849484323600 Sample Failed Step: compile Original change's description: > Files SWA: Moving to a new directory. > > Bug: 1111229 > Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Bo Majewski <majewski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805598} Change-Id: Iaced93329ca1f5e37d6cec4f9e3fdf6b5ae8664f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401927 Cr-Commit-Position: refs/heads/master@{#805604}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Iba02761d0858ff1087f77809e3e15ff6d9e881c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402193Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805603}
-
My Nguyen authored
These functions dealt with input methods, which is only used for Chrome OS. Will move all the Chrome OS only logic into a separate file in chromeos once the migration is over as these are linked with languages preference and still shared with Chrome OS's browser. Bug: 1113439 Change-Id: Ia90d82506d5517e9f74b32d47415a4ed89f2faf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398440Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805602}
-
Zentaro Kavanagh authored
- This is already the default and was previously removed from all components. See [1]. [1] - crbug.com/1068407 Bug: 1125150 Test: None Change-Id: I486944d6c6a5c0a8ffad04fd5da94a2a3c62fc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401586 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805601}
-
Zhenyao Mo authored
BUG=711140 TEST=manual R=sunnyps@chromium.org,rafael.cintron@microsoft.com Change-Id: I407e1ff43b5788819e54acce6358b0ff4ed1bfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399842Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805600}
-
Sven Zheng authored
The flakiness was introduced by this CL https://crrev.com/c/2397715 which was a reland of CL that was reverted because it made this test flaky. Bug: 1111979 Change-Id: I3153d0a27a85f36b282406f3cf15c6661d060dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402160Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805599}
-
Bo Majewski authored
Bug: 1111229 Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#805598}
-
Richard Chui authored
Make the close desk button visible and navigable for switch access users. Switch access users are unable to execute keyboard commands through their physical switch devices, rendering them unable to close virtual spaces without the close buttons being visible. Test: manual Change-Id: I8624783a586424307971f0a27ba9c80456fa788b Fixed: 997011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391594 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805597}
-
Daniil Lunev authored
Bug: b:151176984 Change-Id: I21cdb37edcc8880c86660393c7e4ed620e70fe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397984Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#805596}
-
Solomon Kinard authored
References: crrev.com/c/2368147 & testing_api.md#use-promises. Bug: 1119846 Change-Id: Id7e603c415f8d2c6fee00a615b97078e486fe6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382888 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599551854-84903541b1ee77a3a0a009f1d73fc84d0ed1091a.profdata to chrome-win32-master-1599659830-8ef8811788e74327dac6ace27b47b5f70375bbf0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5223de08a550548ab8ee808194055cf85b58b1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805594}
-
David Van Cleve authored
Looks like this has been failing flakily on Windows and Mac for a while; most recently, it's caused the Mac10.13 Tests (dbg) builder to fail: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29 Tbr: gtsteel@chromium.org Bug: 1126649 Change-Id: Ib3313cdcee9351d1e2bb1b4553456b2bc6c6e5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401973 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805593}
-
Keren Zhu authored
* Add MdIPHBubbleButton, a transparent MD button with optional white border. * Add snoozable option to IPH bubble. Disable auto-dismiss for snoozable button. UX spec: https://docs.google.com/presentation/d/1l19RBFdJjsLIO2KPVANY-ObfwmUCkpQ1Lj8IeLAqJZM/edit#slide=id.g92aa3ae4f7_1_43 Screenshot: https://screenshot.googleplex.com/5brgyBvGcaoMeEP Bug: 1121399 Change-Id: Ic3ca76b6edcb52bdc9d856aa6ee11476e018218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394157Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805592}
-
Lukasz Anforowicz authored
This CL introduces DataURLLoaderFactory::Create static method that allows creating an DataURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<DataURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing DataURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static methods. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I173ce25efbdb95442c9978856a93163e9f067495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357618 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805591}
-
Raphael Kubo da Costa authored
Point to https://w3c.github.io/screen-wake-lock rather than https://w3c.github.io/wake-lock. While the latter redirects to the former, anchors are broken in the redirection. Change-Id: I2eca3e236c0105af8017a09af872935dadd43bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395718 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805590}
-
Zentaro Kavanagh authored
- It was accidentally deleted here [1] [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2224346/24/chromeos/components/print_management/resources/print_management.html Bug: None Test: None Change-Id: Ifeed774ca437c29bc38582ce4e5c18ac71619efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402287Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#805589}
-
Seokho Song authored
The input validation has only been considered underflow or overflow. If min and max values are equal and the user input value is different, we should show a message that the values does not match. In this CL, InputType will calculate 'value != min && min == max' to check it must be same. Bug: 1073923 Change-Id: Ia7e1e5e9ece70cd31034f3bda2c833dd36ed1d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389281 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805588}
-
Shrek Shao authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1788138, these tests were enabled on Android. But flakes are seen on Nexus 6: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%206%29/33613 Following the similar pattern of skipping them as in: https://chromium-review.googlesource.com/c/chromium/src/+/1808584 https://chromium-review.googlesource.com/c/chromium/src/+/1628391 TBR=kbr@chromium.org Bug: 609629 Change-Id: Icd07a38c4e3a5ff8c12c791bdf0f6b066014e726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401708Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#805587}
-
Tom Anderson authored
This fixes a regression where accelerators like Ctrl+T would not work after changing the keyboard layout after [1]. XKB internally selects and handles NewKeyboardNotify events, which get fired when changing the keyboard layout. This CL fixes the issue by manually selecting and responding to these events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2317767 R=sky CC=nickdiego Bug: 1125886 Change-Id: Ie8b84e1947da2deb527cd572f7a646b4f833b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402301 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805586}
-
Tom Anderson authored
After [1], gfx::GetXDisplay() returns a different display for each thread. This introduces a race condition since |g_handler| is shared across all threads. Since X11ErrorHandler will be removed soon anyway (since XProto uses a different error-handling mechanism), this CL simply removes the DCHECK(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 BUG=1122006 R=sky Change-Id: I1101a3456f4609481a1f204634102dac89bad0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402304 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805585}
-
Lukasz Anforowicz authored
This CL introduces AboutURLLoaderFactory::Create static method that allows creating an AboutURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<AboutURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing AboutURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Id93cc5b5078019d95dd19988ffdffb8e40d7ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358053 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805584}
-
Becca Hughes authored
If Kaleidoscope is available to the user and also we need to shown the first run to the user then we send back a different state to the module telling it to use the first run promo. BUG=1121360 Change-Id: Id48006d0b4c079742b674c73a99895b2e8abcbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401504 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805583}
-
Ryan Hansberry authored
Implement BleMedium::StartScanning() and BleMedium::StopScanning(). This requires adding a ServiceDataMap (mapping from service id to service data) to bluetooth::mojom::DeviceInfo, to represent BLE advertisements. See go/nearby-chrome-bt for more details. Bug: b:154848193 Change-Id: I40489f8128bcda9409b20b43be52e73b2a9a2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370094 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805582}
-
Kenichi Ishibashi authored
The following service worker related mojom in blink will be used from both //content and //components/services/storage when we move ServiceWorkerStorage to the Storage Service: * navigation_preload_state.mojm * service_worker_database.mojom * service_worker_registration_options.mojom As described in crrev.com/c/1920008, putting these mojom in the mojom_platform target causes some problems when we try to use them from //components/services/storage. This CL gives them their own mojom target the same way crrev.com/c/1920008 did. These mojom files depend on web_feature.mojom and script_type.mojom. web_feature.mojom has it own target. This CL also gives script_type.mojom it own target. Bug: 1016064 Change-Id: I75123c67c6be18060f9eda09f448a0107cfb598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395197Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805581}
-
Daniel Classon authored
Adds deep links to the A11y page as well as the Manage A11y, Text to Speech, and Switch Access subpages. Adds tests for the A11y page and Text to Speech subpage. Bug: 1084154 Change-Id: I822a128b7230d9fb6de250294b3e00e2e17d01bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391785 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d42f9890bdc..66e88206d65d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126258 Tbr: davidvc@google.com,adithyas@google.com Change-Id: Ia67f4aa822426db89d58c61454a0b3ff57faf497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805579}
-
Andrew Grieve authored
Improves error messages for existing asserts, and adds one for blink_symbol_level=0 Bug: 1126200 Change-Id: I6624f6858ee568a33b5174ab8ba7c1834c1d5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401853 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805578}
-
danakj authored
When moving code from frame_host, we found that there are a large number of presubmit failures in the code already. This fixes the majority of them, except: 1. MessageLoopRunner is deprecated, use RunLoop instead. Which happens a fair number of times. 2. Uses of BindNewEndpointAndPassDedicatedReceiverForTesting() from production code in RenderFrameHostImpl and RenderFrameProxyHost. These are a bug, as the code is not actually called by tests, it is production. R=avi@chromium.org Bug: 1091083, 1038710 Change-Id: Ida76d545307f0003227fd93e5467426c35ea7a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401270Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#805577}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 5 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: I2cced4fc69b139458e5204eb2bc6f553101b6388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402186Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805576}
-
Bence Béky authored
Update changes to existing histogram names; remove QUIC_ prefix from entries 101 and above; add 18 new entries starting with 151. Change-Id: I5cfd1b915bd2a5069182912445b0f0c4b8f6d59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399011Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805575}
-
Alex Ilin authored
A hidden <input type="color"> element displays the color picker in the top left corner. This CL replaces the hidden attribute with the "visibility:hidden" style and zero element size. Screenshot: https://drive.google.com/file/d/1egjk4ZrO_cj0D7Tu5fMOL3INqwAhY6F7/view?usp=sharing Fixed: 1126668, 1047800 Change-Id: Ia7d91759e3a76ea3efa5b45d742e77765e101071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401141 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805574}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b0da2f1d4f9e..70f34e0b8eaa 2020-09-09 sebmarchand@chromium.org [Telemetry] Allow specifying a custom shutdown timeout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1124774 Tbr: rmhasan@google.com Change-Id: I58dbf1fa732e6f3a7ad4ca8e41da2317af05bdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/215d2b0fa42d..5eea6aea02d9 2020-09-09 brianosman@google.com SkSL: Fail harder when trying to return a value from a void function 2020-09-09 brianosman@google.com SkSL: Disallow 'void' except as a function return type 2020-09-09 herb@google.com remove initialOrigin - no longer needed 2020-09-09 johnstiles@google.com Add a new statement type 'InlineMarker' to indicate inlined functions. 2020-09-09 brianosman@google.com Fix use-after-free when variable declarations become unreachable 2020-09-09 csmartdalton@google.com Add more flat line cases to trickycubicstrokes 2020-09-09 bsalomon@google.com Temporary hack to force text texture index varying to be float. 2020-09-09 brianosman@google.com SkSL: Catch any dangling Type or Function references before optimization 2020-09-09 johnstiles@google.com Run the optimizer until we stop finding improvements. 2020-09-09 westont@google.com [infra] Target Android10 for GalaxyS9 2020-09-09 jmbetancourt@google.com add oboe version 1.4.3 to third_party dependencies for Android's skottie audio player If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idce21eb66a6ead3b7297120831d3b4d71332087c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805572}
-
Richard Li authored
When playing a SDR video after playing a HDR video, GPU process will crash on Intel platform. The root cause is Chrome sets different color space in VP without reset VP, which will cause something wrong happens in VP. This CL provides a fix that VP will reset when input/output color space changes. What's more, color space will be set to VP only when it changes, which reduces frequency of calling VideoProcessorSetStream/*Output*/ColorSpace1() Bug: 1121061 Change-Id: I096e5fb47593e0df034452719029a3750850bc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371478 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805571}
-
Richard Li authored
media::HDRMetadata is going to be moved to ui/gl/, so its corresponding mojom bind should be move to that path. This is a preparation for passing HDRMetadata to SwapChainPresenter. Bug: 1122910 Change-Id: Id62709d95acc7517578cc37e940f0dca9a3f6d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389103Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#805570}
-
Melissa Zhang authored
This CL fixes a bug where sometimes target text height obscures a section of the text. Bug: 1097623 Change-Id: I70c4841de68a831f13bd074c1a9bff569a779500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399164Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805569}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 3 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: Id33a88a789bb1322519f11b3e861c3cbe93280db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401703Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805568}
-