- 09 Jan, 2020 40 commits
-
-
sebsg authored
This reverts commit 7076daa4. Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 Original change's description: > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > Test was producing a minor image diff, has been triaged. > > Bug: 1040202 > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729597} TBR=kbr@chromium.org,bajones@chromium.org Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729736}
-
Mike Reed authored
bug: skia:9768 Change-Id: Ic366b14972c13625fc83f44f6f0782bc4052f44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988721Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#729735}
-
Yuichiro Hanada authored
The histogram is still useful for us to track Android IME support usage on ARC++. Bug: 911354 Change-Id: I280704e50df1829115ffe5b7da23cdf905371b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989605 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#729734}
-
Gauthier Ambard authored
The Settings used to have CollectionViews instead of TableViews. Now that the use of CollectionView has been removed, we can remove the classes used to implement it. Bug: 894800 Change-Id: I0865b61f884760d956855d0771f5524e12662a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993281 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729733}
-
Yutaka Hirano authored
QuicTransport.ConnectWithError has a wrong TODO led by my misunderstanding of the spec. Remove the TODO and add additional checks. Bug: 1011392, 1037752 Change-Id: Ia75f2c5ade51c8cd0a44d0cf48dff18ccf98ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981949Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#729732}
-
Kent Tamura authored
This reverts commit 9fc859a3. Reason for revert: It was a wrong approach. https://bugs.chromium.org/p/chromium/issues/detail?id=1037728#c11 Original change's description: > Restoring control state should dispatch 'input' and 'change' events. > > According to the last two paragraphs of [1], UA should dispatch 'input' > and 'change' events if it fills control values on behalf of a user. > > [1] https://html.spec.whatwg.org/C/#common-input-element-events > > Bug: 1037728 > Change-Id: Ic389cc4e3bc4523f740b0164ac863baba66dcd35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981241 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727843} TBR=tkent@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037728 Change-Id: I504d202de886e4278369ab3da37c41b70b773f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993078Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#729731}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a4e536a0953d..3aa0411a4cb6 git log a4e536a0953d..3aa0411a4cb6 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 liviurau@chromium.org Whitespace to trigger builders 2020-01-09 sigurds@chromium.org [network] Change signature of empty protocol message handler Created with: gclient setdep -r src/third_party/devtools-frontend/src@3aa0411a4cb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032063 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If21fb5bcf68210cebc62a0702d584dea613cf9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729730}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af272d6eb830..b19eb399cb53 git log af272d6eb830..b19eb399cb53 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 danilchap@webrtc.org Delete obsolete unused rtp header extension conversion Created with: gclient setdep -r src/third_party/webrtc@b19eb399cb53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idcb7c385329f9990e2d0e14482385612619e98bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993274Reviewed-by:
-
Mythri A authored
https://chromium-review.googlesource.com/c/chromium/src/+/1986844 re-recorded browse:social:tumblr_infinite_scroll:2018 story. This was disabled for multiple reasons. With the current recording the pinpoint jobs on pixel2, android-go, linux, windows and mac platform ran successfully. So re-enabling this on all platforms. Bug: chromium:1027686, chromium:961417 Change-Id: I47ece821103e485faa7b0378a3a680cc93275a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991422Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#729728}
-
Olivier Robin authored
This reverts commit 738d6a13. Reason for revert: This Cl breaks ios-simulator bot https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/51842 Original change's description: > Enable HistoryServiceUsesTaskScheduler by default > > Change-Id: Iaee9edf31fd2303a28bbeedc155cb7dd9381cdb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960467 > Auto-Submit: Oliver Li <olivierli@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728929} TBR=sky@chromium.org,olivierli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I13aad198a6783d207513d3f4d07500d22ebe8316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991627Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729727}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 835781a4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iaec054cf83a770da4320293e6f22dc32a9ec14f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729726}
-
Tomasz Dobrowolski authored
This unit test uncovers a problem with WebPageNotifierController, which is not working properly with anything else than full URL patterns (in scheme://url format). Most test cases are disabled for now (see test_patterns vector), until the problem is fixed. Bug: 989845 Change-Id: Ifb514d603e489fc3775fe0d3c9e4e419b47dc722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811122 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#729725}
-
Luca Hunkeler authored
Print screen: https://screenshot.googleplex.com/xnR0bvVCEhQ Bug: b/146145185 Change-Id: I44c5c87906d6f2755a6bd0c3370f0306c5b0d6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969344Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#729724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65793110f5f1..42d8fcc5f877 Created with: gclient setdep -r src-internal@42d8fcc5f877 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I96ec8127dd0cceacb0904d2ce8ed384b3f572a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993266Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729723}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1186eac..d2faec18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5de8f2f8698c5d1a6fd8e265aec504e125423bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729722}
-
Yuki Shiino authored
After the unified heap, lifetime control in v8_message_channel_custom.cc should be no longer needed. Removes the custom bindings. Change-Id: Icc0228509a490efc3bc53afd3db1d2019eef185d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993070Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#729721}
-
Mikel Astiz authored
This reverts commit d35a5b72. Reason for revert: suspect of causing crashes. Bug: 1040498 Original change's description: > Bookmark sync: use GUID as temporary server ID during commit > > This patch effectively relands the logic reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which > caused crashes in the past (CHECK failures). > > In this new form, the underlying issue is addressed: for users that > don't use GUID-based merging of bookmarks, local GUIDs are reassigned > randomly to avoid GUID collisions in the local bookmark model. > > Bug: 978430,1004205 > Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729405} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: Ia25a087dacc36e8ca6ad351a4664e9478b1ba23a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978430, 1004205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991628Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729720}
-
W. James MacLean authored
This CL adds an 'isolation' key to OriginPolicy, as per the proposal at https://github.com/domenic/origin-isolation#example. Bug: 900995 Change-Id: I8b676070d5a38dfb394427c244cf10936072c229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975992 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#729719}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/debe1986ce2c..85c4a438f6f1 git log debe1986ce2c..85c4a438f6f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 phoglund@google.com Add support for sending histogram.proto JSON to /add_histograms. Created with: gclient setdep -r src/third_party/catapult@85c4a438f6f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: oysteine@google.com Change-Id: I57cb5f630c4873a496583edd712e7b0c3c339310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993270Reviewed-by:
-
Tomasz Moniuszko authored
Bug: 1020136 Change-Id: I313a479663dda83c4bdf7d882911b029bbbe2cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901466 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729717}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9553930c2093..6c26eac37f09 git log 9553930c2093..6c26eac37f09 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 eseckler@google.com Merge "ui/extension: Record using Chrome's browser DevTools target" Created with: gclient setdep -r src/third_party/perfetto@6c26eac37f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6c7f0bf4a3b3d618b694711d7f7ea504f41e43a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993268Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.18-1578309018-benchmark-81.0.4016.0-r1 to 81-3987.18-1578309018-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f495f8c28427fb55415306d595b9435d493b52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993273Reviewed-by:
-
Mia Glaese authored
Screenshots here: https://drive.google.com/drive/folders/17MCAlDrQidwqYw1sDP1gJAeQZB2FGxbl?usp=sharing Bug: 982018 Change-Id: Id682d6544b123fe6bb7c9777c319aff8c85458b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989994Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#729714}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/293d46c31c84..af272d6eb830 git log 293d46c31c84..af272d6eb830 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5bd3bd2b..efba8d29 (729553:729663) Created with: gclient setdep -r src/third_party/webrtc@af272d6eb830 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia44b546e70559ac4e347b60df63cd7317c254524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993260Reviewed-by:
-
Marc Treib authored
Followup to https://crrev.com/c/1975726 Sync supports delaying the engine startup by 10 seconds. This is meant for avoiding contention during browser startup. Before this CL, the 10-second delay would also apply in a few other (rare) situations, for no particular reason. After this CL, the delay happens only during browser startup. This is mostly for simplicity/consistency; it's not expected to have any real impact. Bug: 1035874 Change-Id: Icd7ef6989c4cc252913d9060c6e14191d0b7c24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989533 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Yue Li authored
Update to use the newly added util method for Google branded devices. Bug: None Test: Manual Test Change-Id: I0c8c10c6d4dce5f6e556826c7ee0a6595a116d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985636Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#729711}
-
Yue Li authored
This change adds a new autotest API: isArcPackageListInitialRefreshed, to check whether the ARC package list has been refreshed. Bug: 982538 Test: Run the tast testcase added in Change-Id: I1b9633be08098c9dcb23609fdc0332d09d1f545b https: //chrome-internal-review.googlesource.com/c/chromeos/platform/tast-tests-private/+/1948653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981249Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Kent Tamura authored
Revert "Restoring control state should dispatch 'input' and 'change' events only if values are changed" This reverts commit ca02d552. Reason for revert: It was a wrong approach. https://bugs.chromium.org/p/chromium/issues/detail?id=1037728#c11 Original change's description: > Restoring control state should dispatch 'input' and 'change' events only if values are changed > > This CL is a follow-up of crrev.com/727843, which caused a regression > seen in the local-NTP. > > * HTMLTextAreaElement and HTMLSelectElement: > Call QueueInputAndChangeEvents() only if their values are changed. > > * HTMLInputElement and input type implementations: > InputTypeView::RestoreFormControlState() returns a boolean flag to ask to > call QueueInputAndChangeEvents(). > > Bug: 1038655 > Change-Id: Ib68077516d1d6c032dbc2599abbcd541c281f4de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983692 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729334} TBR=tkent@chromium.org,masonfreed@chromium.org Change-Id: I645ae24b3feaa2a29f26812f360fe87f46a523e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993077Reviewed-by:
-
Antonio Gomes authored
Now, only cases actually needed (or logical) and test code still uses these containers in modules/peerconnection. Production code has been migrated. BUG=787254 R=haraken@chromium.org Change-Id: I40e76739853ae99475ed9ef0ecf2f7243011827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992280 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6228fdf6f84..1c40e03a4215 git log f6228fdf6f84..1c40e03a4215 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 45a4d0f36bd6..77c89ff847b6 (13 commits) 2020-01-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 258b887827ab..ac72777ef763 (1 commits) Created with: gclient setdep -r src/third_party/angle@1c40e03a4215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I169a8676e9782f2ce7dddbb4c48f6340ab777ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993263Reviewed-by:
-
Antonio Gomes authored
BUG=787254 R=haraken@chromium.org Change-Id: I5e2b5d72784ba5d7ebe813fe2b1b82043d4e406c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991410 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Michael Lippautz authored
This reverts commit 5342b454. Reason for revert: Dynamic header lookup cannot work while concurrent sweeping is active. More details see bug. Original change's description: > heap: Keep object header on pre-finalizer registration > > Pre-finalizers are heavy and not supposed to be used on short-living small > objects. Spend an additional word to store the header on registration. This > allows inspecting liveness without going through a call on every garbage > collection. > > Bug: 982754 > Change-Id: I30a2d60198dd6b2b49febcd49983d17175874dad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904177 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713880} TBR=mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982754,1033662 Change-Id: Ice55879d9b94a413a324ad745329a6c0aecda42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992422Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729705}
-
Huanzhong Huang authored
Part of the new clear browsing data dialog cleanup effort. This change removes the feature flag definition. Bug: 947456 Change-Id: I2231e58c58583ba6b825a32c6390937b0894f9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985012 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.18-1578307131-benchmark-81.0.4016.0-r1 to 81-3987.18-1578307131-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I02aadf8c65da155b847a949bfb01f68ae0c40da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993267Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/065d0bc7..e1186eac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I876ed3c72945c94207fb2e6524676c94054e43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992529Reviewed-by:
-
Wez authored
TBR=jam,haraken,dmazzoni Bug: 949593 Change-Id: I8d72a108dd764a6caeab3329d296bd8fb898307f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986126Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#729701}
-
Antonio Gomes authored
... instead of WebVector. It avoids a needless copy/conversion. BUG=787254 R=haraken@chromium.org Change-Id: I16766e7906e3ba53a2fc43725f4555e55bee511f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991409 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Liviu Rau authored
Bug: chromium:1018670 Change-Id: Ia9234fd7591e083e0845dda31e3c8763469fdd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969350 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#729699}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52175631d301..debe1986ce2c git log 52175631d301..debe1986ce2c --date=short --first-parent --format='%ad %ae %s' 2020-01-09 phoglund@google.com Add makefile for histogram.proto. Created with: gclient setdep -r src/third_party/catapult@debe1986ce2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1929452 Tbr: oysteine@google.com Change-Id: I3e23bcc74f7b1d4f17f2efdf1ff9fb332063227d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992519Reviewed-by:
-
Jaeyong Bae authored
This patch means adding number type to text fields in IsTextField Bug: 919544 Change-Id: If4d24d01721268e723c5a24c846bdfba520a8117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973516Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#729697}
-
