- 12 Feb, 2020 40 commits
-
-
Victor Costan authored
Testing code that was moved from //content to //storage is still under the content namespace. This is hindering Storage Service-related refactoring. This CL updates the namespace to reflect the directory structure. This CL also makes mechanical code health improvements (such as new -> base::MakeRefCounted) applied when obvious. clang-tidy improvements are applied where requested by Tricium. Bug: 653751 Change-Id: I3d0b5712b531d0d33205ee2a3de3de5dce73e84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048986 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740558}
-
Charlie Reis authored
WebUI bindings aren't granted to error pages, and we weren't granting them when reloading a NavigationEntry that had earlier been an error page. To fix this, reset all sensitive state (including bindings) on the NavigationRequest when the destination SiteInstance changes from what the NavigationRequest expected it to be. Bug: 1046159 Change-Id: I2b004423ad2f1f7aecd86220be75d32f26404040 Fixed: 1046159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045143 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740557}
-
Daniel Cheng authored
Mostly cleanup. Note that this still uses atomics instead of C++11's thread-safe statics. C++11's thread-safe statics incur a large (200+ KB) size penalty since they guarantee that only one thread enters the initialization block. Change-Id: I3b013b55d5108f86ede39d0e0273ea10f8abf5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045757Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740556}
-
Koji Ishii authored
This patch moves functions to get related objects of the current position from |NGInlineCursor| to |NGInlineCursorPosition|, in particular: * BoxFragment() * GetLayoutObject() * GetMutableLayoutObject() * GetNode() Also moves: * InlineBreakToken() * InkOverflow() This patch has no behavior changes. Bug: 982194 Change-Id: I39fe7268977dd2fce12e75f1c012d78ca9b9e2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049934Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740555}
-
Koji Ishii authored
Following bot results are included. 1317 1321 1322 1323 1324 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1338 1339 1340 1341 1343 1352 1353 1355 1356 1357 1358 1360 1361 1363 1364 1365 1366 1368 1369 1372 1370 59 lines were removed and 25 lines were deflaked by consecutive results since 1352. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I2e080c213b8ae75699d0e85c6a8475df2d0b0f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043617Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740554}
-
Ian Kilpatrick authored
This fixes failures with FlexNG enabled, see: https://test-results.appspot.com/data/layout_results/linux-rel/292466/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html (*/text-with-display-style.html) NGBoxFragmentPainter didn't have a ScopedPaintTimingDetectorBlockPaintHook for the flexbox on the stack, meaning that the performance entry was never recorded for the flexbox element. This patch emplaces the ScopedPaintTimingDetectorBlockPaintHook for all box fragments. Bug: 845235 Change-Id: I5bb1a20734e9ef6c0d5babe5d6bff4ffb6d4aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044522Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#740553}
-
Koji Ishii authored
This patch moves floating objects in an inline formatting context from the fragment tree to |NGFragmentItem|. r717514 <crrev.com/c/1903122> moved them to the fragment tree. This patch reverts it, but fixes the problem it tried to solve (floats in empty inline formatting contexts) by adding |IsBlockLevel()| as suggested by <crrev.com/c/1927041>. Also contains new float hit-test code in this new structure. Fixes ~3 failures. Bug: 982194 Change-Id: Ic7320797a2aaab7bc0ca0a1bbea03f38baf7d693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022123 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I3dc766262c8202dd3e545acb09a7fcd7e1eb4baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050795Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88210f038eea..74ecbaf391f4 Created with: gclient setdep -r src-internal@74ecbaf391f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I55c51f6f84e1d1dea457ca8a4a8afd54d142c0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740550}
-
Kent Tamura authored
Bug: 1049998 Change-Id: I539c4dae08338bbd15e0880709ae1c35e88b314f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050405Reviewed-by:
-
Manas Verma authored
We would like to know the relative conversion rates between CVC and WebAuthn. This CL introduces metrics that logs which authentication method was used when a form was submitted. Bug: 949269 Change-Id: I6c362327b3538b0c8890628316429654e6fae10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048043Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#740548}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/601fc962a276..fdcff246690a git log 601fc962a276..fdcff246690a --date=short --first-parent --format='%ad %ae %s' 2020-02-12 fancl@chromium.org Remove the Sheriff model and related infra Created with: gclient setdep -r src/third_party/catapult@fdcff246690a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050891 Tbr: oysteine@google.com Change-Id: Iac9f761954d371759d2dae1d6a7b224e90e43bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740547}
-
Kevin Marshall authored
Postpones the destruction of the AmberRepo until the tests have finished, so that the repo can continue to be used during test runtime. Bug: 956100,1028775 Change-Id: I794b698af6dd6f84cb140d178cf888a175381f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966691 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#740546}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id3db89d2e0ba4b10b3e76ce4e076285fc0aacb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050098Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#740545}
-
Luciano Pacheco authored
Naming/Renaming input commits the new name when the input loses focus, this is broken when user right-click on the input, since context menu pulls the focus to itself for a11y. Change the renaming controllers to listen to the contexmenu event to be able to not commit the new name in this condition. Change some "let" to "const" as pointed by presubmit. Fixed: 1008816 Change-Id: Id5ccb97598afd597871793d2165f3132b9363448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049150Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#740544}
-
Timothy Loh authored
This CL updates our checks for allowing Plugin VM to not require an image url, allowing better support for manual installation via vmc. Admins can currently bootstrap via setting a dummy url in policy, but we probably shouldn't require this. The launcher icon and settings page will now both always show if PluginVmAllowed and PluginVmLicenseKey are set, regardless of the PluginVmImage policy and plugin_vm.image_exists pref. On launching the installer, it will immediately complete if the user installed Plugin VM using VMC, or otherwise display en error indicating an invalid configuration. Bug: b:148281022 Change-Id: If85ca4ca14a096db17c32b26769a72d55bc92eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043331Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#740543}
-
yilkal authored
In v1 of Per-App Time Limits Chrome and web apps should share time limit set by the parent. Bug: 1015661 Change-Id: I6cc5bc06bdcc6f00aa76bcdfcb2407b09c1b42c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051185 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740542}
-
Nnamdi Theodore Johnson-Kanu authored
All strings used by the settings page of both the Chrome browser and Chrome OS were located in the same file. This CL begins the process of separating the strings into specific files. shared_settings_strings will contain strings shared between the browser and the OS. Bug: 967883 Change-Id: I7a08fcf3286229212cba545d29c99ee3ef36fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042733Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#740541}
-
Regan Hsu authored
This CL exists on top of and will land only after the following CL lands https://chromium-review.googlesource.com/c/chromium/src/+/2042926/5. Bug: 1049830 Change-Id: Ifcff3209159a1c8221eb71890d987e83978e449c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051164 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Nicholas Verne authored
Buttons now enable/disable appropriately when crostini dialogs (e.g. installer, upgrader, remover) are showing. Bug: 1024693 Change-Id: Ic060aee82665ef5083f09b25e0dd4e9723d047a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049145Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
-
Eriko Kurimoto authored
This CL passes real ContentSecurityPolicy and ContentSecurityPolicyType values to creation_params which are used for SharedWorker scripts fetching. By this change, outsideSettings CSP is applied to scripts statically imported from module SharedWorker top-level scripts. This behavior is tested in the static import section in the added test. (Previously the CSP was not applied at all for such scripts, but it's OK because module SharedWorker is not yet shipped.) This CL doesn't affect the behavior of classic SharedWorker and dynamic imports (either from module or classic SharedWorker). Web-platform-tests to check its behavior on Module SharedWorker are added. WPTs for Classic SharedWorker will be added in the following CLs. Bug: 1049011, 824646 Change-Id: I6fa79b0394426f09b19da1abbdf9ecf483d558ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038297 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#740538}
-
Robert Sesek authored
Bug: 778317 Change-Id: I3fae34b8d7cc9d1d3431604f9537bdb6774c76a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050138Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
Bug: 634140 Change-Id: Ic09bdb2d88b59af4778bd6c1eed2afb39375bedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041716Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5934f107c17a..88210f038eea Created with: gclient setdep -r src-internal@88210f038eea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1041701 Tbr: jbudorick@google.com Change-Id: I1147a8c4d526185d16496c04d28a10b0c0dd7a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051371Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72e9f4d73f65..e1ccac7ff9f0 git log 72e9f4d73f65..e1ccac7ff9f0 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 ynovikov@chromium.org Don't print INFO level log messages in Release by default. 2020-02-11 jmadill@chromium.org Vulkan: Command graph linearization (Step 5). Created with: gclient setdep -r src/third_party/angle@e1ccac7ff9f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: If1693f2f63411440580844f9a3d4d3f58e872d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051137Reviewed-by:
-
Yoichi Osato authored
Since in some cases the request body was not accessed after copying, this CL introduces ResourceRequestHead class which represents request without request body. The existing ResourceRequest occurrence not using request body will be migrated to ResourceRequestHead. Previous discussion: "Restruct blink::ResourceRequest for streaming body upload" http://bit.ly/2OdzJ1e Brief summary: class ResourceRequestHead { KURL kurl; ... }; class ResourceRequest : public ResourceRequestHead { scoped_refptr<EncodedFormData> http_body_; }; Bug: 787704 Change-Id: Ifedfeac31843cbcd5c9966fda9ac062fde26921d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032451 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#740533}
-
James Vecore authored
Fixes warnings produced when this CL is patched in https://crrev.com/c/2006413 which does stricter type checking on mojom structs from colsure. Fixed: 1047844 Change-Id: Ia1dd0159329ec697bce6d5b832abc8a70d083706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050846 Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740532}
-
Rakina Zata Amni authored
Now both render-subtree: skip-viewport-activation and skip-activation subtrees are not in the AX subtree at all, as discussed in https://github.com/WICG/display-locking/issues/102#issuecomment-564205445 Now only render-subtree:invisible subtrees are in the AX tree, and they are automatically marked as offscreen because the nodes are activated when they are on screen. Bug: 1001930 Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#740531}
-
Manu Cornet authored
(Unnecessary and also confusing ;-) ) Change-Id: I65461dc660c91d279e351ab405d1ee42cc569b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049828 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740530}
-
Jon Mann authored
This puts all fields directly on the WifiConfigurationSpecifics proto instead of using the legacy format of keeping them nested in WifiConfigurationSpecificsData. Bug: 966270 Change-Id: If26e390eba1b65411d4884316568db7db27c6bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045154 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#740529}
-
Alan Cutter authored
This CL removes one difference between promotable web apps and "Create Shortcut" web apps where Blink's understanding of the app's scope was disabled for shortcut apps. This makes promotable web apps and shortcut apps behave the same for autoplay policy, keyboard events in app windows and picture in picture mode (see uses of Document::IsInWebAppScope()). This is desirable because promotable/non-promotable web apps are effectively identical to the user so the fewer hidden behavioural differences the better. Bug: 910016 Change-Id: I4d1e29566520369436b58ecdd1ba2eaefa17de31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041379 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#740528}
-
Bettina authored
Allowlist ping experiment is launched so this flag is not needed anymore. Bug: 953106 Change-Id: I9145dd18b83e90ad0661e364d730090f0318db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051039Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#740527}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/2041678. Having a verb for these methods is better as these will become mojo methods. Bug: 1046335 Change-Id: I945b2da96754d6f29b8451ddd9194f9fd781757b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048623 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#740526}
-
David Grogan authored
This refactors flex base size calculation to more explicitly match the parts of https://drafts.csswg.org/css-flexbox/#algo-main-item . As a result it is pretty verbose. Bug: 845235 Change-Id: I1a49c7f153b8e0779b1d1eaa1206bd5056e9da2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986054 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Sam Maier authored
Since we've moved manifest merger to using cmdline-tools, we no longer need android_sdk/public/tools. Bug: 1049700 Change-Id: I2946fe85a861b8e9ddc85af357953007259e7977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044885 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#740524}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5b39823026a7..601fc962a276 git log 5b39823026a7..601fc962a276 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 dproy@chromium.org Add origin trial token for 127.0.0.1:8003 Created with: gclient setdep -r src/third_party/catapult@601fc962a276 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: oysteine@google.com Change-Id: If8c94e5f938797b683b08fbd0aaa913f707fe091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051133Reviewed-by:
-
Alex Danilo authored
Bug: 992823 Change-Id: Id4c2453cce71d969b92d19ec78f1f28d6424e5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045280 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
Just set state back to kRequestSent when auth credentials are supplied by the client. Change-Id: I8f344fe8deba0cc5fcbf04c6d4d412f2a83878d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051295Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#740521}
-
Takumi Fujimoto authored
Replace them with base::OnceCallback/base::RepeatingCallback and base::BindOnce()/base::BindRepeating(), respectively. Bug: 1007800 Change-Id: Id5d7312a5882b9acd3168b255ba67048bfc37908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050622Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#740520}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify enum histogram recording by changing the enum metric to be an enum class and defining kMaxValue where needed. Bug: 742517, 1047547 Change-Id: Ie82d26a8866d005e481a67614b2756a03115d58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046541 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740519}
-
