- 02 Mar, 2018 40 commits
-
-
Sorin Jianu authored
BUG=818069 Change-Id: Ie4989031929e5b65a0a783809d3ee588227e6a75 Reviewed-on: https://chromium-review.googlesource.com/944051Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540531}
-
Peter Beverloo authored
All it does right now is verify that starting a Background Fetch request from JavaScript makes the (real) download service accept a request. It will provide the base for various other integration tests to follow. Change-Id: Ib748ba394d4933d486617c4fc77a643ed9cf8d62 Reviewed-on: https://chromium-review.googlesource.com/940121Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#540530}
-
Erik Chen authored
Bug: 801006 Change-Id: Ic75538c44814c912ab623af4959f74cd081000f7 Reviewed-on: https://chromium-review.googlesource.com/939668 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540529}
-
mck.giri authored
This CL migrates renderer to browser IPC messages. Also, This CL registers MediaStreamTrackMetricsHost as a Mojo interface to be exposed to the renderer from RenderProcessHostImpl. The host is created whenever a request is made from the renderer. Bug: 787422 Change-Id: I113b774858633d787f300099177277835af69da2 Reviewed-on: https://chromium-review.googlesource.com/795524Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#540528}
-
jonross authored
We've now triagged all of the Mac specific failures that have been seen when running viz tests on Mac FYI bots. This updates the filter files to document which bug is tracking the failures for which tests. TBR=kylechar@chromium.org Bug: 760181 Change-Id: I0ef68761fd8be57619d35ed9a8de87dbfbd59132 Reviewed-on: https://chromium-review.googlesource.com/946127Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#540527}
-
Daniel Bratell authored
Missing include guards tend to break jumbo builds and makes everyone involved sad so better to have a presubmit check for it. There is a risk that this triggers on correct code so it includes a way to disable it per source file. Include the string "no-include-guard-because-multiply-included" and there won't be any warning for that file. By popular demand there will also be a warning if the name of the include guard doesn't follow the coding standards, but since mistakes are common, that check is only enabled for new files. Bug: 814776 Change-Id: Id18b3d43288b9a064e537460d667957b355bbd33 Reviewed-on: https://chromium-review.googlesource.com/931761 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540526}
-
Saman Sami authored
Currently CopyOutputRequests given to CompositorFrameSinkSupport end up in whatever surface happens to be the last activated surface at the time. This could result in several bad scenarios such as CopyOutputRequests being dropped, handled late, applied on an old surface taking a stale snapshot, or force SurfaceAggregator to draw two surfaces of one frame sink at the same time. Always move CopyOutputRequests given to CompositorFrameSinkSupport to the surface that SurfaceAggregator will draw. Bug: 817364 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2a4dffdb17c3b76260ab40a456604c1a73ca1c07 Reviewed-on: https://chromium-review.googlesource.com/943940 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540525}
-
agrieve authored
This reverts commit cbd2ab58. Reason for revert: Crashing tablet tester: https://ci.chromium.org/buildbot/chromium.android/KitKat%20Tablet%20Tester/ Original change's description: > Fix URL bar text being cropped by action buttons. > > A recent change to the layout of the URL bar and the action buttons > container broke the calculation and application of margin to the URL bar > to avoid overlap between the action buttons and the URL bar. > > This CL fixes the calculation of the new action container's width and > the appropriate margin to apply to the URL bar, fixing the issue where > text in the URL bar was hidden underneath the action container. > > Bug: 816432,816376 > Change-Id: Ic1793f29885392aae97f1b767b65276b597795e7 > Reviewed-on: https://chromium-review.googlesource.com/938383 > Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540394} TBR=mariakhomenko@chromium.org,tedchoc@chromium.org,twellington@chromium.org,thildebr@chromium.org Change-Id: Ic2b3820e4ae978af5d3610b67133c2e4272cda3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816432, 816376, 818187 Reviewed-on: https://chromium-review.googlesource.com/946428Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540524}
-
Jeremy Roman authored
base::MakeUnique no longer exists. Finally, add a link to Google/Abseil C++ TOTW 126, which further explains the guidance around make_unique. Bug: 755727 Change-Id: I953cff07f88d8d3dcf4f3c31870abc25397e8107 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/944918Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540523}
-
Steven Valdez authored
Bug: 641225 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d6d153c1e9bf480f3a736fc1cfd8c1cebac8a19 Reviewed-on: https://chromium-review.googlesource.com/934522Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540522}
-
Daniel Vogelheim authored
This implements an origin trial for signature-based SRI. It introduces a flag in IntegrityMetadataSet to store whether signature are enabled, because origin trials are enabled/disbabled based on a request's Origin, but the Resource instance itself isn't bound to such an origin. Hence, that information needs to be passed in. Change-Id: I5780c614044165231e948fdf01ec09f3355671f5 Bug: 753349 Reviewed-on: https://chromium-review.googlesource.com/924187 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#540521}
-
Yi Gu authored
Rename animation_player_unittest.cc to animation_unittest.cc Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9e15c5275330c06516c13ab55f41d4f97802bfd7 Reviewed-on: https://chromium-review.googlesource.com/945409Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540520}
-
Leszek Swirski authored
Due to a bad refactoring, ScriptResource was setting data on a cache handler field it owned, rather than the cache handler of the Resource. Bug: chromium:783124 Change-Id: I364b1d704821d9c14ad67b2af449c6f5b9aeca43 Reviewed-on: https://chromium-review.googlesource.com/946249Reviewed-by:
-
Maxim Kolosovskiy authored
This CL is Step 3 & Step 4 from the description of crbug.com/800318. Bug: 800318 Change-Id: I50d8936f80d193044c159a7d0f12285aaecfdeb6 Reviewed-on: https://chromium-review.googlesource.com/927361 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540518}
-
Daniel Bratell authored
The default chunk size is not 200 anymore, for a number of months. Change-Id: I8370e472628ddcf1c49bdc09d989bdadf3ea78b3 Reviewed-on: https://chromium-review.googlesource.com/946097 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#540517}
-
Maxim Kolosovskiy authored
[Password Manager] Merge code of |PasswordUpdatePendingView| and |PasswordPendingView| into |PasswordPendingView| This CL is Step 2 from the description of crbug.com/800318. Bug: 800318 Change-Id: I8b71209a8ab820c54a5a122ce0b4b907abd036bb Reviewed-on: https://chromium-review.googlesource.com/926601 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/414af52e1273..406b235a95c4 $ git log 414af52e1..406b235a9 --date=short --no-merges --format='%ad %ae %s' 2018-03-01 erikchen Fix logic in memory dump event. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I3779e6a02155825ae99d0d78ef577b5f2aad1648 Reviewed-on: https://chromium-review.googlesource.com/946111Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540515}
-
Cait Phillips authored
This should have landed with https://chromium-review.googlesource.com/c/chromium/src/+/761239 and fixes an isssue where users can add new credit cards in Settings/Autofill even if credit cards are disabled. Bug: 700812 Change-Id: Iccd242ae2f5aef910081199dbbf1a67328953b63 Reviewed-on: https://chromium-review.googlesource.com/944505Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#540514}
-
Tao Bai authored
The frame could be gone since TEXTFIELD_CHANGED is posted in FormTracker. Note: This crash isn't introduced by FormTracker, the TEXTFIELD_CHANGED has been posted for a long time. Bug: 818005 Change-Id: I9ea9e100219940d5f975183543acd9263cd0af49 Reviewed-on: https://chromium-review.googlesource.com/945074 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540513}
-
Greg Thompson authored
BUG=810302 TBR=grt@chromium.org Change-Id: Iabaf1bb1466db928e48f80eed48c0b4f7b3fab04 Reviewed-on: https://chromium-review.googlesource.com/946094Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540512}
-
Greg Thompson authored
BUG=818170 TBR=grt@chromium.org Change-Id: If59a726f649a32efe7498405e29c0335e3231f09 Reviewed-on: https://chromium-review.googlesource.com/946248Reviewed-by:
-
Yi Gu authored
Previously we run animation on pending tree upon impl side invalidation to calculate valid animation state. However it's unnecessary because the recycle tree that the pending tree is relying on has already been updated. Accordingly, the animation logic should stay in CommitComplete to avoid extra cost. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I3182c3d1a2f9f13bc2758d216d1dd8bbade8f1ab Bug: 791279 Reviewed-on: https://chromium-review.googlesource.com/919602 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540510}
-
Bence Béky authored
This CL partially re-lands https://crrev.com/c/927491 among other things. This CL is mostly to prepare for adding tests for WebSockets over HTTP/2. Add missing include to spdy_network_transaction_unittest.cc for HttpResponseInfo. Change two WebSockets test file to use wildcard.pem instead of spdy_pooling.pem. Move WebSocketExtraHeadersToString from a test file anonymous namespace to websocket_test_utils.h. Also change argument type for extra headers in websocket_stream_test.cc to WebSocketExtraHeaders and use this helper function to convert them to a string. In websocket_stream_test.cc: * Change all tests to use www.example.org instead of localhost so that it is compatible with the test certificate wildcard.pem. (This is only a requirement for wss, but it is cleaner if all tests use the same hostname.) * Change tests that will be parametrized to test WebSockets over HTTP/2 as well to use wss scheme. * Change WebSocketStreamCreateUMATest to be a derived class of WebSocketStreamCreateTest instead of creating an instance of it, and use HistogramTester for simplicity. * Change test base class methods and members from public to protected. * Inline trivial AddRawExpectations() method. Bug: 801564 Change-Id: I76a3ed145baa0f9171089765852e3165d43c9710 Reviewed-on: https://chromium-review.googlesource.com/942522 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540509}
-
Greg Thompson authored
BUG=818167 TBR=grt@chromium.org Change-Id: I568d03c8c644030b248cfa23e837bb4ea59814ee Reviewed-on: https://chromium-review.googlesource.com/946189Reviewed-by:
-
Greg Thompson authored
WebViewTests/WebViewTest.SelectShowHide/0 is timing out. BUG=818161 TBR=fsamuel@chromium.org Change-Id: I75d31a766844f4a7c8568db678802bc83cd7ba6d Reviewed-on: https://chromium-review.googlesource.com/946168Reviewed-by:
-
Greg Thompson authored
BUG=818154 TBR=grt@chromium.org Change-Id: Ifef703601046ece334cf571c32866d1ce0aabab9 Reviewed-on: https://chromium-review.googlesource.com/945993 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds a verifier that checks markbit consistency after performing marking, i.e., a child of an object is marked if its parent is marked. The verifier supports - Parent objects on NormalPage - Children objects on NormalPage and LargeObjectPage - Regular strong fields - Weak fields in HashTable backing stores. Bug: chromium:757440 Change-Id: I4481f4cdfaa518a08304764fc6e3b8a052355175 Reviewed-on: https://chromium-review.googlesource.com/928423 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540505}
-
Mugdha Lakhani authored
provided by the user as part of BackgroundFetchOptions. This functionality will be expanded in the future to select the icon that best suits the display area. Downloading of this icon is not fatal to the fetch, hence no feedback is given to the caller of the API. This is also why no layout tests are added. Tested manually using a test website and logging to validate the correct codepath is invoked, and the expect icon is loaded in memory. Bug: 813564 Change-Id: I75215fc55d7c61b472ceb1cb8e601ca5f477a174 Reviewed-on: https://chromium-review.googlesource.com/939781 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Christos Froussios authored
For a given password form, all_possible_passwords contains every pair of <password value, password input element>. It will be usued to improve the accuracy of selecting the correct password element from a password form, when the form contains multiple password fields. The type is generalised from PossibleUsernamePair. Bug: 817750 Change-Id: I339d7fbb204cc1278131a3e510ba28325299adf4 Reviewed-on: https://chromium-review.googlesource.com/925462 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540503}
-
Dominik Röttsches authored
CFF2 fonts are initially instantiated using FreeType, but when applying variation parameters, Blink attempted to switch back to CoreText. This failed, since CoreText cannot instantiate those, leading to variation axis values not being applied. Extend format probing in FontCustomPlatformData to keep the original SkFontMgr for the base_typeface_ that this font is originally instantiated from. Thanks to Laurence Penney (@lorp) for the report. Bug: 815251 Test: fast/text/variable-fonts/cff2-variations.html Change-Id: I7d438788380c2f052fdf79b11c8145dce2721483 Reviewed-on: https://chromium-review.googlesource.com/943109Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#540502}
-
Greg Thompson authored
Times out fairly consistently. BUG=810302 TBR=estade@chromium.org Change-Id: I345f7d1ffd6d5e5dedc18cb3aaf4ef669200b59a Reviewed-on: https://chromium-review.googlesource.com/945791Reviewed-by:
-
Greg Thompson authored
Flaky segfaults. BUG=818147 TBR=grt@chromium.org Change-Id: I98496aff414bd09cb75c81071c0ae52d90940a67 Reviewed-on: https://chromium-review.googlesource.com/945991Reviewed-by:
-
Han Leon authored
This CL mojofies the legacy IPC EmbeddedWorkerHostMsg_CountFeature. After that eliminates embedded_worker_messages.h. BUG=772793 Change-Id: I1b50b37344be8613faede665c44295a7eba91f81 Reviewed-on: https://chromium-review.googlesource.com/909922 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Per discussion on blink-core-owners-discuss@. No-Try: true Change-Id: I4373516490e7bee5de2c0bbb55dcbd030f04dec7 Reviewed-on: https://chromium-review.googlesource.com/943345 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#540498}
-
Leszek Swirski authored
Makes the cache handler management in Resource virtual, and move the implementations to ScriptResource, so that other resources can create and manage different implementations of CachedMetadataHandler. One simplification to enable this is to move the platform sending logic, different between service workers and non-service-workers, into a separate callback class, which is passed to the cache handler creation. Bug: chromium:783124 Change-Id: Ib1dcea072bce3f91e0c07732ca1881089187b0f5 Reviewed-on: https://chromium-review.googlesource.com/895686 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Marc Treib authored
These have been replaced by Sync.SyncCycleInterval in https://crrev.com/c/939398. Bug: 791845 Change-Id: I77ee65cbfbb97f9b1a55009e8c4365007659ecaa Reviewed-on: https://chromium-review.googlesource.com/939465 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#540496}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: If4653c563a28d5afaa544fdf8d3450df2ad0bb2e Reviewed-on: https://chromium-review.googlesource.com/939144Reviewed-by:
-
Takeshi Yoshino authored
Change-Id: Ice7ddaa8a6400408b901530122b4f0469a149b70 Reviewed-on: https://chromium-review.googlesource.com/936348Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=817995 TBR=xiyuan@chromium.org Change-Id: Ie00bcb4d84764b4e7f0e24fae5d054768b0de6f5 Reviewed-on: https://chromium-review.googlesource.com/945734Reviewed-by:
-
Dominik Röttsches authored
Disable the test for older Mac OS as we can't maintain multiple versions. Bug: 817930 Change-Id: I42d7cc1c84e0e02618b69fddcab7c73f93396c1c Reviewed-on: https://chromium-review.googlesource.com/945729Reviewed-by:
-
