- 15 May, 2018 40 commits
-
-
Matthew Jones authored
Scrim visibility in the location bar is now completely controlled by a single function. The scrim observer is now added and removed based on the scrim visibility to avoid conflict with other observers (like the bottom sheet). Bug: 834927 Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d Reviewed-on: https://chromium-review.googlesource.com/1026168 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#558785}
-
Dan Sanders authored
Bug: 522298 Change-Id: I0450f150aed0c84935b1355f849331d97ed17ab2 Reviewed-on: https://chromium-review.googlesource.com/1056325 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558784}
-
Fernando Serboncini authored
Bug: 742360 Change-Id: I49c21ea926e8c228986dc041108ca7b9449966c5 Reviewed-on: https://chromium-review.googlesource.com/676088Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558783}
-
Hans Wennborg authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1059655 they should pass. Bug: 842698 Change-Id: Ia986149f107ba7d8de203aa5cf6f69e560008655 Reviewed-on: https://chromium-review.googlesource.com/1059656Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558782}
-
Fady Samuel authored
In order to synchronize top/bottom bar controls with web content we need to allocate a new LocalSurfaceId on the impl thread whenever the renderer compositor wants to reposition them. This CL does so. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1cf41134ecaefa9df963769725b1af86c7739435 Bug: : 672962 Reviewed-on: https://chromium-review.googlesource.com/1058311 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558781}
-
kapishnikov authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6f6ce3b6bb80481c5862d44d36b7cb8590c57870 Reviewed-on: https://chromium-review.googlesource.com/1059730 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558780}
-
David Black authored
Changes include: - Stopping interaction on widget close (fixes ESC key bug). - Stopping interaction on input modality change (if not voice). Bug: b:79441527 Change-Id: I99e3de5ac8967e79a81bfbe1733da99df52ed03f Reviewed-on: https://chromium-review.googlesource.com/1052430 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558779}
-
Lukasz Anforowicz authored
Bug: 842995 Change-Id: Ia322131520ba004da8b6ab1e8c4c749971625006 Tbr: foolip@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1060024Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#558778}
-
Mark Pearson authored
Change-Id: Ifb8cc02dc6d7cd3379316e52f51b6b3303451b03 Reviewed-on: https://chromium-review.googlesource.com/1057996Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558777}
-
Rohit Rao authored
When the BookmarksUIReboot flag is enabled, uses TableViewPresentationController to present Bookmarks in the UIRefresh style. BUG=843108 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I036d6897ec99437707abc09c550da7e63ae7a028 Reviewed-on: https://chromium-review.googlesource.com/1059716Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#558776}
-
Sorin Jianu authored
Since the migration to the new urls has been completed, this change removes the deadcode. Bug: 685897 Change-Id: I1d3262cb857c4bc7d014bbd67161bdc751b300ad Reviewed-on: https://chromium-review.googlesource.com/1056088Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558775}
-
Navid Zolghadr authored
Measure the scrolling performance regardless of whether touch or wheel input triggered the scrolling. Bug: 842846 Change-Id: I04750f3537f4da326e9a2f3c0e16e895bc696c2a Reviewed-on: https://chromium-review.googlesource.com/1059583Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558774}
-
spqchan authored
Bug: 843180 Change-Id: I81b3bbfcf9f5762661e836a3bb69df48df6b061f Reviewed-on: https://chromium-review.googlesource.com/1059939Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558773}
-
Bence Béky authored
Bug: 819101 Change-Id: Ice48803d024d75ea1ea0311b098df29de25a4c63 Reviewed-on: https://chromium-review.googlesource.com/1057453Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558772}
-
Stephen Lanham authored
This wil help Chromium reviewers target the right folks for Android changes more quickly. BUG= Change-Id: I9ddabaafe79074202560bf02df7911abe47b19a9 Reviewed-on: https://chromium-review.googlesource.com/1059582 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558771}
-
Ricky Liang authored
Fix an out-of-bound memory access bug in unit tests. Original change's description -------------------------------------------------- media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice This CL implements the TakePhoto() API for the Chrome OS camera HAL VideoCaptureDevice, including the following features: - Full size still capture - Auto-focus, auto-exposure, and auto-white-balancing stabilization BUG=chromium:832772 TEST=Run capture_unittests on DUT TEST=Make sure TakePhoto() API works on https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html TEST=Run capture_unittests on host with asan and lsan build TBR=wuchengli@chromium.org,emircan@chromium.org Change-Id: Ieafc98e07bbc39ac64347eea76baa3a496c0c775 Reviewed-on: https://chromium-review.googlesource.com/1059915Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558770}
-
Ria Jiang authored
To prepare for VizHitTestDrawQuad finch trial in beta, we need to add a field trial config which would enable VizHitTestDrawQuad feature by default in all perf bots and browser tests [1]. This CL explicitly disables VizHitTestDrawQuad feature in one of the test configs in SitePerProcessHitTestBrowsertest and PDFExtensionHitTestTest so we can still test both with and without VizHitTestDrawQuad feature before VizHitTestDrawQuad is turned on by default. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1053907 Bug: 804888 Change-Id: I42265f3c6249eb1c2b1c5c74a2e2b2fddfa35455 Reviewed-on: https://chromium-review.googlesource.com/1059699Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558769}
-
Morten Stenshorne authored
Frames and framesets ignore display:none, and will render no matter what. The style adjuster would check for display != none, before attempting to adjust, and would therefore just do nothing and accept whatever. We only used to override display and position (force to "block" and "static", respectively). Additionally force "float" to "none", as framesets are really unsuitable containing blocks, since they inherit from LayoutBox rather than LayoutBlockFlow. So, putting anything exotic inside is potentially dangerous. It confused the layout engine in general, and also managed to trick the multicol machinery into treating a floated frame child of an absolutely positioned frameset parent as column content. Bug: 840986 Change-Id: I08d2e8823c88fb3b690d71d4fac275377d082e64 Reviewed-on: https://chromium-review.googlesource.com/1059618Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#558768}
-
Kush Sinha authored
Add an |AccountManager::Observer| callback for token updates and remove the |AccountManager::Observer| callback for account list update. Having both of these callbacks does not make sense because: - Addition of a new account in AccountManager would have triggered both callbacks. - An account list update callback is not that useful. chromeos_unittests --gtest_filter="*AccountManager*" Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"; Change-Id: Id3347fbd4bd162edc43760e0da1c17b5a55add11 Reviewed-on: https://chromium-review.googlesource.com/1057667Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Joel Einbinder authored
Change-Id: Ib16be938e7df8c90f02da1211f350d172c34ebff Reviewed-on: https://chromium-review.googlesource.com/1047949 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558766}
-
Joe Downing authored
Enabling the feature for Canary/Dev by default. We are working through the final signoffs for the feature and want to start getting stability info and test feedback from dev/canary. BUG=680809 Change-Id: I93bdc72aac156668ed758572066a2da29d4d684b Reviewed-on: https://chromium-review.googlesource.com/1058928Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558765}
-
Malay Keshav authored
This patch enables the font subpixel positioning for the browser ui and blink for fractional device scale factors. It also adds a switch to force disable subpixel positioning for easier debugging and testing on devices. Bug: 839214 Change-Id: If8fd7dbc39ac3950bc27b5b7435b482fb4931065 Component: Font, subpixel positioning, kerning Reviewed-on: https://chromium-review.googlesource.com/1053289Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#558764}
-
Alexandros Frantzis authored
Add a parameter for an owned GpuFence to the GLSurface and GLSurfaceOverlay ScheduleOverlayPlane() methods. The GLSurface/GLSurfaceOverlay objects own the provided GpuFences, and forward them to internal consumers (e.g., GLImage) using unowned handles where needed. Also add the GLSurface::SetUsePlaneGpuFences() method to control whether GLSurface objects actually use the overlay plane GpuFences for overlay display synchronization. Bug: 828393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I192bd91eabd6167943e03fe31177d128f7060d63 Reviewed-on: https://chromium-review.googlesource.com/1021512 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558763}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df9ba269..324a3e44 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I9172e6c31a4621055cd13f93633617e5111e17e8 Reviewed-on: https://chromium-review.googlesource.com/1059447Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558762}
-
https://webrtc.googlesource.com/src.git/+log/59216ec4a415..28a325b52314 $ git log 59216ec4a..28a325b52 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:837922 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I870a6247f79807e033d7a70773eb0f9b0d2946e9 Reviewed-on: https://chromium-review.googlesource.com/1059708 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558761}
-
Eugene But authored
Bug: 841105 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4471a98cdef13e54b790ebcd565d59c67dba8bfd Reviewed-on: https://chromium-review.googlesource.com/1054196Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558760}
-
Francois Doray authored
These methods were only used by the chrome://discards UI, which can instead access the LifecycleUnits directly. Bug: 775644 Change-Id: Iae97a1d6bcf5af1fcd555608ad05e4921ff8e437 Reviewed-on: https://chromium-review.googlesource.com/1057692 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558759}
-
Patrick Monette authored
Retrieving this information requires IPC to the remote process, which is blocking and thus must not be done on the UI thread. But the ModuleEventSinkImpl instance must still live on the UI thread, because thats where the RenderProcessHost instance lives. The RenderProcessHost must be accessed to get the handle to the remote process inside the ModuleEventSinkImpl::Create() factory function. To make the process handle available from the background task, it is now duplicated and passed to the task via the PostTaskWithTraits() call. Bug: 832286 Change-Id: I3948a585f3d7645d706b0e8977cdf3182f212306 Reviewed-on: https://chromium-review.googlesource.com/1058339Reviewed-by:
-
Yuanyao Zhong authored
Bug: b/78599329 Test: build cast_shell Change-Id: I87afd8567613295860bc16a0e1c664a3ec4ee1a4 Reviewed-on: https://chromium-review.googlesource.com/1058596 Commit-Queue: Yuanyao Zhong <yyzhong@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0c1e2c3be1569cc89385e210d9fabfa1ecda6a84 Reviewed-on: https://chromium-review.googlesource.com/1054336Reviewed-by:
-
Hans Wennborg authored
Bug: 608541, 840756, 842698 Change-Id: Iaaaf79dc775a6738cff55037ee9c6ff354530e19 Reviewed-on: https://chromium-review.googlesource.com/1059655Reviewed-by:
-
Tommy Steimel authored
This CL adds new sizing CSS classes to the media controls. These are set based on the video width and will be used for size-specific CSS rules. Currently, these classes make no visual change. In addition, this CL refactors the old method of updating CSS classes on the controls via directly setting the class attribute to a built string of classes. This allows CSS classes to be independently set on the controls (e.g. toggling "test-mode" and "audio-only" without having to update the whole class string). Bug: 839088 Change-Id: I771c024f10bdd923fd0dac51dd872b33b719dddb Reviewed-on: https://chromium-review.googlesource.com/1056032Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558754}
-
Sammie Quon authored
Previously it would calculate positions including the ignored item and shift the indices of the items placed behind the ignored item. Now it calculates positions ignoring the item. Test: Added tests Bug: 842957 Change-Id: Idc56917e8be76dc91721d3b02357834ba22a9258 Reviewed-on: https://chromium-review.googlesource.com/1058833Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#558753}
-
James Cook authored
This is needed to get the touch hud application running out-of-process. GetWindowBoundsInScreen was returning root-window coordinates, not screen coordinates. Bug: 840380 Test: added to views_mus_unittest Change-Id: I1364d17a6eb87a748e50c5367dcf9164c25b5274 Reviewed-on: https://chromium-review.googlesource.com/1058320Reviewed-by:
-
Raphael Kubo da Costa authored
This fixes the build with GCC after a722110a ("Fix non-signal-safe calls in BrokerClient"). GCC seems to use a different underlying integer type than clang and fails with the following message: In file included from ../../sandbox/linux/syscall_broker/broker_simple_message.cc:5: ../../sandbox/linux/syscall_broker/broker_simple_message.h:80:33: error: enumerator value ‘3183328640’ is outside the range of underlying type ‘int’ enum class EntryType { DATA = 0xBDBDBD80, INT = 0xBDBDBD81 }; ^~~~~~~~~~ ../../sandbox/linux/syscall_broker/broker_simple_message.h:80:51: error: enumerator value ‘3183328641’ is outside the range of underlying type ‘int’ enum class EntryType { DATA = 0xBDBDBD80, INT = 0xBDBDBD81 }; ^~~~~~~~~~ Bug: 255063, 819294 Change-Id: I21dc7471ea6b5a28a54f7ecfad32f84d62ed16a7 Reviewed-on: https://chromium-review.googlesource.com/1059778Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Max Morin authored
TBR=miu@chromium.org Bug: 824019 Change-Id: Ib70a7edf1c42ea2643393611bca81e3b986fb333 Reviewed-on: https://chromium-review.googlesource.com/1059779Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#558750}
-
Brett Wilson authored
There were some missing newlines in the macro expansions for shared documentation that made the action and action_foreach docs look wrong. clang-format also changed the way the macros are defined. Change-Id: Id32ac1f625db86008268c1692eed970f0ae59c10 Reviewed-on: https://chromium-review.googlesource.com/1057890Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#558749}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/babd098f3684..cbf0204555fe $ git log babd098f3..cbf020455 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 vbendeb do not try collecting issues information for an empty issues list Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I64e27eede61a4d0560b483a1493ac277466422be Reviewed-on: https://chromium-review.googlesource.com/1059578Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558748}
-
Maks Orlovich authored
Posting headers gotten on IO thread from NetworkDelegate off to UI thread isn't guaranteed to work (since the IO thread is still using them!); so instead extract out the bits that are actually needed immediately. Bug: 840235 Change-Id: I067378ab1fee252af6c6cbd7562b75776477e979 Reviewed-on: https://chromium-review.googlesource.com/1057875Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558747}
-
Devlin Cronin authored
Factor the Extension object out of PermissionsData::CanExecuteScriptEverywhere(), instead passing in the extension ID and location directly. Also clean up a few duplicate calls to the method by locally caching the result. Bug: 842270 Change-Id: I434a3df769d32d9f63e2e77bc393d634dcdba4da Reviewed-on: https://chromium-review.googlesource.com/1056036Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558746}
-
