- 26 May, 2020 40 commits
-
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: I8333f375425024ed83b4ccf23492257c6b773c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158059 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771819}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for GetValue. Move the methods outside the class definition. Bug: 819294 Change-Id: I109472a0b6fa7ddab3529bc92bba680252b40f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128307Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771818}
-
Victor Hugo Vianna Silva authored
This CL introduces the functionality for the save button in the new PasswordSaveUnsyncedCredentialsLocallyView. The saving logic lives in ManagePasswordsUIController, as is done for the save bubble. The bubble controller now also retrieves the credentials from the UI controller when needed, instead of copying them. In this way, the credentials live in a single place (ManagePasswordsState) and can be easily cleared. Bug: 1060132 Change-Id: Id59f4fd3a4d642aade389d207e3290b049c8d867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139653 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771817}
-
David Van Cleve authored
Since M85 will likely be the first stable release with the pending referrer changes fully rolled out, extend the referrer policy histograms, used for measuring this change's effectiveness, to 2020-12-30; this will give plenty of time to analyze a holdback after M85 stable. R=csharrison Fixed: 1084041 Change-Id: I433a7226263440f31e4879d2757aefa247764a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214915Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 290dd0f0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I08096e6e3bde44d014d94ef132e2ebc797ea7aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215907Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771815}
-
Thomas Lukaszewicz authored
Having some part of the NativeAppWindowViews' initialization happen when it is first inserted into a view hierarchy means that the View is unable to support being re-parented to a different view hierarchy. This change allows NativeAppWindowViews to be reparented into a different hierarchy, giving the class greater flexibility and allowing for the eventual change to have ClientView be a child of NonClientFrameView. Bug: 1083822 Change-Id: I8a5beed53fd24f6b5c3dfd1fe0cb1490427cb9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207491Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771814}
-
Victor Hugo Vianna Silva authored
No behavior is changed. Before this CL, passwords_section was responsible for initializing and storing the displayed password strings of each element in savedPasswords and multiStoreSavedPasswords. Those were even initialized to the empty string, relying on implementation details of ShowPasswordBehavior (an empty string means the plaintext password is not being shown). This CL makes the password string a property of ShowPasswordBehavior, simplifying the passwords_section code. As a consequence, the PasswordUiEntryWithPassword and MultiStorePasswordUiEntryWithPassword typedefs are no longer needed. RemovePasswordBehavior's entryToRemove property and ShowPasswordBehavior's item property are both renamed to entry, since they represent the same object. Bug: None Change-Id: I58b58626999de5144913730d853ae0a4b839ae56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215321 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#771813}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: Ief3450f4469a8216de2ed1b339c555311b2f9442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167425 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Carlos IL authored
Transient navigation entries were only used for non-committed (overlay) interstitials and a few tests. Since overlay interstitials have been removed, this CL changes the tests to use regular entries, and removes the transient entry concept. Bug: 1077074 Change-Id: Ide09a628fae91a04308ae26efde7112f1e468250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149954 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771811}
-
Marina Ciocea authored
http/tests/devtools/elements/styles/stylesheet-tracking.js is flakily timing out. Bug: 1046784 Change-Id: I354535ac4d818580348e71647d12d42d68507b2d TBR: petermarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215330 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771810}
-
Nektarios Paisios authored
This patch is a second precursor to a more substantial change that would move hypertext computation to AXNode from AXPlatformNodeBase which will in turn open the way for AXNodePosition to be merged with AXPosition and for Views to be exposed as a tree of AXNodes. See https://chromium-review.googlesource.com/2150294 Currently, we have multiple methods that compute inner text, IsLeaf and IsChildOfLeaf one set in BrowserAccessibility and another in AXPlatformNodeBase. We want to centralize all platform independent utility methods in AXNode and AXNodeData. There was some confusion in the existing codebase regarding what should be included in inner text. Some code assumed that the name attribute of a leaf node could not be included, unless it was derived from its contents, or its placeholder in the case of a text field. Other parts of the codebase were more relaxed about this requirement. This patch adopts this requirement for the whole codebase, because the definition of inner text should only include visible text that is present inside the node itself, but not text derived from an attribute, e.g. an ARIA label. This is apparent from the name "inner text" itself, but it also stems out of the need to support computing bounding boxes for character ranges in inner text. If the name of an element is derived from an attribute such as an ARIA label, that attribute won't expose any bounding box information. If the name of an element is derived from a related element, e.g. a figcaption or an HTML label, the bounding box of that element is unrelated to the original element's inner text. APIs to compute bounding boxes are exposed in IAccessibleText, ATKText and ITextRangeProvider. See also the definition of IAccessibleText in the IAccessible2 Specification, the definition of ATKText in the ATK Specification, or the definition of ITextProvider in the UIA Specification. 1. https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html "The IAccessibleText interface should be implemented by all components that present textual information on the display like buttons, text entry fields, or text portions of the document window." 2. https://developer.gnome.org/pygtk/stable/class-atktext.html "... if the text is editable, multi-line, typically longer than three or four words, attributed, selectable, or if the object already uses the 'name' ATK property for other information, the atk.Text interface should be used" 3. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nn-uiautomationcore-itextprovider "Provides access to controls that contain text." 4. https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange "If an embedded object spans a range of text, the plain text should include the inner text of the object, but not the alternative text (the name property of the embedded object) because it might be inconsistent with the descriptive inner text." RELNOTES: N/A R=dmazzoni@chromium.org, aleventhal@chromium.org TBR=rsesek@chromium.org Bug: 1049261 Change-Id: Ic39687eb98c3ef7575214de2c659eb28d6633466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171436 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771809}
-
cfredric authored
Change-Id: I621327ca4c1c1c992e4e9d55abc406096266fa19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210483Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#771808}
-
Daniel Nicoara authored
The plane may not support the specific format for scanout. This is fine if the buffers have an opaque version (ie: XRGB and ARGB) and blending is disabled for scanout as the opaque version is used for scanout. BUG=1082545 TEST=Ran in cros VM Change-Id: I1a5caac796999d778eea272eed06dcbc261ac5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212980 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#771807}
-
Antonio Sartori authored
This fixes a bug introduced by https://crrev.com/770126. Also after CORS redirects we store the right initial URL in the ResourceTimingInfo. Bug: 1085332 Change-Id: I2e7b55967cc54c8bee87cd62920db76f1a25e517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212280Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#771806}
-
Side Yilmaz authored
This CL fixes wrong usages of profile at PaymentRequestHeader by adding extra profile parameter to |setTitleAndOrigin| function, while PaymentRequestUI passes the profile to the function. Bug: 1041781, 1075562 Change-Id: I9c23f54332c956ac27ea54ae6ef80c836034fcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215807Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#771805}
-
Jan Wilken Dörrie authored
This change applies the current enabled clang-tidy checks [1] on //components/password_manager and //chrome/browser/password_manager and performs some manual clean-up. [1] https://source.chromium.org/chromium/chromium/src/+/master:.clang-tidy;drc=d4c5e82aef1c958951e8810a3de7d03dfa7ad7c1 Bug: 776257 Change-Id: I6254e3384f889bba6229882bba6849caacfde9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214547Reviewed-by:
-
Ian Kilpatrick authored
These tests were inadvertently testing our UA stylesheet for the audio element. In our UA stylesheet we have: audio { width: Xpx; height: Ypx; } which means that the intrinsic size tests are failing. This fixes the tests to change the width/height when appropriate to "auto". There is probably a discussion which needs to be had about the UA style for the audio element, but not today. Bug: 960385 Change-Id: I3c5e1362015dec9cc95b7f4683a552e4afcc7424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212635 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771803}
-
Greg Thompson authored
For base::ReplaceFile to succeed on Windows, both the source and target files must have no open handles. Since ImportantFileWriter writes to a temporary file, closes it, and then calls ReplaceFile with that temporary file as the source, it will only succeed if no other processes have an open handle on either file. On Windows, the very act of closing a file that has been modified broadcasts a message to filesystem observers that a change has happened in the directory holding the file. Certain software may then try to open the file that was just closed. This, of course, will block ReplaceFile. This CL boosts the priority of the thread hosting an ImportantFileWriter for the brief window containing the close and replace operations. With any luck, this will help Chrome win the race against other software so that ReplaceFile succeeds more often. BUG=1075917 R=gab@chromium.org Change-Id: I2dd286f63e8b269d209da7497167b53ea3a54ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214624 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#771802}
-
Marina Ciocea authored
Test times out flakily on linux-chromeos-rel. Bug: 1085666 Change-Id: I5566b39e71ff5b321b5a1ec1cfae10fdca2fe503 TBR: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215812Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 to 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7224bc03cc627b84136b860de466ddd1a74a76d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771800}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 to 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I758899c5370cc84984d93d4c8611194516ab1ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216155Reviewed-by:
-
Fredrik Söderqvist authored
This test generates a lot of <text> elements that will never be made visible by the test as currently written. Reduce the number of <text> elements to only those that will potentially intersect the viewport of the scrollable container during the test. Bug: 571296 Change-Id: I048516e4084cb4101a4058ee89b973d2cca7f338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215849 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771798}
-
Harald Alvestrand authored
This test has been disabled on various platforms because of flakiness since 2015. Attempts to discover why it was flaky have been fruitless. We now have other tests (external/wpt/webrtc/simulcast) for testing simulcast functionality, so the value of fixing this one seems low. Bug: chromium:452623 Change-Id: I664010899c2a81d64a01c32a067aa93c214d9f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190672 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#771797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de2049e85aec..31001a610da6 2020-05-26 tommi@webrtc.org Remove receive_crit_ from Call. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0d20a386329c2283bdde63f3cacdcc194d36a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215897Reviewed-by:
-
Michael van Ouwerkerk authored
Change-Id: Ic7bece7e93e79e75e44d5c594c52b3d6c834cdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214539 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#771795}
-
Caitlin Fischer authored
Also, deletes the corresponding Java test, which is now redundant. Bug: 1049736 Change-Id: Ib8fb2833128d88c6fc6189ab2e45bbb245a8d697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208597Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 to 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I51001ab2fd33ca0ca3e1ca5339c6790ea0456af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216157Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50020926f80d..55e97987f5f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: marinaciocea@google.com Change-Id: Id1bdaf4bba039682eb0576d75d5ab2e059f67004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215893Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771792}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 to 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id3d4a793c9de8039bb02cd8187d98aa9a963e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216196Reviewed-by:
-
Fergus Dall authored
Bug: None Change-Id: Iced536274befbab8d08bd46bbed3755ebc996882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206754 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#771790}
-
Alex Ilin authored
This reverts commit 9d2c67b2. Reason for revert: the assertion fails in many tests on Android L First failed builds: - Lollipop Phone Tester (https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25458) - Lollipop Tablet Tester (https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/14622) Original change's description: > android: Add LifetimeAssert to WindowAndroid > > Bug: 1081250 > Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771220} TBR=boliu@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081250 Change-Id: I5721ca7286cdae4a462b83fb90aed393afca7d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213537Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771789}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibe1e5dec8827a85520dd4989ed8d9f54c3dcb620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216195Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 to 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifd4114c4c3ce9df3be2258f751adad456f78942e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216191Reviewed-by:
-
Igor authored
The histogram is still useful since it gives some input in addition to what we get from EnrolledPolicyHasDMToken histogram. And since there are some values in the later that show some possible problems, we want to keep this histogram active for a while. BUG=chromium:1066033 TEST=None Change-Id: I31a9e6ee4b158fa843f36d6a3d44b5d18fee567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214886 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Auto-Submit: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771786}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5479f2a80cf..19ffa683a1c0 2020-05-26 bryct@amazon.com Add make-continuous-headless target (headless option) to Makefile. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I3452e577521df2677295741eab1393ea6e1231c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215896Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ea04b09d5a4..4b342721d088 2020-05-26 tvanderlippe@chromium.org Use acorn-loose from front_end/third_party 2020-05-26 tvanderlippe@chromium.org Update http-proxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia22346907ba9eaa1d38c38358abfcc704ef59dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215894Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590479866-bd3b364dec503175394de5d27879ac865b50ea38.profdata to chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2827716810487cf98bf8d1354e65055d6eff85bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215900Reviewed-by:
-
Mohamed Amir Yosef authored
This CL is making use of the recent modification to the combobox that now supports: 1- Showing icons in the dropdown menu. 2- Showing different text in the combobox from the dropdown menu. 3- Showing a secondary text (2nd line) in the dropdown menu. Mocks: https://screenshot.googleplex.com/12SDSKY7RUm Screenshot: Open: https://screenshot.googleplex.com/JQ886fwsNDs Account selected: https://screenshot.googleplex.com/rdi2vPbiPV7 Device selected: https://screenshot.googleplex.com/qvxGgLXfiz9 Bug: 1044038 Change-Id: I0a3dcc5df6f68771d338190a40f6d9a162c825a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207223 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Ensure calls to MediaPlayer#seekTo are guarded by appropriate SDK level checks, to avoid lint errors. This slipped in while the linter was down due to an error somewhere. TBR: wnwen@chromium.org Bug: 1081243, 895776, 656015 Change-Id: I38143673afa986b310573595435dd2237d8a620b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214947 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771781}
-
Jochen Eisinger authored
Bug: 873178, 927509 Change-Id: I3bdacf95a6c653a9eeabadafe0a7b11a525a6aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215810Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771780}
-
