GitLab

R=enne@chromium.org

Review URL: https://codereview.chromium.org/1288093005

git-svn-id: svn://svn.chromium.org/blink/trunk@200888 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In https://codereview.chromium.org/1292863003
shadow-dom/events/event-dispatch/test-001.html
shadow-dom/events/event-retargeting/test-004.html
missed to be removed from failure expectation.

This removes these 2 entries from TestExpectation.

BUG=505364
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1303683003

git-svn-id: svn://svn.chromium.org/blink/trunk@200887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393155

Review URL: https://codereview.chromium.org/1305463002

git-svn-id: svn://svn.chromium.org/blink/trunk@200886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a CL to fix (a part of) the regressions observed in tough_animation_cases
benchmarks on oilpan builds. In short, this CL fixes the heavy allocation design
of CSSAnimationUpdate.

Currently, a lot of CSSAnimationUpdate objects are allocated on Oilpan's heap.
This is problematic because the CSSAnimationUpdate objects hold HeapVectors and HeapHashMaps,
which produce a lot of unnecessary garbage in Oilpan's heap.

This CL makes CSSAnimationUpdate stack-allocated and explicitly clears the HeapVectors and HeapHashMaps
when the CSSAnimationUpdate is destructed on stack. When we need to hold a pending CSSAnimationUpdate
on CSSAnimation, it is held as a part of object of CSSAnimation. That way we can avoid
allocating unecessary HeapVectors, HeapHashMaps etc every time a pending CSSAnimationUpdate is created.

BUG=325467

Review URL: https://codereview.chromium.org/1281493004

git-svn-id: svn://svn.chromium.org/blink/trunk@200885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Moved Position::up/downstream implementation to VisibleUnit.cpp and
renamed mostForwardCaretPosition/mostBackwardCaretPosition.
This CL splits Position implementation from layout object.
Position::upstream just calls mostForwardCaretPosition but the callers will
  call it directly.

BUG=518738

Review URL: https://codereview.chromium.org/1299323006

git-svn-id: svn://svn.chromium.org/blink/trunk@200884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ServiceWorker: Show a warning when ServiceWorker(Client) attempts to send a transferable ArrayBuffer

In the current implementation, ServiceWorker and ServiceWorkerClient do not
support sending an ArrayBuffer as a transferable object yet and unexpectedly
lose the buffer without any warning.

BUG=511119

Review URL: https://codereview.chromium.org/1303823002

git-svn-id: svn://svn.chromium.org/blink/trunk@200883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |nodeIsUserSelectAll()| out from |PositionAlgorithm| template
class to "EditingUtilities.cpp" to simplify |PositionAlgorithm| class for
improving code health, since |nodeIsUserSelectAll()| doesn't depend on
|Strategy| template parameter.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1307523002

git-svn-id: svn://svn.chromium.org/blink/trunk@200882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL depends on https://codereview.chromium.org/1271733002/ (chromium) and https://codereview.chromium.org/1280733002/ (blink).

BUG=518713,510650

Review URL: https://codereview.chromium.org/1286153003

git-svn-id: svn://svn.chromium.org/blink/trunk@200881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@adb1c28f977cb1f4ee22a44d6f4a6f1055682ff1
imported web-platform-tests@1e70f2fac661cdb44d500ae8fe545c710179cbef

* html/dom/documents/dom-tree-accessors/Document.currentScript.html
  now makes XMLHTTPRequest to "/" and throws, thus skip it now.

* html/webappapis/animation-frames
  - 1 new test fails, "-expected" added.

* shadow-dom
  - 2 failing tests were removed in upstream.
  - 1 new crash in focus-navigation.

* css-writing-modes-3
  - 4 new ref tests fail.

* NOPRESUBMIT=true because of tab characters in shadow-dom/testcommon.js.

NOPRESUBMIT=true
TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=490511, 492664, 505364

Review URL: https://codereview.chromium.org/1292863003

git-svn-id: svn://svn.chromium.org/blink/trunk@200880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since scaling a zero-sized image can result in dealing with NaNs (in case
that we're scaling it using an inf, which is fairly possible), we should
avoid doing that. This CL makes sure that we do.

As to why we're dealing with zero sized images to begin with, I've opened
crbug.com/522637, but it seems like something that can happen regardless,
when ImageResource doesn't have an Image.

BUG=521954

Review URL: https://codereview.chromium.org/1299493005

git-svn-id: svn://svn.chromium.org/blink/trunk@200879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

At one point the caret was placed at an incorrect position for complex
scripts. This was caused by advances and/or bounds calculation was
incorrect when white-space:pre is applied to a text run of complex
scripts.

It was fixed in later patches. This CL adds a test for the failure to
prevent it happening again.

BUG=513994

Review URL: https://codereview.chromium.org/1303673005

git-svn-id: svn://svn.chromium.org/blink/trunk@200878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of used functions |kit(TextAffinity)| and
|core(TextAffinity)| in "TextAffinity.h" to cleanup code for improving code
health.

This is follow-up of a review comment in http://crrev.com/1293593004.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1291283008

git-svn-id: svn://svn.chromium.org/blink/trunk@200877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/1287283002/ unintentionally removed code
to consider estimatedRemovalRate when judging a threshold for page navigation GCs.
This CL recovers the code.

BUG=474470

Review URL: https://codereview.chromium.org/1301893003

git-svn-id: svn://svn.chromium.org/blink/trunk@200876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds a layout test to ensure that client ordering is done properly.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-matchall-method

1. (Chromium) https://codereview.chromium.org/1285373002/
2. (Blink) This CL.

BUG=461411

Review URL: https://codereview.chromium.org/1286123004

git-svn-id: svn://svn.chromium.org/blink/trunk@200875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

JavaScript Symbols are a new (in ES2015) primitive type. This caused
ScriptValueSerializer to go off the rails when it had exhausted its known
list of primitives and then assumed anything else might be an object.

Now the code checks for Object-ness before assuming it. Also refactored
the if/else-if cascade to group all Object handling together, and prune
dead branches.

BUG=522227

Review URL: https://codereview.chromium.org/1297223004

git-svn-id: svn://svn.chromium.org/blink/trunk@200874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1293793008

git-svn-id: svn://svn.chromium.org/blink/trunk@200872 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=
BUG=498539

Review URL: https://codereview.chromium.org/1306523002

git-svn-id: svn://svn.chromium.org/blink/trunk@200871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522674

Review URL: https://codereview.chromium.org/1286383007

git-svn-id: svn://svn.chromium.org/blink/trunk@200870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522274

Review URL: https://codereview.chromium.org/1300093002

git-svn-id: svn://svn.chromium.org/blink/trunk@200869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=502118, 503170

Review URL: https://codereview.chromium.org/1284413004

git-svn-id: svn://svn.chromium.org/blink/trunk@200868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=501896

Review URL: https://codereview.chromium.org/1290883006

git-svn-id: svn://svn.chromium.org/blink/trunk@200867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=514595

Review URL: https://codereview.chromium.org/1297323002

git-svn-id: svn://svn.chromium.org/blink/trunk@200866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should make creating a subclass in a test easier, and hopefully
combined with FrameTestHelpers::WebViewHelper and some cleverness will
allow writing FOUC tests.

BUG=521692

Review URL: https://codereview.chromium.org/1287403005

git-svn-id: svn://svn.chromium.org/blink/trunk@200865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=
NOTRY=

Review URL: https://codereview.chromium.org/1300253002

git-svn-id: svn://svn.chromium.org/blink/trunk@200864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1297903005

git-svn-id: svn://svn.chromium.org/blink/trunk@200863 bbb929c8-8fbe-4397-9dbb-9b2b20218538

filterNeedsPaintInvalidation does the same thing and makes the code more
clear. This also centralizes the callers of scheduleSVGFilterLayerUpdateHack.

Review URL: https://codereview.chromium.org/1292213004

git-svn-id: svn://svn.chromium.org/blink/trunk@200862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLPluginElement::loadPlugin was using scheduleSVGFilterLayerUpdateHack()
to update the compositing state of the LayoutEmbeddedObject. Instead we
can use the setNeedsCompositingUpdate() API which will cause only a
compositing update and skip the wasteful style recalc on the <embed> or
<object>.

I also moved the call to updateSelfPaintingLayer into
setNeedsCompositingUpdate since all callers of it actually want to do
that too.

After this the only user of scheduleSVGFilterLayerUpdateHack is actually
SVG filters.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/1293533005

git-svn-id: svn://svn.chromium.org/blink/trunk@200861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening.

NOTRY=true
TBR=ojan@chromium.org,pfeldman@chromium.org,joelo@chromium.org
BUG=521764,521730

Review URL: https://codereview.chromium.org/1296223004

git-svn-id: svn://svn.chromium.org/blink/trunk@200860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I manually verified this giant pile of tests are okay.
Mostly, the results change from blending border colors at the
corners and from a skia change to how images are scaled. Those
changes happened during the dark times when the 10.10 bot
wasn't processing rebaselines.

BUG=508724,509025
TBR=joelo

Review URL: https://codereview.chromium.org/1286043005

git-svn-id: svn://svn.chromium.org/blink/trunk@200859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow-up to codereview.chromium.org/1286043005

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1294113006

git-svn-id: svn://svn.chromium.org/blink/trunk@200858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=510345

Review URL: https://codereview.chromium.org/1291733003

git-svn-id: svn://svn.chromium.org/blink/trunk@200857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Verified all differences are expected.

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1287423006

git-svn-id: svn://svn.chromium.org/blink/trunk@200856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The mechanism that Blink was using to determine OSX version number was not
reliable. This has since been fixed.

> I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system
> font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily()
> to correctly return the system font on 10.11, but this causes glyph rendering
> problems. In the short term, I'm adding logic to MatchNSFontFamily() to return
> nil on 10.11, which was the original behavior before I landed that CL.
>
> BUG=521034
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618

BUG=521034
TBR=tkent@chromium.org, keishi@chromium.org

Review URL: https://codereview.chromium.org/1299713004

git-svn-id: svn://svn.chromium.org/blink/trunk@200855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522674

Review URL: https://codereview.chromium.org/1305433004

git-svn-id: svn://svn.chromium.org/blink/trunk@200854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like BeginTransform3DDisplayItem, these can also create transforms that
we need to know about. The logic is fairly straightforward and mostly shared
with 3D transforms.

BUG=460986

Review URL: https://codereview.chromium.org/1295403003

git-svn-id: svn://svn.chromium.org/blink/trunk@200853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

UMA metrics indicate we have great validity. Enable the hit test cache
in release by default. Keep the validity checks around in ASSERTs
are enabled.

BUG=398920

Review URL: https://codereview.chromium.org/1294913004

git-svn-id: svn://svn.chromium.org/blink/trunk@200852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code is not implemented nor called. Discovered while digging into a
selection issue.

Review URL: https://codereview.chromium.org/1291253003

git-svn-id: svn://svn.chromium.org/blink/trunk@200851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extract BoxPainter::calculateBackgroundImageGeometry implementation
and related functions to the BackgroundImageGeometry class. This
enables shrinking the API surface of BackgroundImageGeometry and eases
further code health improvements.

BUG=521481

Review URL: https://codereview.chromium.org/1300103003

git-svn-id: svn://svn.chromium.org/blink/trunk@200850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Repaint test expecations changed due to SlimmingPaint work, but
it happened during the window where Yosemite results weren't
being updated.

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1296253004

git-svn-id: svn://svn.chromium.org/blink/trunk@200849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's too inaccurate.

BUG=502407
R=jchaffraix@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1285273004

git-svn-id: svn://svn.chromium.org/blink/trunk@200848 bbb929c8-8fbe-4397-9dbb-9b2b20218538