GitLab

BUG=none
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2735973003
Cr-Commit-Position: refs/heads/master@{#455780}

https://skia.googlesource.com/skia.git/+log/c65aec976196..5395c598dbc3

$ git log c65aec976..5395c598d --date=short --no-merges --format='%ad %ae %s'
2017-03-08 halcanary FuzzCanvas: TextBlob RSXform SkMaskFilter SkPathEffect
2017-03-08 reed make GrPaint.h private -- IWYU
2017-03-09 reed move intermediate patheffect classes inside src

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I475a55e1ddb0449b34908151d04b6c4a738fe9c1
Reviewed-on: https://chromium-review.googlesource.com/451966Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455779}

The bug seems to have been there since we added DisplayItem::kCaret.
This breaks under-invalidation checking itself only. It won't cause
any visible issue to release builds, except small performance
penalty that the drag caret is always repainted because of no match
in the cache with the wrong id.

BUG=699480

Review-Url: https://codereview.chromium.org/2742693002
Cr-Commit-Position: refs/heads/master@{#455778}

We are adding COMPONENT/TEAM information into OWNERS file
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716753003
Cr-Commit-Position: refs/heads/master@{#455777}

BUG=697971

Review-Url: https://codereview.chromium.org/2738933002
Cr-Commit-Position: refs/heads/master@{#455776}

This adds TLS 1.3 specific metrics for SSL connection errors and
latency and a Google specific metric for SSL connection errors.

BUG=699226

Review-Url: https://codereview.chromium.org/2732103003
Cr-Commit-Position: refs/heads/master@{#455775}

This will begin collecting DOM hierarchy data in upcoming threat reports. The feature was initially just for safety but it's not needed to control the launch of populating the DOM field.

BUG=674618

Review-Url: https://codereview.chromium.org/2731913003
Cr-Commit-Position: refs/heads/master@{#455774}

This test is failing on all downstream iPad versions.

BUG=700001
TBR=gambard

Review-Url: https://codereview.chromium.org/2739943004
Cr-Commit-Position: refs/heads/master@{#455773}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/627310

https://chromium.googlesource.com/chromium/src/+/0f9cfc4753603

BUG=699044
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2736403004 .
Cr-Commit-Position: refs/heads/master@{#455772}

BUG=699536

Review-Url: https://codereview.chromium.org/2737843004
Cr-Commit-Position: refs/heads/master@{#455771}

This CL makes the following changes:

(1) Make SpdySession use Socket::ReadIfReady(). This new behavior is
    hidden behind a field trial flag, SocketReadIfReady.
(2) Make SpdySession lazily allocate |read_buffer| on demand.
(3) Make SpdySession release |read_buffer| when Read() completes or
    when ReadIfReady() cannot be completed synchronously.

Re-allocating an 8KiB buffer should be cheap, see more discussion
at https://groups.google.com/a/chromium.org/d/msg/project-trim/QtliUsApxyk/AOSnyuY7CgAJ

BUG=690915

Review-Url: https://codereview.chromium.org/2734933002
Cr-Commit-Position: refs/heads/master@{#455770}

Change SVGUseElement to use the observeTarget() helper from
SVGURIReference. Since SVGUseElement has some additional requirements
for its reference management, a more low-level observeTarget() variant
is exposed.
To facilitate this change, clearShadowTree() is renamed to
clearResourceReference(), and the shadow tree tear-down is hoisted out
of it.

BUG=661598

Review-Url: https://codereview.chromium.org/2744613002
Cr-Commit-Position: refs/heads/master@{#455769}

I think this would be nice as documentation, as these classes can be
quite confusing to people outside of content/ experts.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2727263004
Cr-Commit-Position: refs/heads/master@{#455768}

After this is added, Mac10.12 builders will be used when getting new baselines (rebaseline-o-matic and rebaseline-cl), and and will be checked when removing flaky expectations (update-test-expectations).

I believe that https://codereview.chromium.org/2738053002 should be committed first.

BUG=697971

Review-Url: https://codereview.chromium.org/2731403011
Cr-Commit-Position: refs/heads/master@{#455767}

Browser process hit testing was enabled on Android in r455559, along
with the appropriate browser tests. Unfortunately on some builders these
tests fail, due to coordinates being off skewed from expectations. The
tests attempt to account for scale factor rounding error on Android that
does not exist on other platforms, due to differently treatment of DSF,
but apparently the variance can be quite high across devices. We need
to investigate a way to work around this in browser tests.

BUG=700007
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2743733002
Cr-Commit-Position: refs/heads/master@{#455766}

Change SVGFEImageElement to use the observeTarget() helper from
SVGURIReference.
A slight change in behavior for when a load is initiated for a potential
image resource is made. Instead of using a "failed element lookup and a
non-existing id" as the condition, use "failed element lookup and non-
local resource reference".
Also add a new method clearImageResource() and put the tear-down for
the image resource, and change a use of ownerDocument() to just
document().

BUG=661598

Review-Url: https://codereview.chromium.org/2740003003
Cr-Commit-Position: refs/heads/master@{#455765}

It was used to distinguish hang types in the big hang timer in RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2737553003
Cr-Commit-Position: refs/heads/master@{#455764}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2743723002
Cr-Commit-Position: refs/heads/master@{#455763}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2742783002
Cr-Commit-Position: refs/heads/master@{#455762}

This utilizes length of scripts and stylesheets recently exposed in the protocolto avoid requesting content in CoverageModel.

Review-Url: https://codereview.chromium.org/2735133004
Cr-Commit-Position: refs/heads/master@{#455761}

Revert of webrtc-internals: dont remove tab (patchset #1 id:1 of https://codereview.chromium.org/2739443002/ )

Reason for revert:
This is breaking some Mac builds
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/14781

Original issue's description:
> webrtc-internals: dont remove tab
>
> instead of removing the tab when a peerconnection is garbage collected
> this adds a symbol which removes the tab on click.
>
> BUG=416876
>
> Review-Url: https://codereview.chromium.org/2739443002
> Cr-Commit-Position: refs/heads/master@{#455743}
> Committed: https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75

TBR=guidou@chromium.org,tommi@chromium.org,philipp.hancke@googlemail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=416876

Review-Url: https://codereview.chromium.org/2745433004
Cr-Commit-Position: refs/heads/master@{#455760}

This will let us simplify the Mojo code a bit in the future, and it
makes it consistent with all other ResourceHandler methods, which
always use ResourceController for resuming and cancellation, rather
than returning a bool.

No ResourceHandler currently takes advantage of this behavior, though
this CL updates all intermediary ResourceHandlers to support it.

BUG=687240

Review-Url: https://codereview.chromium.org/2668603003
Cr-Commit-Position: refs/heads/master@{#455759}

Changes VrShellDelegate to only be created when VR classes are available, and adds a check to static native method to ensure VR classes are available.

BUG=700002

Review-Url: https://codereview.chromium.org/2744623002
Cr-Commit-Position: refs/heads/master@{#455758}

Follow up cleanup after https://codereview.chromium.org/2716493004/

BUG=695189

Review-Url: https://codereview.chromium.org/2735063005
Cr-Commit-Position: refs/heads/master@{#455757}

On backend notification, the UI must remove all displayed suggestions and
reload all suggestions.

BUG=699124

Review-Url: https://codereview.chromium.org/2739153002
Cr-Commit-Position: refs/heads/master@{#455756}

Similar to crrev/2632043002/, this CL create TestRule for each existing test base
class (ContentDetectionTestBase, JavaBridgeTestBase, NativeLibraryTestBase).
It refactors these test base classes and new TestRules on top of test common layer.
It also remove any inheritance field reference for mTestCallbackHelperContainer to
calling the new API getTestCallbackHelperContainer() for the purpose of common
implementation.

BUG=640116

Review-Url: https://codereview.chromium.org/2739603003
Cr-Commit-Position: refs/heads/master@{#455755}

https://skia.googlesource.com/skia.git/+log/08541e8d7f28..c65aec976196

$ git log 08541e8d7..c65aec976 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 bsalomon Make GrClip.h private
2017-03-08 caryclark limit addEndMoveSpans loop in pathops

Created with:
  roll-dep src/third_party/skia
BUG=684553


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I8fb788b1ad19d487930809d3dda039660584d4ee
Reviewed-on: https://chromium-review.googlesource.com/451885Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455754}

Revert of Include the AppData file for Chrome and Chromium (patchset #4 id:60001 of https://codereview.chromium.org/2424093003/ )

Reason for revert:
This is breaking linux build bot (again), please do not submit before fixing:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16722

Original issue's description:
> Include the AppData file for Chrome and Chromium
>
> Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
> will be filled with the information from the common/google-chrome/google-chrome.info
> file and should reflect the current channel (stable, beta, devel). On the other
> side the Chromium one should be a general one and it will be reused by
> distributions that are packaging the Chromium themselves.
>
> For AppData specification please see:
> https://people.freedesktop.org/~hughsient/appdata/
>
> BUG=654190
>
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Original-Commit-Position: refs/heads/master@{#455457}
> Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Commit-Position: refs/heads/master@{#455731}
> Committed: https://chromium.googlesource.com/chromium/src/+/caa17f475b1ccf16ce0d4f89902663f4462396a8

TBR=phajdan.jr@chromium.org,xhwang@chromium.org,tomas.popela@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654190

Review-Url: https://codereview.chromium.org/2738043003
Cr-Commit-Position: refs/heads/master@{#455753}

This patch adds functionality to the testing class NavigationSimulator,
to allow for NavigationThrottles to defer and cancel the navigation.

The new functionality is tested by new NavigationSimulator unit tests,
as well as new subresource filter unit tests exercising the untested
SubframeNavigationFilteringThrottle.

BUG=637415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2698393002
Cr-Commit-Position: refs/heads/master@{#455752}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a105b33..13fe480

$ git log a105b33..13fe480 --date=short --no-merges --format=%ad %ae %s
2017-03-09 kjellander@webrtc.org Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
2017-03-09 kthelgason@webrtc.org Reland of Add unit tests for RTCMTLVideoView. (patchset #1 id:1 of https://codereview.webrtc.org/2733953006/ )
2017-03-09 kthelgason@webrtc.org Reland of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #1 id:1 of https://codereview.webrtc.org/2739793003/ )
2017-03-09 oprypin@webrtc.org Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )
2017-03-09 kjellander@webrtc.org PyLint fixes for tools-webrtc and webrtc/tools
2017-03-09 kwiberg@webrtc.org Make error reporting more detailed
2017-03-09 oprypin@webrtc.org Enable cpplint and fix cpplint errors in webrtc/*audio
2017-03-09 ilnik@webrtc.org Fix CpuTimeTest to tolerate MSAN interference (some background test-related work).
2017-03-09 nisse@webrtc.org Reland of Delete unused TaskRunner abstraction. (patchset #1 id:1 of https://codereview.webrtc.org/2732363004/ )
2017-03-09 nisse@webrtc.org Revert of Delete cryptstring.h and cryptstring.cc. (patchset #1 id:1 of https://codereview.webrtc.org/2740633003/ )
2017-03-08 nisse@webrtc.org Delete cryptstring.h and cryptstring.cc.
2017-03-08 zhihuang@webrtc.org Add the function ToRtpParameters.
2017-03-08 nisse@webrtc.org Delete deprecated PeerConnection methods, and corresponding using declarations.
2017-03-08 kthelgason@webrtc.org Revert of Add Metal video view in AppRTCMobile and metal availability macro. (patchset #5 id:80001 of https://codereview.webrtc.org/2722583002/ )
2017-03-08 kthelgason@webrtc.org Revert of Add unit tests for RTCMTLVideoView. (patchset #6 id:100001 of https://codereview.webrtc.org/2723903003/ )
2017-03-08 alessiob@webrtc.org Conversational Speech generator, main script with shell arguments
2017-03-08 kjellander@webrtc.org Refactor + enable GN check on video_coding_utility
2017-03-08 elad.alon@webrtc.org GetTransportFeedbackVector return vector with lost packets too, sorted by seq-num
2017-03-08 kjellander@webrtc.org Enable GN check for webrtc/logging
2017-03-08 kjellander@webrtc.org Revert of Temporarily disable failing video_quality_loopback_test.py (patchset #1 id:1 of https://codereview.webrtc.org/2704073002/ )
2017-03-08 nisse@webrtc.org Revert of Delete unused TaskRunner abstraction. (patchset #2 id:20001 of https://codereview.webrtc.org/2622923002/ )
2017-03-08 solenberg@webrtc.org Remove VoEVolumeControl interface.
2017-03-08 nisse@webrtc.org Delete unused TaskRunner abstraction.
2017-03-08 kjellander@webrtc.org Enable GN check for webrtc/modules/video_processing
2017-03-08 ilnik@webrtc.org Disable failing 15 thumbernails full-stack test on windows

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2741663003
Cr-Commit-Position: refs/heads/master@{#455751}

Follow-up to https://codereview.chromium.org/2730183003:
* The types in IDLTypes.h are traits types with no member functions, so
  using CORE_EXPORT does not have any effect and we can drop it.
* Export the entire NativeValueTraits specializations in
  NativeValueTraitsImpl.h instead of only their nativeValue() member
  functions.
  In addition to avoiding some repetition in the code, doing so also solves
  some linkage issues on Windows with debug component builds, where targets
  such as 'webkit_unit_tests' or 'blink_media_unittests' would fail to
  reference the aforementioned specializations and lead to errors like this:

    FAILED: media_blink_unittests.exe media_blink_unittests.exe.pdb
    E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./media_blink_unittests.exe /PDB:./media_blink_unittests.exe.pdb @./media_blink_unittests.exe.rsp
    V8RecordTest.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class WTF::Vector<struct std::pair<class WTF::String,int>,0,class WTF::PartitionAllocator> __cdecl blink::NativeValueTraits<struct blink::IDLRecord<struct blink::IDLString,struct blink::IDLLong> >::nativeValue(class v8::Isolate *,class v8::Local<class v8::Value>,class blink::ExceptionState &)" (__imp_?nativeValue@?$NativeValueTraits@U?$IDLRecord@UIDLString@blink@@UIDLLong@2@@blink@@@blink@@SA?AV?$Vector@U?$pair@VString@WTF@@H@std@@$0A@VPartitionAllocator@WTF@@@WTF@@PEAVIsolate@v8@@V?$Local@VValue@v8@@@6@AEAVExceptionState@2@@Z) referenced in function "void __cdecl blink::RecordTestV8Internal::setStringLongRecordMethod(class v8::FunctionCallbackInfo<class v8::Value> const &)" (?setStringLongRecordMethod@RecordTestV8Internal@blink@@YAXAEBV?$FunctionCallbackInfo@VValue@v8@@@v8@@@Z)

  The exception to the rule here is IDLSequence: since it needs template
  parameters of its own, it is not a full specialization of
  NativeValueTraitsBase, and at least win_clang complains when it is
  exported:

    E:\b\c\b\win_clang\src\third_party\WebKit\Source\bindings\core\v8\NativeValueTraitsImpl.h(289,8):  error: 'dllimport' attribute ignored [-Werror,-Wignored-attributes]
    struct CORE_EXPORT NativeValueTraits<IDLSequence<T>>

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2742453002
Cr-Commit-Position: refs/heads/master@{#455750}

The issue is that PSS::GetModelTypeStoreFactory requires valid PSS which doesn't
have to be available when sync is disabled (for example in guest mode on
ChromeOS). The reason it is currently wired through PSS is that PSS conveniently
has path and blocking task runner required for ModelTypeStore.

I added static GetModelTypeStoreFactory function that takes profile path and
SequencedWorkerPool. It ensures that, for a given path, all task runners use the
same sequence token and thus properly sequneced. Datatypes that wish to be
hosted in shared leveldb database should use this factory function.

I also fixed issue that backend_map_ is accessed from multiple threads and thus
might get corrupt. I wrapped it into a class with lock.

BUG=688533
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2732333003
Cr-Commit-Position: refs/heads/master@{#455749}

Add arguments to the editing functions.

BUG=676290

Review-Url: https://codereview.chromium.org/2740833003
Cr-Commit-Position: refs/heads/master@{#455748}

This is one of the few CLs refactoring budget pool mechanisms for the
addition of the new WakeupBudgetPool.

- Move TimeBudgetPool into budget_pool.h to keep task_queue_throttler
size manageable.
- Split TimeBudgetPool into BudgetPool (interface) and TimeBudgetPool
(realisation).

There will be a separate CL uncoupling TaskQueueThrottler from BudgetPool.

R=alexclarke@chromium.org,skyostil@chromium.org

BUG=699541

Review-Url: https://codereview.chromium.org/2741473002
Cr-Commit-Position: refs/heads/master@{#455747}

BUG=NONE

Review-Url: https://codereview.chromium.org/2738183003
Cr-Commit-Position: refs/heads/master@{#455746}

Merge internal change: 149537594

BUG=

Review-Url: https://codereview.chromium.org/2740453006
Cr-Commit-Position: refs/heads/master@{#455745}

This CL exposes the Open in New Tab and Open in New Incognito Tab methods of
the Reading List Coordinator as part of the
ReadingListCollectionViewControllerDelegate.

BUG=676290

Review-Url: https://codereview.chromium.org/2745563002
Cr-Commit-Position: refs/heads/master@{#455744}

instead of removing the tab when a peerconnection is garbage collected
this adds a symbol which removes the tab on click.

BUG=416876

Review-Url: https://codereview.chromium.org/2739443002
Cr-Commit-Position: refs/heads/master@{#455743}

DOMDataStore holds a pointer to a separately allocated DOMWrapperMap (which
itself contains a HashMap with a reference to the actual hashtable). This
reduces the number of heap allocations (and pointers to follow to manage
non-main-world wrappers) by one.

Review-Url: https://codereview.chromium.org/2742553002
Cr-Commit-Position: refs/heads/master@{#455742}

We now use MSVC 2015, which supports expression SFINAE.

Review-Url: https://codereview.chromium.org/2739513003
Cr-Commit-Position: refs/heads/master@{#455741}