- 15 Dec, 2020 40 commits
-
-
Alice Wang authored
This CL moves AccountPickerDelegate to signin.ui target. Bug: 1158335 Change-Id: Ibd61670d9ef1ac098b3ba826b9239ece9dd2c283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592994Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837125}
-
Alex Ilin authored
This CL prepares the profile picker to work with the force signin policy. The list of changes: - Propagate IsSigninRequired() value from ProfileAttributesEntry to the WebUI - Modify the profile card to display "Sign in [lock]" prompt on profiles that require sign-in - Remove asserts checking that the force signin policy is disabled - Add native handlers for launching a locked profile and creating a new profile when the force signin policy is enabled Screenshot: https://drive.google.com/file/d/1Y03Kpe_4CoO5DWLbJ79Fu5j-hjjz0xzz/view?usp=sharing Bug: 1156096 Change-Id: I8aa315c4459ecf3e9d0faed331a3590aa92a0169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584002 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#837124}
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: I385d767ae4aee2160f85904afa5bac1da1c7923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593607Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#837123}
-
Peng Huang authored
The crash in vkGetPhysicalDeviceProperties2() which is supported by Vulkan 1.1.0. The Vulkan loader may support 1.1.0, but the device may not support 1.1.0, so we need check device API version before calling it. Bug: 1158768 Change-Id: Ib306feda2c4b790ef06e5802e4777744bf1c4892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593548 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837122}
-
John Abd-El-Malek authored
Bug: 1156663 Change-Id: I0ca8c2a2882c627780f94dae09b0e19a65bd04a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591708Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#837121}
-
Ossama Mahmoud authored
Bug: 1156668 Change-Id: I5ab27202a535c829304291ac53dc9545eeb292da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588909 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#837120}
-
Shengfa Lin authored
ChromeDriver python expecting pid in constructor Bug: chromedriver:3681 Change-Id: Icb1e56720ca3c8231442628254f965d675df1696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592807Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#837119}
-
Alex Turner authored
Currently, it creates a copy of the map, which means no metrics should be recorded. Change-Id: I8d00d464e448fa364cfd47dd8657b3c4f650fff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590384 Auto-Submit: Alex Turner <alexmt@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#837118}
-
Scott Violet authored
My intention is to merge this to 88. This adds the following changes to cct: 1. context menu when in incognito mode no longer shows 'open in chrome'. As the app menu explicitly doesn't show 'open in chrome' I'm assuming it's an over site that 'open in chrome' is shown in the context menu. If this isn't an over site, I can hide this behind the flag I previously added. 2. Makes it possible for first parties to use this regardless of the feature state if an extra is present. Reason for this is I plan to merge this to 88, in which the feature is disabled. 3. Makes it possible for colors to come from the intent. This is only enabled if an extra is present in the bundle and restricted to first parties. 4. Makes it possible for not show the incognito icon. This is only enabled if an extra is present in the bundle and restricted to first parties. BUG=1157916 TEST=Various tests in CustomTabActivityIncognitoTest Change-Id: I812f46e935dcae01b8d161893059ecf81c146522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582643 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837117}
-
Joe Downing authored
The current PolicyWatcher exposes a set of 'current' policies which is actually the default policies with overrides from any platform policy which is actually set. This works fine for driving behavior but in some cases we actually want to know whether a policy value we receive is the 'default' or if an admin has set it explicitly. To allow this, the PolicyWatcher will now store the set of platform policies on the machine and provide it on request. I plan to use this for logging (to get an idea of policy usage and popularity) and for cases where we want to provide a flag from the website to the NMH but also want admins to override the value if needed. Since the PolicyWatcher provides the platform policies now, I renamed GetCurrentPolicies() to GetEffectivePolicies() as I think that name reflects the fact that it is a merged set of policies. Change-Id: Id2fd578ac42d925922e8beb5f028374d7bcdcbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587614Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837116}
-
Yao Xiao authored
This is a reland of b5ab6427 Seems this CL shouldn't be the cause for the test failure that the reverted CL is referring to. Based on https://ci.chromium.org/p/chromium/builders/ci/android-asan, the android_sync_integration_tests also failed before (#9128). It also succeeded (#9148) after the recent mass failures (#9146), and the successful build occurred without the revert. Besides, this CL simply renamed a struct field / some APIs. Any potential errors should be caught by the compiler. Original change's description: > Rename publicly_routable field in the history APIs to floc_allowed > > What: Rename publicly_routable field in the history APIs to > floc_allowed. The database schema is left unchanged to save the > migration cost. Updated the comment for VisitRow::floc_allowed. > > Why: This bit is expected to be used only for floc. We've decided to > incorporate another opt-out status, and may introduce more status in > the future. Therefore it makes sense to rename to floc_allowed. > > Bug: 1157761 > Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836815} Bug: 1157761 Change-Id: I4d9329f953f3ee4d3707c2a4e06e27a8542c2bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592194Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hggko_uXuyxm_pLSASRkHELwYPxwaBF969K75Dw8z_MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/161823671,b/169023690,b/174201860,b/174536568,b/175517195,b/175636714,b/175638149 Tbr: media-app@grotations.appspotmail.com Change-Id: I22450ce53bfefbd560ed610a48ec42cab73a4ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593422Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837114}
-
Joshua Pawlicki authored
This standardizes the updater at waiting at most 5 seconds for launchctl to reflect changes. Bug: 1151333 Change-Id: I7b15048b44a894b0244eea4fb265f59ee764e7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593550 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837113}
-
Marc Treib authored
Tbr: chrisha@chromium.org Bug: 1158715 Change-Id: Ib60e031f87da6d6e81759cb7461248a6ccd5556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593628Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#837112}
-
Matt Menke authored
The test had assumed connection partitioning was enabled. This CL makes it run with partitioning both enabled and then disabled. Bug: 963480 Change-Id: I7ee0d035969f7b0eaa3759080258cef53147a992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587350Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837111}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9efbf74cf61..e0eb7753ae75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: treib@google.com Change-Id: I0b18974e1503dc01137a8636f545e9eacc53def4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593415Reviewed-by:
-
Lubo Ivanov authored
Chrome's perfetto producers. This is done to reduce the overhead of tracing. The batching period of 1s was determined using https://chromium-review.googlesource.com/c/chromium/src/+/1835498 in Chrome on gLinux, but with 4KB Chunk size (which corresponds to the chunk size on Android, where batching would have the most pronounced effect). The effects of various delays on overhead can be seen at https://drive.google.com/file/d/1Og9cSTaNmsSy1P6k0nfoyHK8n094HMrW/view?usp=sharing. A spreadsheet with the full perfstat results, on which this graph is based, can be found at https://docs.google.com/spreadsheets/d/15wxYJaR2hvUVY2MtqI29gPYwdkGxDZVqrUkSOZWspPs/edit?usp=sharing. Since all affected producers already set will_notify_on_stop=true, we can just flush commits while stopping a datasource to avoid losing any batched data. Related changes in perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/1260461 https://android-review.googlesource.com/c/platform/external/perfetto/+/1309414/13 https://android-review.googlesource.com/c/platform/external/perfetto/+/1450696/14 Bug: 1029298 Change-Id: I880cb2e49c169bcf6e216eb12ce52b8bd40ba4ad Change-Id: I880cb2e49c169bcf6e216eb12ce52b8bd40ba4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149648 Commit-Queue: Lyubomir Ivanov <lri@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837109}
-
Guido Urdaneta authored
This makes this method pure virtual and implements it in all derived classes. Prior to this CL, MediaStreamVideoSource had a weak pointer factory, which was incorrect as derived classes define more data fields which could become invalid before the factory invalidated outstanding weak pointers. Bug: 1158227 Change-Id: I31e6e0f624e9ba81b74e234b72c58f9dc5dbd585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588928 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837108}
-
Victor Hugo Vianna Silva authored
These histograms have nothing to do with components/sync, they were mistakenly added to the sync histograms file. Bug: None Change-Id: I5d22799a2a4c20534db04de3ff8531cef781a38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590036 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837107}
-
Dominic Farolino authored
Before this CL, MockAgentSchedulingGroup would always invoke the AgentSchedulingGroup base class constructor which is now reserved for the kLegacy MBI feature mode. This caused the ctor to DCHECK in tests when MBI mode was enabled. After this CL, MockAgentSchedulingGroup conditionally invokes the right AgentSchedulingGroup constructor given the flag. Consequently, MockRenderThread::GetIOTaskRunner() needs to be able to return a non-null TaskRunner. This CL gives MockRenderThread the ability to set a new IOTaskRunner manually so that it can be returned when necessary. While we're here we also remove PrintMockRenderThread_set_io_thread_for_testing() since the base class MockRenderThread now handles that. We also entirely remove ChromeMockRenderThread. Bug: 1158656 Change-Id: I1ab1231048ecc1b798549634811706f86a7bafb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591929 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#837106}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I5a379fb181f277cd3cd67c193912e29a0b949836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566738 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#837105}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7808f1c464a..cf8ec1f68676 2020-12-15 mbonadei@webrtc.org Introduce empty rtc_base:async_resolver target. 2020-12-15 mbonadei@webrtc.org Add TBR to the WebRTC code freshness updater and send to CQ. 2020-12-15 natim@webrtc.org Using absl::optional for round trip time return type handling. 2020-12-15 deadbeef@webrtc.org Get rid of recently added rtc_openssl_is_boringssl build argument. 2020-12-14 mbonadei@webrtc.org Add WebRTC code freshness version string. 2020-12-14 ilnik@webrtc.org Use a task queue for call interaction in video_replay tool 2020-12-14 mbonadei@webrtc.org Fix order-dependent tests. 2020-12-13 sprang@webrtc.org Extend LibvpxInterface with VP9 support and use it from LibvpxVp9Encoder 2020-12-11 natim@webrtc.org Enforcing return type handling on VoIP API. 2020-12-11 hta@webrtc.org Add tests for adding many transceivers and renegotiating. 2020-12-11 hmaniar@nvidia.com Reland "Enable FlexFEC as a receiver video codec by default" 2020-12-11 deadbeef@webrtc.org Reland: Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL. 2020-12-11 deadbeef@webrtc.org Do all BaseChannel operations within a single Thread::Invoke. 2020-12-10 sprang@webrtc.org Splits vp9_impl into libvpx_vp9_encoder and libvpx_vp9_decoder. 2020-12-10 philipel@webrtc.org Remove EncodedFrame::inter_layer_predicted. 2020-12-10 philipel@webrtc.org Remove use of inter_layer_predicted in FrameBuffer2. 2020-12-10 landrey@webrtc.org Rename UNIT_TEST to WEBRTC_UNIT_TEST 2020-12-10 saza@webrtc.org Revert "Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL." 2020-12-10 deadbeef@webrtc.org Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL. 2020-12-09 philipp.hancke@googlemail.com sdp: add missing continue after parsing b= lines 2020-12-09 devicentepena@webrtc.org Erle metric: avoid the decreasing of the metric when there is no render activity. 2020-12-09 philipel@webrtc.org Stop using inter_layer_predicted flag for VP9. 2020-12-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a89d00b3..708cc13d (834813:835045) 2020-12-09 alessiob@webrtc.org RNN VAD: FC layer simplified 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2be5b61c..a89d00b3 (834670:834813) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88d50e234435b85c641c616bbaebfc3724291749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837104}
-
Liquan (Max) Gu authored
This CL does not cause behaviour change. Changes: * Renamed "continueShow" to "continueShowWithUpdatedDetails" * In onPaymentDetailsUpdated(), replaced mSpec.getPaymentDetails() with details because they are the same object. Bug: 1149936 Change-Id: Icea9f313b513861d4655e3f66f053c015c6f775f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590059Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837103}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4baf1b64..6b82504a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If0b95f4643334edac638242f497abc0bb1f29682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593588Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837102}
-
Illia Klimov authored
ContentSettingsType::PLUGINS was unregistered in that CL https://chromium-review.googlesource.com/c/chromium/src/+/2577782 This CL adds "plugins" for deprecated ContentSettingsType DCHECK. TBR=finnur@chromium.org Bug: 1157738 Change-Id: I860746df406892c8e6e1f94eaa6fd12eaed4958d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587036Reviewed-by:
Illia Klimov <elklm@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837101}
-
Roman Aleksandrov authored
Move size calculation of oobe-adaptive-dialog to C++ which enables better fit for on-login OOBE dialog and unifying sizes between fullscreen and on-login screen versions. Recalculate all of the needed CSS vars based on dialog size. Since the dialog is centered no need to provide paddings around dialog for fullscreen OOBE. Bug: 1151292 Change-Id: Icd6fad02255abf105c940ad610caad5b578c06ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567008Reviewed-by:
-
Hiroki Nakagawa authored
PrerenderURLLoaderThrottle::mode_ is always mojom::PrerenderMode::kPrefetchOnly, so the field is not necessary. Even after this change, the constructor of PrerenderURLLoaderThrottle still takes the mode as an argument just for validation check. This will be removed by follow-up CLs that remove the mode from callers of the constructor. Bug: 755921 Change-Id: I72c5cb9ca3c1d03e9316fbf60aa067d3bff02cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592237Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837099}
-
Francois Beaufort authored
This CL has no functional changes. It moves NDEFErrorTypeToDOMException function to the only file where it's used: ndef_reader.cc. Bug: 520391 Change-Id: I910d57147dba47579b78586edce8041d0b2d326c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587167Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#837098}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: If2e115d6de11f15340b8464720315f0ff2433f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592795 Commit-Queue: Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
kylechar authored
https://crrev.com/c/2431550 made it so that texture parameters would be reset before compositing from the texture. Texture parameters can be modified during concurrent reads of the texture, eg. using 2D canvas drawImage() to copy a video frame into a canvas. Skia didn't know the texture parameters had changed, so the parameters value could be wrong at composite time, with no way to know when this happened. Always resetting texture parameters had a performance impact on Linux. The display compositor doesn't need to worry about concurrent reads for TileDrawQuad or render pass textures since these textures are only used by cc and the display compositor. Resetting texture parameters can be skipped for those cases which mitigates most of the performance impact. Add a bool to ImageContextImpl to track if it needs to worry about concurrent reads to accomplish this. Bug: 1148236, 1092080 Change-Id: If233d5f43ba978fe6848bcc46721a159c1779922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572641 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837096}
-
edchin authored
https://crrev.com/c/2581033 missed a few cleanup items. Bug: 1099646 Change-Id: I4f1fabcade940a977b6b0f0af3ed855b3929eb1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591818 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#837095}
-
Bo Liu authored
Also refactor the fake draw_fn implementation. This is to prepare for adding a vulkan draw_fn implementation. Split draw_fn implementation into: allocator.cc/h: Controls functor data lifetime context_manager: Effectively global. Responsible for owning the surface and EGL context. Calls sync/draw/context_destroyed on functor and responsible for owning the "impl reference" to functor data. context_manager uses EGL bindings from ui/gl, but nothing else to avoid conflicting with chromium side implementations, and to avoid initializing a TaskRunner on render thread. Only GLES call is glReadPixels after draw, which relies on chromium implementation not releasing its bindings after draw. Refactor and simplify the java side by explicitly adding a thread to post tasks and a WaitableEvent; this avoids saving state and using a Lock object. Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-m-nexus-5x-64 Bug: 1141687 Change-Id: I71752b31f401fdb277062fe1347dfa826a20bb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587238 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: -
Marc Treib authored
This reverts commit 3909caf2. Reason for revert: Broke TestSuiteTest.RunFlakyTests and . RunMockTests, see crbug.com/1158815 Original change's description: > Roll ANGLE from fd7733e97423 to cb8903b14336 (1 revision) > > https://chromium.googlesource.com/angle/angle.git/+log/fd7733e97423..cb8903b14336 > > 2020-12-15 lehoangq@gmail.com Metal: Ignore OS's internal shader cache when testing. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: cwallez@google.com > Change-Id: I21b81c00947e5964d12841f6334bc1e5cf3f6bd6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592058 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#836969} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I88ba1edfa0ddbfc60cbc7c3ec742f8c5263d107f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593099Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/24bbbbb25f7d..e07510293160 2020-12-15 bclayton@google.com Fix HLSL emission of RWTextures 2020-12-15 bclayton@google.com spirv-writer: Emit the DepthReplacing execution mode 2020-12-15 bclayton@google.com spirv-reader: Fix texture[Load|Store] with lod 2020-12-15 bclayton@google.com ast: Clone symbols instead of ever-growing 2020-12-15 bclayton@google.com traits: Replace FirstParamType with ParamType 2020-12-14 bclayton@google.com Start cleaning up tests (3/N) 2020-12-14 bclayton@google.com Start cleaning up tests (2/N) 2020-12-14 bclayton@google.com Start cleaning up tests (1/N) 2020-12-14 bclayton@google.com ast: Inject Source parameter into create calls if not provided 2020-12-14 bclayton@google.com Move all Source constructor params to be the first 2020-12-14 dneto@google.com spirv-reader: reject sampling operations on non-float textures 2020-12-14 bclayton@google.com Remove BlockStatement::insert() 2020-12-14 bclayton@google.com Remove BlockStatement::append() 2020-12-14 bclayton@google.com Improve error messages raised by SpvParserTest 2020-12-14 dneto@google.com spirv-reader: convert unsigned ConstOffset 2020-12-14 bclayton@google.com reader/spirv: Remove use of BlockStatement::append() 2020-12-14 dneto@google.com spirv-reader: convert coordinate type when unsigned If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Iaaa0130aa9d70b34d4606a8f65b50b22d6e8b364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593274Reviewed-by:
-
Hiroki Nakagawa authored
Only a few files exist in core/loader/private/. Having the `private` sub-directory seems to no longer make sense. This CL moves files there into core/loader. Bug: n/a Change-Id: I8475b8b9401688432016c7d3ad5ff17e6adb3f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400646 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#837091}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iea319ef80b0aa8e5391a79c9834eca871ad161d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592133Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837090}
-
arthursonzogni authored
Check what happens when opening an about:srcdoc window from a sandboxed about:srcdoc iframe. This patch was intended to be one of the regression tests for https://crbug.com/1158306. At the end, I realized it isn't. It is still worth adding it. The real test where Chrome fails will be added in: https://chromium-review.googlesource.com/c/chromium/src/+/2587047 Bug: 1158306 Change-Id: I2f6f7468564c66c17b679c4007cc6b4e26cb980c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584812 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#837089}
-
Joshua Pawlicki authored
This should reduce flakiness of the updater_tests's IntegrationTest.* suite. Also re-enables one such disabled test, which should now be more reliable. Bug: 1151333 Change-Id: I1c5d920f7aaed5c51e717333e77c04d670383196 Fixed: 1151333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590055 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: I332718280875f9a4b8c08e27d2f700f510c6a24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584939Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Brian Ho authored
Currently, fixing exo bugs for Lacros is cumbersome due to version skew between Lacros/ash. In a single CL, we ideally want to 1) land an exo fix and 2) land a conditional workaround in Lacros until ash is uprevved to actually include the exo fix (see the bug for a real world example). To remedy this, this CL introduces a new |bug_fix| event that sends down IDs of bug fixes present in exo when the zaura_shell is bound. Clients (notably |ui::WaylandZAuraShell|) can listen for this event and gate features on the presence of certain bug fixes by calling |WaylandZAuraShell::HasBugFix(bug_id)|. Bug: 1151508 Change-Id: Iec39e32c4b507545aaf59c0a73f3fa61f9a7e3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568204 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#837086}
-
