- 14 Oct, 2019 40 commits
-
-
Kalpak Tapas authored
This is a preparatory change for adding accessibility support for PDF annotations. Currently, text, links and images within a PDF page are supported in an accessibility context. These are passed as separate parameters in Set/GetAccessibilityPageInfo methods exposed through the Pepper API. When annotation support comes in, the number of parameters would increase to 6 making those function calls unwieldy and requiring additional extensions to the templated DispatchResourceCall function. This change groups links and images into a new *PageObjects struct which will also be the home for the upcoming representation of PDF annotations. Bug: 1008775 Change-Id: Icee1b9b17290614265be8c65c5b594d3a99fe767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831957Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kalpak Tapas <katapas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705481}
-
Luciano Pacheco authored
When the user is resizing the app using the splitter, and the tree has has overflow-y content, a scroll bar appears. That is annoying. Fix by hiding directory scroll bars while the splitter is active. Similar to what was done for directory tree on CL:1851789 Bug: 992821 Change-Id: Ic11d88a943af4a756496e6f18b78910249c87be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858026 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#705480}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19a311d0aef7..c34e434df0d7 git log 19a311d0aef7..c34e434df0d7 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 67486ec24551..fede5cb664d9 (12 commits) 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 92809357..e034419f (981 commits) Created with: gclient setdep -r src/third_party/skia@c34e434df0d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None Change-Id: Ia697e5bad6db4a74f7994a404fe5c1da5f1a18db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705479}
-
Christoph Schwering authored
Added a new class AutofillTickClock analogous to AutofillClock. Added a new class TestAutofillTickClock analogous to TestAutofillClock. Replaced usage of base::Time::Now() with AutofillClock::Now(). Replaced usage of base::TimeTicks::Now with AutofillTickClock::NowTicks(). The only exception are autofill_test_utils.h's functions NextYear() etc., which refer to the actual date (e.g., for a test credit card entry). Migration to TaskEnvironment::MOCK_TIME is non-trivial because it doesn't support setting time to an absolute value but only fast-forwarding by some delta. Bug: 1009364 Change-Id: Iabb693b6eb8a6ebe9fa5ef2bb493a90ae8918422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850434Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#705478}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1550399cc0a1..dd6f66826702 git log 1550399cc0a1..dd6f66826702 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 dberris@chromium.org Revert "Dashboard - Force test metadata to update sheriff on upload" Created with: gclient setdep -r src/third_party/catapult@dd6f66826702 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1006252,chromium:1013984 Change-Id: I0b7e3253b625b0f9715c3dfcedd31606323ff4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859063Reviewed-by:
-
Timothy Loh authored
The OnWindowActivated observer method does not guarantee that the |gained_active| argument is non-null, so GuestOsEngagementMetrics should not assume this. This is causing tast tests to fail when the PluginVm feature is enabled, as the matcher used, IsPluginVmWindow(), doesn't null-check the window. ARC is unaffected as IsArcAppWindow() does a null-check. Bug: 990252 Change-Id: I4673e1c9fbbc8142057481d51567be0e5677656d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859417Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#705476}
-
Koji Ishii authored
The discussion at crbug.com/1013040 clarified that the line initial style of |NGInlineBreakToken| is nullptr for [class C breaks]. In that case, it is still fine to compute the line initial style from the containing block. This patch updates the comment and add DCHECK. [class C breaks]: https://www.w3.org/TR/css-break-3/#end-block Bug: 1013040 Change-Id: Ie000ab7c259f91d445a4dca1b510559c5146722f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855548 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705475}
-
Kuo Jen Wei authored
Fix by correcting the orientation before square cut. Bug: b/141670036 Test: Take photo in square mode with different orientation, verify the orientation of result file is correct. Change-Id: I7350d0846c438e8f6f4af5482ccef3b03df4ee23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857801Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#705474}
-
Noel Gordon authored
This reverts commit 5a12eea7. Reason for revert: The fixture is a timeout/pass in DEBUG only, but this CL disabled test on all bots: RELEASE/MSAN/ASAN. So can we please not do that? Thank you. Original change's description: > Disable more CopyBetweenWindows tests. > > Similar to copyBetweenWindowsDriveToUsb, copyBetweenWindowsLocalToUsb > and other related tests are also flaky. Disable them all. > > TBR=austinct@chromium.org > > Bug: 1008909 > Change-Id: Ib87e1403a653fa599111faa38b30947ca0fbf216 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857650 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705367} TBR=thestig@chromium.org,austinct@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008909 Change-Id: Iabbc58b3c23781b51d1b1fd3bc41df5d635c9f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859414Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705473}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7e1b45d9c28..19a311d0aef7 git log a7e1b45d9c28..19a311d0aef7 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ae022faf53b9..1c462ebc904c (1 commits) Created with: gclient setdep -r src/third_party/skia@19a311d0aef7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None Change-Id: I3ea5fd77c1d463cd147c3843e43e939427d48a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859334Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b3dd5a9..74897164 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1804f2cd2ea2ef2607d356b04b34da6d2ecd918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859354Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705471}
-
Jeremie Boulic authored
The add provider menu no longer lives in the directory tree. Move its css icon to file_manager.css. Bug: 993292 Change-Id: I68d986a2f4581a4acee27177778517bad33e6cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858062 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/bf0413d8c1d6..5843bfd65204 $ git log bf0413d8c..5843bfd65 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 renjietang Fix GOAWAY max frame length. 2019-10-10 renjietang Merge different HTTP/3 QUIC version label into one called VersionUsesHttp3. 2019-10-10 fayang gfe-relnote: Do not send connection close when client receives a version negotiation packet. Not affect prod, not protected. 2019-10-10 fayang Automated g4 rollback of changelist 269791493. 2019-10-10 renjietang Run all QUIC versions in quic_stream_test. 2019-10-10 bnc Remove usages of QuicMakeUnique, Http2MakeUnique, SpdyMakeUnique. 2019-10-10 dschinazi Improve debug logging and test display 2019-10-09 nharper Use const uint8_t[] instead of vectors for QUIC initial obfuscation salts 2019-10-09 dschinazi Support local vs remote flow control with TLS, and fix initial limits 2019-10-09 dschinazi Use max TLS idle_timeout and use in session tests 2019-10-09 nharper gfe-relnote: Introduce QUIC_VERSION_50, protected by quic_enable_version_50 2019-10-09 nharper gfe-relnote: Expose properties of TLS connection in quic::CryptoNegotiatedParameters. Protected by quic_supports_tls_handshake. 2019-10-09 bnc Simplify QpackEncoderStreamSender API. 2019-10-08 dschinazi Deprecate quic_use_length_prefix_from_packet_info 2019-10-08 dschinazi Deprecate quic_framer_uses_undecryptable_upcall 2019-10-08 dschinazi Deprecate quic_use_hashed_stateless_reset_tokens 2019-10-08 vasilvv Refactor common QuicTransport constants into their own file. 2019-10-08 renjietang Add ToString to packet header enums. 2019-10-08 bnc Remove obsolete statement from quiche/README.md. 2019-10-08 bnc Coalesce QPACK encoder stream writes in QpackEncoderStreamSender. 2019-10-08 bnc Send Insert Count Increment instruction after decoding a header block if possible. 2019-10-07 renjietang Move connectivity probing related code from QuicFramer to QuicPacketCreator. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: Ifac7287447b48a2dad870a64cf1c38f6e070dd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857400Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705469}
-
Chris Hall authored
The ax_enums file has moved from .idl to .mojom. This change fixes all current outdates references to old .idl filename. R=aboxhall,dmazzoni,dtseng Change-Id: I31069ebfec2a37432a9c868c5758734b8b32d1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855062Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705468}
-
Alan Cutter authored
This CL limits the web app manifest updating feature to just Chrome OS. This is a tentative rollout of the feature and avoids having to deal with updating desktop shortcut icons for the time being. Bug: 926083 Change-Id: I44dabf843316c15b03dccf7e6287231ba078a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859295 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
This method is only used by .firstrun. FeatureUtilities is bloated with assorted code which should be moved to other places. Also move subroutines used by canAllowSync(). Bug: 1012975 Change-Id: I8e05540e2c726c1781c140d894241ffefe3a851a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857187Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#705466}
-
Austin Tankiang authored
Policy can force the default download path to be in Drive. This is done using a policy path variable '${google_drive}' in the forced path, which is expanded into a legacy drive client path (e.g. '/special/drive-...') in a policy handler. This path is then later converted into a DriveFS path if DriveFS is enabled. This path can't just be expanded to a DriveFS path, as that requires the user's Profile, which isn't accessible in a policy handler. Now that the legacy drive client is being removed, skip expanding it to a legacy drive client path, and just leave it as a path variable, and expand it to a DriveFS path at the same time as legacy path migration. Bug: 1003238 Change-Id: I3f5b3d316b958eefd2f964d70eb2a7f2a932273d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838843 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:Min Qin <qinmin@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#705465}
-
Jeevan Shikaram authored
App Management is on track to be launched in M79. Update the flag accordingly. Change-Id: Id05413b409397da76e33fa80cc645d001112fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859235 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705464}
-
Chris Hall authored
The automation.idl file was moved in 9e3b5c57 This change updates the comment in ax_enums.mojom to reflect this new location. R=aboxhall,dmazzoni,dominickn Change-Id: I2c4c1b22f610426e340974039ac3b6513c4817b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855243Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705463}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b70e8a807b99..91eb1bdd8b07 git log b70e8a807b99..91eb1bdd8b07 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org osutils: ReadFile: port to Python 3 2019-10-13 vapier@chromium.org run_tests_unittest: mock out ClearPythonCacheFiles Created with: gclient setdep -r src/third_party/chromite@91eb1bdd8b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I780923008553e11a091f491ab420b0455466cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858919Reviewed-by:
-
Yuchen Liu authored
|interfaces_| is used when ENABLE_MOJO_RENDERER or ENABLE_MOJO_CDM. Since this object is not specific to one service, remove the guard on it. Bug: None Change-Id: I586293c9974b1aec97908d14208a0811c1ae5448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854637 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#705461}
-
Jeremie Boulic authored
Test: browser_tests --gtest_filter="*FilesApp*dirCreateMultipleFolders" Bug: 1004717 Change-Id: I803d147640ee67875b8729dffa6e4bbac4704e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855244 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
The dictionary used for fuzzing is ~500KB, which results in fuzzing at ~1 case/sec on clusterfuzz. Reducing the dictionary size allows the fuzzer to run much faster, but may result in less coverage. Use a FuzzedDataProvider to generate a range of dictionary sizes to get a mix of coverage and make the fuzzer much faster. BUG=1009087 Change-Id: Ia25feef99e48a1ed28ea6de636430d3509c69def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847603 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705459}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 753caf71. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I473e3afc630457a3170a7128c17139d118b3da3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858572Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705458}
-
Jason Lin authored
This is possibly the culprit of the crash reported in the bug. This CL also resets |completed_callback_| in CrostiniRestarter::Abort() to localized the crash point so that similar crashes in the future are easier to diagnose. In the same spirit, |observer_list_| is cleared in CrostiniRestarter::RunCallback(). This CL also adds 3 missing abort tests: AbortOnSshKeysFetched, AbortOnMountEvent, and AbortOnMountEventWithError. Bug: 1009894 Test: out/Default/unit_tests --gtest_filter='CrostiniManagerRestartTest.*' Change-Id: I62c4f5c1c3b4e23d7bf0113548753b6344a95569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851788Reviewed-by:
-
Alice Boxhall authored
Previously, ignored nodes created issues as we would walk up the tree looking for ParentObjectUnignored, but add all (including ignored) children. This fix works around the issue by directly adding each node as the only child of its parent node as we walk up the ancestor chain. Bug: 1011245 Change-Id: Iece13d28a81dd8c54b55ebf23dbc423503742ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839220Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::TestWindowsHandle interface. Bug: 955171 Change-Id: I9c5e191c80b6d31a20fa3d6f0648f84d532006c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833468 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#705455}
-
David Grogan authored
NG fragments don't support collapsed borders yet. This manifested with background-clip. When the position/size of the clipped background was determined, the cells' full borders were used, not half of the winning border as is correct in collapsed mode. Bug: 1008400 Change-Id: I53a80c88d854136e8d3f540fe7b8c969152aad13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858519 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c28d6f116472..b70e8a807b99 git log c28d6f116472..b70e8a807b99 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 mmortensen@google.com Begin implementing GetTargetVersions by porting code to get android Created with: gclient setdep -r src/third_party/chromite@b70e8a807b99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia5f5db98de0607c42128c85a9127e3c7079ce486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857608Reviewed-by:
-
Elly Fong-Jones authored
These dialogs all use static label text for their buttons so these are all fairly mechanical. Bug: 1011446 Change-Id: I88b2d54d7993f342678353578d90ee0ea3877093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854690Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705452}
-
tby authored
We're seeing high error rates from the Drive QuickAccess API, this adds a metric logging the error code. This CL also converts some LOG(WARNING)s into VLOG(1)s for debugging. Bug: 1011221 Change-Id: I0d0b612d85f8720f0b03cf66fe0b88973e2594c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838799 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#705451}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie1b71b050f7854ba5ab32d566319bebc537775d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859061Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::TestString16EmbeddedNulls interface. Bug: 955171 Change-Id: Ib816287c1e31095aabe3c3c1e46f84337f36c828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833601Reviewed-by:
-
Maggie Cai authored
This CL adds a method to the App Service to Launch App with Intent, and implements the method for ARC publisher. BUG=853604 Change-Id: I4f50a463bf1f5b313bc144ccd1166f1c113fa173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838782 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#705448}
-
Anand K. Mistry authored
Hunspell::suggest() is much slower than Hunspell::spell(), which results in the fuzzer running at ~1 case/sec on clusterfuzz. Splitting the fuzzer into two to test the functions separately allows spell() to be fuzzed much faster and effectively. BUG=1009087 Change-Id: I733754bcf78a84bd4448ab2e753899fea947b309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847596Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3838fe3c82b4..a7e1b45d9c28 git log 3838fe3c82b4..a7e1b45d9c28 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@a7e1b45d9c28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I84516559b49f3324b6ce76681bcd010e16461724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857609Reviewed-by:
-
Darren Shen authored
It is deprecated and no longer used. Bug: 1009903 Change-Id: I6774a4506bd0bb41a5d1a5909a40a2a781564b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833029 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#705445}
-
Alan Cutter authored
This CL is a simple refactor that moves WebAppInstallManager code for enqueuing tasks that use a WebContents into a helper method. This is in preparation for adding an update task to the queue: https://chromium-review.googlesource.com/c/chromium/src/+/1811402 Bug: 926083 Change-Id: If66cebcbefe6ce931340c8d3c149fd42c9b36168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832131 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#705444}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2f89c000483..fede5cb664d9 git log a2f89c000483..fede5cb664d9 --date=short --no-merges --format='%ad %ae %s' 2019-10-13 jmadill@chromium.org Vulkan: Remove resource destruction layer suppressions. Created with: gclient setdep -r src/third_party/angle@fede5cb664d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ida2ca1c29b898f09723534a338e8b6719835b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858604Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::TestMojoSandboxHooks interface. Bug: 955171 Change-Id: I105f2220f847fc9a51da9eb79244bd6213354497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833467Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
