GitLab

Bug: 956177
Change-Id: Icd47f45c63503a11d84bc40867eb2a0746b6b17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589908
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657718}

New histograms to record DB initialization outcome, update outcome,
number of entries loaded, etc.

Bug: 895821
Change-Id: Icc4af7ddfe194731b30ee41c10c358694676b523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592279
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657717}

Extend resampling-input-events and resampling-scroll-events flags to M80
as the work is still in progress.

Extend touch-drag-n-drap flags to M82 since it's not going to be fully
enabled in all platform yet. (Currently default enabled on ChromeOS and
Android, need work on windows)


Change-Id: I6c4db759f0313511d96b82aba74ed023b8b29894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594821Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657716}

This CL changes TabGridDialogMediator so that dialog only triggers
resets of GTS when the dialog is showing.

Bug: 960140
Change-Id: I3ab8bef8f961a3feae0782b8b898c4458b899a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598333
Commit-Queue: Yue Zhang <yuezhanggg@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657715}

Move the WebScopedVirtualTimePauser class from public/platform/ to
public/platform/scheduler.

R=haraken@chromium.org

Change-Id: I45eaa78d252f808ff1c34ec0c77499280caaacd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601034Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657714}

Parameterize the readback and synchronous cc pixel tests, and add
SkiaRenderer as an option.

These tests are currently all passing except for texture readback in
SkiaRenderer, so enable them.

Refactor LayerTreeHostSynchronousPixelTest by combining some common
code.

Bug: 948128
Change-Id: Idc238534f0d1311812a71749a31db320b0fe2dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598215Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657713}

This CL also rearranges some WPT code, in particular it moves the
"coupleIceCandidates" helper into RTCPeerConnection-helpers.js, and
changes the order of SDP application in doSignalingHandshake.

Note: This is not a complete fix to the state bug, since it turns out
that including a datachannel in the test will still cause the state
to not reach "connected".

Bug: 959128
Change-Id: Ic542c4ff99b2e3f2d2dbc171cca1be11b2b0fde5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601139Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657712}

Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/DRz-uHqPCLw/ZNDiwL0ZAwAJ

Bug: 891556
Change-Id: I3a851ca721f6ec29971e9a9ca76df1966a6b1ad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593615
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657711}

This reverts commit 696fd3af.

Reason for revert: Crashes are already captured

Original change's description:
> [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG round 4
> 
> This reverts commit 0af2a61e.
> 
> Reason for revert: Need another round of crash capturing.
> 
> Original change's description:
> > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3"
> > 
> > This reverts commit cbdaf211.
> > 
> > Reason for revert: Crash data already collected in 3763 and 3764
> > 
> > Original change's description:
> > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3
> > > 
> > > This reverts commit 33b5c673.
> > > 
> > > Reason for revert: Adding production CHECKs to collect LayoutNG failures
> > > for the 3rd time.
> > > 
> > > Original change's description:
> > > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG""
> > > > 
> > > > This reverts commit 26ca019a.
> > > > 
> > > > Reason for revert: Crash data already collected
> > > > 
> > > > Original change's description:
> > > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"
> > > > > 
> > > > > This reverts commit ec11fe81.
> > > > > 
> > > > > Reason for revert: Try to catch more crashes in the wild after
> > > > > a fix (crrev.com/c/1546713) has been landed.
> > > > > 
> > > > > Original change's description:
> > > > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"
> > > > > > 
> > > > > > This reverts commit bade42c5.
> > > > > > 
> > > > > > Reason for revert: New crashes already caught. Reverting CHECKs
> > > > > > back into DCHECKs to reduce noises.
> > > > > > 
> > > > > > Original change's description:
> > > > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG
> > > > > > > 
> > > > > > > Bug: 946004
> > > > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a
> > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305
> > > > > > > Reviewed-by: Koji Ishii <kojii@chromium.org>
> > > > > > > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > > > Cr-Commit-Position: refs/heads/master@{#644907}
> > > > > > 
> > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > > > > 
> > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: 946004
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156
> > > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#645407}
> > > > > 
> > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > > > 
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > > 
> > > > > Bug: 946004
> > > > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248
> > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#646516}
> > > > 
> > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > > 
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > 
> > > > Bug: 946004
> > > > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440
> > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#647418}
> > > 
> > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > > 
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > 
> > > Bug: 946004
> > > Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500
> > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#649773}
> > 
> > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 946004
> > Change-Id: If61d1cbfaeb6a445b8ceee193dba198978d2719c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567130
> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#650624}
> 
> TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 946004
> Change-Id: I43e61cc397ebbb44fb15f9a5bc0448077c281f60
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600400
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657538}

TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org

Change-Id: I542cc5aeaabdcbbf046a1c3b69fc5c539645e9e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 946004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600536Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657710}

Rename layered_api .js files to .mjs to fit with Google's advice here: https://developers.google.com/web/fundamentals/primers/modules -
for kv-storage, virtual-scroller, and blank. Change resource and tests files to reflect.

Bug: 938963
Change-Id: I5d08c24cbc055d3623101ba8019d84343f90c458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599191Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657709}

Now that we aren't shipping mash, this code is no longer necessary.

BUG=958135
TEST=this is purely dead code removal
TBR=tsepez@chromium.org

Change-Id: I68be857d43df73ecf67f2bb40e97b91cfc3b5ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600600
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657708}

We use feature SERVICE_MANAGER_FOR_BACKGROUND_PREFETCH to setup the experiment
for both PrefetchBackgroundTask and DownloadBackgroundTask running in the
reduced mode. Also caches the features in FeatureUtilities.

Bug: 933358
Change-Id: I5b4b01a010d9ee75e1b453a75044f1688d0b660d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590510Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657707}

Bug: 958163
Change-Id: I403d10452daf01dc3ac3b4b8f26bce25cc721533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599677Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657706}

https://skia.googlesource.com/skia.git/+log/15c91422339a..5785e4a16530


git log 15c91422339a..5785e4a16530 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 bungeman@google.com Use SkFontHinting instead of macros.


Created with:
  gclient setdep -r src/third_party/skia@5785e4a16530

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Ice3c197511cda8832a901ef851d5dd82f8b72ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601224Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657705}

https://webrtc.googlesource.com/src.git/+log/4fb12b0caec9..d8b9ed77cf52


git log 4fb12b0caec9..d8b9ed77cf52 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 nisse@webrtc.org Promote RtcEventLogOutputFile to api/
2019-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db92e075..8939017d (656805:657653)
2019-05-08 mbonadei@webrtc.org Do not use absl::flat_hash_map in DefaultVideoQualityAnalyzer.
2019-05-08 eladalon@webrtc.org Fix typo in SupportsEncoderFrameDropping's documentation
2019-05-08 jakobi@webrtc.org Add lifetime concealment stats to NetEqStatsPlotter.
2019-05-08 eladalon@webrtc.org Rename "average_freeze_duration" metric to "freeze_duration_average"
2019-05-08 eladalon@webrtc.org Add missing overrides to QualityTestVideoEncoder
2019-05-08 eladalon@webrtc.org Fix comment over Vp8FrameBufferController::SupportsEncoderFrameDropping
2019-05-08 jsphchn@google.com Add support for ignoring errors encountered while configuring preferred attributes of an audio session.
2019-05-08 nisse@webrtc.org Move some RTP-related observers from common_types.h
2019-05-07 eladalon@webrtc.org Add metrics related to video freezes to VideoAnalyzer
2019-05-07 sprang@webrtc.org Remove packets from RtpPacketHistory if acked via TransportFeedback
2019-05-07 mbonadei@webrtc.org Do not run CheckNoStreamUsageIsAdded on tests.
2019-05-07 mbonadei@webrtc.org DefaultAudioQualityAnalyzer: use bytes_recv instead of packets_recv.
2019-05-07 nisse@webrtc.org Log transport feedback max interval
2019-05-07 titovartem@webrtc.org Add support of specifying concrete codec for video stream
2019-05-07 nisse@webrtc.org Move RtcpPacketTypeCounter and observer to rtcp_statistics.h
2019-05-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2345bf12..db92e075 (656700:656805)
2019-05-06 andersc@webrtc.org Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper.
2019-05-06 asapersson@webrtc.org Add ability to configure quality scaler settings through field trial.
2019-05-06 ilnik@webrtc.org Don't invalidate whole update_rect if buffer conversion didn't change any pixels
2019-05-06 nisse@webrtc.org Add FILE* constructors to RtcEventLogOutputFile
2019-05-06 nisse@webrtc.org Delete windows-specific stop flag in PlatformThread
2019-05-06 mbonadei@webrtc.org Reland "Add Video Bwe stats collection to DefaultVideoQualityAnalyzer."
2019-05-05 hta@webrtc.org Revert "Version 2 "Refactoring DataContentDescription class""
2019-05-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ba5acd25..2345bf12 (656600:656700)
2019-05-05 hta@webrtc.org Version 2 "Refactoring DataContentDescription class"
2019-05-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0225b2f9..ba5acd25 (656458:656600)
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b9ad721a..0225b2f9 (656347:656458)
2019-05-03 sprang@webrtc.org RtpPacketHistory: StoreAndCull default on, support ack removals
2019-05-03 peah@webrtc.org Remove deprecated call to UpdateHistogramsOnCallEnd
2019-05-03 peah@webrtc.org Remove the enable flag from AEC2 and AECM
2019-05-03 dklee@google.com Ensure that we always set values for min and max audio bitrate.
2019-05-03 srte@webrtc.org Don't require call to ValidateFieldTrialsStringOrDie for ScopedFieldTrials.
2019-05-03 andersc@webrtc.org Add priority to RTCRtpEncodingParameters.
2019-05-03 perkj@webrtc.org Provide AlrDetector with event log in GoogCC.
2019-05-03 srte@webrtc.org Allows injection of network controller factory in test fixture.
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e821123c..b9ad721a (656244:656347)
2019-05-03 ilnik@webrtc.org Remove deprecated interface in I420BufferInterface::GetI420
2019-05-03 henrik.lundin@webrtc.org NetEq: Minor change to print-out format for interruption stats
2019-05-03 ivoc@webrtc.org Expose new audio stats on the API
2019-05-03 srte@webrtc.org Adds debug printing of network estimate.
2019-05-03 srte@webrtc.org Avoids mismatching packets on wraparound in log parser.
2019-05-03 eladalon@webrtc.org Rename configurations_ to vpx_configs_ in LibvpxVp8Encoder
2019-05-03 eladalon@webrtc.org Refactor handling of configuration overrides from Vp8FrameBufferController
2019-05-03 peah@webrtc.org Remove the reporting of histogram data for AEC2
2019-05-03 nisse@webrtc.org Delete deprecated PlatformThread looping
2019-05-03 julien.isorce@chromium.org Check nullity of CGColorSpaceCopyICCProfile's return value
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ea179c51..e821123c (656127:656244)
2019-05-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b510663a..ea179c51 (655963:656127)
2019-05-02 srte@webrtc.org Reland "Reland "Improving robustness of feedback matching code in event log parser.""


Created with:
  gclient setdep -r src/third_party/webrtc@d8b9ed77cf52

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:930186,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:None,chromium:945468,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ica294935dc913db249608b61b0c6f4e04b5b0cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601223Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657704}

Bug: 941690
Change-Id: Ic05861d2d813a4104957e0bd355c9e8dcd20f7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596322Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657703}

UnescapeBinaryURLComponent() unconditionally escapes all escaped
characters. It was using UnescapeURLComponent(), which leaves
"%00" though "%1F" escaped, as well as certain UTF-8 characters that
aren't safe to display in the omnibox. Since a GURL is constructed
with the result, it will re-escape all these characters, anyways,
with the exception of when these characters appear at the end of a
URL, in which case GURL will truncate them. Since GURL does this for
spaces, too, and this wasn't a problem before, presumably it's fine
for these more obscure characters, too. The UTF-8 characters that
aren't safe to unescape for display in the omnibox are still valid
UTF-8 characters, and it doesn't make sense to keep them escaped when
they're not for display to the user.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave additional weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I6c086765c77d68cb4f164ba7891737fb08925462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592807
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657702}

Lack thereof caused a compile failure:
  https://ci.chromium.org/p/chromium/builders/ci/win-rel/15603

Bug: 960460
Tbr: rdevlin.cronin@chromium.org
No-Tree-Checks: true
No-Try: true
Change-Id: I122bbabdc2590c4a06b0330ca1aa080e75a295f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600837Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657701}

This reverts commit 255dca91.

Reason for revert: Still breaks pixel2 bots, now due to aapt2 error loading libc++.so.


Original change's description:
> Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab."
> 
> This is a reland of e3d9c6d3
> 
> Original change's description:
> > [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab.
> >
> > This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit
> > browser. In making this change a new 'exact_browser' option is added to
> > tester_config in perf_data_generator to allow specifying a particular binary to
> > be run rather than guessing.
> >
> > Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1511455
> >
> > TBR=crouleau@chromium.org,perezju@chromium.org
> > BUG=934251
> >
> > Change-Id: I21bf7ae8e42f0e4c127748eeecc58a8af34334a1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587563
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> > Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#654862}
> 
> TBR=crouleau@chromium.org
> TBR=perezju@chromium.org
> 
> Bug: 934251
> Change-Id: I18a8dcb554f52ddff6e1b39d02566faff67c68a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599614
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657640}

TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org

Change-Id: Idfef7d330bb25e965c5c834b5d4b58ed68eba238
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601040Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657700}

It has been using UnescapeURLComponent() instead to unescape file names.
UnescapeURLComponent() leaves various UTF-8 characters that are unsafe
to display in the omnibox, but valid in other contexts escaped, as well
as "%00" through "%1F". In addition, it was being told to keep path
separators escaped. The UTF-8 logic was unnecessary here, and it's
better to fail on unexpected input rather than to partially unescape
it. Switching to UnescapeBinaryURLComponentSafe() gets us both of
these behaviors.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I009667ec4ccf92e49810ece56d5e2f8e9604a096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598321
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657699}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bde98f63..c562f4de

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia1aed0e84f713f90a0f4bdecc607805adea46e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601116Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657698}

1. Change proto package name to viz.proto.
2. Move FuzzedCompositorFrameBuilder into source file and just expose a
   helper function.
3. Update a few comments.

Bug: 923088
Change-Id: I42a57d223c5206f17c77088bb1e256be37b89f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596834Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657697}

- Emit trace event when the time is unpaused when Pauser is destroyed.
- Randomise trace_id to avoid collisions with other events.

R=alexclarke@chromium.org
TBR=haraken@chromium.org

Change-Id: I7492cf1975dc6735dda143b981943b73d2f65b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601033Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657696}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f21a6e5b1ab..746bb12c4652


Created with:
  gclient setdep -r src-internal@746bb12c4652

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org

Change-Id: Icd705981ede418b5cfde739c11adb17975f17a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601222Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657695}

As the visual left/right caret movement has become un-maintainable,
this patch removes them and replaces them by logical movement.

This patch:
- Exposes line direction utilities from inline_box_traversal.cc to be
  reused by SelectionModifier. These utilities will be moved/refactored
  later for better code structure.
- Changes SelectionModifier to use logical left/right movements for
  character and word granularities.

All other changes are removal of dead code and test expectations
changes.

Bug: 958831
Change-Id: Ic4cf83290beb2521c620167be32b4fa4d716a3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593632
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657694}

Use BackgroundTaskScheduler for Background Sync everywhere by default.

Status of ramp up:
Currently this feature is enabled at 1% on stable.

Next steps:
1. After this CL is merged, I'll enable it at 100% everywhere via Finch.
2. I'll remove the field trial test config.
3. Remove the feature flag and all code that checks for it + now dead code.

Bug: 924490
Change-Id: Ia4578e283997da0b716ddbfef72222105ec2285f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599528Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657693}

Before this CL:
When the account that Sync uses switches from being secondary to being
primary (i.e. the user opts in to full Sync), then SyncAuthManager
exposes that as a sign-out + sign-in to its client (ProfileSyncService).

After this CL:
In this situation, SyncAuthManager just sends a single
AccountStateChanged notification, and ProfileSyncService handles this
case appropriately by reconfiguring itself.

This seems like it'd be a rare edge case, but it can happen during the
regular Sync setup flow: The account becomes available (i.e. has a valid
refresh token) before it is marked as primary. The consequence was that
Sync would begin to start up (in transport mode), but then immediately
get shut down, just to start up again. One concrete outcome was that
two cache GUIDs got generated, which could muddle up metrics.
After this CL, Sync does not get shut down in between, but just gets
reconfigured.

Bug: 956478
Change-Id: If8396f604fc1430c81b5a86d3f684252cb3f4c2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598805Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657692}

This change relands
chromium-review.googlesource.com/c/chromium/src/+/1595219 but with a fix
for the Win7 test failure. The only difference between this CL and the
original CL is the edits to delayloads_unittests.cc.

This change is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1551709. It
removes the chrome_elf_imports_unittests executable and combines the
tests with the similar tests in the more generic delayloads_unittests
executable. It also adds delayloads_unittests to the pipeline for
execution.

Bug: 948829
Change-Id: I9713d51f6393c5e134607644672d616a5ea30993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597222Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657691}

Want to use this for official builds.

Bug: 960197
Change-Id: I07e16c1caf375742d4951c315f1c20a2dc38b711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601294
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657690}

- DCHECK -> CHECK in Bus::AssertOnOriginThread/DBusThread to
  enable thread assertion in release build;
- Add warning log if Bus::SendWithReplyAndBlock takes more
  than 1 seconds;

Bug: 883029
Change-Id: Id630ed56e82a24c88c96820cfc36f5b36c72dd00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594064Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657689}

The motivation is that some projects (e.g. v8) deps in a git mirror of the
build/ directory but don't have tools/win available. This makes the build/
directory not depend on tools/win again.

Bug: 960658
Change-Id: Ibaa9a81862e89ea049299149a5d9aa7e7c4b5850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600776
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657688}

Speculative fix for histogram recording - int values are not registering
in UMA.  Maybe avoiding the converstion to long will fix.

BUG=960613

Change-Id: Ia639c3a4b16091af6c82c007bfde97ae7653e5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600640
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657687}

This reverts commit dc16c8dc.

Reason for revert: Fails on regular ASAN builds because all unreachable objects are poisoned directly after marking.

Original change's description:
> timer: Specialize TaskRunnerTimer for GCed classes
> 
> This allows us getting rid of WillObjectBeLazilySwept which peeks into
> garbage collection internal state.
> 
> Change-Id: I82b38def090c33f1b6e6727ab4b685abb0409ea1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598826
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657650}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: I38047dc29ca14158aa891d99c15e218c1fdb7570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599623Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657686}

This reverts commit b4d80c99.

Reason for revert: Pursuing alternate strategy of preserving base::MD5 interface, but replacing its implementation with boringssl.

Original change's description:
> Replace base MD5 impl with boringssl in //net
> 
> This CL also makes several IWYU changes outside of //net. After making the
> changes in //net, these missing includes became compilation errors.
> 
> Bug: 755368
> 
> Change-Id: Ieb18e0ab0dd4478f9ce8285f45ecee21a9c84e0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570525
> Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
> Reviewed-by: Nathan Parker <nparker@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
> Auto-Submit: Daniel McArdle <dmcardle@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656167}

TBR=rsleevi@chromium.org,thakis@chromium.org,peter@chromium.org,sammc@chromium.org,nparker@chromium.org,olivierrobin@chromium.org,dmcardle@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 755368
Change-Id: I1486c246381b67052e85c1fbb2d81309b919526c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601193Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657685}

This CL makes VASurface's ReleaseCB |release_cb_| a OnceCallback,
since it doesn't make any sense that a release callback can be
called repeatedly.

Callsites use BindOnce() to bind to a RepeatingCallback for
conveniency, since |va_surface_release_cb_| is bound once on
the main thread with a WeakPtr.

Test: chrome plays video on nocturne, v_d_a_unittests on the same.
Bug: 822346
Change-Id: I7f0bb1658981f89b5b3a7d2bae388cec4b99efd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598496Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657684}

Since users can type arbitrary strings, these lines are reachable and must be
handled.  For now, handle as they were already, e.g. by returning zero.  We may
later decide to do something else, e.g. return nullopt.

This also adds better range-checking, so that e.g. "257" entered for an int8_t
does not become "1".

Bug: none
Change-Id: I4a0185f921c3f40f38439798c52de0ce92f3be30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600650
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657683}

TBR: thestig@chromium.org
Change-Id: I678bae3ca64bde9c8628a44997e507f506a5a140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601295
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657682}

The current approach is quite confusing and inconsistent. The value
nullptr means too many different things, depending on the situation.

This CL introduces a new, hopefully clearer model, where nullptr always
means invalid at computed-value-time, and base::nullopt means "no entry
found". This means that, if a ComputedStyle has a present entry of
'nullptr' for a given custom property, we do not e.g. fall back to
values from StyleInitialData.

However, if there is no entry (base::nullopt), we look up values from the
root-bucket (see StyleInheritedVariables), and/or StyleInitialData.

A consequence of this approach, is that explicitly applied initial and
inherited values must actually be present on the ComputedStyle; we can not
return to a state of base::nullopt. This is because of the root-bucket
optimization of StyleInheritedVariables, which makes it impossible to
actually erase a value in all cases. (We actually don't have the same
restriction for StyleNonInheritedVariables, but the behavior is the same,
for simplicity).

Another change in this CL, is that StyleInitialData now has the initial
"data" as well as the initial "values". This is again to avoid that
nullptr has different meanings. If we didn't store the initial data,
we could end up with a nullptr for registered properties with an
implicitly initial value. This is incompatible with the "nullptr means
nullptr" idea.

Note that CSSInvalidVariableValue isn't technically needed anymore after
this CL, but since it's going to be useful for the Cascade project (during
the application phase only, not as a persistently stored object), I'd like
to keep it. It has a unit tests, so it's not completely unused.

BUG=947004
R=futhark@chromium.org

Change-Id: I4922f0d36f3d3d4fde6a25e56ef5c14c0c9890f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601135Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657681}

Bug: None
Change-Id: Ie7b3b5a4c7c2649d7bd0c4916ce2696abc0cc70d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595452
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657680}

https://android.googlesource.com/platform/external/perfetto.git/+log/c2849eabed44..254a80307c6e


git log c2849eabed44..254a80307c6e --date=short --no-merges --format='%ad %ae %s'
2019-05-08 lalitm@google.com metrics: fix reading uninitialized memory in metrics platform
2019-05-08 lalitm@google.com Merge "trace_processor: add metrics test infra"


Created with:
  gclient setdep -r src/third_party/perfetto@254a80307c6e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I63360d9a0206bd50db93d962c7cf44a9c69e05ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657679}