- 05 Jun, 2018 40 commits
-
-
Xi Cheng authored
Change-Id: I32519c87031058bb49b0ab005e4f8128d9502200 Reviewed-on: https://chromium-review.googlesource.com/1087590Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#564664}
-
Bernhard Bauer authored
Change-Id: Ie3482a4bce615ea70392f4722132cbcd0ded77bf Reviewed-on: https://chromium-review.googlesource.com/1087058Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564663}
-
Xiaohan Wang authored
This is useful for logging. Bug: 846793 Change-Id: I8982b3cffae0fa51900a745766e0351492ad2e76 Reviewed-on: https://chromium-review.googlesource.com/1085558Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564662}
-
lgcheng authored
Show notification about usage & diagnostics during ARC setup if the user does not see the ARC ToS dialog due to all relevant settings being managed, and usage & diagnostics is enabled for the device. Bug: b/73338614 Test: Unit test added Test: Manual Change-Id: Ia27b2d1864a3be47b2dcfeb662aa2d72106f80c8 Reviewed-on: https://chromium-review.googlesource.com/1086354Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#564661}
-
Aaron Leventhal authored
Bug: None Change-Id: I97010e6898ca9e7dd48f6cdc4a43460db850bc5d Reviewed-on: https://chromium-review.googlesource.com/1078915 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#564660}
-
Findit authored
This reverts commit 7acb4716. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 564609 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdhY2I0NzE2ODA4ZjMwM2M3YzhiYWZjNzYyZjFmY2RhNzY5YTMzYmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/27041 Sample Failed Step: device_unittests on Mac-10.11 Original change's description: > device/fido/mac: encrypt credential metadata in the macOS keychain > > This adds a CredentialMetadata class to encrypt any account metadata > associated with a WebAuthn credential (user ID, user name, user display > name, and RP ID) before writing it to the macOS keychain. > > The key will be generated and stored in the Chrome profile under which > the credential was created. (It is currently hardcoded but I'm changing > that in a follow-up CL.) Deletion of the profile or key will therefore > render the data unreadable. > > Bug: 678128 > Change-Id: I536d537e9220cc5f89d487c7f94e169d06d62e7a > Reviewed-on: https://chromium-review.googlesource.com/1073708 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#564609} Change-Id: I24c8937ae0855ce542e16f0fa9f21ca159d51abe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678128 Reviewed-on: https://chromium-review.googlesource.com/1087613 Cr-Commit-Position: refs/heads/master@{#564659}
-
Scott Violet authored
We had accumulated quite a few test AcceleratorTarget implementations. This patch adds one to ui/base:test_support and converts usage. BUG=848883 TEST=test only changes Change-Id: Icb543f1f0c20a9341510362493683f7eeed1b485 Reviewed-on: https://chromium-review.googlesource.com/1087534 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#564658}
-
Bernhard Bauer authored
This allows removing special cases for CH, particularly in the content suggestions code. Bug: 805070, 847420 Change-Id: I69db669f85564e10e4452cec8bb7dcf75773f283 Reviewed-on: https://chromium-review.googlesource.com/1087048 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564657}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5352ad7..1659e97 git log 5352ad7..1659e97 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 sakal@webrtc.org Use DecimalFormat instead of String.format. 2018-06-05 peterhanspers@webrtc.org Support cropping and rotation override in Metal renderers. 2018-06-05 magjed@webrtc.org Android: Remove deprecated CapturerObserver methods 2018-06-05 ilnik@webrtc.org Cleanup webrtc:: namespace from leaked TimingFrameFlags Created with: gclient setdep -r src/third_party/webrtc@1659e97 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:b/80240768 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I681963bf4943ffdf1428a80175af3e03ad299d27 Reviewed-on: https://chromium-review.googlesource.com/1087300Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564656}
-
Min Qin authored
Windows seem to have a poor sparse file support. The test took about 180 seconds to pass, and sometimes it times out. BUG=846276 Change-Id: I9899c6025e938f38e5079f4ef6da53fcffa1709d Reviewed-on: https://chromium-review.googlesource.com/1087591 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#564655}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c53433e..8bc3398 git log c53433e..8bc3398 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 vapier@chromium.org lint_unittest: refactor assert helper to make checking easier 2018-06-05 dgarrett@chromium.org Reland "chromeos_config: Move zoombini-release to swarming." 2018-06-05 dgarrett@google.com scheduler_stages: Correctly test for swarming slave. Created with: gclient setdep -r src/third_party/chromite@8bc3398 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:834076,chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic83da17e578ec3206a22b73b08d1a81bcd6ae310 Reviewed-on: https://chromium-review.googlesource.com/1087391Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564654}
-
Nico Weber authored
Also run non_android_and_cast_and_chromeos_chromium_gtests on the mac clang bots, it was missing unintentinoally. Effectively adds battor_agent_unittests to the memory waterfall and to the clang tot bots, and adds snapshot_unittests to the mac clang tot bots. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511,843729 Change-Id: I83fe8723e3634c516a378fb76d8b02ac6a2fab4f Reviewed-on: https://chromium-review.googlesource.com/1087574Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564653}
-
Eugene But authored
Placeholder URLs are also used for WebErrorPages features, so this CL ignores placeholder URLs in decidePolicy callbacks if WebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54fb0a5e6dd692d741db4bac298f760165d276f7 Reviewed-on: https://chromium-review.googlesource.com/1087364Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564652}
-
Nick Harper authored
TBR=estark@chromium.org Change-Id: I9a42c6925763fbb36997aae5929a2ed256e4ccdb Reviewed-on: https://chromium-review.googlesource.com/1087544Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#564651}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4c1bea2..591c140 git log 4c1bea2..591c140 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dtu@chromium.org [pinpoint] Show results2 in an iframe on the Job page. Created with: gclient setdep -r src/third_party/catapult@591c140 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I49b376afc7eaafff41e9ac4aac4531cf4a056b5e Reviewed-on: https://chromium-review.googlesource.com/1087549Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564650}
-
Jacob Dufault authored
A child class (ie, LoginPinView) may override OnEvent and not OnMouseEvent. The default OnEvent implementation dispatches to OnMouseEvent so existing uses should remain the same, at the cost of an additional function call. Bug: 848018 Change-Id: I20ce712ceadeeda8738eb83d450d9390daedf949 Reviewed-on: https://chromium-review.googlesource.com/1079890Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#564649}
-
Nick Harper authored
TBR=estark@chromium.org Change-Id: Iaf24e51b0fc806219d7d0b54719bf32505e2e6f2 Reviewed-on: https://chromium-review.googlesource.com/1087533 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#564648}
-
Xiaocheng Hu authored
The layout tests has a big test() function holding a set of independent test cases, each with a single assert() statement. This patch breaks the big test() into one test() for each test case to improve coding style, and also makes the output more informative when the tests fails. Change-Id: I11d1032b8af0335bdedcee456fdaaf5abcacba5c Reviewed-on: https://chromium-review.googlesource.com/1087628 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#564647}
-
Scott Violet authored
There are a couple of issues addressed here: . kFocusable_InitProperty was not wired up correctly. . Ash created top-levels were not picking up the value set by clients To fix these I'm adding kCanFocus. ws2 sets this from calls by clients to WindowTree::SetCanFocus(). Ash uses this property as well if the client supplies kFocusable_InitProperty. I think kFocusable_InitProperty should go away. That'll be easier once we get rid of --mash. I'm also forking the TopLevelWindowFactory tests. I moved the existing ones into TopLevelWindowFactoryMash (these only run with --mash). I also made the tests work in classic mode with ws2. I added a new file for this that is built in ash_unittests. BUG=842301 TEST=covered by tests Change-Id: I016ed612e7ab1d7bc1cdc4840c3aa9271078ab9e Reviewed-on: https://chromium-review.googlesource.com/1086151 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564646}
-
Ryan Sturm authored
This test suite now handles requests instead of looking at connections and tracks the count of requests based on a specific URL pattern. The first test will pass when no image requests have been loaded, so if for some reason 20 round trips to the renderer do not gaurantee the request is seen on the net/ stack, the test will still pass. The second test creates an image request while the page is paused, and upon unpausing the page, waits for the image request to be seen in the embedded test server. The third test loads the image in the same pattern as the second without ever pausing the page. Bug: 848675 Change-Id: I5a72cf1765b583bdb83ade2046366c12d6d70613 Reviewed-on: https://chromium-review.googlesource.com/1086125 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#564645}
-
Sean Topping authored
By default, this should just propagate visibility information to the delegate. In the future, NotifyVisibilityChange should only be called by the window manager. Documentation for CastContentWindow was improved as a minor clean up. Bug: internal b/79874784 Test: CQ Change-Id: I3eab9b60b74037cd1f122e03460d0b8fe6db00c0 Reviewed-on: https://chromium-review.googlesource.com/1086042 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564644}
-
Lakshmi Kumar Dabbiru authored
Enable Upstream GPay branding Config file change at https://critique.corp.google.com/#review/198897909 Change-Id: I44bb9d7ef8e7bdc590dddd5b902bb0b970ada5da Reviewed-on: https://chromium-review.googlesource.com/1087542Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#564643}
-
Sadrul Habib Chowdhury authored
The four terminal components are set in various places, but they are are never actually consumed or processed for anything. These components are removed, and replaced instead with a LatencyInfo::Terminate() method to mark the termination. Removed components: INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT This also renames INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT to just INPUT_EVENT_LATENCY_FRAME_SWAP_COMPONENT. BUG=849686 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If2fb7941c299393e77d8909e3681c6292e5c0e74 Reviewed-on: https://chromium-review.googlesource.com/1087292 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#564642}
-
rbpotter authored
- Set pixels and points to different values, to improve existing test. - Test setting the margins via both dragging and textbox. - Test that setting the settings (e.g. from sticky settings) updates the controls. Bug: 773928 Change-Id: I17daf6705b6dd66cbec68577c979fa5182176288 Reviewed-on: https://chromium-review.googlesource.com/1083888Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#564641}
-
Justin Novosad authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I773e98e6906c6c1f5a9add6274e3891510d8b9a5 Reviewed-on: https://chromium-review.googlesource.com/1087353 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564640}
-
Xianzhu Wang authored
Now use "const LayoutTableSection* repeating_table_section" instead of "bool is_repeating_table_section" so that we can know which table section is actually repeating and avoid an inner thead not in repeating context (while can repeat) is treated as the repeating section. We still don't support nested repeating table sections (that is, repeating table section under another repeating table section, not the cases in fragmentation/nested*.html which are about repeating table sections in nested tables under non-repeating table section of another table). Filed crbug.com/849459 for it. Bug: 849029 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib0b921a95dc0257cbe11577edef8d1d77071db16 Reviewed-on: https://chromium-review.googlesource.com/1086285 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564639}
-
Jian Li authored
This is to avoid potential data race issues in tests. Bug: 836442,837104 Change-Id: Ic46e2834e1a50fa3644e6fe5ec0d4ef874e0b0a0 Reviewed-on: https://chromium-review.googlesource.com/1086156Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564638}
-
Mark Pearson authored
Change-Id: I7e6e474a0962b56fe044691b5de2869ab334b766 Reviewed-on: https://chromium-review.googlesource.com/1065070 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564637}
-
Morten Stenshorne authored
The legacy layout engine has a bug that's not present in LayoutNG, making it impossible for LayoutNG to pass fast/text-autosizing/clusters-insufficient-text.html . The bug: If a new formatting context in-flow block-level object gets pushed down by a float, strange things happen in legacy layout if this object is a writing mode root. Rather than using the initial containing block as guidance for its inline size, it behaves as if inline-size were set to min-content. So just specify height (inline-size) as min-content in the test, to get identical behavior in the legacy engine and LayoutNG. Bug: 848874 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5928318f17ad3105350bd38d3b81cbe5c35819d0 Reviewed-on: https://chromium-review.googlesource.com/1086996Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564636}
-
Ryan Landay authored
The new Android horizontal tab switcher currently focuses on the previous tab when it's opened. We implemented this behavior because we thought the most common action in the tab switcher is to switch to an earlier tab. However, user metrics suggest that it's actually more common to switch to a later tab, the most common action is actually to close the current tab. Additionally, we received qualitative user feedback that this behavior feels annoying. This CL removes this behavior so the horizontal tab switcher will now focus on the current tab. Bug: 831359,849480 Change-Id: Id77c422f51005b39a135a6682c75b3a7ab3dce24 Reviewed-on: https://chromium-review.googlesource.com/1085632 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564635}
-
Francois Doray authored
With this CL, TabLifecycleUnit::CanFreeze() returns false if the tab is already frozen. This is important because calling Freeze() on a TabLifeycleUnit that is already FROZEN causes a transition to PENDING_FREEZE, and because the page is already frozen from the renderer point of view, there is no transition back to FROZEN. Bug: 775644 Change-Id: I216310e83605374f6708ef182dd2b9bf4f531494 Reviewed-on: https://chromium-review.googlesource.com/1085995 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#564634}
-
Mohamed Amir Yosef authored
Instead of using a custom BookmarkModelTypeController, use the generic ModelTypeController. This work has been unblocked by fixing the bug crbug.com/819993 Bug: 516866 Change-Id: I57eab3fba8a40cd7158de7fedb4326ef32f44db7 Reviewed-on: https://chromium-review.googlesource.com/1087450 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564633}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d47dffd..d566165 Created with: gclient setdep -r src-internal@d566165 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:784511 TBR=mmoss@chromium.org Change-Id: If656010c171244e05236e5f9f0082f4dbcc22533 Reviewed-on: https://chromium-review.googlesource.com/1087609Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564632}
-
Manuel Rego Casasnovas authored
Text from the spec (https://drafts.csswg.org/css-contain/#containment-layout): "... if the element is an internal table element other than display: table-cell, or if the element is an internal ruby element, or if the element’s principal box is a non-atomic inline-level box, layout containment has no effect." The patch disables "contain: layout" for internal table elements but table cells, internal ruby elements and non-atomic inline-level boxes. Some of the new tests pass or fail incidentally due to crbug.com/785212, once that's fixed all the tests should be working as expected. BUG=843329 TEST=external/wpt/css/css-contain/contain-layout-008.html TEST=external/wpt/css/css-contain/contain-layout-009.html TEST=external/wpt/css/css-contain/contain-layout-010.html TEST=external/wpt/css/css-contain/contain-layout-011.html TEST=external/wpt/css/css-contain/contain-layout-012.html TEST=external/wpt/css/css-contain/contain-layout-013.html TEST=external/wpt/css/css-contain/contain-layout-014.html Change-Id: I5f0893a9ce69dc8e76cf16acb1b8556bf0e02adf Reviewed-on: https://chromium-review.googlesource.com/1087268Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#564631}
-
Raymond Toy authored
This is a reland of 325b492f Initialize tail_time_ in constructor so we don't have uninitialized variable. Original change's description: > WaveShaper must output non-zero values even if input is silent > > If the curve for the WaveShaperNode is such that a zero input produces > a non-zero output, the WaveShaperNode needs to output that value even > if the input is silent (or disconnected). > > Do this by setting the tail time of the processor to 0 or infinity > depending on whether the curve specifies an output value of zero or > not, respectively. > > Bug: 807301 > Test: WaveShaper/silent-inputs.html > Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b > Reviewed-on: https://chromium-review.googlesource.com/896266 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564186} Bug: 807301 Change-Id: I866c5b303b40c1245d86daf43c592eed39d6a9c9 Reviewed-on: https://chromium-review.googlesource.com/1087427Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564630}
-
Aleks Totic authored
We were not updating margins correctly inside NGBlockNode::RunOldLayout. Symptom was that BODY(flex) block size was too big when HTML had margins inside quirks mode. Another side effect of this fix is two crashes have gone away. Added explicit test case for BODY(flex) in quirks mode. Bug: 849490 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd Reviewed-on: https://chromium-review.googlesource.com/1086381 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564629}
-
Jonathan Backer authored
Fixes an issue that the fuzzer found. Bug: 849664 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1180b9d0eced6709b1a3245c2f96deca123a71b3 Reviewed-on: https://chromium-review.googlesource.com/1087530 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#564628}
-
Michael Warres authored
Modify framer to build frames with IETF frame type values in version 99. Merge internal change: 198057262 https://chromium-review.googlesource.com/c/chromium/src/+/1086588 Expose PCC's DebugState in TransportState trace Merge internal change: 198054448 https://chromium-review.googlesource.com/c/chromium/src/+/1086587 Make toy client to log socket recv buffer overflow whenever more packets are lost. Merge internal change: 198050613 https://chromium-review.googlesource.com/c/chromium/src/+/1086452 Remove QuicStreamSequencerBuffer::Gap Merge internal change: 198028095 https://chromium-review.googlesource.com/c/chromium/src/+/1086451 Remove PCC special case in send_algorithm_test.cc. Merge internal change: 197613391 https://chromium-review.googlesource.com/c/chromium/src/+/1086136 Add IETF Ack Framer/deframer to QUIC Version 99 Merge internal change: 197586715 https://chromium-review.googlesource.com/c/chromium/src/+/1086133 More Transport Parameters in QUIC; protected by --quic_supports_tls_handshake Merge internal change: 197484241 https://chromium-review.googlesource.com/c/chromium/src/+/1086130 Deprecate FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data. Merge internal change: 197422127 https://chromium-review.googlesource.com/c/chromium/src/+/1085861 Deprecate FLAGS_quic_reloadable_flag_quic_fast_is_disjoint. Merge internal change: 197422019 https://chromium-review.googlesource.com/c/chromium/src/+/1085858 Add QUIC v44 which will use IETF header format. Protected by normal flag --quic_enable_version_44. Merge internal change: 197199677 https://chromium-review.googlesource.com/c/chromium/src/+/1085856 Add EpollCallbackInterface::Name() method, to aid debugging. Merge internal change: 196864754 https://chromium-review.googlesource.com/c/chromium/src/+/1083718 Add source_connection_id and source_connection_id_length to QuicPacketHeader, and default them to 0 and 0-byte, respectively. Also add them to all related functions. Merge internal change: 196734148 https://chromium-review.googlesource.com/c/chromium/src/+/1083631 Send and receive Transport Parameters extension in TLS for QUIC Merge internal change: 196720679 https://chromium-review.googlesource.com/c/chromium/src/+/1083431 Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_42_2. Merge internal change: 196716890 https://chromium-review.googlesource.com/c/chromium/src/+/1082822 Deprecate FLAGS_quic_reloadable_flag_quic_register_static_streams. Merge internal change: 196711027 https://chromium-review.googlesource.com/c/chromium/src/+/1083231 In GFE, make QUIC be able to offload pacing to USPS when possible. Protected by quic_restart_flag_quic_offload_pacing_to_usps. Merge internal change: 196706015 https://chromium-review.googlesource.com/c/chromium/src/+/1083092 Send an ACK in 1ms if no packets have been received in an SRTT. Enabled when the connection option ACKQ is supplied and protected by FLAGS_quic_reloadable_flag_quic_fast_ack_after_quiescence. Merge internal change: 196698436 https://chromium-review.googlesource.com/c/chromium/src/+/1082716 PSK integration for Quartc. Merge internal change: 196680315 https://chromium-review.googlesource.com/c/chromium/src/+/1082815 Use IETF QUIC STREAM frame format for Version 99. Merge internal change: 196653181 https://chromium-review.googlesource.com/c/chromium/src/+/1082814 Deprecate FLAGS_quic_reloadable_flag_quic_is_write_blocked. Merge internal change: 196600942 https://chromium-review.googlesource.com/c/chromium/src/+/1077448 Modify PacketDroppingTestWriter not to drop more than 3 packets in a row. Merge internal change: 196569604 https://chromium-review.googlesource.com/c/chromium/src/+/1076449 Deflake EndToEndTestWithTls.ServerSendPublicReset. Merge internal change: 196562935 https://chromium-review.googlesource.com/c/chromium/src/+/1077227 Rename connection_id and connection_id_length in QuicPacketHeader to destination connection_id and destination_connection_id_length, respectively. Merge internal change: 196548721 https://chromium-review.googlesource.com/c/chromium/src/+/1077055 R=zhongyi@chromium.org Change-Id: I09c984a5089bdda8a4c101863f5ac7e30dd33b04 Reviewed-on: https://chromium-review.googlesource.com/1086597Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Michael Warres <mpw@chromium.org> Cr-Commit-Position: refs/heads/master@{#564627}
-
Siddhartha authored
Bug: 845717 Change-Id: I744a2376340082abf10db5d208397b3a0a2657d8 Reviewed-on: https://chromium-review.googlesource.com/1086293Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#564626}
-
Jonathan Backer authored
We don't support it on all code paths and it's not used by CC for raster. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iad7cf9d3bdb7131065a11bc2f6314165a45cab25 Reviewed-on: https://chromium-review.googlesource.com/1087041 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#564625}
-