- 16 Oct, 2020 40 commits
-
-
Adam Langley authored
onDestroy is called some time after an Activity is dismissed (i.e. "stopped") in Android terms. But I think caBLE operations should be suspended immediately when the Activity is dismissed. BUG=1002262 Change-Id: Idcc09daa17cd2ad691bd26a24c3f4af1ea1a1a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477518Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#817979}
-
Fredrik Söderqvist authored
This makes sure that the requests for the cursor resources has been issued before the following loadImages(...) call. Bug: 1137716, 1138589 Change-Id: I691360327c0d4f70f8eb50fdae224ab53dcc6111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479523 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#817978}
-
Aaron Krajeski authored
It used to be the case that all small canvases were rendered in software. This was changed to improve performance, simplify code and improve testing. Unfortunately it caused a ton of crashes for webview devices. crbug.com/994310 A kludge was introduced to prevent these crashes for webview devices only: https://chromium-review.googlesource.com/c/chromium/src/+/1800346 Now that more than a year has gone by and there's been a lot of movement in all the relevant codebases (skia, webview, canvas, oop-r, etc.) it's worth seeing if this spike in crashes still happens. To remove this kludge would allow us to finally clear up the code path and greatly simplify testing. Bug: 1136603 Change-Id: Idca3844ee13f064adf8043ebcdc43808c6588f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463328 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db0288d747ae..7db7139f4032 2020-10-16 bsalomon@google.com Revert "Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage."" 2020-10-16 tdenniston@google.com Reland "Add subset of W3C test suite to SVG corpus" 2020-10-16 bsalomon@google.com Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie1c0116fca5c584ce8169a7e85f4c895e739ef87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817976}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/711de82cd1ce..a667f878b15c 2020-10-16 kwiberg@webrtc.org Polish the "Using Abseil in WebRTC" docs 2020-10-16 danilchap@webrtc.org In VP9 wrapper fill information required to produce Dependency Descriptor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42722705e199ab16e03eddb20ea26c3792feb876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480542Reviewed-by:
-
Hung Vu authored
This CL handles how users' choices will be recorded if the location suggestion dialog is triggered. Bug: 1136234 Change-Id: I8118fc1ccd6fb64d3509cae2173cd3190bb98a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473357Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#817974}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=gab@chromium.org Change-Id: I1ed6961a801d4c1a15b322003c35bf45735db8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475054 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817973}
-
Victor Costan authored
Change-Id: I2cd08bd561f5d9a8be8b0c6562cebe80f4afe398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478886Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817972}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4fb7cc9ec8f..119d867c232d 2020-10-16 lehoangq@gmail.com Metal: autogen blit & clear shaders for integer textures 2020-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 312a2b1c to 20073b86 (419 revisions) 2020-10-16 lehoangq@gmail.com Metal: Support 2D array textures and base & max levels. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7f44a8610cf19f50e794506f01b5796fb49ac7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478893Reviewed-by:
-
Toni Barzic authored
Increases the delay for announcing search query changes to give chromevox more time to announce query changes, and to give search results more time to stabilize. Makes sure the selection moves to the search box text field when the user interacts with the search box (e.g. when they change the query). This should ensure that the chromevox announces the textfield changes to the user. Note that this should be done only if the selection has moved to a search result (otherwise ChromeVox would announce the full extfield value on each text update). To achieve this, SearchResultPageView has to notify the SearchBoxView that it changed the current selection - the cl adds a11y_selection_on_search_result_ member to the SearchBoxView that is set by SearchResultPageView, and reset by SearchBoxView when the selection moves back to the textfield. Removes calls to notify a11y selection changes from search result views. SearchResultPageView already handles result selection changes and sends the selection updates, but it also updates the search box state. Moves the a11y selection to the close button when it's focused. Updates the search box accessible name when search box is active not to reference using keys to navigate apps (as there are no apps to navigate when the search box is active). BUG=1111579 Change-Id: Ib11bcc9122e7545c7a37ad4ea2a6005459ee6176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476903 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817970}
-
Maksim Sisov authored
This is the last test suite that can be enabled. Next test suites can be enabled only after more resourcese are allocated. See https://crbug.com/1125488 to track the status of that. Bug: 1134495 Change-Id: I611def00a1967c615227d84563ee0fd0d8beb803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479165 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817969}
-
Ethan Jimenez authored
1. Refactoring how `NGGridLayoutAlgorithmTrackCollection` provides iterators for its internal `NGGridSet` collection. 2. Introducing new fields to `NGGridSet` that will be used by the track sizing algorithm, mapping directly to concepts like planned increase, item-incurred increase, infinitely growable, etc. 3. Adding indices to `GridItemData` that point to the `begin` and `end` of the range that each item spans across the relevant collection of `NGGridSet` for both track directions; these indices are cached in the new `NGGridLayoutAlgorithm::CacheItemSetIndices` method. 4. Introducing `NGGridItemContributionType`, an enum to delimitate the stages from https://drafts.csswg.org/css-grid-1/#algo-spanning-items; this enum will be used to determine the size that a grid item will contribute to intrinsic track sizing. It will also be used to adapt the behavior of many of the methods introduced above according to the stage of the algorithm. 5. Introducing most of the intrinsic track sizing algorithm steps described in https://drafts.csswg.org/css-grid-1/#algo-content. Implementation is made up of the following methods: - `ResolveIntrinsicTrackSizes` - `IncreaseTrackSizesToAccommodateGridItems` - `DistributeExtraSpaceToSets` Several other helpers are introduced, but scoped to an unnamed namespace only accessible to `NGGridLayoutAlgorithm`. 6. Updating expectations for several blink web tests; new crashes caused by the missing 'dense' auto placement of grid items are exposed, a fix for this issue is expected to land in a follow up change. Bug: 1045599 Change-Id: Ifffe899ffd5d6752d8e7c319ed04cfde53c825b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461695Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817968}
-
Ryan Heise authored
Change-Id: I86a9b0e4d74f57cf1e20976084504cacc1883b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480804Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817967}
-
spdonghao authored
Bug: 1126823 Change-Id: I32ec909f844c29433d1b60e0048ba725052718f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475575Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817966}
-
S. Ganesh authored
Handle multiple guid substitutions, where |dynamic_guid| is of the form "158428a4-6014-4978-83ba-9fad0dabe791=3d852661-c795-4d20-9b95-5561e9a1d2 d9," "63B8FFB1-5314-48C9-9C57-93EC8BC6184B=D0E1CACC-C63C-4192-94AB-BF8EAD0E3B 83". Before specifying |dynamic_guid| in the build, the IDL file is first compiled with "158428a4-6014-4978-83ba-9fad0dabe791" and "63B8FFB1-5314-48C9-9C57-93EC8BC6184B". These are the "replaceable" guids, i.e., guids that can be replaced in future builds. The resulting MIDL outputs are copied over to src\third_party\win_build_output\. Then, in the future, any changes to these guids can be accomplished by providing a |dynamic_guid| of the format above in the build file. These "dynamic" guid changes by themselves will not require the MIDL compiler and therefore will not require copying output over to src\third_party\win_build_output\. The pre-generated src\third_party\win_build_output\ files are used for cross-compiling on other platforms, since the MIDL compiler is Windows-only. Bug: 1109612 Change-Id: Ia0af825860df7adec3b23e11d32838de02c52604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476894Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817965}
-
Patrick Noland authored
Despite asserts to the contrary, the TabModelSelector can evidently be null at initialization time. Taking a cue from other TabSwitcher components, we allow for this possibility and move the observer setup to setTabModelSelector and make the observer safe to trigger when the underlying view is still null. Bug: 1137994 Change-Id: I9576699235a4f46ff6d28381eaefecea45c150c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477283 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817964}
-
Claude van der Merwe authored
This CL prevents Wifi Sync v2 from being enabled after multidevice setup if: 1. Wifi Sync V2 is not supported on the host device. 2. Wifi Sync V2 is prohibited by enterprise policy. The unittests are also updated to test for these cases. Bug: 1117619 Change-Id: I7e797430f4bc81700281ce74c54b2497a71fe312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468916 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#817963}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fab8fd6a143c..ae3dc89611ac 2020-10-16 alcastano@google.com [Devtools docs] Add build directory parameter in layout tests 2020-10-16 pfaffe@chromium.org TypeScriptify DebuggerWorkspaceBindings 2020-10-16 szuend@chromium.org Fix parsed JSON request payload in Network headers view 2020-10-16 carl@cpespe.com Add clip-path property values for autocomplete menu 2020-10-16 bmeurer@chromium.org [wasm] Add support for mouse hover for WebAssembly disassembly. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058836,chromium:1071432,chromium:1138110,chromium:954126 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a31dc07626591d7a9e496b629fc99ab115fc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480402Reviewed-by:
-
rbpotter authored
Support more general resource path rewrites by adding the option to pass such rewrites from the caller in the form: "original_file_path|resource_path_for_grd" Leverage this to rename rollup files, and remove the special-case logic that was used for this purpose originally. Bug: 1132403 Change-Id: Icffa7d85497ab000044fed1ebcd9542cb5b869bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476623Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817961}
-
Liquan (Max) Gu authored
Added PaymentAppService#resetForTest() to allow unit tests to clear the factories. This is needed because the singleton PaymentAppService does not clear its states between tests. This method will be used by the //clank tests. Bug: 1091475 Change-Id: Iffd27a74868cca573e3e1086a449f31f3344f66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477035 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817960}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010160700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/9Q3G72W_FP-DamN_GtRTUZe7jm4X8tsVnaUJ3Gp3fuMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: If3747bdf022e79c6bcf2795958582569db3e4b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817959}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.20-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I79e36cc5159e3040fc336b4af82d3ffe6322f491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480923Reviewed-by:
-
Nina Satragno authored
Do not send a PinUvAuthParam when reading a large blob. The current version of the spec states this results in an invalid parameter error. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I6028fd8dbc21f2f89b845f30547d6b325b1aacc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477455 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Paul Moy authored
Add two new fields to cros_healthd's CpuInfo Mojo struct. These two fields represent the time since boot that the device has spent in user mode and system mode, respectively. This will aid in the migration from deprecated Chrome APIs, which are currently the only sources of this information. Bug: chromium:1131602 Change-Id: I7987a28908eecd4f6feff14b35d42e9d7f1f2d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472600Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817956}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib2c79c979f0006075a1b7980c7e718437cfd9c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477241 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Yuly Novikov authored
TBR=bsheedy Bug: 1139336 Change-Id: I25464321de11fd36b8c93717bd33df864f5671d7 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480962Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#817954}
-
Abigail Klein authored
This ensures that the associated control of the settings subpage always exists. Bug: 1055150, 1139209 Change-Id: Ied4245e55315096db19d50dd8f584bba8dbe718e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480062Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010160700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rrmrHRTSDAizvCLGZJ2cK4G6dB81VsAGljn1FJVQwlAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I27a0108f194f9bb1d9512e6fc568a142af620316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480122Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b1938273e405..2a8ada795146 2020-10-16 cwallez@chromium.org Format: Move the baseType to be per-aspect. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I19317298405af2b87f662d376ccfbce45832c4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479664Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Some posted tasks in Safe Browsing would continue as normal, even after the Profile object is destroyed. Prevent those tasks from running when the Profile gets destroyed, to prevent instability when the DestroyProfileOnBrowserClose flag is enabled. Most of the new code is adapted from before these CLs: https://crrev.com/c/1832883 https://crrev.com/c/1830291 Bug: 88586 Change-Id: Idb8ab585313001c70784a5866fe4bea1d53415dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467358 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817950}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifd3f2f29c286b42d1838fb6199d8e1ddce31c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480123Reviewed-by:
-
Harry Cutts authored
This is empty for now, and will have settings added in follow-up CLs. There should be no visible changes to the UI when the flag is disabled. Bug: 1114828 Test: check sections display correctly with and without the flag set, and with and without mice and TrackPoints connected Change-Id: I8a13634be3cc3f256b3b4e562264ceb6f753316f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471900 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by: -
Eric Orth authored
Rename BuildTestDnsResponse[WithCname]() to BuildTestDnsAddressResponse[WithCname](). Clears up the unspecified name to be used in a subsequent CL for a more generic non-type-specific-builder, which will make it easier to write tests for HTTPS before I actually add parsing of those records. Also, while poking at these methods, modernize things a bit by having the DnsResponse returned as a movable value rather than unique_ptr. Also, fixed up the response copying internal to MockTransaction to actually fully copy the underlying buffer. The change from unique_ptr made it more obvious that const correctness was being broken. Change-Id: Idafcb6713fd213c48a6cc7432ffd7932295ca8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476780 Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#817947}
-
Hidehiko Abe authored
This reverts commit 4ee47291. Reason for revert: The unexpected test failure on the revert reason is fixed by crrev.com/c/2477055. Original change's description: > Revert "Undefine OS_LINUX for Chrome OS." > > This reverts commit 9b1cb285. > > Reason for revert: Appears to break linux-chromeos-rel: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41980 > > In particular, the test says this: > > #if defined(OS_LINUX) && defined(OS_CHROMEOS) > // QueryOutputProtectionStatus() is known to fail on Linux Chrome OS builds. > std::string expected_title = kEmeUnitTestFailure; > #else > std::string expected_title = kUnitTestSuccess; > #endif > > The condition becomes impossible after this CL. It's not obvious to me whether defined(OS_CHROMEOS) is the right fix here, because the comment specifically refers to Linux Chrome OS. > > Hence reverting so that this can be sorted out with media folks before relanding. > > Original change's description: > > Undefine OS_LINUX for Chrome OS. > > > > Bug: 1110266 > > Test: Built and took diff of the executable via objdump. > > Change-Id: I80832fb472e6cc78d1e967f6216b1c33cc79ba73 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475013 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817475} > > TBR=thakis@chromium.org,hidehiko@chromium.org > > Change-Id: I42d0ff74a7f640edd2b9d986628329dcff6c5d4e > No-Presubmit: true > Bug: 1110266 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477033 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817543} TBR=thakis@chromium.org,jbroman@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1110266 Change-Id: I0aef4ae2fce1c70e89af0af982101d6cd7b6226b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477195Reviewed-by:
-
Marc Treib authored
Before this CL, ProfileSyncService contained a fixed list of data types that was supported in transport-only mode. That wasn't the right place for this logic: The central SyncService shouldn't have any special knowledge of individual data types. This CL introduces a new DataTypeController::SupportsTransportOnlyMode method that lets us move this logic into the individual controllers. Bug: 1056715 Change-Id: If2da58cd86c4f1035a7bb8e78f8776e1cc8451aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475117 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817945}
-
Victor Hugo Vianna Silva authored
This API was needed in the Directory implementation of Nigori as part of the process of enabling a custom sync passphrase. Nowadays this is taken care by SetEncryptionPassphrase(), so this CL removes it. It had three remaining callers: the Android and iOS ones are easy to adapt; the third is the implementation of the SyncBrowserProxy.setSyncEncryption() Javascript API, called from the sync settings WebUI page. setSyncEncryption() has poorly-defined semantics (crbug.com/1139060), so it requires a few more changes. In short, instead of receiving only what's needed ("Is a new passphrase being set? Which one?"), it takes an entire SycPrefs [1] object, with the would-be parameters encoded by callers in the setNewPassphrase/passphrase/encryptAllData fields. This CL takes a first step in cleaning this up. The encryptAllData field is no longer set in the JS, nor parsed in the backend, since it was only used to decide whether to call EncryptEverything(). This already requires that we update some JS tests: they used to verify the entire prefs object, now they must verify only the necessary fields. Next CLs will modify the signature of setSyncEncryption() to take only what's needed. [1] https://source.chromium.org/chromium/chromium/src/+/97d49f526544f71dcef5b3ed21f03c507014cff7:chrome/browser/resources/settings/people_page/sync_browser_proxy.js;l=94 TBR=jlebel@chromium.org Bug: 1033040 Change-Id: Ibe508f60dc7d16096bddf808b31a0fe8046010d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476637 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: -
Claude van der Merwe authored
This policy allows administrators to prohibit users from enabling the upcoming Wifi Sync V2 feature which allows users to sync Wifi network configurations between Chrome OS devices and a connected Android phone. Bug: 1117619 Change-Id: I351d675c880f5b6be014a619274455e5922b0786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466677 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3b5599f..eaf54362 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6fae22bf0903ab84e47a8ab09f18aedbe3e79dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479822Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817942}
-
Adam Langley authored
Although this APP_NAME pattern is used elsewhere, it doesn't work in this context because the string ends up getting processed by the Android system and thus there's no possibility to insert the substring. Lots of other strings in this file mention Chrome directly, so do that. (Skipping screenshot requirement because the screenshot already exists and the context isn't changed.) BUG=1002262 Change-Id: Ic393a88f2b546aa72438d0da6a71aad666f5a256 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477517Reviewed-by:
-
Denis Kuznetsov authored
Fixed: 1133776 Change-Id: I45a1a077fa76de40a1c5b7602e7382c8335acdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479424 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#817940}
-
