- 22 Oct, 2020 39 commits
-
-
Andrew Grieve authored
This reverts commit 49fdeca1. Reason for revert: Breaking presubmit due to stale .pydeps file: android_webview/tools/run_cts.pydeps Original change's description: > Android: Use locally-build devil deps only when build_with_chromium=true > > Bug: 1120190 > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819489} TBR=agrieve@chromium.org,bpastene@chromium.org Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819668}
-
Thomas Lukaszewicz authored
This fixes a bad revert of the tab strip in the below CL https://crrev.com/c/2487252 Bug: 1099917 Change-Id: Ied10f472e699daadb280640f7455fc3685cb9826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490490Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819667}
-
Peter Kasting authored
Bug: 772945 Change-Id: I5b0720ca91cee30529e893ffa5924a9ada68f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490324 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819666}
-
Jinsuk Kim authored
Add a new watch definition 'android_toolbar' and a list for watching chrome/browser/toolbar java package. Change-Id: I1cc0ffa66d59abe55974f73700a14b62ec21e59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490963Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819665}
-
Reilly Grant authored
Bug: 707640 Change-Id: Ic48094a645da16c1c59e5403aabd2f4a0ee6218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490762 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#819664}
-
Nina Satragno authored
Calculate the pin param based on the hash of the set parameter instead of the raw value. Bug: 1114875 Change-Id: I1b443e4ce5d932445ae1e6bf965e5aee1b878369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487460 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#819663}
-
Francois Doray authored
28-days of Beta experiment revealed no regression: go/onecopyrasterbufferplaybacknormalthreadpriority-beta-results Bug: 1072756 Change-Id: Ib2e06e1e748073321ca37618b2466a2880b12ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485590 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#819662}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.27 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ife0f4a802666a3836c26eb8657b3b99f15a3de50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490925Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819661}
-
Josh Simmons authored
1) Tests were failing on pie-rel bots because swarmed builds do not include API keys. I've updated the tests to set a flag to ignore these missing keys. 2) Tests were still flaking quite a bit due to batching and state not being cleared between runs. I've tried a couple things (enabling extensive clearing, opening new tabs and closing tabs after tests) but the only way I've been able to get them to run without flakes is by disabling batching. I'll need to dig into translate internals to determine what the right fix is here. 3) Tests were failing the network_service_out_of_process_chrome_public_test_apk phase because, while the network monitor _says_ it has a connection to the internet during these tests, tests run under this configuration will actually refuse to resolve any DNS requests. I've added early returns for when the network service is out of process, but longer term I've opened crbug/1134812 to track the removal of the internet dependency. Similar to #2 this will take digging into Translate internals to make them more testable. BUG=1141160 Change-Id: I4cac8deed71235c2e2da6a6a690edbbaed047b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461711 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#819660}
-
Jinsuk Kim authored
Made HomeButton work without dependency on chrome.browser.homepage classes. All the deps are now deferred to ToolbarManager. The dependencies are injected not through ctor but init method introduced in this CL since the home button and the enclosing view (ToolbarLayout) are instantiated from xml. Menu handling logic was moved to HomepageManager to make it test- friendly. Also removed a bunch of dead code in HomeButton. Several public setters (ActivityTabObserver, ThemeColorProvider, StartSurfaceSupplier) were used by BrowsingModeBottomToolbarCoordinator only (see https://crrev.com/c/1981099). There's no callsite left any more as the class was already gone. Bug: 1127732 Change-Id: I56b8cc200d79a2790f0fd81b515bbe0d41fe5d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459428Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819659}
-
Jinsuk Kim authored
This CL is a speculative fix that adds null checks against the native pointer before calling into native layer. The native pointer gets nulled out when the native object is destroyed, so this can help avoid potential UAF. Bug: 1131346 Change-Id: Ie27dc55f308d64638ff09b5bcdbeb53ef2f8edde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483740Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819658}
-
Morten Stenshorne authored
Certain source files here depend on generated core files, such as core/css/css_property_names.h . Expressing this dependency without causing linker errors is tricky. This solution is based on CL:2489922. Bug: 1140604 Change-Id: I91932db7d3df4ce517950e0bd2c747e4468cef69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488560 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819657}
-
Ben Pastene authored
This moves the remainder of the tests in pool=chromium.tests.cros.vm to the main test pool by applying the magic named-cache optional-dimension to every test/bot that uses the 'chromeos-amd64-generic' mixin. Bug: 1132206 Change-Id: I94dcaecdb21f2a8b36c432273ef7dc0ae690f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490549Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819656}
-
Chong Gu authored
Bug: 1141040 Change-Id: I80a3482481762231b35a7cba82bb3781f6706b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490331 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
-
Kartik Hegde authored
Add the DnsResolution routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied DnsResolution changes and successfully ran the DnsResolution routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=dns_resolution). Change-Id: If10388526b50c05aab047ba30d00642d28c9e079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345005 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819654}
-
Shakti Sahu authored
This CL adds 1 - Country code flag for testing 2 - Instant fetch flag to fetch on startup 3 - Don't show the IPH card if there are no tutorials 4 - Fixed a UI bug in chrome://translate-internals where it doesn't allow overriding the country code when country code is undefined. Change-Id: I2277b2844c78278cfe91b15d56c1c0c9a52da326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490545 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819653}
-
Yue Li authored
The current annotation model does not work well with non-English words. Prioritize translation to solve the issue. Also increase the translation text length threshold. Bug: b/158509369 Test: Run existing tests Change-Id: I7316a55f934f570f5c035ced35b03369717a160f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487540Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#819652}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I9115677e06b9e2ca8486c028f005f757b7a33ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490338 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Tom Anderson authored
The X server may send unsolicited events (from clients calling XSendEvent() or from new keyboard mappings). So we must check that the event is the correct type before dispatching it. R=dalecurtis Change-Id: Ic3e19f7da1415c358991609c9b016bd60ead2038 Bug: 1140927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490674 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819650}
-
Xing Liu authored
This CL obsoletes the following metric: Notifications.Announcement.Events. Bug: 1130635 Change-Id: Id5fd616571e3b3c59b9bed483aa02e2c97b4b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486031Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819649}
-
Ryan Daum authored
* Observes visibility of the aura window that contains the webview and adds a new OnVisible hook when the window is made visible. * Requests initial focus when visible. * Same OnVisible hook will be used to register IME observers in a forthcoming cl. Bug: internal b/169848935, internal b/161811385 Test: manual on device and with wayland webview client Change-Id: I37d0dad610f99398363c6b8f91579cb0a42853c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487700 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#819648}
-
Taylor Bergquist authored
Tabs were being laid out based on the current width of the old and new tabstrips when tabs were dragged out of a tabstrip. Because the new tabstrip was always smaller than the old one, it was laying out from scratch instead of using the bounds the tabs used to have, even though those bounds could make sense in the new window. Now, it compares the tab drag area width, which doesn't depend on the contents of the tabstrip in the same way and doesn't suffer from this issue. Bug: 1140808 Change-Id: Ic2e5136358ccdeea3a706d8dce4015d4c79cfe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490143Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819647}
-
Shawn Gallea authored
This is needed to allow CastAppRpcInstance to know when the object has been destroyed. Bug: b/170144761 Test: Locally on device Change-Id: I878ea2c45c644bd74e52bf365d8af91b0fc9ac1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490177Reviewed-by:
-
Jeffrey Cohen authored
https://hsv.googleplex.com/6244305050009600 Bug: 1139773 Change-Id: If27b3ff02b867e972c3b1f579e707e643fe7047e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490848Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819645}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602665973-82a3b15c2fe4da417cf5b287fae1d2a3020f8e39.profdata to chrome-win64-master-1603291852-8226e53db1ad923442028152d5859381e4c42533.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id7acdbaecb3549669ec502b75cec62708d929c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819644}
-
Clark DuVall authored
I only verified my first fix on arm and not arm64. The libs from DFMs need to be in secondary_abi_shared_libraries if we're building on arm64 with a non-64 bit browser. Bug: 1126301 Change-Id: I7cf497b875cce6a28dc81873ef8f244969b60382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490668 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Hayato Ito authored
This reverts commit 974e1b68. Reason for revert: culprit CL for a build error on mac-archive-rel https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16425? In file included from gen/third_party/blink/renderer/bindings/modules/v8/v8_internals.cc:12: In file included from gen/third_party/blink/renderer/bindings/core/v8/v8_animation.h:11: In file included from ../../third_party/blink/renderer/core/animation/animation.h:42: In file included from ../../third_party/blink/renderer/core/animation/animation_effect.h:35: ../../third_party/blink/renderer/core/animation/animation_time_delta.h:8:10: fatal error: 'third_party/blink/renderer/core/animation/buildflags.h' file not found #include "third_party/blink/renderer/core/animation/buildflags.h" Original change's description: > Remove enable-send-tab-to-self-omnibox-sending-animation flag. > > This bug fix has been launched since M84. > > Bug: 1124205 > Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508 > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819562} TBR=jeffreycohen@chromium.org,sophey@chromium.org Change-Id: I20af4e4dc812a4b934d435fabc4d7e1930d37a33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490965Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819642}
-
Hung Vu authored
This CL will add 2 event metrics: - LOCATION_SUGGESTION_SHOWN: counts how many times this dialog type is triggered. - NOT_ENOUGH_SPACE: counts how many times the red error text is shown. Bug: 1136234 Change-Id: Ief19e9528802340fc908085f30a27737382c977c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487829Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#819641}
-
Aaron Leventhal authored
Use DumpWithoutCrashing() to get reports for problematic content. Also, add information to the crash reports about objects that are involved, and include information about commonly problematic properties. Note: DumpWithoutCrashing() once added to AXTreeSerializer once before but was reverted due to too many reports. AX-RelNotes: n/a Bug: None Change-Id: Iac5f0ba377e03881efdb6734a954fbb9f1f3125c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480624 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic4e18011de03fff582c96c97a418a9550d203240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491051Reviewed-by:
-
Nico Weber authored
Still on the 10.15 SDK, so still no real change here. I again locally removed libcodedirectory.dylib from the .yaml file when running the script. Tweak the instructions in the yaml file a bit. I used to copy over the whole Xcode app, which used to take a few minutes. The new process only takes seconds. Also add a word of caution that following these instructions doesn't update the locally used Xcode in itself. Bug: 1108831 Change-Id: I3b3f3d698378c347161118ba59ce49a6e23ab891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490920 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819638}
-
Thomas Lukaszewicz authored
overflow-scrollbar-combinations.html is flaking consistently on Linux Tests builders. See below for example build. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/94750 Bug: 1141206 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I5ccb03ce75a47f3a8523a1b033b67144392d1fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490850Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819637}
-
Nate Chapin authored
Change-Id: I7d0598be2359323a33915fff8c4345eeac8a2a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490546 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Victor Fei authored
Consider the following ax tree and ax positions representing an editable text input: ++1 kRootWebArea ++++2 kTextField editable ++++++3 kGenericContainer editable ++++++++4 kStaticText editable "Hello" ++++++++++5 kInlineTextBox "Hello" TextPosition1 anchor_id=5 anchor_role=inlineTextBox text_offset=4 annotated_text=hell<o> TextPosition2 anchor_id=2 anchor_role=textField text_offset=4 annotated_text=hell<o> The above text positions point to the same position in the text field but with different anchors. Calling AXPosition::CompareTo on these positions should return that they are equal. However, CompareTo returns the result that TextPosition1 is logically less than TextPosition2; which is incorrect. This is due to the following: On TextPosition1 anchor_id=5 anchor_role=inlineTextBox, we have the following call sequence: 1. AXPosition::CompareTo 2. AXPosition::SlowCompareTo 3. AXPositionInstance::CreateAncestorPosition 4. AXPosition::CreateParentPosition 5. IsEmbeddedObjectInParent In step 4 CreateParentPosition we call IsEmbeddedObjectInParent, but incorrectly evaluates text field's immediate child (generic container, id=3) as embedded object and returns true. This results in a position with wrong offset created in step 4 CreateParentPosition, and eventually resulting in wrong comparison in step 1 CompareTo. This CL fixes the above issue, by correctly handling text field case in IsEmbeddedObjectInParent. AX-Relnotes: Narrator cursor on Google's search input now properly follows text cursor as backspacing and left/right arrow key is pressed and correctly announcing the correct character. Bug: 1141171 Change-Id: Iba85b745d60b5c039f8b65a606bab7224bab4f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473065 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819635}
-
Allen Bauer authored
Bug: 772945 Change-Id: Id38927134e6b1ddef00ac6db1bac189ab625a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490553 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Ng Zhi An authored
When converting floating-point to any integer type, the fractional part is discarded, so any value in the range (-1.0,-0.00) (exclusive) will truncate to -0.0, and so will fit in an unsigned destination type. See https://en.cppreference.com/w/cpp/language/implicit_conversion#Floating.E2.80.93integral_conversions. Change-Id: Id8a5263d486cc3cd25670da27c417c66e28fccdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488717Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819633}
-
Kartik Hegde authored
Add the DnsLatency routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied DnsLatency changes and successfully ran the DnsLatency routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=dns_latency). Change-Id: I2e00fae7f641344a20372923c4d6be8e51cc5a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345004 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Adds missing message ack invocations which blocked flow of FIDL messages. The issue didn't exist prior to CL 2458877, because the FIDL/Blink bridge that was in place discarded flow control signals. As a result of that CL, CastMessagePortImpl now communicates point-to-point over FIDL with no bridges in between, and therefore the lack of acknowledgements lead to stalls in message delivery. Test: Manually tested Cast Streaming. Bug: 1140743 Change-Id: I05be612c110340094725f4aeb13cfc2e8e1adeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490552 Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#819631}
-
John Lee authored
This CL increases specificity of dark mode CSS for a folder that has a drag over it to force the CSS to override other colors. Fixed: 1139798 Change-Id: I6bda5834d06e9d3a4ebd27aea468df3c44a42512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490680Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819630}
-
- 21 Oct, 2020 1 commit
-
-
Yuheng Huang authored
Currently type checking of some of the functions using tabSearch.mojom.Tab is suppressed because we are trying to dynamically add some fields to it. This CL addresses the issue by wrapping tabSearch.mojom.Tab with TabData so tabSearch.mojom.Tab can stay unmodified. Bug: 1133558,1099917 Change-Id: Ibb792f2c84350f2ab234874b251f36360076bc50 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3314641Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
