- 20 Apr, 2020 40 commits
-
-
kylechar authored
Currently on Windows when the browser UI thread finds out the HWND is about to resized it blocks until any pipelined swap buffer calls have been issued. This is because if swap buffer is called when the framebuffer and window size don't match D3D will scale the texture to fit which stretches everything. For software compositing this doesn't appear to be an issue because D3D isn't involved. The direct composition path also doesn't appear to need this, since it creates a child HWND in the GPU process and draws to that. The child HWND isn't being resized by the browser so there is no stretching. This CL changes the UI thread so it only blocks for ANGLE D3D without direct composition path. Bug: 859168 Change-Id: Ie8ca1a661cdc06537e85b5be292c148ebc0503e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152998 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#760506}
-
Olivier Li authored
This requires some concept of watch state "snapshot" since we don't want to record the same hangs twice. Most of the complexity in the CL is related to that concept since the actual creation of the crash key is rather simple. Bug: 1034046 Change-Id: I41f910143c9a268451d1c88ce6684f680f873aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106486 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#760505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3e8db38..7a9eedf8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b23994fc674b62a94c4e347395eda9eb39a3eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156825Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760504}
-
Andrew Grieve authored
In order to: 1) not require recompiles when toggling is_java_debug, 2) allow incremental_install=1 to still have local variable information even when is_java_debug=false. Bug: None Change-Id: I0cd458d4445a925f02034907dc5673585e87c78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155206 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760503}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //mojo. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sky@chromium.org Bug: 714018 Change-Id: Iad24325ddf3b59c0f89c48cb3549331fc8ac3495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132395 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#760502}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c3a7dbe1482..dc4f75f7eed2 git log 4c3a7dbe1482..dc4f75f7eed2 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 hbos@webrtc.org [Adaptation] Make ResourceUsageState nullable, remove kStable. Created with: gclient setdep -r src/third_party/webrtc@dc4f75f7eed2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic1b4d08e91be2d39e44f8cba6ea769866d02e9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760501}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/ui. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sky@chromium.org Bug: 714018 Change-Id: I6661c11bb345bf98753aee7166bcd34a600f808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132373Reviewed-by: -
Sasha McIntosh authored
UMA: Display.ParseEdidFailure Bug: 1031787 Change-Id: I8a70ca4813569485df01e8d781eb4e9fceacbf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150689Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760499}
-
Nohemi Fernandez authored
The new architecture has multiple checks in place to ensure that coordinators are stopped (either by interrupt or completing an operation). Because the old architecture did not have these checks we were able to write more liberal tests. Bug: 1005509 Change-Id: I79f62b85c343b9dac8fccd5a81e0fb8a6d0dbee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156412Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#760498}
-
Gauthier Ambard authored
This CL makes sure that the feature to use the default user agent given by the WebClient is only working on iOS 13. Fixed: 1071746 Change-Id: I042b59c8ed6b993a75ebba40a5b8c7b3c9ad44a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153152 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760497}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 17d5c326. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 68a6734c "[blink] Add tests for destructive writes with JavaScript modules" 516e2447 "[WPT] Remove unused green-100x50.png images" ffd2e9cc "[css-grid] Migrate grid-automatic-minimum-for-auto-rows to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4224bf0ddbbccf2544787fc290f99c44c3759b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156512Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760496}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I8f9225a46f65ce7064cf4940f2c77e4178b962f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156605Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760495}
-
Dominique Fauteux-Chapleau authored
Bug: 1069026 Change-Id: I4dc8e84276d3e1f6a2c0d87c6e4f3ab588acbbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154732Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760494}
-
Greg Thompson authored
property_walker.Clean now logs errors so that RunCleanCommand does the best it possibly can and InstallerTest.tearDown will persist logs. BUG=1013720 R=zmin@chromium.org Change-Id: Ib936cadfc279983773457ffa3673e1f2564b64d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153056 Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760493}
-
Colin Blundell authored
As part of sharing as much as possible between the //chrome and //weblayer implementations of intent launching as possible, this CL dedupes the identical ExternalNavigationDelegateImpl#isPdfIntent() helpers into the shared ExternalNavigationHandler.java. Bug: 1071390 Change-Id: I030e22605ad1d982c339ec1a04ffdc55cef2ed35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156545Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760492}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I3d82c2cef13b3803682e2aeb2cdf4e4313b2ea30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156725Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#760491}
-
Omer Katz authored
If a not_fully_constructed object was reached again and marked by concurrent markers while the not_fully_constructed worklist was being emptied, we would get a race between setting mark bit and reading size for verification in debug modes. Bug: 986235 Change-Id: Ibb7b7619e6965901fb2a94a5c742db10070b64e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156488 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760490}
-
Denis Kuznetsov authored
Fixed: 1071770 Change-Id: I38fc772129e93663ab7adcc650dce351bfc2128e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156546Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#760489}
-
Peng Huang authored
There is a typo which uses surface_msaa_count_ instead of final_msaa_count . But this typo shouldn't cause any problem, because surface_msaa_count_ and final_msaa_count are always 0. Bug: None Change-Id: I269324ceffc8ddea79478f7232ab6670ded00dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155622 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#760488}
-
Sebastien Lalancette authored
- Pulling up ownership from BVC to BrowserCoordinator. - Making it a short-lived coordinator instead of long-lived. - Renamed ActivityServiceLegacyCoordinator (removed Legacy). - Made ActivityServiceCoordinator a PresentationProvider for its controller. - Removing the ShareProtocol. - Calling shareDidComplete for password scenarios. - Removed "active" state from singleton controller. Bug: 1068606 Change-Id: I12105135614ef8cc45d7679bee63f34725cc058f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147778 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#760487}
-
Mohamed Amir Yosef authored
This reverts commit 2d2185d8. Reason for revert: This caused ios build failures https://ci.chromium.org/p/chromium/builders/ci/ios-device/154217? Original change's description: > [iOS][Credential-Provider] Observe changes in the password store > > Updates the credential store with changes from the password store. > Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer > the async nature of it. > Creates entry functions for adding, updating, and removing passwords > which will be used to also keep up to date the OS metadata in a follow > up CL. > Injects the credential store for easier testing. > > Bug: 1066803 > Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760483} TBR=vasilii@chromium.org,javierrobles@chromium.org Change-Id: I769316c34e40c248a245553b1e5f78c834eee1aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156786Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#760486}
-
Omer Katz authored
Ephemeron tracing can occur during incremental marking steps if there is no other work for it to do and the deadline was not reached. The check whether a weak key is marked could race with a concurrent marker marking it. Bug: 986235 Change-Id: I5727a8800471dd24bb3f74430356c4dd7c12b130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156493Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/869374bcab6f..f3fda0023405 git log 869374bcab6f..f3fda0023405 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 sigurds@chromium.org [issues] Refactor issue displaying 2020-04-20 tvanderlippe@chromium.org Change waitForFunction condition to add more debugging output in network-datagrid.ts Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3fda0023405 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066813,chromium:1070577,chromium:1072304 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90059b84574e13717d7898eb7b512f1ced9f9385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156440Reviewed-by:
-
Javier Ernesto Flores Robles authored
Updates the credential store with changes from the password store. Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer the async nature of it. Creates entry functions for adding, updating, and removing passwords which will be used to also keep up to date the OS metadata in a follow up CL. Injects the credential store for easier testing. Bug: 1066803 Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760483}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f059df7a4390..a0481ae89c39 git log f059df7a4390..a0481ae89c39 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 fmayer@google.com Fix next id in HeapprofdConfig. Created with: gclient setdep -r src/third_party/perfetto@a0481ae89c39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I587d8a44ae264a89d33a5ce1f4c01d05505934cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156439Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/361890eb3994..4cd3c7a92530 Created with: gclient setdep -r src-internal@4cd3c7a92530 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071780 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Ic5d147fde42099bc9c7b439a72cdeaeed098e486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156436Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd2697aa..e3e8db38 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If451254ef986a96c5165e3cff553cfb28abcb45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156510Reviewed-by:
-
Christian Dullweber authored
The feature is not fully launched yet, so increasing expire_milestone. Change-Id: I287aef3827babdeb33849670dd6dc7ec07f4e282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154799 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#760479}
-
Sean Harrison authored
Work is continuing using the privacy-settings-redesign flag on TOT, so we are extending the expiry of the flag by two milestones. Bug: 1032584 Change-Id: Ic47a7b4b349b0fd12cd00c0cb90774d36d210d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153163Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#760478}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed005be78815..4c3a7dbe1482 git log ed005be78815..4c3a7dbe1482 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 danilchap@webrtc.org Remove RtpVideoHeader::discardable flag. 2020-04-20 sprang@webrtc.org Updates RtpVideoSender to populate RtpRtcp::Config.field_trials Created with: gclient setdep -r src/third_party/webrtc@4c3a7dbe1482 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id25b0da718222c121bc4ffaef7f6f22147b5dc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156438Reviewed-by:
-
edchin authored
EditBookmarksEnabled is an enterprise policy that determines whether the user can edit any bookmarks. The policy is mapped to a user pref. This CL is part of a series of CLs that add support for this enterprise policy on the iOS platform. Bug: 1072326 Change-Id: I6fd2e640e35191b4e6feec6fd41b9e063c7f2a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153772 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#760476}
-
Emanuel Ziegler authored
Since a Response object with a null body is valid, we should throw a WebAssembly.CompileError instead of a TypeError for WebAssembly.compileStreaming and WebAssembly.instantiateStreaming. This allows us to remove the expected results from the corresponding WPT test because it passes now. R=ahaas@chromium.org Depends-On: I238288de73283a06c5075d0060977b366c0fbe09 Change-Id: I19568e6c0906de518fd6e5b417ef7e045e9d43c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142212Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#760475}
-
Victor Hugo Vianna Silva authored
Close any pending reauth UI since the opt-in pref wouldn't be set upon success. Bug: 1045515 Change-Id: Ie7fcc17413adba447cf4045185d4717a9068350e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151459 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760474}
-
Colin Blundell authored
This KeyedService will be needed in the integration of translate functionality in //weblayer. The factory is adapted from that of //chrome (with one subtlety documented in crbug.com/1072334). Bug: 1072334, 1025620 Change-Id: Id1a53fd79c64b157224cf78d436f3567c5c0a837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153161Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760473}
-
Philipp Hancke authored
in order to avoid RTX probes showing up on the receiving end BUG=chromium:1066819 Change-Id: Icfeead1bc08557f6cb2fc3080c20b7f4bd92be29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144080Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#760472}
-
Nasko Oskov authored
These tests use a custom observer for navigations which watched for navigation starts. As we make some internal navigation changes in WebUI the navigation starts before |observe_new_contents| returns a new WebContents. To fix this, the CL removes WaitForDidStartNavigate in favor of the more generic content::TestNavigationObserver. This is based on lukasza@'s work in https://chromium-review.googlesource.com/c/chromium/src/+/1815980. Bug: 883549, 1069939 Change-Id: I55bcfcb5bd96f32c566cca5ca0de2efd1844af70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150056 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#760471}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb3815208a9a..869374bcab6f git log bb3815208a9a..869374bcab6f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 tvanderlippe@chromium.org Port shared test runner logic into separate package 2020-04-20 sigurds@chromium.org [issues] Misc CSS improvements Created with: gclient setdep -r src/third_party/devtools-frontend/src@869374bcab6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979,chromium:1071369 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8334c73b6f0e4d24a1af080d30e456cb0bb9e674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156435Reviewed-by:
-
Rune Lillesveen authored
These tests were flaky timing out occasionally on multiple platforms. Bug: 1071114, 1071418 Change-Id: Ia1e1b5edab76d35731b0d384f78d68fa79487bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152800Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#760469}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/34b3e095fffc..f059df7a4390 git log 34b3e095fffc..f059df7a4390 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skyostil@google.com base: GCC 7.1 compatibility fix Created with: gclient setdep -r src/third_party/perfetto@f059df7a4390 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibf824fa0b7425df41080692617d7de9b5cb93414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156434Reviewed-by:
-
Kazuhiro Inaba authored
This reverts commit 6aac6001. Reason for revert: Suspected culprit breaking all GAIA tests b/154460326 BUG=b:154460326 Original change's description: > cros: Enable GaiaActionsButton by default > > Bug: 1068314 > Change-Id: I5189e4dd76f6e168d9d17b2bd1bdfceeada68bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138072 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760004} TBR=rsorokin@chromium.org,raleksandrov@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068314 Change-Id: I1e51924d767996dc7725b7f231a6f08b229817f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156331Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
-
