- 17 Mar, 2020 40 commits
-
-
Kei Nakashima authored
This reverts commit 32f57805. Reason for revert: I mistakenly add a wrong file. Original change's description: > Added a function |InsertBefore| to NewLinkedHashSet. > > Implemented |NewLinkedHashSet::InsertBefore| and added test for it. > > Change-Id: I987a8c82c329565125d3a42f674b28d18e91ef38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103015 > Commit-Queue: Kei Nakashima <keinakashima@google.com> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750825} TBR=yukishiino@chromium.org,haraken@chromium.org,bartekn@chromium.org,keinakashima@google.com Change-Id: I568bcc2ce4801c57e0e2b4f88f2be93d5e78d226 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106699Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#750859}
-
David Munro authored
Bug: None Test: crostini unit tests and browser tests Change-Id: I07aaa9e92881b522d0e533831b44ba13a46b59ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106036 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#750858}
-
Noel Gordon authored
Apparently the png was never created but its sha1 was, and that tricks ./translate.py (see bug). Remove the .sha1 file to untrick that tool. Bug: 1062142 Change-Id: I7e01ae2293ae6036118467e6eb29b6e7889043ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106700 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750857}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7a6643ddf5c..a58084c626ce git log d7a6643ddf5c..a58084c626ce --date=short --first-parent --format='%ad %ae %s' 2020-03-17 phoglund@google.com Make all values in the proto doubles. Created with: gclient setdep -r src/third_party/catapult@a58084c626ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: crouleau@google.com Change-Id: Ide05976a70ec5d1d59528335ca4b3eda7b00dcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750856}
-
Andrew Grieve authored
Makes the tool easier to use, and easier to document how to use by not requiring it to be built first. We have only a single non-prebuilt .java file, so it's easy enough to just check in the .class file for it. Bug: 995290 Change-Id: I7b934b3337eccb044a470dd92270ce7338b1fd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106257 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#750855}
-
Daniel Hosseinian authored
Change the interface of PrintBackend::CreateInstanceImpl() to include a flag indicating that the backend is to be used for Cloud Print. The new interface PrintBackend::CreateInstanceForCloudPrint() passes |true| for the flag, but usage of the flag will follow in a future CL. The flag is necessary for runtime switching of the CUPS backend on macOS. Because cloud print is still configured to rely on PPD attributes, we want to still use the CUPS PPD backend over the CUPS IPP one. CreateInstanceForCloudPrint(), which will only be built and called on CUPS platforms, would ensure that the CUPS PPD backend is used. Bug: 226176 Change-Id: Ic9c376af9992bb70516d1de39da3c9666cff145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089987 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#750854}
-
Jing Wang authored
Removed the old setSetting/getSetting API. The new API now accept settings bundle instead of single entries so we can add type constraints on the values. The design doc: go/cros-ime-settings-migration The existing histogram values for getSetting and setSetting have never been used since the functions were not used in production code, so overwrite them with new api. Changes in input_method_private.js are auto generated by scripts. Bug Id: 1060906 TEST: tested with cl/298964323 on ChromeOS emulater. Change-Id: I2cd503d6acf696c0ad008f3894bf09f54e1a7531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099343 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#750853}
-
chrome://media-appTrent Apted authored
The `Save` operation in chrome://media-app started failing after r749464. Console errors like `createWriter` is undefined. r749464 tore out the old API and replaced it with a new one. Unfortunately, this only changed IDL files, and not the externs file that JS needs to compile against. This change updates the externs file to match the IDL file, making the regression detectable at compile time. Filed b/151394309 to investigate ways to detect when the externs file does not match the idl files and complain about it. The externs file is verbatim from cl/300232012. Bug: 1061813 Change-Id: I2de55447b640aec3338640db75a323a877beffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103011Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#750852}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41b4ab193a14..d24752e63ae4 git log 41b4ab193a14..d24752e63ae4 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 jmadill@chromium.org Capture/Replay: Write to single binary data file. 2020-03-17 jmadill@chromium.org Re-enable optimization for angle_perftests. 2020-03-16 jmadill@chromium.org Move perf test common files to a source set. 2020-03-16 jmadill@chromium.org Refactor ANGLE common test utils. Created with: gclient setdep -r src/third_party/angle@d24752e63ae4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I4c603ea84a180d23f33557ba515846d999a2aa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106920Reviewed-by:
-
Matt Reynolds authored
When a USB device descriptor is read, a UsbDeviceInfo object is created with information about the device. This info is used to update the UsbDeviceInfo held by the UsbDevice object. However, some UsbDeviceInfo fields are not filled when the device descriptor is read and must be preserved from the original UsbDeviceInfo. This CL adds |guid| to the list of fields that must be preserved from the UsbDeviceInfo held by the UsbDevice object. BUG=1012862 Change-Id: Ib97c2e63155c432141fd57477687ca70bbfdd212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850414Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750850}
-
Hsin-Yu Chao authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2302d21944c8..3e21563e6e10 $ git log 2302d2194..3e21563e6 --date=short --no-merges --format='%ad %ae %s' 2020-03-12 hychao system_api: Modify dbus method name to SetNextHandsfreeProfile 2020-03-11 kimjae dlcservice: Expose Simple Polling Interface 2020-03-12 ahassani system_api: Add OWNERS file for dbus/dlcservice 2020-03-10 yhong system_api: fix comment in runtime_probe.proto 2020-03-10 kimjae Revert "dlcservice: Expose Polling Interface + Cache Memory Internals" 2020-02-26 hychao system_api: Add CRAS dbus API NextHandsfreeProfile 2020-02-28 kimjae dlcservice: Expose Polling Interface + Cache Memory Internals 2020-01-31 yichengli system_api: Add fingerprint-related definition to cryptohome protobuf Created with: roll-dep src/third_party/cros_system_api Bug: b/149188379 Change-Id: I11b43c6f7361ca88dcee1a3d6237888c1b73c0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100456 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750849}
-
Eric Willigers authored
WebAppControllerBrowserTest::SetUpOnMainThread() now starts its https server, avoiding the need to start the server in each test case. The http server and cert verifier in CustomTabBarViewBrowserTest are retired, as this functionality is already provided by WebAppControllerBrowserTest. Change-Id: I67bcd661bca0ed647d3b2e9c8efa2217f19978cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089441 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#750848}
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: I99903ff70a9fe8f4c17cda12b5390c148b6c1960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105658Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#750847}
-
Anand K. Mistry authored
Native SMB integration is in active development, and other NativeSmbFileShare.* metrics are set to expire in M85. Bug: 1053060 Change-Id: I4297071694c8ff4173cf2a6aa972f5b3dbd718df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101397 Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#750846}
-
Alexander Cooper authored
Creates interfaces for BrowserXrRuntime to be consumed by classes that will remain in chrome/. This updates existing usages that will no longer be able to access the BrowserXRRuntimeImpl class to use the public interface (primarily this is everything outside of vr/service). Note that although right now BrowserXRRuntimeImpl lives in chrome/, it will soon be moving to content/, once the remaining dependencies for the rest of vr/service have been broken (so as to avoid over-exposing methods needed by these classes to talk to each other). Currently the only way to get a BrowserXRRuntime is via the XRRuntimeManager. While some of the XRRuntimeManager methods will be moved to a public interface in future changes, it will still only be possible to get an XRRuntimeManager (and therefore a BrowserXRRuntimeImpl) in chrome/ until the move actually happens. Bug: 1031622 Change-Id: I42e1cfd18842166ce1f8eeaa6003d7f84e52aef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103305 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#750845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34d90bebd8ba..c99efb2f8c62 git log 34d90bebd8ba..c99efb2f8c62 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 sokcevic@google.com Add gerrit_client unit tests Created with: gclient setdep -r src/third_party/depot_tools@c99efb2f8c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6fb8feb07ab115021510fc6c1594a888ae6836b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106914Reviewed-by:
-
Avery Musbach authored
All/SplitViewOverviewSessionInClamshellTest.ResizeWindowTest/? All/SplitViewOverviewSessionInClamshellTest.CloseWindowWhileResizingItTest/? All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.WindowResizingPerformanceHistogramsTest/0 Test: ash_unittests Test: ash_unittests Test: ash_unittests Bug: 1059477 Change-Id: I799bdc89d58e9ed4df5a1e74f9b40c48c7b82908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100890Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I9988634f003ace728c7380837c6fdd858c7622a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106657Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750842}
-
Luciano Pacheco authored
This fixes the visual glitch when opening Files app a vertical scroll bar would "blink" in the right hand side of the action bar. Fixed: 1061848 Change-Id: Ifa39df13497ebf63bfd2bd7e84bd8a6ba25d010c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105659 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
There are a couple of callsites of the method outside tab package: ReparentingTask and TabModelSelectorImpl. They are always used by ChromeActivity or one of its child Activities(CustomActivity), therefore the checking the detached state is as simple as checking the nullity of the associated WindowAndroid. This CL replaces the callsites with an expression evaluating the nullity. The only callsites left are within the tab package, so the method can be package-private. Bug: 995903 Change-Id: Ic30a0a4647d582e0a1b26f7ac0319a8b078d75af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101412Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#750840}
-
Daniel Murphy authored
Prerequisite work to avoid annoying lint errors. R=loyso@chromium.org Change-Id: I4495933115f833c0723473b24da3c39afa4a587e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106344Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9170376d36ad..1aa882626c3d git log 9170376d36ad..1aa882626c3d --date=short --first-parent --format='%ad %ae %s' 2020-03-17 btolsch@chromium.org Add first CastSocket E2E test Created with: gclient setdep -r src/third_party/openscreen/src@1aa882626c3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I80e103a4245c7cd44bd15f2e7688309d197f9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106919Reviewed-by:
-
Katharine Daly authored
In the event that an admin configures a secure DNS policy that breaks DNS lookups, users should be able to fetch a replacement policy. Bug: 955454 Change-Id: I33381560a2166b55f1939fac4f59a267d29a5eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106413Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#750837}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66f59d1fe63..0ad56875dec9 Created with: gclient setdep -r src-internal@0ad56875dec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I86debc31e44d5ec95ed1ba2f92f931cbbcd17740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106764Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750836}
-
Ken Rockot authored
This adds a config entry for the experimental group in the first stage of the out-of-process Storage Service rollout. Bug: 1057802 Change-Id: I2d638fd881d0b8a39d80202278cafdd56eccbfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106756Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#750835}
-
Hwanseung Lee authored
The AndroidSetupSearchEngine feature is enabled by default and the config has no effect anymore. Therefore, remove the config and every reference to AndroidSetupSearchEngine. Bug: 1057939 Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#750834}
-
Nicholas Hollingum authored
Previously if the user cancelled the backup, we would proceed with the upgrade as though the user had elected not to backup at all. With this change, the flow will instead return to the initial screen when the user cancels, rather than proceed. Bug: 1061203 Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#750833}
-
Nicholas Hollingum authored
The file chooser foregrounds itself and restacks the other windows, which results in the upgrader dialog being stacked below the settings window (this happens if the user upgrades from the settings UI). To prevent this we add a "MaybeBackupStarted" call to the observer, that can be used to restack the upgrader window on top once a backup location is chosen. We use "maybe started" since crrev.com/c/2102935 will independently make the ui return to the start screen, in which case the dialog needs to be brought-to-foreground as well. Bug: 1060778 Change-Id: Idb363b6dd4d87bb7227de846fcedfb9c1566c2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104729Reviewed-by:
-
Tommy Nyquist authored
This test was failing on KitKat phone tester. BUG=946722,999361 TBR=dullweber@chromium.org Change-Id: Ib0d0852dc6b2b2eb1ddfe3739a3ad9942de6e3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106034Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#750831}
-
wutao authored
Bug: 1050650 Test: build Change-Id: Ia8d9a687045eaf4c4d6525862a0613db100c77b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105955Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/457f4e7fe507..d7a6643ddf5c git log 457f4e7fe507..d7a6643ddf5c --date=short --first-parent --format='%ad %ae %s' 2020-03-17 dberris@google.com Add more logging to histogram processing Created with: gclient setdep -r src/third_party/catapult@d7a6643ddf5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@google.com Change-Id: I63cfe62e67969eda8a428c26e2809d1815407ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106772Reviewed-by:
-
Robert Woods authored
The parameters to RegisterFileHandlersWithOs currently include separate sets of MIME types and file extensions corresponding to the file handlers for the web app being installed. This CL replaces those with a single vector of apps::FileHandlers. There are a couple of reasons for doing this. First of all, the Linux implementation of this method will require an explicit mapping of MIME types to file extensions, which is needed to register new MIME types with the OS, and which is lost when extracting the separate sets. Second, the work of extracting those sets is better done by the callers to this function anyway; for example, in the Windows implementation, the MIME types set isn't used at all, meaning that unnecessary work is being done to produce it in the first place. Bug: 938103 Change-Id: Ie0a6e7196e7f71338602d9c3e2d0d593283be8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101393 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Alan Screen authored
Insight regarding availability of OpenXPS for printing has been acquired, leading to more general question about XPS availability of any type (MSXPS or OpenXPS). This particular metric no longer needed. Bug: 1053273 Change-Id: I72013cfcc78e14c160794b1841b1bb14ef656a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105393Reviewed-by:
-
Theresa Wellington authored
This reverts commit eddf4f01. Change 1 of 2. The next CL will update downstream dependencies. Moves //chrome/android/public/profiles/ to //chrome/browser/profiles/ and //chrome/android/public/crypto/ to //chrome/browser/android/crypto/. Note that this will break the downstream build temporarily. Since there are JNI files generated, unless the package is updated we cannot keep a temporary mirrored build target as was done in https://chromium-review.googlesource.com/c/chromium/src/+/2095444 BUG=1052382 Change-Id: Ia33f81e0d2896d0f5ac7122b941e17a58a79e823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102758Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#750826}
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::InsertBefore| and added test for it. Change-Id: I987a8c82c329565125d3a42f674b28d18e91ef38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103015 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Mingyu Kang authored
Bug: 1060860 Test: WavAudioHandlerTest.SampleFloatDataTest Change-Id: If973db35bdf71ed8364de9dec6fc3e0d51285c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099716Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#750824}
-
Eugene Zemtsov authored
VideoPlaybackRoughnessReporter tracks moments when each frame was submitted and when it was displayed. Then series of frames are split into groups of consecutive frames, where each group takes about 1/2 second of palyback. Such groups are also called 'frame windows'. Each windows is assigned a roughness score that measures how far playback smoothness was from the ideal playback. Information about several windows and their roughness score is aggregated for a couple of playback minutes and then a window with 95-percentile-max-roughness is reported via the provided callback. Currently roughness is not reported via any server side metrics. Integration with UMA and UKM coming soon. Bug: 1042111 Change-Id: I5a12e400f00f91fc0b63d15e88bca5c0ab09d5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097951 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750823}
-
Abhijeet Singh authored
This CL updates the logic for showing Quick-Answers to the users when they have explicitly granted the consent by acknowledging the User-Consent view or implicitly done so when the user-consent view has been sufficiently impressed. The major change will be that once impression caps have been reached, the Quick Answers will begin to be shown in addition to the consent-view not being shown anymore. This is because the requirements updated to treat the consent-view as more of a notice. Bug: b:151363933 Test: Tested on Chrome OS VM. Change-Id: Ic7868ed208e0fe5c05da57509459d7888665d3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101725 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750822}
-
Eugene Zemtsov authored
This field is intended to be used in following CLs to annalyze video playback smoothness. Bug: 1042111 Change-Id: I577916538ca029e437b591ef9d03f04f78e29f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097950 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
-
Sammie Quon authored
Use the api which does clipping, which is more performant than using masks. Test: manual Bug: 1056490 Change-Id: Id9612882241ec95832c562e60fcf20c82bc88e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099291Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#750820}
-
