GitLab

BUG=none
TBR=mpearson@chromium.org
R=jiayul@chromium.org

Review URL: https://codereview.chromium.org/601033002

Cr-Commit-Position: refs/heads/master@{#296604}

BUG=416722
R=piman@chromium.org
TBR=cpu@chromium.org (sandbox_win.cc)

Review URL: https://codereview.chromium.org/606463002

Cr-Commit-Position: refs/heads/master@{#296603}

BUG=416722
R=garykac@chromium.org

Review URL: https://codereview.chromium.org/602763003

Cr-Commit-Position: refs/heads/master@{#296602}

This helper method is also used by internal Chromecast calls.

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400914

Review URL: https://codereview.chromium.org/606483002

Cr-Commit-Position: refs/heads/master@{#296601}

The setting is enabled by default for Android builds, but not
practical for Chromecast on Android.

R=byungchul@chromium.org,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/606453003

Cr-Commit-Position: refs/heads/master@{#296600}

Includes last frame's duration in the determination of
SourceBufferStream's |max_interbuffer_distance_|, to prevent an
unusually long segment-ending frame from triggering discontinuity when
adjacent buffers are appended.  A more correct fix requires
StreamParsers to always emit valid frame durations (crbug 351166), and
would use them exclusively to determine discontinuity.

BUG=351489
R=dalecurtis@chromium.org
TEST=No media_unittest, layout, or yt-dash-mse ToT conformance regression. Fixes b/17570928.

Review URL: https://codereview.chromium.org/597293004

Cr-Commit-Position: refs/heads/master@{#296599}

Output:
Failed to load ../out/Release/xdisplaycheck with cwd=/tmp/run_tha_testSvCWuD/chrome
Xvfb exited, code 1
Xvfb output:
>
> Fatal server error:
> Server is already active for display 9
> 	If this server is no longer running, remove /tmp/.X9-lock
> 	and start again.
>

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/600283002

Cr-Commit-Position: refs/heads/master@{#296598}

createMediaPlayer() will soon get called with the additional
parameter |initial_cdm|. Adding a method to include it.

BUG=358271
TEST=mojo compiles with upcoming blink changes

Review URL: https://codereview.chromium.org/600233002

Cr-Commit-Position: refs/heads/master@{#296597}

BUG=17297,18218,20582,21479,27315,27644,28847,28072,31634,35164,35625,40429,40659,47949,50286,50297,50638,50968,52681,53742,53989,55773,58860,51682,60873,61737,61929,63024,63670,64463,65940,67291,68090,73036,73299,75136,75142,75714,77265,77388,79994,80239,82328,82682,84329,86303,87461,90976,91889,91892,92579,93036,96300,96559,96671,96689
NOTRY=true
TBR=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/605543003

Cr-Commit-Position: refs/heads/master@{#296596}

BUG=None

Review URL: https://codereview.chromium.org/604623002

Cr-Commit-Position: refs/heads/master@{#296595}

Offer to download the Software removal tool when the sw_reporter component found something that it can handle.

For chrome/app/chrome_command_ids.h
TBR=cpu@chromium.org

BUG=416582

Review URL: https://codereview.chromium.org/599653002

Cr-Commit-Position: refs/heads/master@{#296594}

BUG=402072
TBR=xiyuan,jamescook

Review URL: https://codereview.chromium.org/596603002

Cr-Commit-Position: refs/heads/master@{#296593}

I missed this in r296574

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/602873004

Cr-Commit-Position: refs/heads/master@{#296592}

This is flaky because the app list ends up trying to read an ImageSkia
on one of Cocoa's background threads.

While NSView has a `canDrawConcurrently` function, AppKit is not calling
it in the case that is making this test flaky. The documentation says,
"The default is NO for most types of views.." [sic], and I've verified
it is `NO` and tried overriding it, but it was just never called.

However, having -[NSView canDraw] return `NO` seems to work fine.
Returning NO when there is no message loop ensures a draw only occurs on
a thread that Chrome created (not one of Cocoa's background threads),
and doesn't raise any DEPS issues.

BUG=417148, 415264

Review URL: https://codereview.chromium.org/599803002

Cr-Commit-Position: refs/heads/master@{#296591}

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/599863003

Cr-Commit-Position: refs/heads/master@{#296590}

When webview translates into the screen from offscreen by calling
WebView#SetTranslateX/Y, onDrawHardware is called with an empty global
visible rect.
When the webview is still offscreen, Android frameworks won't call
DrawGL on WebView, which means the "parent draw constraints" stored in
hardware renderer won't contain the draw constraints when the webview is
offscreen.
When webview gets an ondraw with an empty global visible rect, we need
to make sure the parent draw constraints of the corresponding DrawGL is
always posted back to child compositor and triggers an invalidate.

BUG=417479

Review URL: https://codereview.chromium.org/603633003

Cr-Commit-Position: refs/heads/master@{#296589}

This change includes implementation for MemFs and FuseFs.

I've also reordered the fuse_operations struct to match the order used in the
real FUSE implementation.

BUG=414793
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/604513002

Cr-Commit-Position: refs/heads/master@{#296588}

BUG=42958,47950,49279,51379,51590,51679,52837,52957,54308,55533,56359,56676,58321,58340,58546,60556,60654,80462,80550,80551,84224,112278,112450,112594,118890
NOTRY=true
TBR=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/605553002

Cr-Commit-Position: refs/heads/master@{#296587}

BUG=417526
NOTRY=true
TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/600243003

Cr-Commit-Position: refs/heads/master@{#296586}

BUG=416722
R=sky@chromium.org

Review URL: https://codereview.chromium.org/606453002

Cr-Commit-Position: refs/heads/master@{#296585}

RenderFrameHostManager::CommitNavigation was not using scoped_refptr when it created a new SiteInstance.  This resulted in the new SiteInstance being deleted in FrameTree::CreateProxiesForSiteInstance after iterating through the frame tree with base::Bind due to its ref count falling to 0.

This was the cause of crashes in  RenderFrameHostManagerTest.BrowserSideNavigationCrossSiteNavigation and RenderFrameHostManagerTest.BrowserSideNavigationIgnoreStaleNavigationCommit under --site-per-process.  These tests now pass.

BUG=417518

Review URL: https://codereview.chromium.org/599253002

Cr-Commit-Position: refs/heads/master@{#296584}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/591413006

Cr-Commit-Position: refs/heads/master@{#296583}

BUG=416722
R=gene@chromium.org

Review URL: https://codereview.chromium.org/606443003

Cr-Commit-Position: refs/heads/master@{#296582}

R=byungchul@chromium.org,lcwu@chromium.org
BUG=332744

Review URL: https://codereview.chromium.org/595113002

Cr-Commit-Position: refs/heads/master@{#296581}

BUG=416722
R=wfh@chromium.org

Review URL: https://codereview.chromium.org/606443002

Cr-Commit-Position: refs/heads/master@{#296580}

A simple cloud extension example that uses the file system provider API
This example is different from https://codereview.chromium.org/360673004
as it is an extension and not an app.

BUG=415847

R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/587293002

Cr-Commit-Position: refs/heads/master@{#296579}

Metric exists but is spelled wrong in JS.

R=tim@chromium.org,estade@chromium.org

Review URL: https://codereview.chromium.org/572113002

Cr-Commit-Position: refs/heads/master@{#296578}

This has to be landed first. After the recipe change, I'll remove the old ones.

BUG=414808
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/599993003

Cr-Commit-Position: refs/heads/master@{#296577}

App Shims are small .app bundles for Mac, which run in their own
process to provide packaged apps with an OSX Dock icon, using IPC to
communicate with the browser process.

Most of the app_shim code currently lives in src/apps/app_shim, but app
shims are very much a browser feature, so it doesn't belong there. It's
causing DEPS problems for athena efforts.

This CL moves most of apps/app_shim to chrome/browser/apps/app_shim
(c/b/apps didn't exist until a few months after src/apps/app_shim).

The shim itself (i.e. chrome_main_app_mode_mac.mm) doesn't run in the
browser process - it has its own, shim process. Those parts are moved to
a new folder: src/chrome/app_shim, consolidating files currently spread
across src/apps/app_shim and src/chrome/app.

app_shim_launch.h and app_shim_messages.h are used in both the shim
process and the browser process. They're moved to chrome/common/mac.

Summary of changes:
  {apps => chrome/browser/apps}/app_shim/*
except
  {apps => chrome}/app_shim/chrome_main_app_mode_mac.mm
  {apps/app_shim => chrome/common/mac}/app_shim_launch.h
  {apps/app_shim => chrome/common/mac}/app_shim_messages.h
  app_shim.gypi renamed to browser_app_shim.gypi
  chrome/app_shim/app_shim.gypi added
and
  chrome/{app => app_shim}/app_mode-Info.plist
  chrome/{app => app_shim}/app_mode_loader_mac.mm

- apps/app_shim/DEPS now just generated_resources.h
- 'app_mode_app' target moved from chrome.gyp to app_shim.gypi

BUG=266705

Review URL: https://codereview.chromium.org/585123004

Cr-Commit-Position: refs/heads/master@{#296576}

With this change they take about 1 hour 25 minutes to cycle.

Next step is likely swarming net_unittests.

BUG=387743
R=jam@chromium.org

Review URL: https://codereview.chromium.org/525613003

Cr-Commit-Position: refs/heads/master@{#296575}

In followup patches, I'll remove the now empty testers.

BUG=414808
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/603013002

Cr-Commit-Position: refs/heads/master@{#296574}

Revert of Revert of [AiS] Merge answers into highest-scoring result (patchset #1 id:1 of https://codereview.chromium.org/598253002/)

Reason for revert:
Broken GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/13101

Original issue's description:
> Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/)
>
> Reason for revert:
> The new tests are flaky:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > [AiS] Merge answers into highest-scoring result
> >
> > Answer contents and type must always be copied to the highest-scoring
> > suggestion, to ensure answers are not lost due to suggestion
> > deduplication.
> >
> > BUG=415836
> > R=mpearson
> >
> > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922
> > Cr-Commit-Position: refs/heads/master@{#296520}
>
> TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=415836
>
> Committed: https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7
> Cr-Commit-Position: refs/heads/master@{#296555}

TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415836

Review URL: https://codereview.chromium.org/599273002

Cr-Commit-Position: refs/heads/master@{#296573}

Lots of crash reports from SGS devices running JB, mostly galaxy S3
A driver bug is filed against samsung

BUG=365494

Review URL: https://codereview.chromium.org/602953002

Cr-Commit-Position: refs/heads/master@{#296572}

Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #4 id:60001 of https://codereview.chromium.org/589213003/)

Reason for revert:
May be crashing Chrome:
https://code.google.com/p/chromium/issues/detail?id=417511

Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}

TBR=raymes@chromium.org,dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384528

Review URL: https://codereview.chromium.org/601923003

Cr-Commit-Position: refs/heads/master@{#296571}

This CL adds a few more tests to app_shell_browsertests:
WebViewAPITest.TestAllowTransparencyAttribute
WebViewAPITest.TestAutosizeAfterNavigation
WebViewAPITest.TestAutosizeBeforeNavigation
WebViewAPITest.TestAutosizeHeight
WebViewAPITest.TestAutosizeRemoveAttributes
WebViewAPITest.TestAutosizeWithPartialAttributes

BUG=352293

Review URL: https://codereview.chromium.org/604443003

Cr-Commit-Position: refs/heads/master@{#296570}

There were several consumers assuming that the returned hosts had no brackets.

BUG=417417

Review URL: https://codereview.chromium.org/602973002

Cr-Commit-Position: refs/heads/master@{#296569}

This gets two changes:

  Rename GN public variables.

  Lock page in LoadFXAnnot to prevent unintended page closing

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/594383004

Cr-Commit-Position: refs/heads/master@{#296568}

This is to make sure the starting list of account
mapping properly reflects the mappings present in the
previous Chrome session.

BUG=374969

Review URL: https://codereview.chromium.org/600053002

Cr-Commit-Position: refs/heads/master@{#296567}

BUG=416829
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/598233002

Cr-Commit-Position: refs/heads/master@{#296566}

The test has been broken since MojoBootstrap was introduced.
The change makes it impossible to inject failure from the ChannelMojo
subclass.

This change uses large data as pending message to trigger failure,
instead of overloading IPC::ChannelMojo functions.

R=viettrungluu@chromium.org
BUG=417439

Review URL: https://codereview.chromium.org/598093006

Cr-Commit-Position: refs/heads/master@{#296565}