- 15 Jun, 2020 40 commits
-
-
Sergey Ulanov authored
This reverts commit 28bafce9. Reason for revert: Flake due to the tests timing out. Original change's description: > Reland "Reland "Group tests of Trusted Types for WebUI"" > > This change groups tests of Trusted Types for WebUI into 10 WebUI pages > per test to minimize the size of the file. This change also fixes a bug > where `CallJavascriptFunction` might be called before allowing JS. > See: crrev.com/c/2242372 > > Bug: 41905 > Change-Id: I5f28e056ca3bcb3f39678e2b6009e66316848322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242656 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#777969} TBR=dpapad@chromium.org,Jun.Kokatsu@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 41905 Change-Id: Ica2a1b8b76e2cb2d6690514e336b6e5e42183f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246984Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778516}
-
Wan-Teh Chang authored
Add the boolean parameter premultiply_alpha to ConvertVideoFrameToRGBPixels((), default to true. This will be used by blink::AVIFImageDecoder. Change-Id: I2a9f2ab55c0dbfa4a9e44bd749cdee187088f33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243866Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#778515}
-
Brian Sheedy authored
Refactors the Skia Gold-related code in //content/test/gpu/gpu_tests to be the same as //build/android/pylib. All the code that interacts with Gold is encapsulated in its own class, and users simply run one method and check its output to perform an image comparison. Also adds a bunch of unittests (also taken from //build/android/pylib) since the split makes the code unittest-able. Drive-by fixes a related TODO in //build/android since the same TODO was fixed in the GPU code in this CL. Bug: 1093994 Change-Id: Id2fe1506796695f258069334149550cfaea49f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243718Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#778514}
-
Adam Langley authored
Currently, creation requests that specify public-key algorithms that an authenticator doesn't support can still be routed to that authenticator. When that happens, it fails immediately and we ignore it, so it never blinks. Instead, don't route such requests to the authenticators in the first place and replace them with dummy touches. BUG=1094066 Change-Id: Ie89c387887339f4dfc970a9f2205c6c354d141f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214100 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#778513}
-
Kyle Horimoto authored
Prevents the need for an extra OWNERS review for search tag screenshots. Change-Id: I5959ee4b10555025ad71f18c9dcb501604496104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246821 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#778512}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b7cf9d6efd4..359f70a9b525 2020-06-15 ddrone@google.com Merge "Initial Protozero extension support" 2020-06-15 treehugger-gerrit@google.com Merge "Add a trace-argument for per-frame state." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib5e434ad7a5406f5c5db3b305e49f079ba826feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778511}
-
Chris Lu authored
This change overrides bannerInfobarButtonWasPressed: to add a modal request if upload is on. This keeps consistency with existing implementations of save card. Bug: 1071914 Change-Id: Ia82426b15cd6d2aeb733934d085faead88bfb24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241866 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#778510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/add1180e0488..2c91b8d5a4b1 2020-06-15 awdavies@google.com [telemetry][fuchsia] dev_finder -> device-finder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I185c1c2a8a2c84a099303dc542a9a71011ba5100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778509}
-
Xing Liu authored
This CL adds a date time picker dialog for download later feature. The logic is not wired to DownloadDialogBridge yet. Bug: 1078454 Change-Id: I543f389a5c357db49e2f478533f2a367a46a06cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245932 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778508}
-
Lei Zhang authored
Fix policy and metrics files, where various owners entries use chromium.com instead of chromium.org. Change-Id: I92007a632f1f410d7e3a662f2fee3f5df9ec48a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245680Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#778507}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie8b3002cbf7ba01a539c391d40fd31d73a56a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245682Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#778506}
-
Rakib M. Hasan authored
Doing a git diff may be expensive. The deleted test files from the diff will already be in the set of deleted test files that are still referenced in test expectations. Bug: 1050760, 1050754 Change-Id: I7793af519df5e27596a7423acd44c25679ef8a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246944 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#778505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99e196c0..85169498 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d6d0b984610e9784cd4fb02b82690e643db476d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778504}
-
Kevin Ellis authored
Previously, the transition generation was updated when an ontransition event was generated; however, this timing is too late since a transition created after a style flush should be in a new transition generation even if in the same animation frame. Bug: 1095105 Change-Id: Ibf90a68b8f57357f3e26a98af7e10ee0d63b4bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246924Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#778503}
-
Vasiliy Telezhnikov authored
This CL replaces usages of CodecBufferWaitCoordinator in CodecImage with |is_texture_owner_backed| flag as the real usage of coordinator was moved to CodecOutputBufferRenderer and here we just need to distinguish between overlay/texture owner cases Bug: 1076564 Change-Id: Iaa55fdfe3ba1830eec3ec75fba21061918926ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246547 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778502}
-
Leonid Baraz authored
Fix for moveable objects handing by ASSIGN_OR_RETURN macro. Without this change, some of the added unittests do not compile. Bug:b:153361703 Change-Id: I0a511d2dc3256d110db63d75d96221203ab40b61 Change-Id: I0a511d2dc3256d110db63d75d96221203ab40b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242690 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#778501}
-
Justin Donnelly authored
This new header version will be used to run a second round of on-device experiments but with pre-period analysis this time. Bug: 1079341 Change-Id: I3bd554b014c21c270e4bd7b9873334c74ab94b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246624Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#778500}
-
Vasiliy Telezhnikov authored
This is first CL for cleanup after we started to use proper VideoFrame::visible_rect for Android. This code isn't used anymore. Bug: 1076564 Change-Id: Ibb29512f57346ab2c785031a909e839562949fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246180Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#778499}
-
David Bertoni authored
This CL removes using HTML pages to load scripts and converts tests to event page-based extensions. Bug: 1093066 Change-Id: I98ba6d2545bac20f1109cffa66cabece4207200b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240055Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778498}
-
Ben Joyce authored
Bug: 1005891 Change-Id: I68e4f08bd48d84d122f5920a3216ae7e3bc06ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246938Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778497}
-
Elly Fong-Jones authored
Bug: None Change-Id: Iaa77ee61ba63e9b2ec1412f844a1e4834c8cf4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246637Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#778496}
-
Anqing Zhao authored
Change-Id: Iba122adad93174ea75504d15c53cc9c9795ab52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246512Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#778495}
-
Andy Paicu authored
CL was reverted because tests failed on Android L, the problem being that the EME API call fails automatically on Android L. Disabled these tests before M. Original CL text: https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.2 all of which could be automated and are related to the "protected content" settings page. TBR=yfriedman@chromium.org Bug: 1063164 Change-Id: Ib5e76f5257e57abf6e96a33ac6257af0435ea0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246570Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778494}
-
Anastasia Helfinstein authored
Adjusts the focus ring colors for Switch Access to match the spec. AX-Relnotes: n/a. Bug: 1094069 Change-Id: Ie52bc7e7b5e46f24278f0c63f618224288102aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244113Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#778493}
-
Abhijeet Singh authored
Currently QuickAnswersPreTargetHandler cancels the active menu when its associated view is deleting, but never gets the chance to observe the deletion because it gets destroyed as a member field of the view before the view has had a chance to call the base class's ~View() that notifies the observers of deletion. This CL moves the menu-canceling logic to the event-handler's destructor instead of observing the view's deletion. This way the logic is executed when the view and along with it the handler is destroyed. Bug: b:158767170 Test: Tested on Chrome OS VM. Change-Id: I782b63d058083405d2d992ec8b23c6b5f0cfaaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242039 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778492}
-
Sadrul Habib Chowdhury authored
. Remove unused LatencyInfoProcessor and related code. . Clean up the public API for LatencyTracker. BUG=none Change-Id: I6b03d0ec5128f25513baf9ca924cf0ed0547d211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242685Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#778491}
-
Sergey Ulanov authored
This reverts commit b17b2a5b. Reason for revert: MediaFeedsServiceTest is flaking, see https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51421 Original change's description: > [Media Feeds] Add safe search check at feed level > > We already check the feed items against Safe Search > but we should also check the feed itself so we > can avoid fetching the feed if it is unsafe. > > BUG=1085095 > > Change-Id: I8546c372e6915512c7bb5ddde8ce379cb8cd14c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220275 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778395} TBR=tsepez@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I9e9206e8799606203e87e574030d30e5a8aaba9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246932Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778490}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4234d78201af..c3c2c9b6b09c 2020-06-15 rharrison@chromium.org Rolling 3 dependencies 2020-06-15 idanr@google.com Rolling 5 dependencies 2020-06-15 yunchao.he@intel.com D3D12: use one barrier to transit states for all subresources 2020-06-15 yunchao.he@intel.com Optimize subresource tracking - use texture view 2020-06-15 yunchao.he@intel.com Refactor subresource related variables to a struct - backend 2020-06-15 cwallez@chromium.org Texture: Change to mArrayLayerCount to mSize.depth If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I67969a766bcab7d3c95fa7cb20302b475f7bf062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778489}
-
Wan-Teh Chang authored
Accurately check if media::PaintCanvasVideoRenderer::ConvertVideoFrameToRGBPixels() (which uses libyuv under the hood) supports the YUV color space of the avifImage. Prefer libyuv over our own YUVAToRGBA() function because libyuv is much faster. libyuv is less accurate than YUVAToRGBA() (which uses floating-point arithmetic), so the pixel difference thresholds for three test images need to be increased. Bug: 960620 Change-Id: I3d9052a5e4e91d9ba5e9ae740814963a2204d19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244116 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#778488}
-
Emily Stark authored
This CL makes the omnibox behave as expected on blur under the hide-on-interaction and reveal-on-hover field trials. Specifically: - In hide-on-interaction, on blur the path remains visible but hides on the next user interaction. - When just reveal-on-hover is enabled, on blur the path should disappear until next hover. Bug: 1093881 Change-Id: Ie358537932ed116c3764cb54b161ba00b7c831e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242589 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#778487}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2c6b51469688..323c2565a364 2020-06-15 patrick.brosset@microsoft.com Avoid overlapping grid column and row labels 2020-06-15 zhin@chromium.org [third-party] Add acorn-numeric-separator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1086817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3386ce1ffb4f3d184499985fc312f9c7a6c4a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246745Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778486}
-
Ayu Ishii authored
This changes GetAllForUrl to return CookieWithAccessResult which includes CookieEffectivesSameSite data. This is so that it can eventually switch to use EffectiveSameSite for for CookieListItem SameSite which is mostly the same as SameSite except for when it is UNSPECIFIED in which case it will check for the SameSiteByDefaultCookies setting and whether the cookie is recently created. This is per github discussion here [1]. It is based off a change this parent change here [2], which returns CookieWithAccessResult data from GetCookieList. The switch to have EffectiveSameSite be returned to the client will be implemented in a future CL tracked here [3] once all endpoints can consistently return CookieEffectivesSameSite. [1]https://github.com/WICG/cookie-store/issues/102 [2]https://crrev.com/c/2212697 [3]https://crbug.com/1092695 Bug: 1065010 Change-Id: Id5aa68770491506b62443db985d6594ba70bb6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208410 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#778485}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I093c33fba938e7e5d406502f9bce55e8ca459b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246930 Auto-Submit: Zach Trudo <zatrudo@google.com> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#778484}
-
Anastasia Helfinstein authored
When a Switch Access user selects a window, it should focus the window. AX-Relnotes: n/a. Bug: 1094400 Change-Id: Iae0049d0051ae6ab395d5e6b816978bfccd0ecb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243838 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778483}
-
Anastasia Helfinstein authored
This adds support for switches that send key codes mapping to keys representing the arabic numerals 1-5, as a short-term solution to supporting more switch devices. The long-term solution will be to assign switches by pressing them, but the amount of design and engineering work required for that makes it infeasible for the initial launch. It is tentatively planned for a subsequent milestone. AX-Relnotes: n/a. Bug: 864809 Change-Id: Ieeffa9f2dcdb55d7363e2802c87152ad784cb495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240067 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#778482}
-
Gil Dekel authored
This CL modifies IsPrivacyScreenSupportedOnInternalDisplay() to return true only when the current internal display is not disabled (i.e. returns a valid current_mode()). This is done so the UI can update accordingly and remove the privacy screen pod when there's a the internal screen is disabled (e.g. when an external monitor is connected and the lid is closed; AKA docked device). Bug: b:157775487, 1090385 Change-Id: Ia51d8e5b6cad48259e1114c4e61b194f97b1ff28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246186 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#778481}
-
Panos Astithas authored
Bug: 646113 Change-Id: Ida1310943dd8130f3281aa9f4003dd320a8b3444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244460Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Panos Astithas <pastithas@google.com> Cr-Commit-Position: refs/heads/master@{#778480}
-
Henrique Nakashima authored
This CL moves to the tabmodel module the following classes: - TabModelSelector - TabModelSelectorObserver - EmptyTabModelSelectorObserver - TabModelFilterProvider Bug: 1090033 Change-Id: I11f471c105e2679e5b5c8e2317e0d50162dcf45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239901 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#778479}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I08170fb9b8412cd77903dd3f4bb2a7b4ae4c2216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243357 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778478}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I89764965c649837fe070f5711d6bee66e7a12f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242688 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778477}
-