GitLab

Revert of Split Screen mode implementation. (patchset #3 of https://codereview.chromium.org/461503002/)

Reason for revert:
Breaking "Linux Chromium OS ASan LSan Tests (3)" http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2721

Original issue's description:
> Split Screen mode implementation.
> 
> Implements Split Screen mode and window cycling behavior.
> Resubmit of https://codereview.chromium.org/420603011/
> 
> TBR=oshima@chromium.org,mukai@chromium.org
> 
> BUG=383421
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289064

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383421

Review URL: https://codereview.chromium.org/468053002

Cr-Commit-Position: refs/heads/master@{#289208}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289208 0039d316-1c4b-4281-b951-d872f2087c98

Segfault occurs in internet_options_handler.cc when accessing a
non-existent policy. This was introduced in https://crrev.com/427903004.

Please note: http://imgur.com/sD3vz0W.jpg

BUG=403111
R=pneubeck@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/470433002

Cr-Commit-Position: refs/heads/master@{#289201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289201 0039d316-1c4b-4281-b951-d872f2087c98

This file was just a placeholder, including blink_test_environment.h
waiting for Blink to be updated.

Now that Blink was updated and rolled into Chromium, we can remove it.

Chromium side (part 1) ->
https://src.chromium.org/viewvc/chrome?revision=288636&view=revision
Blink side (part 2) ->
https://src.chromium.org/viewvc/blink?revision=179977&view=revision
Chromium side (part 3) -> this patch

BUG=None
TEST=webkit_unit_tests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/463603003

Cr-Commit-Position: refs/heads/master@{#289200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289200 0039d316-1c4b-4281-b951-d872f2087c98

- keyboard overlay and partial_screenshot overlay should do nothing
  if there are already overlays.
- overlay_event_filter should cancel the existing delegate if
  another delegate is trying to activate.

BUG=341958
R=jamescook@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/461093003

Cr-Commit-Position: refs/heads/master@{#289199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/465143002

Cr-Commit-Position: refs/heads/master@{#289198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289198 0039d316-1c4b-4281-b951-d872f2087c98

Decoders can register to get notified when a Decryptor is set.
setContentDecryptionModule() provides a new Decryptor to
WebMediaPlayer. Since the decoders run on the media thread, it may
take some time for the old Decryptor to get detached and a new one
connected. Adding a callback to be used so that
setContentDecryptionModule() knows when the Decoders are done with
the notification. The additional callback is optional. This will be
used to resolve the setMediaKeys() promise on the blink side.

BUG=358271
TEST=media unittests and EME layout tests pass

Review URL: https://codereview.chromium.org/416333011

Cr-Commit-Position: refs/heads/master@{#289197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289197 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289195}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289195 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

Review URL: https://codereview.chromium.org/467943002

Cr-Commit-Position: refs/heads/master@{#289194}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289194 0039d316-1c4b-4281-b951-d872f2087c98

Notify the ContentViewClient of selection and insertion-related events,
allowing customized behavior depending on the state of selection. This is
particularly relevant for informing how the selection text string is being
updated.

BUG=400824

Review URL: https://codereview.chromium.org/469483002

Cr-Commit-Position: refs/heads/master@{#289193}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289193 0039d316-1c4b-4281-b951-d872f2087c98

Has a JavaScript file that contains a function to tell whether or not a
page is an article and related functions to get a string of that JavaScript
so that it can be injected into the page.

BUG=383630

Review URL: https://codereview.chromium.org/464973002

Cr-Commit-Position: refs/heads/master@{#289192}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289192 0039d316-1c4b-4281-b951-d872f2087c98

This changes the currently unused V8ObjectVar to store a pointer to the
instance rather than a PP_Instance ID. This is just more convenient for
the code which uses the V8ObjectVar. When the instance is deleted, the
pointer will be cleared so it should always be valid or NULL.

BUG=351636

Review URL: https://codereview.chromium.org/464653003

Cr-Commit-Position: refs/heads/master@{#289191}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289191 0039d316-1c4b-4281-b951-d872f2087c98

Made changes based on new API level to make Lint happy in all
builds.

BUG=327768

Review URL: https://codereview.chromium.org/460453002

Cr-Commit-Position: refs/heads/master@{#289190}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350219
TBR=thestig

Review URL: https://codereview.chromium.org/460183002

Cr-Commit-Position: refs/heads/master@{#289189}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402728

Review URL: https://codereview.chromium.org/464693002

Cr-Commit-Position: refs/heads/master@{#289188}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289188 0039d316-1c4b-4281-b951-d872f2087c98

booleans in Mojo messages":
(http://src.chromium.org/viewvc/chrome?view=revision&revision=282182)

Use ArrayOf(PackedBool) instead of ArrayOfBoolArrayPointers. This makes
it easier for the TBD JS message validator to retrieve the type of an array's
elements. It's also a little more consistent with the rest of codec.js.

BUG=402601

Review URL: https://codereview.chromium.org/460063002

Cr-Commit-Position: refs/heads/master@{#289187}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289187 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorkerCacheStorage currently expects to have its public
functions run by a SequencedTaskRunner.

This CL changes the functions to run on the calling thread and only
uses the TaskRunner for blocking operations.  This way, when calling
the cache and blob storage, we're on the calling thread (IO).

Also added some comments along the way.

BUG=392621

Review URL: https://codereview.chromium.org/460683002

Cr-Commit-Position: refs/heads/master@{#289186}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289186 0039d316-1c4b-4281-b951-d872f2087c98

Moves ForceEnableZoom, UserSetForceEnableZoom, and 
FontScaleFactor preferences upstream and adds support for
observing all those preferences in Java.

UserSetForceEnableZoom is currently stored using Android
SharedPreferences, which are application global, so this
class is currently not keyed off the profile. Preferably
this should be migrated to be per profile, at which point
the FontSizePrefs could be keyed off the profile instead of
being an application global singleton.

BUG=383630

Review URL: https://codereview.chromium.org/415343002

Cr-Commit-Position: refs/heads/master@{#289185}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289185 0039d316-1c4b-4281-b951-d872f2087c98

We migrated to the new kToolbarSize pref over four years ago.  I think this is
safe to remove. :)

Review URL: https://codereview.chromium.org/451193003

Cr-Commit-Position: refs/heads/master@{#289184}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403143

Review URL: https://codereview.chromium.org/469583003

Cr-Commit-Position: refs/heads/master@{#289183}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289183 0039d316-1c4b-4281-b951-d872f2087c98

This helps check that the pexe fetch is able to happen before
the component files are accessed. Otherwise, if the component
files are accessed before the pexe fetch, then it will error
out early, and the PNaCl on-demand installation will not happen.

Followup to Justin's fix: https://codereview.chromium.org/453073002
I tested that without Justin's fix, this patch will make the test catch the error.

BUG=401755

Review URL: https://codereview.chromium.org/467863002

Cr-Commit-Position: refs/heads/master@{#289182}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289182 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix for race condition where print preview hangs when attempting to print a PDF that hasn't loaded. (https://codereview.chromium.org/427723004/)

Reason for revert:
The changes fix an issue, but cause a more serious one. 

crbug.com/402402

Original issue's description:
> Fix for race condition where print preview hangs when attempting to print a PDF that hasn't loaded.
> 
> If |type| in RequestPrintPreview() equals PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME and |is_loading_| is true, RequestPrintPreview() returns,
> then is called again, right after |is_loading_| is set to false in DidStopLoading(). 
> 
> 
> BUG=376969
> TEST=See bug for steps to reproduce.
> 
> Additional way to reproduce:
> Build blink_tests and browser_tests in out/Release. Then in src/webkit/tools/layout_tests run this command:
> ./run_webkit_tests.py --platform browser_test.linux source_pdf/
> 
> you can replace linux with win or mac depending on your platform.
> 
> The program will attempt to save a PDF as a PDF through print preview. It will eventually fail because Print Preview will hang due to this bug.
> If you want visual confirmation that this will happen open:
> src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py.
> 
> Then add this line of code to the function cmd_line.
> cmd.append('--enable-pixel-output-in-tests')
> 
> Then run the script again. Enabling pixel output will also make it significantly more likely for the bug to occur.
> Its also more likely to happen on windows for some reason.
> 
> This is how I came across the bug.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287982

Review URL: https://codereview.chromium.org/463123004

Cr-Commit-Position: refs/heads/master@{#289181}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289181 0039d316-1c4b-4281-b951-d872f2087c98

In Cast Streaming we used to fail if coded size of the video frame
doesn't match the configured resolution.

This should be changed to natural size because one some hardware the
capturer can pad the video frames to encode efficiently.

BUG=402501

Review URL: https://codereview.chromium.org/467913002

Cr-Commit-Position: refs/heads/master@{#289179}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388517
NOTRY=true

Review URL: https://codereview.chromium.org/466203002

Cr-Commit-Position: refs/heads/master@{#289178}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396738

Review URL: https://codereview.chromium.org/462313002

Cr-Commit-Position: refs/heads/master@{#289177}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289177 0039d316-1c4b-4281-b951-d872f2087c98

to initialize requests in WebURLLoaderImpl.

BUG=394645

Review URL: https://codereview.chromium.org/453133002

Cr-Commit-Position: refs/heads/master@{#289176}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289176 0039d316-1c4b-4281-b951-d872f2087c98

With the workaround in r286800, mailbox synchronizer skips tile
textures, so is compatible with async transfer egl.

This is a partial revert of r286501.

BUG=399311

Review URL: https://codereview.chromium.org/463563002

Cr-Commit-Position: refs/heads/master@{#289172}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289172 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289171}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289171 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180091:180116&mode=html
TBR=zerny@chromium.org,adamk@chromium.org
BUG=

Review URL: https://codereview.chromium.org/462293002

Cr-Commit-Position: refs/heads/master@{#289169}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289169 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289167}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289167 0039d316-1c4b-4281-b951-d872f2087c98

These changes create support for GetFormattedUrlFromOriginalDistillerUrl,
which is necessary for reformatting the original distiller URL for
display in the Location Bar.

BUG=383630

Review URL: https://codereview.chromium.org/454063003

Cr-Commit-Position: refs/heads/master@{#289166}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289166 0039d316-1c4b-4281-b951-d872f2087c98

This test failed with impl-side painting because PictureLayer did not
skip commits caused by invalidating the layer during Update.

Meanwhile, this CL has some changes that changed the flaky failures
into always-failures. The change is to make the
ThreadProxy::CommitPendingForTesting check not only if a main frame is
in progress, but also if one will happen in the future. The failure was
flaky because the commit would be requested but not happen immediately
when impl-side painting was on due to activation (if the machine was
suitably loaded at the time). I renamed CommitPendingForTesting to
MainFrameWillHappenForTesting because "CommitPending" is a specific
notion in the public API of the scheduler and I didn't want to confuse
these two.

R=ajuma, brianderson, enne
BUG=402449, 397120

Review URL: https://codereview.chromium.org/462803002

Cr-Commit-Position: refs/heads/master@{#289165}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289165 0039d316-1c4b-4281-b951-d872f2087c98

* First, this was to remove blink_common_resources target that was moved
* into third_party/WebKit/public:resources.

* Second, the above clean up reduced webkit/BUILD.gn into a single
* target that could be moved closer to webkit_resources.grd, becoming
* webkit/glue/resources/BUILD.gn and //webkit/glue/resources target,
* which is much more inline with the GN philosophy.

BUG=400860
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=brettw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/458053002

Cr-Commit-Position: refs/heads/master@{#289163}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402728

Review URL: https://codereview.chromium.org/463753002

Cr-Commit-Position: refs/heads/master@{#289162}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/451953002

Cr-Commit-Position: refs/heads/master@{#289161}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289161 0039d316-1c4b-4281-b951-d872f2087c98

When source target and destination target is GL_TEXTURE_2D, we can use
glCopyTexImage2D() directly. It avoids gl state changes, program binding and
drawing call.

|dest_target| of DoCopyTexture() is always GL_TEXTURE_2D, so remove the
redundant argument.

Perf data are as follows:
Linux (Intel IvyBridge i7-3520M): 16 us vs 6 us -> 260% faster
Android (Nexus 5): 331.8 us vs 252.7 us -> 31% faster

BUG=N/A

Review URL: https://codereview.chromium.org/374193002

Cr-Commit-Position: refs/heads/master@{#289160}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289160 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289159}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289159 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Make landmines work on local builds too (patchset #3 of https://codereview.chromium.org/457003004/)

Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):


Traceback (most recent call last):
  File "src/build/landmines.py", line 132, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 119, in main
    gyp_environment.SetEnvironment()
  File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
    with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'

Original issue's description:
> Make landmines work on local builds too
> 
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
> 
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
> 
> R=iannucci@chromium.org
> BUG=400011
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011

Review URL: https://codereview.chromium.org/469623002

Cr-Commit-Position: refs/heads/master@{#289158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289158 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org

Review URL: https://codereview.chromium.org/461313002

Cr-Commit-Position: refs/heads/master@{#289157}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289157 0039d316-1c4b-4281-b951-d872f2087c98

Replace "phone" with "Android phone" in the notification body.

BUG=402269
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/460283002

Cr-Commit-Position: refs/heads/master@{#289155}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289155 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: uninitialize memory access

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio

> Use RE string pattern matching for blacklist strings.
> 
> Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor,
> and machine_model_name.
> 
> BUG=396578
> TBR=piman@chromium.org
> TEST=gpu_unittests
> 
> Review URL: https://codereview.chromium.org/452293002

TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/465163002

Cr-Commit-Position: refs/heads/master@{#289154}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289154 0039d316-1c4b-4281-b951-d872f2087c98