- 19 Sep, 2020 27 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df123b290f75..244d77022cb2 2020-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I80b8effb211c490a47f3ab7a92f0954087a5be40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808623}
-
Yuke Liao authored
libmojo_core.so is generated by the a shared_library rule, which always outputs the .so file inside: ${root_build_dir}/${toolchain_used_to_compile} directory. Bug: 1129223 Change-Id: Ib2937510363ccc4db7df09d000d260d344aed4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419149Reviewed-by:Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#808622}
-
David Maunder authored
In backShouldCloseTab we should not try to close the Tab if the Tab is not initialized. Bug: 1117396 Change-Id: I7ef0b4e50315ddc9560b438c66a7f66161c5e1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410920Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#808621}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31d58940..80dc1e80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93b541c612609ea2142019bc9a219c2684e42f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419475Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808620}
-
David Schinazi authored
This change cleans up the codebase and prepares us for using multiple versions in DefaultSupportedQuicVersions(). Our current plan is to eventually set it to (h3-29,h3-Q050) if our latest experiments in Stable go as planned. R=renjietang@chromium.org Change-Id: Ie1f6b35b42df07f65a8d800616e8f34427282913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419150 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808619}
-
Moe Ahmadi authored
Frequency component must be multiplied by recency decay in numerator. See: http://shortn/_bW5Qq2zTHM Bug: 1096615 Change-Id: I5138dce685607c44289dcab8b42a22968fc8ea0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419533 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808618}
-
Daniel Murphy authored
The WebAppProvider can be uninitialized. Dependencies should use the on_registry_ready() signal. This change is a quick & mergeable fix for a related crash, after which the codepaths will be turned async if possible. TBR-ing dominick so this change can get a canary roll, and they can look at it when they get in on Monday. Patch is very low-risk - resolving crash when there used to be a crash. R=pwnall@chromium.org TBR: dominickn@chromium.org Bug: 1129921 Change-Id: I57c6d4f181f28c178df85c60626423a5619f9494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419537 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808617}
-
Sophie Chang authored
Bug: 1086227 Change-Id: I6e144c0d858e88206b768293ca237d5aa56efc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417532 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#808616}
-
Yuke Liao authored
out_camera_app_dir is constructed by: 'out_camera_app_dir = "$root_out_dir/resources/chromeos/camera"', which already has a toolchain name inside the path if compiled by non-default toolchain. 'out_camera_app_dir' in the grit_flags is supposed to be relative to the target_gen_dir according to grit_rules.gni, therefore, when rebasing, it needs to be rebased against root_out_dir instead of root_build_dir so that the toolchain name bits can be stripped off. Bug: 1129223 Change-Id: Ib2a5bf62f2f5957613398e03e20402c95896801e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419658Reviewed-by:
-
Brian Sheedy authored
Sets --expected-vendor-id for info_collection_tests on the ARM-based Mac DTKs, as we don't currently request a specific GPU for tasks and thus cannot determine it automatically during JSON generation. Bug: 1105656 Change-Id: I0f9a527bb1797dcc8af293b6fed9405bae9732dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419542 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808614}
-
wutao authored
Changes: 1. When get settings fails, we will use backoff policy until max retries. 2. However, we will request settings immediately if the request is called from Settings UI. Bug: b/152921891 Test: added new tests Change-Id: Ied3f02b7dcb24d6fb95b528bac932987b9ee3ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410299 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808613}
-
David Maunder authored
Bug: 1060181 Change-Id: I57ab52c6a8113370829a902d53a1544e9a6a0cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382734Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL supports also_build_ash_chrome arg to allow building ash-chrome in an alternate toolchain. A few other fixes are required to work, but they will be landed in separate CLs because they could affect existing builds, so landing them separately will make it easier to reason and detect potential breakages. Bug: 1129223 Change-Id: I94dc3dc1ca2bc96f029fea3c4f4d6e41d018e2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416999 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Mark Mentovai authored
This enables x86_64 Chrome to run under Rosetta binary translation on arm64 macOS systems. The system page size is no longer considered a compile-time constant on macOS. It may be determined dynamically at run time through the vm_page_size variable. The related vm_page_shift and vm_page_mask variables are also available. On arm64, the system page size is currently 16kB. On x86_64, it’s 4kB. x86 code running translated on currently available arm64 systems (the Apple Developer Transition Kit) is subjected to the arm64 system’s native 16kB page size, meaning that code built with an expectation of 4kB pages, previously correct for native x86_64, will not work correctly in the translated environment. This is significant because the DTK is the only mac-arm64 system available for testing now, and it’s become important to test x86_64 Chrome under Rosetta translation on arm64. To overcome this limitation, the system page size and related constants are, on macOS, made to be determined at run time on the basis of the variables provided for this purpose by the system. In order to make this change without violating Google’s and Chrome’s prohibition against load-time initializers, the variables that had been used to convey page size information need to become functions. On all platforms except for macOS, the functions remain constexpr, are marked to be always inlined, and continue to return the same compile time-determined value they had in the past, so while it appears invasive, this change is in fact physically a no-op on these platforms. On macOS, it is a functional no-op change, except when running x86_64 code on arm64 under Rosetta translation, where it causes correct values to be used for the run-time environment. Adopting a compile-time 16kB page size on mac-x86_64 was considered but rejected due to the potential for memory footprint and performance impact. That approach would result in a behavior change for native x86_64 users, which constitute the vast majority of consumers of the x86_64 build, for the benefit of the comparatively small number of arm64 users running x86_64 Chrome under translation. This is undesirable, particularly for a change that may need to be merged to more stable branches. Apple documentation links: https://download.developer.apple.com/Documentation/Universal_App_Quick_Start_Program_Resources/DTK_Release_notes.pdf “Rosetta 2 Behaviors…Applications that depend on a 4K memory page size will not run. Examples of this may include some web browsers and language runtimes.” Also: https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code#3616877 https://developer.apple.com/videos/play/wwdc2020/10214/?time=544 (9:04) Bug: 1102194 Code-Word: disaster CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I143f38f06444f96eb8a82ede34f2a44ea48318fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361202 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808610}
-
Mike Wittman authored
This configuration solely controls the ThreadProfiler, so rename it to be consistent with the naming of that class and with future code in support of enabling the ThreadProfiler on a per-thread basis. Bug: 1129939 Change-Id: I20d19abe579cabaf7a355182f164898c12861c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418675 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808609}
-
Nico Weber authored
- Mention that we now have a tester bot and link to it - Put actual build instructions to top of the "Building" section - Add some text about copying files to the DTK, and mention quarantine error messages, so that search engines can index them Bug: none Change-Id: I5b5f042280b6077ad89e217e4bf907f4b4c12fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418984 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#808608}
-
Yue Li authored
Bug: b/150034512 Test: Manual Test Change-Id: I87a02b3d0ef65a2e6a26c663fe2ee66d43331423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419263 Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Dirk Pranke authored
A "raw" test type in MB was a test executable that didn't conform to one of the other supported test harness APIs (like the chromium gtest api or the test executable API), and which we would handle by simply running the executable and returning the status code. There was no real need to support this directly; it turns out that every raw test that we current run should've either actually been a gtest-based test or was handled by a generated wrapper (for the ChromeOS Tast-based tests). Fixing this and removing support for "raw" test types allows us to simplify MB a bit but more importantly gets us one step closer to having only one supported API for tests. Bug: 816629 Change-Id: I831efa949614719a8aa5106c5ab5c1c0c48b5059 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380439 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808606}
-
Peter Boström authored
Most of these methods forward to |model_| and then return *this. Inlining these reduces boilerplate. Bug: 1106422 Change-Id: I19724548e73e117f32c38c88fae5c5beaf3f6741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419142 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808605}
-
Yulun Wu authored
Bug: 1110766 Change-Id: I832431d2c500080143bb2b470553764d7262097e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417653 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808604}
-
Kalvin Lee authored
This change moves the Restrictions struct (public in the declaration of PpdProvider) into the PPD metadata parsing code. This is not the change where we cut away the v2 PpdProvider, though, so we retain the old struct definition as PpdProvider::LegacyRestrictions. In addition, this change modifies the semantics of Restrictions; metadata that can be restricted now always contains Restrictions structs, but the struct's members (max and min milestones) are now optional. Bug: chromium:888189 Test: chromeos_unittests Change-Id: I03a3825ec2150e8db93a2187d11285afcd44b07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393615 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808603}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be0a9ca63d9d..ca4d074d54ab 2020-09-18 johnstiles@google.com Fix unit test for InlinerWrapsEarlyReturnsWithDoWhileBlock. 2020-09-18 johnstiles@google.com Add unit test for a dead do-while loop. 2020-09-18 bsalomon@google.com Expand SkYUVAInfo::PlanarConfig/SkYUVAPixmapInfo::DataType values. 2020-09-18 csmartdalton@google.com Fix CanvasKit warnings compiling on Mac with emsdk 2.0.0 2020-09-18 johnstiles@google.com Add program-settings flag to disable the inliner. 2020-09-18 mtklein@google.com quad-pump avx2 and up 2020-09-18 robertphillips@google.com Switch the thread-safe proxy cache over to using an arena for its entries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: scroggo@google.com Change-Id: Ie69b9281937728bea0132439962ae326e110610d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419625Reviewed-by:
-
Nate Chapin authored
* Use LocalDOMWindow rather than LocalFrame/Document for most things. * Change probe::WindowOpen() to take a KURL rather than a url String, to avoid an unnecessary CompleteURL() call. * Remove an obsolete TODO, which refers to a Frame being remote when at a point where it is known to be local. Change-Id: I0860485758fa1ff12843bf965e03c9816e5f2390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414277 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#808601}
-
Daniel Libby authored
This flag is still WIP, but in the meantime it doesn't need to part of about:flags as we don't expect users to toggle it. R=kschmi@microsoft.com Bug: 1110626 Change-Id: I849bd807b609ad39d384177ba081a1109749c90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417637 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Auto-Submit: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808600}
-
Brian Sheedy authored
Prepares the GPU pixel tests for the upcoming migration from a dedicated GPU Gold instance to the general Chrome instance by: 1. Including a combined hardware identifier that will allow us to make forwarding rules more precise. 2. Performing a duplicate, FYI version of the comparison in the Chrome instance in addition to the existing comparison in the GPU instance. Bug: 1113308, skia:10723 Change-Id: Ie6e9abb5e8b7edaec11bde63ece81a45d47792b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415089 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Update the string per design doc (see Bug). Also check ShouldShow() which was missed in the last CL due to rebase error. See screenshot at: https://photos.app.goo.gl/Ho4rr76RK4nnckJe7 Tbr: dcheng@chromium.org Bug: 1126568 Change-Id: I775715eba04f3ff243e3db8b73bba04a42771a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419578 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808598}
-
Elly Fong-Jones authored
This change adds support to Browser and BrowserWindow for a user-configured window title, and has that data persist across session restores. There is no UI for this feature (yet) so this code is only exercised by its own tests. Change-Id: I8235b1b73cea4d32d3c4c6e883c5815f10995ffc Bug: 1096586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204677Reviewed-by:
-
- 18 Sep, 2020 13 commits
-
-
Xianzhu Wang authored
1. Avoid LOG(ERROR) in paint related logging We used LOG(ERROR) (guarded by VLOG_IS_ON() and DCHECK_IS_ON()) for convenience when running chrome without --enable-logging=stderr to show the logs when they are enabled. However, the 'ERROR' tag was confusing to users. Now use DVLOG, VLOG or LOG(INFO). 2. Move graphics_layer_tree_as_text.* back to platform/graphics We moved it to core/paint/compositing when we added a dependency to core code. Now the dependency no longer exists. 3. Remove the change detection code for layer tree/list dump, to make them the same as other dumps, so that we can see complete dumps in verbose log for document lifecycle updates. Bug: 1107874 Change-Id: I2c1b9727bb3f46b87033855b2bf89302ced67428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419143Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808596}
-
Michael Bai authored
Bug: 1130093 TBR: wychen Change-Id: I685977da702ea612918002a923dc978866e5eb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419554Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#808595}
-
Tommy Li authored
This reverts commit efbdaef4. Reason for revert: Causes a crash with parameter names with colons in it. See the bug. Bug: 1130035 Original change's description: > flags: Add support for FEATURE_WITH_PARAMS_VALUE_TYPE feature in switches > > Fixed:805766 > Test:autoninja -C out/mychrome components_tests && ./out/mychrome > components_tests > TESTED=autoninja -C out_hatch/Release chrome && deploy_chrome > --build-dir=out_hatch/Release --device=$DUT > > Verified by setting a feature with param in chrome://flags on hatch > > Change-Id: I83f8c81237c3db50a4f23bf5b17e73363bf10504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401336 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806278} TBR=ellyjones@chromium.org,sweilun@chromium.org,joonbug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie50328d7c07c815f04157fd11103cd5393a03534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419591Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#808594}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None. Change-Id: I5bb22367303e0a84ce68ad6b4d083ec311d2b36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391596 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808593}
-
danakj authored
R=inferno@chromium.org Bug: 974462 Change-Id: I0e9a5201abaf1a6ee3a614c770f09789dc8b190f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417113 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#808592}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..862107080d58 2020-09-18 aerotwist@chromium.org Revert "Reland "Remove support for remote modules"" 2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules" 2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript 2020-09-18 aerotwist@chromium.org Adds remote base helper 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a900e51864e44892aaf27c22a13caf8b36c304d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419623Reviewed-by:
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None. Change-Id: Ibd14ecb887cdb6c59885292890d336966692ff7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389225 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Leonid Baraz authored
These defaults are misleading, since those of them that were different from 'false' were ignored everywhere. According to code search, the code in Chrome and ChromeOs always looks like: if (proto.has_PROPERTY()) { ... = proto.PROPERTY(); } or if (!proto.has_PROPERTY()) { return; } ... = proto.PROPERTY(); Bug: b:168328072 Bug: 1058092 Change-Id: I2b68ddf4316b3fb10ccccb749cbd4cb915df641a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418989Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#808589}
-
Michael Bai authored
Test manually, the persisted log loaded at next startup. Bug: 1076549 Change-Id: Ibfc273431b8ccd313435b55bdb1889b7c5913045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173960Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#808588}
-
Alexander Cooper authored
The runtime is no longer considered by default, as we prefer to use OpenXr. Thus, this runtime is now dead code, and should be removed Bug: 1100622 Change-Id: I4727186c63655848f0ae189e7aa13e9b42d0f73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415308Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#808587}
-
Haiyang Pan authored
* testRenderGrid_10WebTabs * testRenderGrid_10WebTabs_InitialScroll They become flaky after the emulator runs on n1-stardard-4 machines Also remove chrome_public_test_apk from the MM-x86-rel-non-cq builder since it already runs on MM-x86-rel Bug: 1077552, 1127110 Change-Id: I05d1b86e491cbd2bcd7d2b0fb7cec0c5672d2a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419651Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#808586}
-
Xinghui Lu authored
ClearSettingsForOneTypeWithPredicate iterates over all settings, which makes the cleanup O(N^2). To make it O(N), call SetWebsiteSettingDefaultScope with a nullptr as value instead. To make sure the cleanup doesn't cause the jank, add a cap to the number of removed verdicts in a single cleanup. Currently expired cache is cleaned up during shutdown. However, shutdown may not be performed on Android. To make sure the cache is not growing without limits, also start a task to cleanup periodically. stored_verdict_count_real_time_url_check_ is calculated per session. To include the verdicts that are stored on disk, count the verdict directly from HostContentSettingsMap. Bug: 1128669 Change-Id: I6a01060104b4773e276e9472a05aa2c9ab8267db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406150 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#808585}
-
Daniel Classon authored
Adds a util function to determine if Multidevice stubs should be used. Will be used in future CLs that add in the stubs. Bug: None Change-Id: I67bd7695a5b71b749d6447116da5dba9cd565499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406594 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808584}
-
