GitLab

In order to move more RenderWidget code into blink's WidgetBase, move
the VisualProperties IPC struct to blink.

No behavioral changes are intended with this CL.

BUG=1097816

Change-Id: Ie06908cd13292d99775d4ccf9861071214a526ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298228
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788680}

Touch drag-and-drop is enabled or disabled through WebPreferences
instead of a switch check in the renderer. The setting defaults to
the switch state but can be overridden.

The WebUI tab strip enables it always.

Bug: 229301
Change-Id: Ie3be6167f3c3c5d1fe21beb0238d6b2e0bdf05fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270848Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788679}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5521a43e1807ee35df76a4b90ff5520d75867ac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300222Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788678}

This reverts commit 412c3dd4.

Reason for revert: Ran the tests on bot 500 times no failure.
Reland the tests with minor changes

Original change's description:
> Revert "Add location delegation instrumentation tests"
>
> This reverts commit b7b42218.
>
> Reason for revert: the tests are flaky. See https://crbug.com/1099636
>
> Original change's description:
> > Add location delegation instrumentation tests
> >
> > Add some integration tests that runs javascript get geolocations and
> > verify results.
> >
> > Bug: 1069506
> > Change-Id: I368489922b13711b3e9d0f3d800a7cc3172a979c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249372
> > Reviewed-by: Peter Conn <peconn@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Ella Ge <eirage@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#782422}
>
> TBR=mthiesse@chromium.org,peconn@chromium.org,eirage@chromium.org
>
> Change-Id: I3b143731db0bcbae01f880cd1bb70474f0b32e22
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1069506, 1099636
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270321
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782922}

TBR=droger@chromium.org,mthiesse@chromium.org,peconn@chromium.org,eirage@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1069506, 1099636
Change-Id: Ieee32600afecf40dd28c4c92df8bc77f0341add5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292776
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788677}

https://skia.googlesource.com/skia.git/+log/14fdcdc891cc..06980dba90a4

2020-07-15 egdaniel@google.com Revert "Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)"
2020-07-15 egdaniel@google.com Add GrStagingBufferManager and use GrGpuBuffers to manage caching.
2020-07-15 reed@google.com rename SkMipMap to SkMipmap
2020-07-15 adlai@google.com Revert "Add a direct context arg to makeColorTypeAndColorSpace"
2020-07-15 kjlubick@google.com [canvaskit] Quick fix for older skp format

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC nifong@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: nifong@google.com
Change-Id: Id6e397ab67016443a932f45eb5d0067f4ead2282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300281Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788676}

Deleting app shortcuts results in time out on Windows 7 when profile
deletion tests are finished (https://crbug.com/1073451).

Bug: 1075896
Change-Id: I53e94e9059c8d4c9574ff09cc4cf43eba802707f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295142
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788675}

The content ScreenInfo struct isn't necessary if we expose the
WebScreenInfo struct in common. This may be eventually moved to a single
sole mojom definition but at this time the struct is used on IPC and
the public blink API so it needs to be in common.

BUG=1097816

Change-Id: I7ee5fb9a4c9e3210b1884d256a9386604174be56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298182
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788674}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25a5e06a7d17..6531f33eb2bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rogerm@google.com,melandory@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: rogerm@google.com,melandory@google.com
Change-Id: I32b71ac7bb49e54ff2f22f1dac14cd16aa2b4d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300280Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788673}

SkFontArguments started out with an 'Axis' type to specify the
coordinates arguments to a variable font. However, the individual
positions along an axis are referred to as 'coordinates', and the set of
coordinates is commonly referred to as a 'variation'. The term 'axis' is
used in SkFontParameters to refer to the axes themselves.

Use the newer 'VariationPosition' type so that Skia can remove the
somewhat ambiguously named 'Axis' type.

Change-Id: Iea072cfc9c2bc06efab3b18533db4da17289b310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298345Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788672}

When this was added, there was discussion around providing policy
controls around the AlwaysOnVpnLockdown network property, which was
why we added a wrapper in MNCH.

Since that never materialized, and since the one caller does not
implement either callback in release, this CL removes the MNCH
wrapper and removes the callbacks from the API to simplify it.

For DVLOG removal in components/arc/net:
TBR=hugobenichi@chromium.org

Bug: 1054441
Change-Id: Ib9581f22d4ed7f028694ef02db08294cf5ef014a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287388Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Philipp Weiß <phweiss@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788671}

This CL adds the necessary deps to chrome/browser/thumbnail/* to pass
`gn check`, which was previously failing on Android configs.

Bug: 1105848
Change-Id: Iecfd7c46dd7efe46e4f80a23042f7f2ee7a68bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300219Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788670}

Change-Id: I95ad1c549e7b30ad5d5981b869913c0f058e6f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296894
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788669}

We got a list of icons from UX per vertical, those are now added to
the client for easy use through local resources.

Bug: b/161337790
Change-Id: I118b4d2c2c9cb229165cfeccb058718f8580eece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299624
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#788668}

Changed PolicyMap::Set to the newer version which
passes value as base::Value instead of unique_ptr.

Bug: 2270317
Change-Id: Ic705313cf01496caceccd58b759ac3b214641d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299998
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788667}

Call FireWebUIListener instead of CallJavascriptFunction in
InlineLoginHandlerImpl. It will allow to get notification about the
event using cr.addWebUIListener instead of directly exporting the
function.

Bug: 1096007
Change-Id: Ib36630b1d618e1eec948d2f733e38bbe120c2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252144Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788666}

* Move OriginTrialContext from SecurityContext to ExecutionContext,
  since it is unused for RemoteSecurityContexts.
* Construct the OriginTrialContext directly in the ExecutionContext
  constructor, rather than requiring subclasses to do later. This
  requires removing one of the constructor variants that is only used
  for testing, so add SetTrialTokenValidatorForTesting() to
  OriginTrialContext for that test.
* SecurityContextInit is a FeaturePolicyParserDelegate. This is
  because it needs to provide access to the OriginTrialContext
   during FeaturePolicy calculation, because the ExecutionContext's
  OriginTrialContext was not set up when the FeaturePolicy was
  calculated. Now it is. Remove all of the plumbing related to
  SecurityContextInit being a FeaturePolicyParserDelegate, and pass
  SecurityContextInit::execution_context_ where needed instead.
* This means ExecutionContext is the sole FeaturePolicyParserDelegate.
  Have FeaturePolicyParser reference the ExecutionContext directly and
  remove the FeaturePolicyParserDelegate layer.

Change-Id: If57297f1bfefc72a5378dd55e6adc52d80ce8461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293475
Commit-Queue: Nate Chapin <japhet@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788665}

After the work to simplify the promotion and the install, there was work
needed to put the right version into the updater's Info.plist. Also
needed to alter the .install script's way of getting the product name to
account for channels. Also, getting the sequenced task runner handle
needed to happen in active duty as the AppServerMac ctor did not run on
a valid sequence.

Bug: 1105628
Change-Id: I75845700e78045cbe51e7c653ca479e060be0478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294569
Commit-Queue: Michael Chang <donchan@microsoft.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788664}

With the advent of the network service, a lot fewer files use
net::URLRequest than before, but there are still a lot of left over
includes. This CL removes many such unused includes in chrome/.

This CL also removes some other related includes as well.

This is the last CL in this chain - the chain collectively makes a
whitespace change in url_request and then building browser_tests go
from needed ~8000 steps to run down to needing only about 300.

Bug: 1103784, 1104380
Change-Id: I4618cb6fd5611f4449a6ff20849aa8153c93fc9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293195
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788663}

Bug: b:161266545
Change-Id: Ia50275969032a706299a77ef1d6cd8482fbd83cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298221Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788662}

This switches is a relatively well known switch, so the old version is
kept around and produces a deprecation LOG(ERROR) when used.

Bug: chromium:1101491
Change-Id: I89aea90514bfe3a6c5a52e960b8e9434520ffbfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289414
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788661}

Bug: 1104900
Change-Id: Ied3096ac58166b2a254e60220302e47ac53f2621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299723Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#788660}

DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the
case where nullptr is passed for the output argument, Value::RemoveKey()
is a trivial replacement.

Mostly done with the following command line, plus a bit of finesse:
% git grep -l RemoveWithoutPathExpansion | \
  xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g'

Bug: 646113

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Change-Id: I5779a8b0bb93ad00550de27beae1ac73681ae017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298862
Auto-Submit: Anand K Mistry <amistry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788659}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: If41d49c07b8aa0ca263470783db085eb6f1b8dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300223Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788658}

Bug: 1105869
Change-Id: I60c2501fa5134b9be1a52ad4cdedaef59dfa0633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299627Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#788657}

Converts self-contained instances of base::Bind/Closure/Callback (or
instances where base::Binds were passed into already converted
functions) to base::Once* or base::Repeating* versions as appropriate.
This does not fully convert the "loose" files at chrome/browser's root;
however, the other remaining files had more complex dependencies that
would likely warrant being their own change.

Bug: 1007635
Change-Id: Ideb1964f461365aeb65dee23c618a1e0227185e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296281Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788656}

Bug: 1068400
Change-Id: I66b343bfd929ab1f8d9fdf4393df42ea595bbc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295813Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788655}

If an external intent comes when Chrome shows a blocking UI, it should
be delayed until it is possible to execute it.

This CL considers the scene as not active if it is blocked.
The activities are stored in startupParameters when they are
received.
When the scene is unblocked, call handleExternalIntents to
execute it.

Bug: 1101786
Change-Id: I8117b0cd328847e03283f0d11fea825708594af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292475Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788654}

Reason for revert: The SignInManager is created post-native,
which is necessary for the visibility of Sign-in box.

Original change's description:
> [Instant Start] Show Sign-in box for Feed articles pre-native.
>
> Bug: 1086961
> Change-Id: If811181513eced84a7c92960520a5f8e5f398398
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218849
> Commit-Queue: Hao Dong <spdonghao@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776558}

Bug: 1104851
Change-Id: Id83faa05fd29c6b98c760fcec6ee1c758c494b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296452Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788653}

Change-Id: I561d5893976fac92acf02329bf13b7422a9a2e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279211
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788652}

mWindowAndroid==null is overloaded to indicate if ShareSheetController
is registered as an ActivityStateObserver. Setting it to null here
maintains that relationship.

Bug: 1093365
Change-Id: Ia33c96e57e0504ce50fb6cefcb34b14fdcf25136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298176Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788651}

PasswordManager.BubbleSuppression.DomainsWithSuppressedBubble
PasswordManager.BubbleSuppression.AccountsWithSuppressedBubble

PasswordManager.FillingAssistance gives enough information.

Fixed: 1104963
Change-Id: Ic7bc6c18c0f20f9fc6492d33d8ff1c3c53080003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299621Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788650}

The presubmit check reports an error when the feature policy enum is
modified: "*.json5 and *.mojom are out of sync"

This presubmit error is reported even when the files have identical
enum definitions due to a mistake in the error condition. Instead of
comparing the set of json5_enums with the mojom_source_path, compare
with the set of mojom_enums.

BUG=1105600

Change-Id: Ibc80ac41a37a2102e37edbbdbd6a8a77633051fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298225Reviewed-by: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#788649}

This adds a perf test for the current implementation of IDB putAll.
There is currently no trace for putAll but once a trace is added this
test will allow for putAll to be benchmarked.

Change-Id: If9ce6b07d727ded4e36fa190e6981d00636d2b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283512Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788648}

The custom Chromium errorprone plugins were unintentionally disabled
as a result of
https://chromium-review.googlesource.com/c/chromium/src/+/2133870

This CL re-enables the errorprone plugins by using the
auto_service_processor in the javac compile of the
errorprone_plugin java_binary. This preserves the META-INF service
provider configuration generated by auto_service_processor.

This CL:
- Adds the 'processor_generates_service_provider_configuration'
parameter to the java_annotation_processor() template to indicate
whether the annotation processor generates the META-INF service provider
configuration files. If a library depends on an annotation processor
which has the parameter set, the annotation processor will be
passed in the --processorpath and --processor parameters in the javac
compile in addition to the turbine compile.
- Adds the 'errorprone_stderr_path' to the java_library() template to
save the stderr output of the errorprone compile to a file.

BUG=1104558
TEST=errorprone_plugin:tests

Change-Id: If224e9a2cb62b3fae72ffb6664aa54770530672d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291983Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788647}

This updates move_source_file to deal with more generated mojo
headers. Previous patch only handled ".mojom.h". This patch adds
handling of other commonly included generated headers.

BUG=none
TEST=none

Change-Id: I99a1453bb72ed84af179eaa241d1283892e756a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297924Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788646}

https://dawn.googlesource.com/dawn.git/+log/3b17f0bde80c..212c5bd9b2f0

2020-07-15 sdefresne@chromium.org Convert GN libs lists to frameworks
2020-07-15 kainino@chromium.org Fixes for Emscripten generators

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1052560
Tbr: cwallez@google.com
Change-Id: If4a7d2dab4170ca76f6c9330e6976f7f89cf2265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788645}

Currently, ToggleImageButton relies on the tooltip text to provide the
accessible name.

In some circumstances, we want a more explanatory AX name than the
tooltip text, and this is supported by the base Button class.

This CL expands ToggleImageButton to support a different AX name than
the tooltip text, in both toggled and untoggled states.

Bug: 1099788
Change-Id: Icfdcaac4ba50ba233e33663df74a0c32680bce07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292724
Auto-Submit: Tommy Li <tommycli@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788644}

This reverts commit 7303c127.

Reason for revert: Play rolled back their change, this is not needed at this time.

Original change's description:
> Removing "uses-feature" from trichrome library.
> 
> Bug: b/161165552
> Change-Id: Ib9ff477541209344821828b5316679e2b51f71e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296450
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788203}

TBR=agrieve@chromium.org,benmason@chromium.org

Change-Id: I4ba83a17b5e96e8801263ccc595ef8d28da61461
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/161165552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300263Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788643}

This comes from the set of builders listed in Gatekeeper. They currently
don't have tree closing enabled, but after some discussion the decision
is to make them tree closers.

Bug: 1094768
Change-Id: I9b3209958c63dab878ea8b42a7d8b6bc54a3acad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296772
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788642}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/669d1401..b0b63703

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibb59f91910dbede7bef65f31d5903a6dd0a88e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300180Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788641}