- 07 Aug, 2018 40 commits
-
-
Ramin Halavati authored
TBR: georgesak@chromium.org Change-Id: I3606ab0a9b4118eb1f3dea5781411929a4ecae69 Reviewed-on: https://chromium-review.googlesource.com/1165342Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581225}
-
yoshiki iguchi authored
This CL add two methods in ArcMessageCenterLockScreenController. - IsEnabled() for visibility of lock screen notification - GetMode() for mode of lock screen notification Bug: b/111391270 Test: none Change-Id: Ieb41c6dcc78768cff12932a62f33153d4f3e172b Reviewed-on: https://chromium-review.googlesource.com/1164872 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581224}
-
Avi Drissman authored
This reverts commit c05ec33a. Reason for revert: Kills ASAN/MSAN bots; details in message Original change's description: > cros: Ignore clamshell only requests in tablet mode > > There is a bug where users can keep their clamshell mode context menu > open by detaching the keyboard. This allows users to have a side shelf > in tablet mode, and they may get stuck in this state. > > This CL prevents this from happening by ignoring the clamshell options > if they are somehow executed in tablet mode. > > Bug: 870469 > Change-Id: Ifb9638c3ae705bd58a2e785edc5ca84d698651d2 > Reviewed-on: https://chromium-review.googlesource.com/1161387 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581030} TBR=xiyuan@chromium.org,newcomer@chromium.org Change-Id: If3b5e2cf2b9f6012cb165412c54d1d0f15283a07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870469 Reviewed-on: https://chromium-review.googlesource.com/1165422Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581223}
-
Gabriel Charette authored
(base/task_scheduler/OWNERS needs to be removed in a follow-up because of crbug.com/870426) Bug: 870426 Change-Id: Id08ebf3a23705c7a0981ec320bee71cdd69d056f Reviewed-on: https://chromium-review.googlesource.com/1163307Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#581222}
-
Takuto Ikuta authored
This is to fix Deterministic Linux (dbg) builder. Removed mini_installer.exe and previous_version_mini_installer.exe too. Bug: 871760, 870584 Change-Id: Ieb85e844ceb9d5430f3870b26f98ffbe095ad539 Reviewed-on: https://chromium-review.googlesource.com/1165269 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581221}
-
Jérôme Lebel authored
This is a reland of 3b42f46a The original patch has been reverted with crrev.com/c/1162402. The issue has been fixed with crrev.com/c/1163714. This patch can be relanded. The patch is to start the UnifiedConsentService at startup. Original change's description: > [iOS] Start unified consent service at startup > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49 > Reviewed-on: https://chromium-review.googlesource.com/1159062 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580485} TBR: sdefresne Bug: 827072 Change-Id: I3332f38fb24d4ba77e75a70d0201bae71b56cc67 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1165062Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581220}
-
Nicolas Ouellet-Payeur authored
With the policy set to false, the browser used to crash when: - The user enters '?' as the first character in the omnibar - The user hits CTRL+K or CTRL+E to start a default search Bug: 869384 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7b98bd7a745a8e66ffd22b1f972a5110e89a568c Reviewed-on: https://chromium-review.googlesource.com/1162421Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#581219}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like these callsites can use the THREAD_POOL_EXECUTOR instead, since these usages don't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: If2c63496e7851db697e313429baa10508aeb4753 Reviewed-on: https://chromium-review.googlesource.com/1162691Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#581218}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eb73a7bd16c7..7008287219b6 git log eb73a7bd16c7..7008287219b6 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 nisse@webrtc.org Delete struct webrtc::PacketTime. 2018-08-07 titovartem@webrtc.org Fix guards for headers in third party 2018-08-07 yvesg@webrtc.org Fix random crashes - invariant broken in LinkedSet (LRU) implementation. 2018-08-07 mbonadei@webrtc.org Remove memcheck. 2018-08-07 mbonadei@webrtc.org Add 2 more OWNERS to tools_webrtc. Created with: gclient setdep -r src/third_party/webrtc@7008287219b6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8d85887aa6dab94214bc34734edabd5f4994a20f Reviewed-on: https://chromium-review.googlesource.com/1165202Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581217}
-
Rune Lillesveen authored
SitePerProcessHighDPIHitTestBrowserTest.RootWindowTransform/0 and SitePerProcessHitTestBrowserTest.RootWindowTransform/0 are reported as flaky. Disabling. TBR=riajiang@chromium.org Bug: 871321, 870744 Change-Id: I4003753932b98f83e509dfb0bea5f69b03eb7d1e Reviewed-on: https://chromium-review.googlesource.com/1164961 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581216}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=slan@chromium.org Bug: 589840 Change-Id: I9742e8415f6b34bad58acba7ccdc50e4d5ddf12e Reviewed-on: https://chromium-review.googlesource.com/1150282Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#581215}
-
jonross authored
There have been a series of failures of viz_content_browsertests on this bot, so I'm disabling until we have the chance to triage and fix them. TEST=viz_content_browsertests TBR=thakis@chromium.org Bug: 871519 Change-Id: I2aa18d2d73c877079a970258c6e3bf4bd9732e14 Reviewed-on: https://chromium-review.googlesource.com/1165107Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#581214}
-
Javier Ernesto Flores Robles authored
This adds the icon that will be used for addresses in manual fallback. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8790ac81cf35e82a059f80e08114fa81ff9dc679 Reviewed-on: https://chromium-review.googlesource.com/1163503Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#581213}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ec93d0df7d1..ef73f7b272a5 git log 1ec93d0df7d1..ef73f7b272a5 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 primiano@google.com Merge "Add ui/deploy script to deploy UI to appengine" Created with: gclient setdep -r src/third_party/perfetto@ef73f7b272a5 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3482f3692fcfe08ee15ec63b276efb78cf454888 Reviewed-on: https://chromium-review.googlesource.com/1164447Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581212}
-
Matt Menke authored
The test was using a notification to watch for the download that is only sent by the RDH, which is not used when the network service was enabled. Make the test use a download testing observer class instead. Since the test was the only thing using the notification, also remove the old notification from RDH. And remove a couple obsolete entries from testing/buildbot/filters/mojo.fyi.network_browser_tests.filter, while I'm modifying it. Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5e0cd2ecc1c7e10933ad1903e6eaa9c6fee83c61 Reviewed-on: https://chromium-review.googlesource.com/1162646Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Story has been flaky. NOTRY=true TBR=nednguyen@google.com Bug: 871708 Change-Id: Ie0b464376c7257be0d75c16ed80b12cafa2b7f1c Reviewed-on: https://chromium-review.googlesource.com/1165229Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#581210}
-
Peng Huang authored
Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5e8cfd0ad6fc86c6e4e1dcc5983f372a3a3142b3 Reviewed-on: https://chromium-review.googlesource.com/1160770Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581209}
-
Sami Kyöstilä authored
Change-Id: Ibb08b16a76fd89dbdd91cae4f6285d4007a9bf1e Reviewed-on: https://chromium-review.googlesource.com/1165162Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 501f8950. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22558 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy worker-dev@chromium.org: external/wpt/workers TBR=markdittmer No-Export: true Change-Id: Icb1c9f92c4a4e81a331a1c012242f515fbe8a778 Reviewed-on: https://chromium-review.googlesource.com/1165103 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#581207}
-
Rune Lillesveen authored
TBR=tnijssen@google.com Bug: 871740 Change-Id: I3e57e7d01bca2a31eb25d05dc6305c3092b747d5 Reviewed-on: https://chromium-review.googlesource.com/1165227Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/973f34ce..67c8e92b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia7c05d9803fdd046ec3e926233ce95063396c28d Reviewed-on: https://chromium-review.googlesource.com/1164846Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581205}
-
Alexis Hetu authored
With surfaceless EGL implemented in SwiftShader a few months ago, it should be possible to use SwiftShader for headless Chrome on all platforms where it is required. Note: SwiftShader's GPU initialization still has an issue on Chromecast, which will be fixed in a different cl. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5da4f94b7b71a845564627680c7376e70d203a1d Reviewed-on: https://chromium-review.googlesource.com/1161172Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581204}
-
Elly Fong-Jones authored
The URL's contrast on the selected grey background is too low. This change increases the brightness of the URL and darkens the background, pushing the contrast ratio over threshold. Bug: 870290 Change-Id: I30f40bcf85b283ee1ca6ddf82dd20e3dbeb9d91f Reviewed-on: https://chromium-review.googlesource.com/1163731Reviewed-by:
-
Ramin Halavati authored
Traffic annotation auditor's binary is rolled. Change-Id: I226db1602997e3d8af6c36a8afcd461eddd289b5 TBR: georgesak@chromium.org Change-Id: I226db1602997e3d8af6c36a8afcd461eddd289b5 Reviewed-on: https://chromium-review.googlesource.com/1165083Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581202}
-
Matt Menke authored
This CL moves code related to opening files out of the NetworkService (which will eventually be sandboxed), as well as factoring out some of the shared features of the NetLog subclasses, to make code deduplication easier. Implementations are provided for ChromeContentClient and ShellContentClient classes. Bug: 847961 Change-Id: I0a332b4429a2f20cbb38ae1671b8df0fbee28ba1 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1161470 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581201}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: Ic4c8d968e3b07157d5092f54d617b2e69236fae2 Reviewed-on: https://chromium-review.googlesource.com/1165002Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581200}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e19516b87bb1..3cb00fbd5681 git log e19516b87bb1..3cb00fbd5681 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 anthonyalridge@google.com Create a scatter/dot plot for grouping data by label. Created with: gclient setdep -r src/third_party/catapult@3cb00fbd5681 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I70309eb1cbc227ae86e0fb333aea97128d0c561b Reviewed-on: https://chromium-review.googlesource.com/1164448Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581199}
-
Sheng-Hao Tsao authored
This CL hides camera icon of internal camera app in guest mode. Since extensions are not allowed in guest mode, users can't perform any actions after clicking on the camera icon. Bug: 866412 Test: Tested on eve that there's no camera icon in guest mode. Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570 Reviewed-on: https://chromium-review.googlesource.com/1152147Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#581198}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6. The result change is due to service worker servicification. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 736308 Change-Id: I24d926c13211d8a579640fc6a156c01a3eb725bb Reviewed-on: https://chromium-review.googlesource.com/1164971Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#581197}
-
Marc Treib authored
Previously, we'd post a task to perform the shutdown. This meant that there was a brief period where the unrecoverable error was already set, but Sync was still active, which made things hard to reason about. This CL removes the task-posting and instead just directly calls OnUnrecoverableErrorImpl (which calls ShutdownImpl), which doesn't seem to have any ill effects. Bug: 839834 Change-Id: I998488332c531e817ffcd19e44df0e1273d091a5 Reviewed-on: https://chromium-review.googlesource.com/1163707 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581196}
-
Rune Lillesveen authored
This reverts commit 30d8a3b9. Reason for revert: Made SetIconAPITest.Overview test flaky (871720) Original change's description: > Fix flaky webrequest related network service tests in component builds > > These tests needed some extra synchronization due to the changes made in > http://crrev.com/c/1139048. These were flaking in component builds. > > Bug: 871224 > Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 > Reviewed-on: https://chromium-review.googlesource.com/1163987 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580980} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871224, 871720 Reviewed-on: https://chromium-review.googlesource.com/1165122Reviewed-by:
-
Rune Lillesveen authored
Only one of the subtests reported flaky, but didn't know how to disable them separately. TBR=noel@chromium.org Bug: 871684 Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451 Reviewed-on: https://chromium-review.googlesource.com/1164958Reviewed-by:
-
Koji Ishii authored
TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I16f3f57a2389c3d48573817fb5e96a30a825e85a Reviewed-on: https://chromium-review.googlesource.com/1164867 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581193}
-
Oscar Johansson authored
When building using jumbo, files gets merged together and macros with the same name may end up in the same namspace and conflict. This happens for the macro UMA_HISTOGRAM_MBYTES. This commit solves the issue by moving the macro to a shared util file. Bug: 871163 Change-Id: If3af541913a6add55ce739eb43f5a747cf4afd9a Reviewed-on: https://chromium-review.googlesource.com/1163602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#581192}
-
Adam Rice authored
Display a console message (in the context of the page) when a WebSocket is created via the Pepper pp::WebSocket API. Also add deprecation warnings to the documentation. Tested by manual verification that the console message is shown when the PPAPI WebSocket browser_tests are run. Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3NYHaxhRs14/XOdUJBvHAwAJ BUG=870586 Change-Id: Ib4631d11cd94cecad6c42e6b3fb1fb81ffc2b7fb Reviewed-on: https://chromium-review.googlesource.com/1161712 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581191}
-
Jean-denis Muys authored
This CL is part of the long-term goal of eliminating SigninManager as a public API for Chromium's identity code, replaced by IdentityManager. signin_error_notifer_ash_unittest builds a fake signin manager. This is not necessary: tests succeed without that. So removed creation of unused fake signin manager from tests. Bug: 797899 Change-Id: I7bcfca18f2c94192e629385a7c481957387e7fec Reviewed-on: https://chromium-review.googlesource.com/1158685Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Cr-Commit-Position: refs/heads/master@{#581190}
-
Morten Stenshorne authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4dcc14002fc786887ed5dbbe1523c4ba22af94df Reviewed-on: https://chromium-review.googlesource.com/1163518Reviewed-by:
-
Morten Stenshorne authored
Orthogonal flow root children are going to need to calculate an extrinsic constraint space. We already got this right for direct block children, but not for floated children of inline child nodes. Three tests start to pass, but I wrote a new test as well, that's more to the point (it used to fail a DCHECK, and then render incorrectly, if we bypassed that). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7 Reviewed-on: https://chromium-review.googlesource.com/1162175Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#581188}
-
Philip Jägenstedt authored
TBR=markdittmer@chromium.org No-Try: true Change-Id: I7711071a625d3a98c06d09663541cd250e0b9839 Reviewed-on: https://chromium-review.googlesource.com/1164951Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581187}
-
Mohamed Amir Yosef authored
This CL checks bookmark fields for validity/existence before parsing them when migrating from directory to USS architectures in uss_migrator.cc. The original problematic code has been introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1162226 Bug: 516866,871671 Change-Id: I843c62325f3e3ec37ce05783c999bdfd5f3542a0 Reviewed-on: https://chromium-review.googlesource.com/1164946 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
