GitLab

BUG=480733

Review URL: https://codereview.chromium.org/1131933005

Cr-Commit-Position: refs/heads/master@{#330236}

BUG=392232

Review URL: https://codereview.chromium.org/1130603006

Cr-Commit-Position: refs/heads/master@{#330235}

The bug is that chrome.runtime.sendMessage looks for when its callback is
garbage collected, and when it is, close the associated port. It's important to
close the port to notify the other end of the closure, cleanup renderer state
both locally and on that other end, and potentially browser state.

Unfortunately the port management is implemented in JS itself, and port
releasing needs to go through JS. The problem is that it's not possible to call
into JS while in the process of garbage collection, so we delay it, by which
point the JS context may have been destroyed and again it's not possible to
call into JS. We fixed the former case a while ago, and this patch fixes the
latter.

BUG=471599
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1136953017

Cr-Commit-Position: refs/heads/master@{#330234}

This also starts logging CANCELED requests, since they are just as
likely as FAILED/ERR_ABORTED ones to be from what *would've* been
ERR_TIMED_OUT if the user had been more patient. :)

BUG=480565

Review URL: https://codereview.chromium.org/1095553004

Cr-Commit-Position: refs/heads/master@{#330233}

Prior to this change, desktop/window capture would emit frames of any
size, regardless of the resolution change policy; and tab capture would
always emit frames of a fixed resolution.  Both cause a problem where
some receivers of the captured video need to do scaling/letterboxing
themselves for proper UX, and other receivers require this be done on
by the capture pipeline.

This change builds upon https://codereview.chromium.org/1124263004,
which allows the client to specify capture constraints that configure
the capture pipeline to do (or not do) the scaling/letterboxing.  All
frame resolution calculation logic has been factored into one place in a
new CaptureResolutionChooser class, which also depends on new utility
functions added to media/base/video_util.*.

BUG=473336

Review URL: https://codereview.chromium.org/1135823004

Cr-Commit-Position: refs/heads/master@{#330232}

BUG=487351
TEST=manual

Review URL: https://codereview.chromium.org/1131683004

Cr-Commit-Position: refs/heads/master@{#330231}

Revert of Use BoringSSL in the implementation of ClearKey for Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1130893008/)

Reason for revert:
Temporary revert until Monday (blocked on some other internal changes).

Original issue's description:
> Use BoringSSL in the implementation of ClearKey for Chromecast.
> (Previously, this was used only with the "Chrome" branding).
>
> BUG= 488572
>
> R=gunsch@chromium.org
>
> Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab
> Cr-Commit-Position: refs/heads/master@{#330156}

TBR=ddorwin@chromium.org,dougsteed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 488572

Review URL: https://codereview.chromium.org/1141243003

Cr-Commit-Position: refs/heads/master@{#330230}

Changes the basic showing test to show the banner and
simulate a user installing the app.

BUG=457414

Review URL: https://codereview.chromium.org/1137313005

Cr-Commit-Position: refs/heads/master@{#330229}

R=vabr@chromium.org,newt@chromium.org
BUG=486739

Review URL: https://codereview.chromium.org/1140713004

Cr-Commit-Position: refs/heads/master@{#330228}

This CL requires a downstream change:
https://chrome-internal-review.googlesource.com/#/c/214963/

BUG=482618
R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1103163004

Cr-Commit-Position: refs/heads/master@{#330227}

testUnregisterDomainWithUnregisteredDomain fails consistently, testUserAgent is flaky.

BUG=483212

Review URL: https://codereview.chromium.org/1143673002

Cr-Commit-Position: refs/heads/master@{#330226}

Prior IDBObjectStore.getAll implementation used zero as the sentinel value
for maxCount to mean unlimited. This change eliminates that check on the
Chrome side. It is now the callers (Blink's) responsibility to pass in a very
large number (MAXUINT) if the intent is to have the response be unbounded.

BUG=457450

Review URL: https://codereview.chromium.org/1138643007

Cr-Commit-Position: refs/heads/master@{#330225}

Ensure that sync still starts properly after signing out and back in.

BUG=480604

Review URL: https://codereview.chromium.org/1122373004

Cr-Commit-Position: refs/heads/master@{#330224}

BUG=488088
R=boliu

Review URL: https://codereview.chromium.org/1140253006

Cr-Commit-Position: refs/heads/master@{#330223}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db1f311..117dbc2

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1132123004

Cr-Commit-Position: refs/heads/master@{#330222}

For some downloaded items like Chrome apps, Chromium hides the download
bar once the download completes if there are no other download items in
it. However, if you cause the download item to display its context menu,
the context menu will remain visible even after the bar disappears.

BUG=480884

Review URL: https://codereview.chromium.org/1125423002

Cr-Commit-Position: refs/heads/master@{#330221}

BUG=488661
TEST=None

Review URL: https://codereview.chromium.org/1128963008

Cr-Commit-Position: refs/heads/master@{#330220}

Update tz db to 2015d

 Summary of changes available at:
 https://chromium.googlesource.com/chromium/deps/icu/+log/ce41627..5788e27

BUG=473288
TBR=jsbell@chromium.org
TEST=In JS console, run the following to get 1:00 PM for 2015
instead of 2:00 PM. In 2014, it should return 2:00 PM.
  may_25_2015_1100 = new Date("05/25/2015 11:00Z")
  may_25_2015_1100.toLocaleString("en", {timeZone: "Africa/Cairo"})
  may_25_2014_1100 = new Date("05/25/2014 11:00Z")
  may_25_2014_1100.toLocaleString("en", {timeZone: "Africa/Cairo"})

Review URL: https://codereview.chromium.org/1141973002

Cr-Commit-Position: refs/heads/master@{#330219}

The current implementation, in fact, doesn't support specifying both
"--v" and "--log-level" command line switches: only "--log-level" switch
will take an effect. This looks counterintuitive.

For example, browser_tests always start the browser with the
"--log-level" switch specified, so with current implementation there's
no way to enable vlogging in browser_tests using a command line.

The suggestion is, as both of the options refer to the same underlying
"min_log_level", to make the "--v" switch have a higher priority.

BUG=

Review URL: https://codereview.chromium.org/1136463009

Cr-Commit-Position: refs/heads/master@{#330218}

Added the Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histogram to track time between tab switches.

TEST=Manually verified histogram data added on ChromeOS.

BUG=478930

Review URL: https://codereview.chromium.org/1124153007

Cr-Commit-Position: refs/heads/master@{#330217}

BUG=486739

Review URL: https://codereview.chromium.org/1128023008

Cr-Commit-Position: refs/heads/master@{#330216}

This CL classifies the following fallback triggers in BoringSSL ports:

- ClientHello intolerance.
- Microsoft's buggy AES-GCM implementation.
- CertificateVerify was rejected (some servers broke TLS 1.2 client auth).
- Resuming a session at the wrong version.
- F5's buggy NPN implementation.
- Other.

It also records how often each error code triggers the fallback.

Initial numbers for the fixed metrics are actually rather encouraging,
but put this in place for the same release if larger populations' numbers
are worse and we'd need to carve out large swathes of intolerance with
less problematic workarounds.

BUG=459690

Review URL: https://codereview.chromium.org/1127623005

Cr-Commit-Position: refs/heads/master@{#330215}

The functions being called already checks for NULL input.

Review URL: https://codereview.chromium.org/1131093004

Cr-Commit-Position: refs/heads/master@{#330214}

Use WebContentsObserver::RenderViewHostChanged() instead.

BUG=170921
Test=No behavioral change.

Sanity checked with JS speech, whether WebContentsTracker class gets created and destroyed properly.

Review URL: https://codereview.chromium.org/1132163004

Cr-Commit-Position: refs/heads/master@{#330213}

X uses 96 as default, and alters the screen size
but it can be overwritten. Compute the dpi from X
to match what gtk sues as base.

Round the dsf to 1 decimals as finer grained value can cause rendering problem than benefit.

Gpu test expectation on nvidia needs to be updated, so mark these tests as failing now.

BUG=485183

Review URL: https://codereview.chromium.org/1136913005

Cr-Commit-Position: refs/heads/master@{#330212}

BUG=486739

Review URL: https://codereview.chromium.org/1137183004

Cr-Commit-Position: refs/heads/master@{#330211}

On some systems with buggy power managers, calls to the power
manager would result in long pauses that would block the FILE thread.
This yielded degraded performance for other browser tasks
scheduled on the same thread.

BUG=173354
R=miu@chromium.org,rdsmith@chromium.org

Review URL: https://codereview.chromium.org/1141913002

Cr-Commit-Position: refs/heads/master@{#330210}

This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85

This previously landed in https://codereview.chromium.org/1130413005/ but got
reverted in https://codereview.chromium.org/1139233002/ as it broke the Chrome
Linux x64 builds due to a added dependency to "libgcc_s.so.1(GCC_3.0)(64bit)".
The dependency was already allowed for 32bit, so it is allowed for 64bit now,
too.

BUG=328475

Review URL: https://codereview.chromium.org/1144623002

Cr-Commit-Position: refs/heads/master@{#330209}

Properly transfer ownership between PermissionBubbleManagers as
tabs are switched.

BUG=340720
R=rohitrao@chromium.org

Review URL: https://codereview.chromium.org/1130603005

Cr-Commit-Position: refs/heads/master@{#330208}

The only place where Device ID is stored on Chrome OS is the local state from now on.

Order of events:
1) User logs in. There are two options:
  a) User athenticated through GAIA. We read known user device ID from local state if it exists or generate a new one if it doesn't. Then we save the device ID in a user context.
  b) Otherwise, we don't store device ID in user context.
2) If it is GAIA_WITHOUT_SAML-mode, we send device ID to LSO in "oauth2/token" request (OAuth2TokenInitializer class). If it is not, we'll send it in "o/oauth2/programmatic_auth" request on step (5).
3) After NotifyUserLoggedIn() call, we store the device ID from the user context (if it is set) to local state. Then we start to create/load a profile for the user.
4) In constructor of ChromeSinginClient we migrate device id from kGoogleServicesSigninScopedDeviceId pref to the local state, if a value in the local state is empty.
5) We request tokens with "o/oauth2/programmatic_auth" if we haven't done that on step (2). Old code for sending device ID works here, because it relies on ChromeSigninClient which returns device ID set on step (4).

BUG=486044,486136

Review URL: https://codereview.chromium.org/1138143002

Cr-Commit-Position: refs/heads/master@{#330207}

This patch updates record_wpr to use argparse for:
+ record_wpr <XYZ> will make <XYZ> a benchmark name to be recorded.
+ record_wpr --user-story <XYZ> will make <XYZ> a user
story (page set) name to be recorded
+ record_wpr --list-benchmarks & --list-user-stories will
list out benchmark names & user stories (page sets) names.
This is useful since the current record_wpr target name
matching is a bit funky due to  discover.DiscoverClasses's
keys naming scheme.

Subsequent patches will update it so that the target
matching name for benchmarks matched the convention in
benchmark_runner.py & matching name for user stories use
the user stories's class name.

Since more code refactoring are required, I haven't added
unittest for these new changes yet.

TEST="
git cl patch this.
./perf/record_wpr --help
./perf/record_wpr --list-user-stories
./perf/record_wpr --list-bechmarks

"

BUG=470865

Review URL: https://codereview.chromium.org/1147533004

Cr-Commit-Position: refs/heads/master@{#330206}

BUG=476587

Review URL: https://codereview.chromium.org/1134513005

Cr-Commit-Position: refs/heads/master@{#330205}

Removed extra 'dependency' on target 'media_router_test_support'.

Also removed the ':' on some local dependencies.

Original patch: https://codereview.chromium.org/1136623003/
Original patch description:

- Refactor GYP and GN files to share source lists.
- Extract a proper test_support target.
- Fix upstream files with new target structure.

BUG=461815, 464199, 464205
TEST=Linux trybots. It's not clear to be exactly which bot, since
original patch failed after getting through trybots/CQ.

Review URL: https://codereview.chromium.org/1122393005

Cr-Commit-Position: refs/heads/master@{#330204}

requests.

For StartSession, PSImpl keeps a queue of StartSession requests to be
processed. (It can only process one at a time). If the queue has
reached maximum allowed size (10), subsequent incoming requests will
be immediately rejected.

For Joinsession, PSImpl keeps a map of currently JoinSession requests
that are currently processed. If the map reached maximum allowed size
(10), subsequent incoming requests will be immediately rejected.

Also, tried to simplify some of the cleanup flow for
NewSessionMojoCallbacks by introducing a wrapper class that ensures
callbacks are not dropped. Currently the cleanup logic is sprinkled
all over the file so hopefully this makes things cleaner.

We could generalize the callback wrapper pattern in the future if
it makes necessary.

BUG=412331

Review URL: https://codereview.chromium.org/1141683002

Cr-Commit-Position: refs/heads/master@{#330203}

Change https://codereview.chromium.org/1014543006 was supposed to disable
AutomationApiTest.Mixins because it is flaky (it fails ~8% of the time on
Windows, and is also flaky on Linux).

However the disabling didn't work because the newly created MAYBE_Mixins
macro is never used. This fixes that by renaming the test.

The line that always fails is:

assertEq(2, input.textSelStart);

The output is:

Actual: 0
Expected: 2

R=ellyjones@chromium.org
TBR=aboxhall@chromium.org
BUG=467921

Review URL: https://codereview.chromium.org/1129733004

Cr-Commit-Position: refs/heads/master@{#330202}

This moves native_viewport_service into core_services on desktop
mandoline builds, colocating the service with the surfaces service. We
can't do this on android yet because android does some tricks with the
ApplicationLoader to make the native_viewport_service run in the shell's
main thread.

BUG=484234

Review URL: https://codereview.chromium.org/1135703004

Cr-Commit-Position: refs/heads/master@{#330201}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f3c3784..db1f311

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1138873004

Cr-Commit-Position: refs/heads/master@{#330200}

Added to GYP recently https://codereview.chromium.org/1136953009 .
Adding the same flag to GN.

Also update android_tools' BUILD.gn to use v14_skip

BUG=487391

Review URL: https://codereview.chromium.org/1147483002

Cr-Commit-Position: refs/heads/master@{#330199}

BUG=486739

Review URL: https://codereview.chromium.org/1138603005

Cr-Commit-Position: refs/heads/master@{#330198}

This pulls in the following Native Client changes:

7aaf68d: (dschuff@chromium.org) Fix mode of run.py
a55fb84: (sbc@chromium.org) Update ARM sysroot in toolchain_revisions/arm_trusted.json
a0d24db: (bradnelson@chromium.org) Enabling asan pnacl toolchain builders.
9f62c3e: (sbc@chromium.org) Update QEMU version 1.0.1 -> 2.3.0
e04b61c: (kschimpf@google.com) Fix typo in iss https://codereview.chromium.org/1140793002
ce18634: (sbc@chromium.org) Roll ARM sysroot image to bring in new QEMU version
4e5d3d4: (mseaborn@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
30d4b12: (mcgrathr@chromium.org) toolchain_build: Update glibc revision
0beb554: (jvoung@chromium.org) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
473ef0b: (jvoung@chromium.org) Update revision for PNaCl
2da5677: (sbc@chromium.org) Re-enable some ARM qemu tests now that we are using 2.3.0
862ca26: (dschuff@chromium.org) pnacl-ld: Don't run expand-varargs with relocatable output

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1141073004

Cr-Commit-Position: refs/heads/master@{#330197}