GitLab

We should only increment num_attempts for Periodic Background Sync if
the event has been unsuccessful. This also extracts out the logic of
calculating num_attempts into a helper method.

Bug: 989444
Change-Id: I820f91cd2799be9803295cf9baf3dbd194fd3b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729078Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682712}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rogerta@chromium.org

Bug: 968047
Change-Id: Ie0678d17a9847458418eaa08e0832295d70e5e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729216
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682711}

Bug: 980418, 972783
Change-Id: Ie9d53b6e4377bfb90dfdd8343e228856477b40d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715102Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682710}

I'm trying to remove variable shadowing in some Chromium
code to maybe make the code a bit more robust, and there were nested
timestamps named |start| in some test code that triggered the
shadowing warning (not yet enabled).

Bug: 925310
Change-Id: I1ce0b98228e683b497b6362fb1519beadb07de71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729149Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#682709}

When a property node changes in blink, changed bits need to be set on
the associated cc property node for damage. Blink has a fast-path for
directly updating composited property nodes
(see: PropertyTreeManager::DirectlyUpdateScrollOffsetTransform) that
marks the cc property node as changed but does not cause a full update.
Code was recently added when doing a full update that would unset the
changed bit on a cc property node that was directly updated. This patch
fixes that bug by not clearing the changed bit of a directly-updated
node.

This situation could occur if a fast-path direct update and a slow-path
update occur in the same frame. This was only noticed on Windows because
partial swap is used there which makes the damage bug more visible.

Bug: 985729
Change-Id: I483305477d47aef095591c0f7e54720eb06f7827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721197Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682708}

This includes moving modified_request_headers_ and
removed_request_headers_.
And SetRequestHeaders() and RemoveRequestHeaders() functions.

Bug: 916537
Change-Id: I71262f8e3667c3fccaa557a60ca069345b603c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719353
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682707}

Change-Id: Ie5a2015ec45f2ba19055776b70e91fe7a47b1227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728884
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#682706}

Conversion performed via.
  * cd base
  * android/jni_generator/jni_refactorer.py -R --nonstatic
  * Remove unused Java "this" parameters
  * android/jni_generator/jni_refactorer.py -R
  * Fix base natives callers outside //base

See docs linked to from crbug.com/898261 for more info on the project.

Bug: 929661
Change-Id: I68049badf63ca5a307f5dc8304e20fb469ef29b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695855
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682705}

https://webrtc.googlesource.com/src.git/+log/e529ecb5bb99..6acb069c2c13


git log e529ecb5bb99..6acb069c2c13 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 srte@webrtc.org Adds default for PeerConnectionObserver::OnIceConnectionChange
2019-07-31 sprang@webrtc.org Fix SendSideBweWithOverhead using new pacer code path.


Created with:
  gclient setdep -r src/third_party/webrtc@6acb069c2c13

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:b/138582168
Change-Id: I7f0fdfd983f4ab46691e69a9736c5488cedd91c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729051Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682704}

Disable TwoClientPreferencesSyncTest.Sanity_E2ETest because flaky.

TBR=mastiz@chromium.org

Bug: 988404
Change-Id: I19c4fcffdf71fdea48eb8e35cf55f81aaa841386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729074Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682703}

The logical_values file has a bunch of writing-mode fixups for float,
clear, and resize.

While doing some work with floats I almost missed the appropriate call
to Resolved* indicating this was a bad API design.

Moving this into ComputedStyle and changing the default accessor to
Unresolved* will hopefully prevent any future errors.

Change-Id: I729af24ef90bea3669d33c2bc4b2dd4dc08bfb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700398Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682702}

https://android.googlesource.com/platform/external/perfetto.git/+log/04065f4cd9d6..ccb430fd4ebb


git log 04065f4cd9d6..ccb430fd4ebb --date=short --no-merges --format='%ad %ae %s'
2019-07-31 treehugger-gerrit@google.com Merge "perfetto-ui: Show progress bar when loading tracks"


Created with:
  gclient setdep -r src/third_party/perfetto@ccb430fd4ebb

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I78fbaa3b1a929329ad85592ada294f686f0a781f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728262Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682701}

This CL implements CSSCustomListInterpolationType::Composite by adapting
the callback passed to ListInterpolationFunctions to the Composite
function of the inner interpolation type.

For the current set of supported syntaxes, only <length-percentage>
uses non-interpolable values. This CL adds a
NonInterpolableValuesAreCompatibleCallback which DCHECKs that we don't
have any non-interpolable values (except for <length-percentage>).
This ensures that we don't forget to update this function if we add
support for new types to css-properties-values-api in the future.

Bug: 981024
Change-Id: Iccaaa779a2de0446a7bf9823cdb3e42161b07f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688832
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682700}

Fixes the flaky LoadAndLaunchExtensionBrowserTest.LoadAndLaunchExtension
test on Linux. The test tries to run an extension as an app and fails
(expectedly) very quickly. This triggers a race condition in
NotificationPlatformBridgeLinuxImpl where the cleanup code is run before
the init code finishes.

In particular, InitOnTaskRunner() kicks off
notification_proxy_->ConnectToSignal(), which runs a task on another
thread. If CleanUpOnTaskRunner() runs before that task is executed,
the bus is shut down. ConnectToSignal() then reconnects the bus and
nothing shuts it down again, causing a DCHECK(!connection_) in
Bus::~Bus().

BUG=chromium:988160
TEST=Test works flakelessly on my workstation

Change-Id: I57148b8f51c6927582bc69577260078e6cf1e491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722959
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682699}

These classes are no longer used post-unity.

Bug: 978908
Change-Id: I96657e3594feea4fea032a0c4c73216e21c1a0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724673Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682698}

This CL fixes DCHECK failure when Chrome is navigated to chrome://webapks
and the user has not yet selected the host browser for one of the
installed WebAPKs

BUG=989200

Change-Id: Icee4087f6e3d05fa2ff43b9fbfe58f82477c8496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726901Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682697}

When the user tap on a cell of the Edit screen of an Address, the
associated text field should be focused.
This wasn't the case because the selection of the cell isn't registered
if the cell cannot be edited.

Bug: 989486
Change-Id: I5f193c59260151aa811cd15b92ebe2959476db18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728563Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682696}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fb6a1792..38a850d9

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibe6b2a61ed845a891d6e49163074219a0df4f2ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728514Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682695}

Disable CacheStorageManagerTest.TestErrorInitializingCache in Fuchsia
(flaky).

TBR=wanderview@chromium.org

Bug: 989313
Change-Id: I18802fc677a99b9a83fc99a356f7c02ff568d11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729150Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682694}

Disable ContextProviderImplTest.CleansUpContextJobs in Fuchsia (flaky).


TBR=scottmg@chromium.org

Bug: 989085
Change-Id: Ief0416fc1f348a8d275dbfc0b8e53281dee09bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729209Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682693}

Bug: 968047
Change-Id: Ibae113c025e4db430980c75932b8625657d096ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728564
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682692}

ResurrectingPreFinalizer was defined in two different tests that may be packed
in the same jumbo file. They do not exactly belong to the same namespace (blink
and blink::anonymous) but the definition is ambiguous for the compiler.

Renamed it to HeapTestResurrectingPreFinalizer and moved to an anonymous
namespace, which is not strictly required, but it's a good practice.

Bug: 989452
Change-Id: I7717cf87a064e71fa4bc260f5a8add4f04045b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728662Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#682691}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=guidou@chromium.org, mcasas@chromium.org

Bug: 968047
Change-Id: Ie59c787e758dba8d2d280abdf337cca18df3f0d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729069
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682690}

Bug: 987763
Change-Id: I891e4143b2d0dfe7e0ac0c05e448e61122a6b6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724650Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682689}

The ancestor chain is the flat tree ancestors chain. There is no need to
include the shadow roots. The layout tree rebuild root is never the
Document, always an element or text node.

This is done in preparation for flat tree style recalc.

Bug: 972752

Change-Id: I011ad734c02dfa8e09ebf068dd6424d77a4a6e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727290Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682688}

Users may request to close a browser window using close requests
originated from Wayland compositors. These requests can be envoked
by Mod+Shift+Q, for example.

The API responsible for this feature is the listener interface of
xdg_v5 and zxdg_v6 surfaces.

We have already had a dumb implementation for them, but the calls
have not been plumbed. Thus, just forward the calls to the
WaylandWindow and that's it.

Bug: 989043
Test: WaylandWindowTest.OnCloseRequest
Change-Id: I748fa93738900313013a0c4f48a709f28c24c352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728549
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#682687}

Using wpt-import in Chromium 9518eef8.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ia5d985ef1eacc5cd948b129066476f176fc03454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728450Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682686}

font-variation-settings is 'normal' or a comma-delimited
list of string - number pairs.

Each string is 4 characters.

https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def


Change-Id: I9ecd80be68a1575647f4dc64864640bc36ee2b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728583
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682685}

This also eliminated the last caller to LengthInterpolationFunctions::
Composite (out of necessity), hence the two ::Composite* functions
were unified.

Bug: 981024
Change-Id: I197ad0fd246d7aabff08b326e1ee3d9e4520ee35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722941
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682684}

BUG=972848

Change-Id: I34460845917cf1032ddba9198eb0593a68c7a42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723931Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#682683}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6697895fb46b..bf1198869aba


Created with:
  gclient setdep -r src-internal@bf1198869aba

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I67603d509afcad398f8069d749e3fa7c80b31c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729049Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682682}

Creates a new target and file with omnibox EG tests. Adds some tests.

Bug: none
Change-Id: I7e65439aaa706947124d854e49e7e08b84b8cc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649505
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682681}

This includes moving all related functions and members.

This has a potential of reproducing this bug: https://crbug.com/957212.

The bug was initially produced after a big CL was landed that included
some changes from this CL. But due to the size of the changes, it was
hard to point out what the actual problem was.

Bug: 916537
Change-Id: I2c8b11f82e5b5197976b3cdb15de40f3032e68ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720775
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682680}

PR landed: https://github.com/w3c/csswg-drafts/pull/4148

Bug: 987207
Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682679}

A "names" label has been added that enables the user to toggle
whether their contact names should be included in the data shared with
the website that opened the picker.

Secondly, chips for data types that have not been requested by the
developer will now be hidden. At least one type is required so we can be
certain that there is *a* chip. A LinearLayout had to be introduced to
make sure left-side spacing is consistent: previously, the first chip
(names) had a 20dp padding where others had a 10dp padding, but now any
of the chips can be first.

Urgent string updates (Issue 989208) are also included.

Bug: 985708, 988268, 989208
Change-Id: I054871b5c059a029450fd11fad961847b4e3e424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726035Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Auto-Submit: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682678}

Disable
 SSLErrorHandlerDateInvalidTest.TimeQueryHangs
 SSLErrorHandlerDateInvalidTest.NoTimeQueries
 SSLErrorHandlerDateInvalidTest.TimeQueryStarted
on Linux TSAN because flaky.

TBR=agl@chromium.org

Bug: 989289, 989225, 989128
Change-Id: I23df095539a5f0eaf5a3070ccea35067998e981b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728554Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682677}

Enforce CrashInfo#localId to always have a non-null value by accepting
it through a constructor. Hence, eliminate the need for null check in
many places where CrashInfo objects are used.

Updating and format docs and comments in CrashInfo class.

Fixes: 987806
Change-Id: If6f40cf3442ab5cf5601336601dd950a45ad74f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720870Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682676}

Bug: 966896
Change-Id: Id119c1ad1f8ca675b77a4525ba6655d978bb980b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713306Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682675}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8f74bea5b69a..747518d43f4b


git log 8f74bea5b69a..747518d43f4b --date=short --no-merges --format='%ad %ae %s'
2019-07-31 yizhou.jiang@intel.com Remove extra semicolons in shaderc (#768)


Created with:
  gclient setdep -r src/third_party/shaderc/src@747518d43f4b

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I2e6232a66f68057caabb1c5cbdff0f352d7389a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682674}

https://android.googlesource.com/platform/external/perfetto.git/+log/334a2b1fa8b9..04065f4cd9d6


git log 334a2b1fa8b9..04065f4cd9d6 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 rsavitski@google.com Merge "traced_probes: re-flush metatrace data source at DataSourceStop"
2019-07-31 rsavitski@google.com Merge "traced metatrace: encode CommitDataRequests as a "counter""


Created with:
  gclient setdep -r src/third_party/perfetto@04065f4cd9d6

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I810c7177b208a6560deb114fb11cccad6602c43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728259Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682673}