GitLab

Review URL: https://chromiumcodereview.appspot.com/10850012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149586 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r149576, which was reverted as it broke
RemoteFileSystemExtensionApiTest.RemoteMountPoint. Turned out that
ui_weak_ptr_ in GDataFileSystem shouldn't be removed.

Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.

Wez on [chromium-dev] Weak ptrs for derived types?

You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10843043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=hashimoto@chromium.org
for a simple change adding ALLOW_THIS_IN_INITIALIZER_LIST.

Review URL: https://chromiumcodereview.appspot.com/10834120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97804
TEST=existing unittests 

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149583 0039d316-1c4b-4281-b951-d872f2087c98

Broke RemoteFileSystemExtensionApiTest.RemoteMountPoint

Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.

Wez on [chromium-dev] Weak ptrs for derived types?

You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10837061

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149582 0039d316-1c4b-4281-b951-d872f2087c98

FFmpeg's vector_fmac function, without the hassle of 32-byte align
and over allocation.

VectorFMAC_SSE requires 16-byte alignment of the source and dest
vectors.  Size does not need to be a multiple of 4 though.

Performance results from AudioRendererMixerTest.VectorFMACBenchmark:

Benchmarking 200000 iterations:
VectorFMAC_C took 2030.73ms.
VectorFMAC_SSE (unaligned size) took 598.33ms; which is 3.39x faster than VectorFMAC_C.
VectorFMAC_SSE (aligned size) took 597.71ms; which is 3.40x faster than VectorFMAC_C and 1.00x faster than VectorFMAC_SSE (unaligned size).

BUG=133637
TEST=media_unittests + AudioRendererMixer/* tests.

Review URL: https://chromiumcodereview.appspot.com/10802005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149581 0039d316-1c4b-4281-b951-d872f2087c98

In IBusLookupTable::page_size actually does not affect for Chrome OS.
However, if we use chromeos-chrome on linux desktop, zero value crashes ibus's lookup table.

BUG=None
TEST=ran chromeos_unittests

Review URL: https://chromiumcodereview.appspot.com/10828114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149580 0039d316-1c4b-4281-b951-d872f2087c98

- IBusEngineFactoryService takes the ownership of engine_id - CreateEngine handler mapping.
- Make IBusEngineFactoryService::CreateEngine asynchronous, and introduce asynchronous unittest.

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10836047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120576


Review URL: https://chromiumcodereview.appspot.com/10830114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149578 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=140163


Review URL: https://chromiumcodereview.appspot.com/10825148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149577 0039d316-1c4b-4281-b951-d872f2087c98

Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr()
Along the way, copy derat's comment from ContactDatabase on this matter.

Wez on [chromium-dev] Weak ptrs for derived types?

You need to be similarly careful to have WeakPtrFactory appear after any
fields that its WeakPtrs may be used to access if you follow that pattern
instead.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10837061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149576 0039d316-1c4b-4281-b951-d872f2087c98

This is a workaround to avoid the issues we're having with the linker
running out of memory, like:

out/Release/../../third_party/gold/gold32: fatal error:
out/Release/unit_tests: mmap: failed to allocate 1373799052 bytes for output file: Cannot allocate memory

Removing the debug symbols shrinks the binary to about 10% the original
size, which in turn reduces the build's max mmap usage (roughly measured
as going from about 2GB to about 600MB).

Review URL: https://chromiumcodereview.appspot.com/10836067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10836051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149574 0039d316-1c4b-4281-b951-d872f2087c98

Rolled this out in hopes of stopping some crashes, but it didn't help, so relanding.

With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.

Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:

  @MAC-DENY:subrole*
  @MAC-DENY:value*
  @MAC-ALLOW:description*

You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.

BUG=124314


Review URL: https://chromiumcodereview.appspot.com/10662003

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837065

TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149573 0039d316-1c4b-4281-b951-d872f2087c98

These are just calling FOR_EACH_OBSERVER. In the past, these Notify*
functions were used to post a task to UI thread, to notify observers
on UI thread, but we no longer need this indirection.

BUG=138268
TEST=none; this does not change behaviors


Review URL: https://chromiumcodereview.appspot.com/10829130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149571 0039d316-1c4b-4281-b951-d872f2087c98

Java ContentViewCore object may be garbage
collected without first destroying the native object. Because of this,
all C++->Java calls to ContentViewCore must be guarded with a null
check.

BUG=139386,138237


Review URL: https://chromiumcodereview.appspot.com/10827125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149570 0039d316-1c4b-4281-b951-d872f2087c98

These are not the same optimizations in the WebKit version of
SincResampler.  The WebKit version focuses on aligning the input
vector, resulting in at worst two unaligned loads on each kernel
index; or 2 * kKernelSize / 4 unaligned loads per call.

Instead I chose to focus on keeping the kernel vectors aligned
and eating at worst a single unaligned load on the input vector;
or kKernelSize / 4 unaligned loads per call.

Performance results from SincResamplerTest.ConvolveBenchmark:

clang version 3.2 (trunk 159409):
Convolve_C took 2100ms for 50000000 iterations.
Convolve_SSE (aligned) took 677ms for 50000000 iterations.
Convolve_SSE (unaligned) took 717ms for 50000000 iterations.

gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3
Convolve_C took 2183ms for 50000000 iterations.
Convolve_SSE (aligned) took 806ms for 50000000 iterations.
Convolve_SSE (unaligned) took 844ms for 50000000 iterations.

For reference, the original WebKit optimizations:
clang version 3.2 (trunk 159409):
Convolve_C took 2132ms for 50000000 iterations.
Convolve_SSE (aligned) took 1146ms for 50000000 iterations.
Convolve_SSE (unaligned) took 1797ms for 50000000 iterations.

gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3:
Convolve_C took 2209ms for 50000000 iterations.
Convolve_SSE (aligned) took 1450ms for 50000000 iterations.
Convolve_SSE (unaligned) took 4415ms for 50000000 iterations.

In summary, SSE provides an ~2.6x to ~3x speedup on GCC and
clang respectively.

BUG=133637
TEST=media_unittests + SincResampler/* tests.


Review URL: https://chromiumcodereview.appspot.com/10803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149569 0039d316-1c4b-4281-b951-d872f2087c98

Remove 
- IF_EXPECT_EQ
- IF_EXPECT_TRUE
macros and use
- ASSERT_EQ
- ASSERT_TRUE
in gdata_wapi_parser_unittest.cc

BUG=139956
TEST=unit_tests --gtest_filter="GDataWAPIParserTest*"

Review URL: https://chromiumcodereview.appspot.com/10828109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140059
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10829126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137670
TEST='NativeMediaFileUtilTest.*'


Review URL: https://chromiumcodereview.appspot.com/10825042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138155
R=asargent@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10836064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.


Review URL: https://chromiumcodereview.appspot.com/10821127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10836045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138586
TEST=On Lion or higher, run with a fresh profile. Go to settings and add a new profile. The avatar button in the original window is to the right of the fullscreen button.
TBR=gyp

Review URL: https://chromiumcodereview.appspot.com/10823130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126183
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10850011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149558 0039d316-1c4b-4281-b951-d872f2087c98

Add -v/--verbose so you can see what the tool is doing.

Fix for StageDependencies so that it treats the main files
in the same special way that _GenerateManifest does.  The
current behavior creates duplicate nested copies of
of the all main (.nexe) files you pass it.

Remove trailing whitespace.

Add a __repr__ for ArchFile so printing them is less opaque.

Remove ErrorOut in favor of Error exception.  Calling 
sys.exit() all over the place makes things like unit testing
harder.  Error exception is now caught in the main entry 
point so the user doesn't see stack traces for errors.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10837028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149557 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ddorwin@chromium.org
BUG=130689
TEST=media_unittests


Review URL: https://chromiumcodereview.appspot.com/10826098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149556 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10834079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525
TEST=unittests, manual 

Review URL: https://chromiumcodereview.appspot.com/10825068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129311
TEST=unittest


Review URL: https://chromiumcodereview.appspot.com/10677015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10831107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149552 0039d316-1c4b-4281-b951-d872f2087c98

This avoids the need for editing the script, which is impractical when it is
installed from a Debian package.


BUG=131245


Review URL: https://chromiumcodereview.appspot.com/10823109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149551 0039d316-1c4b-4281-b951-d872f2087c98

This may have caused the Win 7 WebKit canary bot to begin crashing; see
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Floading-iframe-updates-axtree.html
If rolling this out does not fix the bot, I will put it back in later tonight.

With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.

Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:

  @MAC-DENY:subrole*
  @MAC-DENY:value*
  @MAC-ALLOW:description*

You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.

BUG=124314


Review URL: https://chromiumcodereview.appspot.com/10662003

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149550 0039d316-1c4b-4281-b951-d872f2087c98

For HiDPI PDF viewer, add new API to fetch properly-scaled resource for the
target display.

BUG=114674
TEST=Run PDF Viewer on HiDPI screen with HiDPI PDF Viewer flag, view buttons

Review URL: https://chromiumcodereview.appspot.com/10836055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525
TEST=unittests, manual

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10821097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132686
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140068

Review URL: https://chromiumcodereview.appspot.com/10837062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149545 0039d316-1c4b-4281-b951-d872f2087c98

This class provides a fake, memory-backed implementation of
ContactDatabaseInterface.

BUG=128805
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149544 0039d316-1c4b-4281-b951-d872f2087c98

Also see http://codereview.chromium.org/7000022

BUG=81634,138570


Review URL: https://chromiumcodereview.appspot.com/10827126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149543 0039d316-1c4b-4281-b951-d872f2087c98

200%

BUG=132686
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149542 0039d316-1c4b-4281-b951-d872f2087c98