GitLab

In favor of less indirection.
Along the way, remove an unsed parameter gdata_file_path from some places.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10182012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122815
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10152008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133543 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10187006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133542 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: Iadd9a6202f0b09e7d3f4171ae7341b2cd8e6e63a

BUG=chromium-os:28616, chromium-os:19569
TEST=Will be tested with implementation of chromium-os:19569


Review URL: http://codereview.chromium.org/10169014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133541 0039d316-1c4b-4281-b951-d872f2087c98

This is no longer in use since ChromeOS is now always building USE_AURA.

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/10073017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133540 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a test to see whether Google will index AJAX-
generated docs.

TBR=rafaelw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10200004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27964
TEST=This is a test

Review URL: https://chromiumcodereview.appspot.com/10105011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133537 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10180006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133536 0039d316-1c4b-4281-b951-d872f2087c98

The selection infrastructure in about:tracing was grown organically and in a hurry.
This refactors the organic selection logic around the concept of a TimelineSelection,
which represents an array of TimelineSelectionHit objects. A selection hit is
created by a track and contains enough information to uniquely identify the
selection both in the track and in the overall TimelineModel.

Counter tracks are then updated to support this new picking infrastructure,
generating TimelineSelectionHits. Whereas TimelineSelectionSliceHit stores its
selected state inside the timeline model, TimelineSelectionCounterHit stores
its selected state inside the track. The counter hits follow the new intended
model; a followon refactoring will be needed to clean up the TimelineSlice
selection state.

As part of this refactoring, the analysis code for traces is pulled from the
timeline view into a standalone analysis class. This allows cleanup and unit
testing of that once-monolithic system. In doing this, the help dialog is moved
up to a custom button in the UI instead of being shown in the analysis area as
was done previously.

Review URL: https://chromiumcodereview.appspot.com/10161025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:28353
TEST=Verify google api is correctly loaded


Review URL: http://codereview.chromium.org/10165017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133533 0039d316-1c4b-4281-b951-d872f2087c98

Remove DOMView.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171006

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10204002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10183007

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10199003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133528 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, animate when a view in the tray hides/shows itself. For now, the
tray does not animate when the size of a view changes (e.g. date-view changes
size because it's 10:00).

BUG=117209
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9969068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133526 0039d316-1c4b-4281-b951-d872f2087c98

a more intricate fix is on the way, see http://codereview.chromium.org/10154004/

for now this fixes the vast majority of crashes and is easy to merge to m19.

BUG=123705
TEST=manual


Review URL: http://codereview.chromium.org/10169024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133524 0039d316-1c4b-4281-b951-d872f2087c98

The process handle is not used since we switched NaCl to using
Chromium's BrokerDuplicateHandle() function.

I have changed NaCl's SelLdrLauncher to not use the process ID or
process handle in this context, so returning dummy values of 0 and -1
will be OK: they will not get passed to kill(), waitpid() or
TerminateProcess().

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.


Review URL: http://codereview.chromium.org/10134029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123033
TEST=In a signed-in profile, open a new tab page. Then open
chrome://settings/syncSetup in another tab. Toggle the "Open Tabs" sync option,
then observe that the "Other devices" menu appears or disappears from the NTP
as appropriate.

Review URL: https://chromiumcodereview.appspot.com/10167001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122302
TEST=Manually checked the images are updated

Review URL: https://chromiumcodereview.appspot.com/10171010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10115017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98

ppapi_proxy_untrusted.gyp should now build with a single link error for main.
BUG=116317
TEST=builds with a single link error for main().
Review URL: https://chromiumcodereview.appspot.com/10167024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133519 0039d316-1c4b-4281-b951-d872f2087c98

Convert the last remaining find bar ui test to a browser test. Also convert all the find bar tests to just use file urls instead of the http server, which is faster (I didn't see a reason to use http).

BUG=121574, 45753
Review URL: https://chromiumcodereview.appspot.com/10188003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133518 0039d316-1c4b-4281-b951-d872f2087c98

This is purely removing code that is no longer called, since 
https://bugs.webkit.org/show_bug.cgi?id=83638 has been fixed.

BUG=124650


Review URL: http://codereview.chromium.org/10179003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133517 0039d316-1c4b-4281-b951-d872f2087c98

mmap returns -1 on failure and in the posix implementation of SharedMemory, this was setting memory_ to -1. However the interface for SharedMemory specifies that memory_ should be NULL if it is unmapped.

Furthermore there was  DCHECK included to check the success of mmap, but I feel this is incorrect because we are returning the success (e.g. other platform implementations don't do this). The caller can DCHECK if they need. We could change this to a LOG call.

BUG=None
TEST=out/Debug/base_unittests


Review URL: http://codereview.chromium.org/10174007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117303
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10139025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133515 0039d316-1c4b-4281-b951-d872f2087c98

This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.

To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.

BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.

Review URL: http://codereview.chromium.org/10146016

TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10184012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133514 0039d316-1c4b-4281-b951-d872f2087c98

This function is not used in production code.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10182009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133513 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/123995
TEST=none. I need to add a set of unit tests to views for WebView, but that requires creating a new exe that can depend on content. I've filed http://crbug.com/124662 for this.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133490
Review URL: https://chromiumcodereview.appspot.com/10186007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133512 0039d316-1c4b-4281-b951-d872f2087c98

R=rch
TEST=browser unit tests

Review URL: http://codereview.chromium.org/10183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116952
TEST=TemplateURLServiceTest.*


Review URL: http://codereview.chromium.org/10184009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121518
TEST=

Review URL: https://chromiumcodereview.appspot.com/10152007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133509 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133508 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10186009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133507 0039d316-1c4b-4281-b951-d872f2087c98

This is working towards getting unit_tests linking for Android
platform.

BUG=117407
TEST=


Review URL: http://codereview.chromium.org/10169022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133506 0039d316-1c4b-4281-b951-d872f2087c98

Call ScriptGetFontProperties() lazily, only right
before its output is needed. This makes sure that
the correct font's properties are used to determine
if there are missing glyphs when going through the
fallback / linking path.

BUG=124453, 105550
TEST=See http://crbug.com/124453.

Review URL: http://codereview.chromium.org/10189001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124027
TEST=pyauto:policy.PolicyTest.testStartupOptionsHomepage


Review URL: http://codereview.chromium.org/10035043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133504 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10164020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=120837
TEST=variuos nacl audio samples


Review URL: http://codereview.chromium.org/10165016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124498
TEST=added


Review URL: http://codereview.chromium.org/10168021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133501 0039d316-1c4b-4281-b951-d872f2087c98

To introduce a real KeyPath type, the return type of keyPath accessors 
needs to change from a String to an IDBKeyPath. To do this requires 
temporarily moving the methods aside. The WebKit API change (which must
land first) is at: https://bugs.webkit.org/show_bug.cgi?id=84208

R=darin@chromium.org,dgrogan@chromium.org
BUG=112308


Review URL: http://codereview.chromium.org/10041014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133500 0039d316-1c4b-4281-b951-d872f2087c98

Adds an automation hook WaitUntilNavigationCompletes() which blocks until pending navigation completes.

Once this call returns it is safe to call the ExecuteJavascript() family of automation hooks.

BUG=124438
TEST=functional/apptest.py


Review URL: http://codereview.chromium.org/10168019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133499 0039d316-1c4b-4281-b951-d872f2087c98

This change treat jobs that receive MIGRATION_DONE response from the
server as a failure, so that they will be retried.  Otherwise we could
end up unnecessarily dropping nudges or notifications.  This was already
effectively the case for jobs that committed items for types that were
being migrated due to a detail of the way ProcessCommitResponse errors
were detected.

This also modifies the handling of configuration done notifications in
the ProfileSyncService so it no longer causes the scheduler to briefly
transition back to NORMAL mode in mid-migration.  The old way of doing
things would often lead to pending nudges being executed while the
migration was still in progress.

Finally, this change reroutes the backend migrator's OnConfigureDone
callback thorugh ProfileSyncService.  Now we can guarantee that the
ProfileSyncService's callbck gets executed first.  This should be less
brittle than hoping that the notifications arrive in a certain order.

BUG=123954,94882
TEST=


Review URL: http://codereview.chromium.org/10167017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133498 0039d316-1c4b-4281-b951-d872f2087c98