- 03 Dec, 2020 40 commits
-
-
Patrick Monette authored
The IdType class already has built-in support for an invalid ID. Bug: 971272 Change-Id: I7121400d72c22b90c153da32f0a0f74e46a27569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545442 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833369}
-
James Vecore authored
This CL plumbs the location hint from Nearby Connections to the SendMessage and StartReceivingMessages calls and puts the information into the Tachyon server requests. This allows Tachyon to use the location hint for geo sharding when available. Fixed: 1142001 Change-Id: I3345ea4e6936c934be46178b2128bca66a69af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568228Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833368}
-
Patrick Monette authored
This voter casts a USER_BLOCKING priority vote when a frame is audible. Bug: 971272 Change-Id: Ic0b777a48451322e8685c3d19e7d95bab89fb273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542562 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Livvie Lin authored
Bug: 1015626 Change-Id: I92d5c225677760bf0a5dc4c3c1381db05dd36697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552626 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833366}
-
Alex Ilin authored
TBR: shaktisahu@chromium.org Bug: 1155085 Change-Id: I40ad4748a310230e75e1b02d0c1697f2c539c9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571756Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833365}
-
Norman Rosas authored
and //components/v…, also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I5a9b09421e2199b2e0ed3edd0ea2f32335253cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570248 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833364}
-
Side Yilmaz authored
This CL gets profile from the current tab model instead of always using regular profile. Bug: 1048632 Change-Id: I61458edce798ff205cdd4b2915bbebb58df504ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567921Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833363}
-
bttk authored
This change dissolves method LocationBarLayout#updateVisualsForState(). Method LocationBarCoordinator#updateVisualsForState() remains, and is used in Toolbar. Bug: 1142883 Change-Id: If8b7b46bd6634adc514d607baab406205852263b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545192Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833362}
-
Charlie Hu authored
This CL fixes the missing Document Policy issue for XSLT document. The fix is similar to the previous fix on Permissions Policy. See https://chromium-review.googlesource.com/c/chromium/src/+/2561144. Bug: 1151954 Change-Id: Ie080c360ddc70ac46a63d5166b3830752ecdd94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563440 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833361}
-
Alice Wang authored
This CL make account picker bottom sheet announces the title when a new screen opens. Bug: 1144826, 1143259 Change-Id: I6e5b28733d0d6dfd99b4d1ed36e1e8de799f846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565533Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833360}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/685cb02ea8d9..76d12f0f5a33 2020-12-03 bclayton@google.com Add EmitVertexPointSizeTransform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Iba3d1b5cbb2a3b4991020d07850c9c0b8d9d9d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833359}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d937e6cbed6..877fbcb69179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibe68df695aa6a882209c58d3e3c569740b017970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570443Reviewed-by:
-
Alex Ilin authored
TBR: reillyg@chromium.org Bug: 1153716 Change-Id: Ia935c5efadae72bfd28e71da4157cdad9432b61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571099Reviewed-by:
-
Jeroen Dhollander authored
This reverts commit 0f98cc3e. Reason for revert: Lots of assistant tests failing on this builder: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Example builds: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10457/overview https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10451/overview https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10456/overview Original change's description: > Uprev Libassistant to 1.50 > > These are the public changes required to uprev to 1.50. > > NOTE: This includes the hash for the rolldep of src-internal, > as Libassistant 1.50 made some non-backwards compatible API changes. > > The internal changes included can be found in crrev.com/i/3414233 > > Bug: b/170170824 > Change-Id: I88f5836e896efe4005d6e9681175da36c07514b0 > Tests: Manually deployed and tested Assistant queries. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548684 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833190} TBR=xiaohuic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/170170824 Change-Id: I2f6ad96933dabb7a9b100dfe45ac28a62979ce67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572117Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833356}
-
Gauthier Ambard authored
This CL makes sure to update the zPosition of the cells in the TabGrid when they are inserted to allow the upper rows to be above the lower rows. Fixed: 1155122 Change-Id: Ib232dab6d35fa23c828fb027358cb2411e396982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571284Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833355}
-
Alexis Hetu authored
This cl is in the context of replacing SwiftShader's GL libraries with SwANGLE (ANGLE with SwiftShader Vulkan as its backend). In order to allow ANGLE to find the proper libvulkan.so when executing tests on the bots, we have to make sure the proper rpath is set. This affects all tests that depend directly or indirectly on //ui/gl:test_support. The affected tests include: app_shell_unittests aura_unittests cc_unittests compositor_unittests gpu_unittests interactive_ui_tests message_center_unittests media_unittests snapshot_unittests unit_tests views_unittests viz_unittests wm_unittests Bug: chromium:1060139 Change-Id: Ida242f511599d38ad1ec16e0f4711d80a957cc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565490Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833354}
-
cfredric authored
singleton sets. This is required since we need to be able to (quickly) distinguish sites that are members of a non-singleton set from those that are members of a singleton set (i.e. they are not a member of any set provided by Component Updater or on the command line). This, in turn, is needed because we need Chrome to ignore the SameParty attribute for cookies set by sites that are not in a First-Party Set, in order to avoid site breakage in the event of a race condition between the site registering their First-Party Set (and applying the SameParty attribute), and Chrome receiving the updated set list from Component Updater. Bug: 1143756 Change-Id: If77b60538c084a306b1c7af3d1bdabdb9fd1b0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560899 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833353}
-
Alex Turner authored
Instead of walking up the frame tree for subframes that inherit activation from their parents, we now synchronously construct a filter. This uses the functionality introduced for inheriting activation from same-origin openers, allowing synchronous construction. This should simplify the logic used, ensuring any activated frame has an associated filter. Bug: 1134288 Change-Id: Iaa624145c2f77fcce3f0e40f7248fa713ff889c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561265 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#833352}
-
Victor Hugo Vianna Silva authored
AndroidSyncSettings will soon disappear, so this CL migrates most uses of isSyncEnabled(), doesMasterSyncSettingAllowChromeSync() and isChromeSyncEnabled(). The rule determining the corresponding API in ProfileSyncService is described in crbug.com/1129426#c5. After this CL, the only remaining uses of the first two methods are in SyncController, and those must remain as long as ASS exists. Future CLs can, however, deprecate the two methods / expose them only to SyncController, in order to avoid the introduction of new calls. The third method remains used in other two questionable places, which can possibly be migrated as well % some discussion. Apart from the transient states, this CL should have no behavioral difference, *except* for a few cases where the additional case of a null ProfileSyncService must be handled, the effect being minor UI changes. This should be fine because a) the behavior would need to change anyway following crbug.com/1105795, b) the case where PSS is null is quite rare anyway (sync disabled by CLI). Bug: 1129426 Change-Id: I90282eb3674e42b270544e74356691d2ae56b91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562849 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#833351}
-
danakj authored
Fullscreen widgets no longer exist. R=sky@chromium.org Bug: 1134674 Change-Id: Ia6e5ca52332092c0804d692715a0499f1df10311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569367 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#833350}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9421b815..a6237ff2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I142a4ef9f6ba01fa66df448968bbde7e9c09b342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833349}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cf173dfbc29..c4b9cd7d79de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sebsg@google.com,antoniosartori@google.com Change-Id: I4c237b19422fb9b1615cfe88e56a9916ebb9232d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833348}
-
Azeem Arshad authored
Originally reverted here https://crrev.com/c/2570237 due to gn dependency check failures. This was caused because of known issue with gn not being able to parse conditional includes https://crbug.com/1125897. Fixed this by adding nogncheck comments for these includes. This also replaces defined(OS_CHROMEOS) macro in the original CL with BUILDFLAG(IS_ASH). This was done to align with http://go/lacros-replace-chromeos-macro-with-ash. This CL updates ShapeDetection service to be hosted in a utility process on ChromeOS. This is being done because the ShapeDetection service implementation for ChromeOS uses a third_party library and does not use any accelerated native shape detection APIs that might need to run in GPU process. Bug: 1093186 Change-Id: I583232c76fff90c3c8d323be46018f59056477c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567179Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833347}
-
Harald Alvestrand authored
Tests that when a PeerConnection closes, all open datachannels get the error and close events. (The bug was fixed earlier, but this adds a test for it) Bug: webrtc:6881 Change-Id: I4734f3d29333dcad98c34cf5dbdc8d4b04a5f986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568278 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#833346}
-
Peter Wen authored
AAR prebuilts need their resources extracted, but the resulting resource target should not need to depend on any of the aar's other deps. Bug: 1154302 Change-Id: I214fc0089a26497babb9a5f6885bf658e5ddca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570096 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833345}
-
Leonard Grey authored
Bug: 839694 Change-Id: Iccea0d36e83733d285a1222bdf1ebb669d7f3104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569969Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833344}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606964048-45fff1aeb7e9c3fd35f310aad8ee0c61f812a3a1.profdata to chrome-win64-master-1606996231-faa54c695225bf8f6afffc1841d10967281c359d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia633d08d6b3f3672b01217f3f3d7fd51f1db6583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568297Reviewed-by:
-
Dave Tapuska authored
All usage of LayerTreeHost has been adjusted, this ptr can now be removed from the RenderWidget class. BUG=1097816 Change-Id: I77cf0adf8e34028c51100be936e9d303e4cf8012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566252 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Joe Mason authored
This class manages the memory request but does not actually do the aggregation. crrev.com/c/2557730 will add another class that does the aggregation after the response is received. The unit tests are still named WebMemoryAggregator because they will also test the new aggregator class which will be invoked by WebMemoryMeasurer. Bug: 1085129 Change-Id: I21a13a407cb96d720463e4d5b009098156324294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569675Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#833341}
-
Dave Tapuska authored
This API doesn't need to be implemented in content/renderer and moving it inside blink removes one more usage of layer_tree_host on RenderWidget. BUG=1097816 Change-Id: Ic979023db67ae93df919f93ba5d570d0865ae9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562945 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/h34dBNFluLOvrol4gz-HIJi_w1-GzSIElYTdJY6clJoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I3da1c09e561251c1d7df9da54400603e9b620567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571194Reviewed-by:
-
Jan Wilken Dörrie authored
R=kazinova@google.com Bug: 1148394 Change-Id: Iabf0963d30c293ab739a01a8a639292f89abd300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569520 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#833338}
-
Stepan Khapugin authored
Creates a new superclass for scene agents. Existing scene agents are all scene state observers, and all have a sceneState property. It also seems useful to have a way to retrieve a scene agent for a given scene. These use features are factored out in a lightweight ObservingSceneAgent class. Existing agents are made subclasses of that. Bug: none Change-Id: Ia1908e339178e52396294fa4f308d759ee32a6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568271 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833337}
-
Elly Fong-Jones authored
These tests are being bulk-disabled as part of arm64 bot stabilization. Bug: 1154345 Change-Id: I903627c4ea56a175716a9618b73e1ed6fd330531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570195Reviewed-by:
Evan Shrubsole <eshr@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833336}
-
Clark DuVall authored
The attribution methods are only available in R, so add a ApiHelperForR class to access them. Bug: 1085041 Change-Id: Ief6957ad59cd499111c96a7a171eb2dca8e3d609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570034Reviewed-by:
-
Elly Fong-Jones authored
These tests fail consistently on the arm64 bot; disable them as part of stabilizing that bot. They will be reenabled as part of fixing the linked bug. Bug: 1154345 Change-Id: I9277a0fceeed48f434ce9643a3aa7ce4f1d20b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570105Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833334}
-
Andrew Grieve authored
Bug: None Change-Id: Ib3b63626cdfad918518896f3dadb1a0eaf3d12dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570749 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833333}
-
Ewann authored
This CL updates the design of TableViews. The presentation style changes depending on the device. Background colors have also been changed. Bug: 922511 Change-Id: Ifc2207146bedbc5f8332b3df7fa112a6525a279a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567928Reviewed-by:
-
Jan Wilken Dörrie authored
ReparseServerPredictionsFollowingFormChange R=kazinova@google.com Bug: 1140480 Change-Id: Ib2c5f3c9c623865beb66f39198377aadc239ab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570372 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
Bug: 1108780 Change-Id: I11765de4e2c29f8a0cc464f0af283aff36b702b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570566 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
