- 13 Jan, 2021 40 commits
-
-
Maxim Kolosovskiy authored
Bug: 946711 Change-Id: I40e15f1a31a2c3e92ff2a145ca7aaa50ebfd9ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627157 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#843059}
-
Clark DuVall authored
This was introduced in http://crrev.com/c/2623118 but will only show up in non-bundle builds. Bug: 1105096 Change-Id: Iadcdae745df6a54fe1d969ada113fafb6c25bce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627140 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#843058}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/08lersZsKT6EkUmpNzG2SgRB6TA4BrTuJsDXDGzdVrIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170162419 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib95d962dd211c036f4c617c7bae6a4d4b49ff01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627558Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62b8364eafc7..215834139a79 2021-01-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e59ae1af7571 to 50bcbaad4cbf (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I7234f53464e5aba327a3c36060a565c927e6b426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627554 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843056}
-
Elaine Chien authored
Bug: 1145666 Change-Id: I745032bf28e1e0313c0ad6c5c47a5e41e85e4d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626193Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/master@{#843055}
-
Jérémie Boulic authored
JS module generation for //ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js Bug: 1133186 Change-Id: I013f805433134151426473d6746904a7296fe358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626706 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843054}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610528340-1fc68c0c17222e2254fe428312433be61c378c49.profdata to chrome-win64-master-1610538373-76fca52980f687d249587bbfe52df46587227f16.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If4c5076ab531e8a9efd195fe164169c8fe1baa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627290Reviewed-by:
-
Colin Blundell authored
This is an unchanged reland of r#842942. That CL was reverted due to suspicions of it causing SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite to flake. However, it turns out that that test was already flaky, as can be seen on the flake portal. For example, this run shows it failing on a CQ run of r#842899: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tester%20(Ozone%20Wayland)/4088/overview Original CL description: This CL continues with the abstraction of dependencies on signin and sync from //components/safe_browsing's access token fetching flow in order to enable reuse by WebLayer. The concrete step taken here is to abstract the dependencies on //components/safe_browsing/core/browser/sync from RealTimeUrlLookupService, passing these dependencies in via the constructor. There are no behavioral changes in this CL: - //chrome and //ios/chrome's factories glue the relevant parameters from //components/safe_browsing/core/browser/sync - //weblayer's factory passes in values for the parameters such that access token fetching for URL lookups continues to be disabled in WebLayer Followup work will bring up support for access token fetching in WebLayer. Bug: 1080748 TBR: kolos@chromium.org Change-Id: I373f970373de7c5d14568a165365fe5a445aef08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627489Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843052}
-
Yao Xiao authored
In the patch where the DCHECK was added (https://chromium-review.googlesource.com/c/chromium/src/+/2595595), the kFlocIdComputeTimePrefKey is also updated. This has caused a one-time DCHECK failure for some client when Chrome was updated. The impact scope is small (i.e.should occur at most once per client and on M89 Canary only, as the PrefKey was initially introduced in M89), but should still be fixed. Bug: 1161160 Change-Id: I0fa226fd902ef732710fbfd0ec1d9a050166922d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625569Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#843051}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9846ef0a828..41a30fd36cbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com,fdoray@google.com Change-Id: I7c24efc7fea5708d93ed99e148d4a0417b996338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627561Reviewed-by:
-
Michael Ludwig authored
This was pulled from https://chromium-review.googlesource.com/c/chromium/src/+/2527768 to keep that CL clearer. Bug: skia:9310 Change-Id: Ie49c491638f3f859c11257e1b3dc0658a95caabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610286 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843049}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b577a78d937c..d46475f87758 2021-01-13 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-13 tcwang@google.com Revert "toolchain_util: Add function to modify kernel afdo metadata" 2021-01-13 vadimsh@chromium.org gen_luci_scheduler: Add "realm" field. 2021-01-12 sfrolov@google.com licensing: improve error messages 2021-01-12 victording@google.com flash-ap: Convert SSH port to string 2021-01-12 lamontjones@chromium.org git: add GetCurrentBranchOrId 2021-01-12 richardfung@google.com Add hatch-arc-s If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I89d0c043af2f05798605a81fca131ae2519af4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627062Reviewed-by:
-
Rakina Zata Amni authored
When javascript: URL evaluates into a string, or XSLT document change happens, we will commit a new document but won't notify the browser of the change of documents, as no URL/origin change happens, essentially treating it as just a content update within the previously committed document. However, we actually create a new DocumentLoader and Document for the commit, and not all attributes of the old document are actually carried over to the new document. This CL copies most attributes from the previous document through DocumentLoader::CreateParamsToClone(), to ensure future navigations within the new document won't result in confusion in the browser. Some examples of things that are now copied to the new document: HistoryItem, http_method, http_status_code, devtools_navigation_token (so XSLT document transformations show up on devtools), etc. Bug: 1151954, 1048106 Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#843047}
-
Alex Turner authored
This simplifies the flow for setting UKM source ID on WorkerGlobalScopes by moving it into the existing GlobalScopeCreationParams. This avoids explicitly passing the UKM source ID to a range of function calls and matches the existing flow for other parameters. Bug: 1138622 Change-Id: Ib588e67f94f1ebd4283ee7c63efc8544e1d74868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616419Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843046}
-
Adam Langley authored
If the input to a QR code only uses certain values (A-Z, 0-9, plus a handful of punctuation) then it can be encoded with 11 bits per pair of symbols. This change adds support for that mode in order to better support eSIM QR codes, which can make use of this. Change-Id: Id3164dada8c45606e6dfa92dd30f6eb213d9b19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623841 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#843045}
-
Hiroki Nakagawa authored
Before this CL, activation for prerendering navigation is avoided by the order of prerender start and map insertion in PrerenderHostRegistry::StartPrerendering(). After this CL, it's explicitly avoided by checking RenderFrameHostImpl::IsPrerendering() in PrerenderHostRegistry::SelectForNavigation(). Bug: 1132746 Change-Id: I112cab26f6abd004554ef0033613ee5e919c5552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626683Reviewed-by:
-
Jasmine Chen authored
Add 2 new client types: ASH_CHROME and LACROS_CHROME and attach a comment to keep the enum in sync with tools/metrics/histograms/enums.xml BUG=b:176787333 TEST=Build simplechrome and deploy Change-Id: Ib3db6feaadbc3837f46b2e9320f1fa9a61a60154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626852Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#843043}
-
Ulan Degenbaev authored
The new name is performance.measureUserAgentSpecificMemory. See https://github.com/WICG/performance-measure-memory/issues/11 for background and motivation. This also renames the existing userAgentSpecificTypes field to types. Bug: 1085129 Change-Id: I6cc8a00ea1774e65e7da09634a979e96d443b941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627392 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843042}
-
Francois Doray authored
To support blink::Thread::ThreadId(), a synchronous wait is necessary on blink::WorkerThread creation. To make it possible to remove the synchronous wait in an upcoming CL, we remove blink::Thread::ThreadId() in this CL. Usage is replaced by other mechanisms: 1. Change the priority of the compositor thread After creating the compositor thread, we post a task to it to obtain its tid via base::PlatformThread::CurrentId(). We send the obtained tid to the browser process so it can set the desired thread priority. 2. Store the tid in WorkerInspectorController Since the code runs on the worker thread, we can just invoke base::PlatformThread::CurrentId() instead of blink::Thread::ThreadId(). 3. Generate an AgentId for testing Instead of using the tid of the main thread as a unique identifier, we use base::GetCurrentProcId(). Bug: 1080709 Change-Id: If92718a2e28b1d9e8ab9f259c95a5f27aee87e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580005 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843041}
-
Francois Doray authored
[sheriff] Add failure expectation for fast/forms/suggestion-picker/time-suggestion-picker-appearance.html on Win7. This expectation was mistakenly removed by https://chromium-review.googlesource.com/c/chromium/src/+/2595684 R=masonfreed@chromium.org TBR=masonfreed@chromium.org Bug: 1045510 Change-Id: Id24b804654e9ad84cce0d73b01755b5aba6ccc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626773Reviewed-by:
-
James Vecore authored
Payload progress percent logging tends to spam logs and is rarely if ever useful. Change-Id: I4eeb5abcc934cdf8b763e924c4a2ac1d0e5658e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627167 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#843039}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6c1a4e7c051ebce47d823b380ee269061e358cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627131Reviewed-by:
-
Stephan Hartmann authored
Comparing base::StringPiece("\x11\x11") with base::StringPiece("\x99\x99") wrongly returns that "\x99\x99" is smaller than "\x11\x11". The problem here is that characters are interpreted signed. In previous example 0x99 is therefore interpreted as -104 which of course is smaller than 17 (0x11). Clang is not affected, because it uses __builtin_memcmp or __builtin_wmemcmp. Solution is to use std::char_traits<T>::lt, which is constexpr in C++14 already and handles signed characters correctly. Bug: 941696 Change-Id: I24edfa4f92058faf87bd029b06832ae1e9e3a6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624670 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843037}
-
Benoit Lize authored
Make sure we don't forget any sanitizer when deciding to not use our own allocator. HWASAN was missing from an "else" clause, even though it requires its own allocator. Reported by bartekn@. Change-Id: Iecfc14d4a4782ab8c72f8015948afe3cd8485169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627155Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843036}
-
Francois Doray authored
TBR=yoavweiss@chromium.org R=yoavweiss@chromium.org Bug: 1164459 Change-Id: I6d70a3ab12f51b4b777de99693fdb0684ffe65d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627688Reviewed-by:
-
Kyle Horimoto authored
We've seen some intermittent connectivity issues where BLE scans do not pick up advertisements sent by the phone. However, it's hard for us to tell what service data is being scanned so that we can match this logged data up with bug reports on the phone. This CL logs this metadata during BLE scans. Bug: 1164572 Change-Id: Icefbd5624a7c5987db944883d1e77d6530951f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626316Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802 2021-01-13 treehugger-gerrit@google.com Merge "Migrate kTrackEventDescriptor to build time" 2021-01-13 hjd@google.com Merge "upkeep: Use empty() rather than size() == 0" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I818943960691d5c413a9dc08ed1d3888c419577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627061Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/a6c17c7e84..322ae2420d Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/a6c17c7e84..322ae2420d No changes to .def files. Bug: None Change-Id: I512dc2a70354d72feb8a8af825f27b4037470367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626438Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#843032}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I400a11265c847f687c49305d58155d7f962fc41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627555Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - selection_menu_controller.js - sort_menu_controller.js - webui_command_extender.js In ui/file_manager/file_manager/foreground/js/ui/: - dialog_footer.js Bug: 1133186 Change-Id: Ia143482ddc25ab56cbd5bb10f3704b3c2764c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626990 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Xi Han authored
The crash is caused by LayoutManagerChrome#showOverview() is called before the LayoutManagerChrome is initialized. More specifically, the TabModelSelector hasn't been set to the LayoutManagerChrome. However, the null check doesn't seem necessary when LayoutManagerImpl#startShowing() is called. Thus we remove this check to avoid crash on the debug build. Bug: 1164884 Change-Id: If5dc74ce39bed62f6ac0fa07a7578fda18ba6bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622326Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I51c3d969d8f97cafb203e9b598cbedd6f48a8025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627134Reviewed-by:
-
Adam Rice authored
Extend the lifetime of histograms Blink.Compression.CompressionStream.Format and Blink.Compression.DecompressionStream.Format. These aren't currently needed, but will be needed again in future when we add more formats. BUG=1158458,1158457 Change-Id: I9aa9ad94eb389a085e626750112ed5d7c319bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624275 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#843027}
-
Hans Wennborg authored
These flags were removed in crrev.com/824947 but the thinlto flag was accidentally left behind. Bug: 1127713 Change-Id: Iea53c31a0f4a0a7ea09153595646ca6d13a9d45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627316 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843026}
-
Raymond Toy authored
Remove the histogram WebAudio.OfflineAudioContext.SampleRate384kHz. Also removing OAC.ChannelCount, and OAC.Length since they all go with SampleRate384kHz and there's no point in keeping these if one of them is expired. Bug: 1165240 Change-Id: I9dcb3ea66ba4ba7704e0bbf1164a9cf0d5a395da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625378Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843025}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ze58P0cJwOmw_WVAzh3TDsg4AbgoRTTor2emAc_jh6EC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173070498,b/174442020,b/174603791,b/176508429,b/176852796,b/177378673,b/177383478 Tbr: media-app@grotations.appspotmail.com Change-Id: I7bc9678c86833e7befa5bf507dc38618f0449155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627557Reviewed-by:
-
Tsuyoshi Horo authored
We still want to preserve the following histograms: * PrefetchedSignedExchangeCache.HeadersSizeTotal * Net.NetworkErrorLogging.SignedExchangeRequestOutcome Bug: 1165258, 1165256 Change-Id: If7d302b8298e89a1d2a164b8f81a459725e1431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626617 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843023}
-
Michele Mancina authored
User connection is evaluated based on the roundtrip times to our backend. The website speed is based on the duration of single "active" cycle in the wait for dom operation. Bug: b/175311081 Change-Id: Id7e57b8958af31d3e841b6d728fef16689b5edd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614838 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#843022}
-
Geoff Lang authored
ANGLE's libGLESv2.dylib and libEGL.dylib ship with Chrome by default so package so export the symbols for crash reports. Bug: angleproject:5534 Change-Id: Ide0b9be3a41034fc41d80c3de337b3a92dd66888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625407Reviewed-by:
-
Francois Doray authored
R=waffles@chromium.org TBR=waffles@chromium.org Bug: 1166196 Change-Id: Iada0c9d68acf3e7c5a0dc395382a2e1cb62d5fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626772Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843020}
-
