- 10 Apr, 2020 40 commits
-
-
Jaeyong Bae authored
This patch means removing spelling markers if the form element is marked as readonly and disabled. The spec seems pretty clear regarding this [1]: The value of textarea elements that do not have a readonly attribute and that are not disabled. [1] https://html.spec.whatwg.org/multipage/interaction.html#spelling-and-grammar-checking Bug: 687949 Change-Id: I716d1607d12a603c821211cc0b1933d05b9fdda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120992 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#758191}
-
Scott Violet authored
Here's the doc for the new function, which is added to Navigation: Sets a header for a network request. If a header with the specified name exists it is overwritten. This method can only be called at two times, from {@link NavigationCallback.onNavigationStarted} and {@link NavigationCallback.onNavigationStarted}. When called during start, the header applies to both the initial network request as well as redirects. @param name The name of the header. The name must be rfc 2616 compliant. @param value The value of the header. The value must not contain '\0', '\n' or '\r'. @throws IllegalArgumentException If supplied invalid values. @throws IllegalStateException If not called during start or a redirect. @since 83 public void setRequestHeader(@NonNull String name, @NonNull String value) { BUG=1065536 TEST=covered by tests Change-Id: Ibe6487bcc7167fd2e68fcaee46915a877f4619b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133171Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758190}
-
Scott Violet authored
This makes changing the active tab trigger exiting fullscreen, so that we don't end up trying to do something bad. This also makes TopControlsContainerView.destroy() remove a callback, just to be safe. This also consolidates code for notify of active change. The net result is a slightly different notification order, but I'm hoping it won't cause problems. BUG=1069417 TEST=FullscreenCallbackTest.testExitFullscreenWhenTabDestroyed Change-Id: I59a8f40b05a4f94b0720cbb4930cb3a87892d4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145093Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758189}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Id6f952376c4be6528664dc2ec765ec6359733b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144748Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758188}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9713ba15b38..469c029a7c22 git log e9713ba15b38..469c029a7c22 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 538512e8e898..34be23373b9e (2 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 75de196cecab..fd593d5f0834 (1 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 47d5e27460af..e7bbc302dff2 (1 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ae6787114fb5..2fd41fab58c8 (2 commits) Created with: gclient setdep -r src/third_party/angle@469c029a7c22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8c1b9d3271bcb9d101858dcee05a2137f0e4c89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758187}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8277ecb30334..c2dcb3eec9ad git log 8277ecb30334..c2dcb3eec9ad --date=short --first-parent --format='%ad %ae %s' 2020-04-10 btolsch@chromium.org Force test logic checks in e2e tests Created with: gclient setdep -r src/third_party/openscreen/src@c2dcb3eec9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieee34ef9d103ad5dffad07776a4a30a3bceb6fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145592Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f13dee83. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id13d71e6a0bf07803b42494d82ca52b08286336c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758185}
-
Nikita Podguzov authored
We are not going to have page size restriction policy in the near future. If we ever implement this policy it will have more scalable format (see follow-up CL). Taking into the account the above, we delete PrintingAllowedPageSizes policy from the code. It's safe as we have never released this policy ('future': 'true') and have even never had appropriate handler for it. Bug: 1015690 Change-Id: I38129f8012e82c6a27413597b615c3111593d821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135690 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758184}
-
Kenichi Ishibashi authored
This CL adds ServiceWorkerResourceMetadataWriter which will be used by browser/embedders to write metadata (V8 code cache) to storage. This will be used after ServiceWorkerStorage is migrated to the storage service. Bug: 1055677 Change-Id: If2a18d89ce5483f8c4792c78309eceeedbdc22d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138659 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758183}
-
Koji Ishii authored
This patch adds a DCHECK to ensure |NGFragmentItemsBuilder| computes the capacity of items before it adds them. Bug: 982194 Change-Id: I50f64eaa6f3f9f1c31ebd5f27b16e2c8e5d20a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145378Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/059c1b75eb67..9f0b36c4610d git log 059c1b75eb67..9f0b36c4610d --date=short --first-parent --format='%ad %ae %s' 2020-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 407aa3d6..bc4df9dd (758038:758140) 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ca551bc6..407aa3d6 (757925:758038) Created with: gclient setdep -r src/third_party/webrtc@9f0b36c4610d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ife89aeabe76f31eb3ed3675ae2f156afbae88fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145441Reviewed-by:
-
Takuto Ikuta authored
Bug: 1069704 Change-Id: Ibb832d55710f5d7cc8546e41100401bec55798e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144807 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#758180}
-
Benoit Lize authored
FontResource clears the decoded data when all clients are removed. This is not interacting well with a recent change, https://chromium-review.googlesource.com/c/chromium/src/+/2134291. The change above discards the encoded data after it has been decoded, as the encoded data is never used afterwards. However, when all clients of a FontResource instance are destroyed (typically when the @font-face src value object is destroyed), we clear the decoded data, but do not remove the FontResource from the memory cache. This means that the following scenario: 1. CSSFontFaceSrcValue is destroyed (typically after a navigation) 2. *No GC* 3. A new document is parsed, and the font is found in the memory cache The newly-matched FontResource is not usable, since it doesn't hold a decoded or encoded representation, triggering console messages, which appear as a regression in the linked bug. This can be fixed in two ways: - Revert the encoded data clearing patch above - Don't drop the decoded data when clients disappear The second solution is preferable, since once all clients have disappeared, the resource will not outlive the next GC cycle unless claimed in the meantime. However clearing the encoded data reduces memory footprint in steady state. In addition, the current behavior leads to a new decompression of the font resource at each navigation, which is wasteful. As a consequence, this patch removes the clearing of decoded data once clients are gone. This was verified as removing the console warnings on cnn.com, which is one of the sites triggering the alert on perf bots. Bug: 1067226, 1067930 Change-Id: I3ebb96b8e310a2d6cf46fbbedfdce95999b520de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141924Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/538512e8e898..34be23373b9e git log 538512e8e898..34be23373b9e --date=short --first-parent --format='%ad %ae %s' 2020-04-09 stevenperron@google.com Handle more cases in dead member elim (#3289) 2020-04-09 h.baensch.92@gmail.com Fix pch macro to ignore clang-cl (#3283) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@34be23373b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I4da9d1a7e21e6346c423d03b6ee52bb113993272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145434Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1049995 Change-Id: Iac13d70fb24f9dc5f36937d625ce33bd7152b092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144079 Auto-Submit: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#758177}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c68dfaf3a529..e9713ba15b38 git log c68dfaf3a529..e9713ba15b38 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 3cfa8e28be80..e6f65d9265e7 (5 commits) Created with: gclient setdep -r src/third_party/angle@e9713ba15b38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Idbb9bcf6eaf7e0d89f4feda21a25a94f7bc3cb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145435Reviewed-by:
-
Brian Manthos authored
Change-Id: I3cd0ce5838f274fa8b913705da9ae47a0aff7d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145258Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758175}
-
Colin Blundell authored
We are shortly going to componentize the AuthenticatorNavigationInterceptor interface for reuse by WebLayer. However, this interface is used downstream: it is both implemented and returned by an implementation of AppHooks#createAuthenticatorNavigationInterceptor(). This CL paves the road for allowing this componentization to occur upstream without breaking downstream: - We introduce an identical //components-level interface. - We add a new method to AppHooks that returns an instance of the //components-level interface. Downstream we can then have the subclass implement both the //chrome- and //components-level interfaces, and implement the new AppHooks method by returning the instance of the subclass (like the implementation of the current AppHooks method). This will in turn allow us to transition upstream to talking in terms of the //components-level interface without breaking downstream. Finally, we will be able to clean up by removing the upstream interface and all references to it downstream, followed by removing them upstream. A happy technical note: As git does content-based similarity comparisons, it picks up the new file as being the same as the //chrome-level one (i.e. git log --follow on the new file shows the history of the //chrome-level one). Bug: 1031465 Change-Id: Ifc843a550a3b96c5cbeb62cde6a3a1b140614db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144172 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#758174}
-
Javier Ernesto Flores Robles authored
Adds to the password form the encrypted password when fetching from the password store or passing through a change list. On iOS this corresponds to the UUID used to retrieve the passwords from the keychain services. This is needed in order to fetch the passwords in Credential Provider without duplicating the entries in the keychain. Bug: 1066803 Change-Id: I921ad33cdc7579835059a4ff8768761ac5e6bf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142112 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758173}
-
arthursonzogni authored
It was very hard to understand how the blink implementation of CSP inheritance was working. The FrameLoader was sometimes defining a CSP in FrameLoader::CreateCSP(), sometime not. Then it was overridden/completed in SecurityInitContext::InitializeContentSecurityPolicy() based on the side effects of several parameters. This patch achieves the following: - FrameLoader always defines the final CSP. - SecurityInitContext does not override it. There are many small potential behaviors changes in the patch. Choices have been made to keep things simple and understandable. Maybe this will introduces some regressions. This will be the opportunity to add additional tests. As a result this marked as: DO NOT COMMIT before M83 branch cut. Change-Id: If00d28601853061556d0d5643dcb467ca262715c Bug: 1065876, 1064676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111170Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758172}
-
Christoph Schwering authored
The static assertion kInvalidValue <= 0 in IdType avoids undefined behaviour in IdType::Generator, which starts off with kInvalidValue + 1. Unsigned types however are guaranteed to wrap around, and UINT_MAX is a common invalid value. This CL therefore makes the static assertion vacuously true for unsigned types. Specifically this change is needed for CL 2141990. Bug: 1040280 Change-Id: I6ca1533be8fa256ff0a53a988c4e360048de3fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142115 Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#758171}
-
Jacobo Aragunde Pérez authored
Also modified the expected output of the corresponding tests, and the SessionCrashedBubbleView so it keeps behaving as before. Bug: 1052675 Bug: 1068316 Change-Id: I33d65c3035644ff8eb32fda7c012a3724fde925c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139712Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#758170}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/595e98f87513..8cc69b103725 git log 595e98f87513..8cc69b103725 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 thestig@chromium.org Avoid a static_assert in FxAllocAllocator in MSVC debug mode. 2020-04-09 nigi@chromium.org Make PRESUBMIT.py accept SkiaPaths expected results. 2020-04-09 thestig@chromium.org Add regression tests for a failure in FindPageIndex(). 2020-04-09 thestig@chromium.org Move testing/tools/.style.yapf to the root directory. 2020-04-09 thestig@chromium.org Rename link_annots.pdf to annots.pdf and add a widget annotation. Created with: gclient setdep -r src/third_party/pdfium@8cc69b103725 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I12ca7a32dca66ee5519dd9ec3c4e4e93ebde96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145190Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/PanIU.....e-tS4... Created with: gclient setdep -r src/third_party/aemu-linux-x64@e-tS4... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I6c4245afc93c8363f3808bf75ab426c46c430263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145433Reviewed-by:
-
Maksim Sisov authored
We have cleaned up ui/gl from USE_X11. These includes are not needed anymore. TBR=backer@chromium.org Bug: 1036285 Change-Id: I6420b774a6a190527f76ab3fa5cb058b54d76a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144136Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#758167}
-
Yuki Shiino authored
Stringifier.IR and IndexedAndNamedProperties.IR are not updated during the compilation, so these IRs shouldn't be used at all. Bug: 839389 Change-Id: Id74cb0f310cd234794f22a675a281ee3b078be42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141500Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758166}
-
Brian Manthos authored
No functional changes. Change-Id: Ic7d93c1c13d174a7d04a251bedcc8b5bcfb458bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145132 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
-
Shakti Sahu authored
This CL includes : 1 - Rounding the tiles using RoundedCornerImageView 2 - Gradient overlay above RCIV 3 - Tile width calculation logic depending on screen size Bug: 1068666 Change-Id: I014a01f17514e8df1da65cfd12e2baf9eb931e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137818 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#758164}
-
Gauthier Ambard authored
This CL makes sure that we don't display the NTP if the loaded page is an interstitial page. This is caused by the behaviour of interstitial when the committed interstitial feature isn't enabled. In that case the workflow is: 1. about:newtab is loaded 2. User loads bad.badssl.com 3. Navigation did start for bad.badssl.com 4. Navigation ends for bad.badssl.com 5. This is a bad ssl page so Chrome actually reverts to about:newtab 6. Load stops, but at this point the visible URL is about:newtab 7. The interstitial is displayed and the visible URL is updated to bad.badssl.com 8. The observers are notified through DidChangeVisibleSecurityState 9. No further callbacks So the main issue is that there is not callback notifying that the visible URL has changed. This CL fixes it by adding a callback on DidChangeVisibleSecurityState and also on LoadStop to avoid having the NTP flashing between 6 and 7. Fixed: 1067250 Change-Id: Ifc57addf5a6fa9e6295446da34e117028add73fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141971 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758163}
-
Nohemi Fernandez authored
Updates EarlGrey tests that are impacted by the new default signout UI. Bug: 1005509 Change-Id: I688c15b7b3a7b77be6da9e87d2047dd831818aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139708Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758162}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b60df8ed2de8..1260c0bbd0ae git log b60df8ed2de8..1260c0bbd0ae --date=short --first-parent --format='%ad %ae %s' 2020-04-10 mathias@chromium.org Update console message expectation Created with: gclient setdep -r src/third_party/devtools-frontend/src@1260c0bbd0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2e8e1509c0ed00d8a9cb7eb4cacb6adc4a4a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145319Reviewed-by:
-
Colin Blundell authored
We are targeting InterceptNavigationDelegateImpl for componentization and sharing with WebLayer. The main blocker is its dependence on Tab. This CL starts decoupling InterceptNavigationDelegateImpl from Tab: - We add a //chrome-level InterceptNavigationDelegateTabHelper object to attach InterceptNavigationDelegateImpl to a Tab. - We add an InterceptNavigationDelegateClient interface that the embedder implements to give the context that InterceptNavigationDelegateImpl is currently obtaining from Tab, and populate it with an initial method. The implementation of the Client interface is currently separate from the TabHelper object due to a thorny circular dependency issue in InterceptNavigationDelegateTest.java. Once InterceptNavigationDelegateImpl is cleaned of all dependencies on Tab I suspect that this circular dependency will go away and we will be able to merge the Client implementation into the TabHelper object. Future CLs will complete the cleaning of //chrome-level dependencies from InterceptNavigationDelegateImpl. Bug: 1031465 Change-Id: I0f63b31d77efffe9d74ff68065c55e59ba163cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134290 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
Currently, during the initial merge of bookmarks it may be possible that processing of local creation may cause crash if the previous neighbour wasn't processed yet (due to matching by GUID with some remote update). This patch fixes that behaviour by finding the last tracked entity. That entity will be used to calculate next UniquePosition. Bug: 1050776 Change-Id: I5275aee07d5bd5f4e4ac534734c209ec2ed78b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144160 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758159}
-
Takashi Toyoshima authored
This patch updates the policy_templates.json to update the announced removal plan. This will also update the official support page for these enterprise policies. Bug: 1053866 Change-Id: Ie31dbeb7d00b4ae9ce2b45757dc9ad4a8c62181f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134753 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Alex Kalugin authored
Check for ShouldKeepErrorPageInCurrentProcess in case of failure produces incorrect log output (both new error codes). Change-Id: I405c1c901ce5abe516a37d30a408633b0c81eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144198Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#758157}
-
Mansi Awasthi authored
This CL adds an end to end browser test for validating that PDF text fields are getting added to the accessibility tree correctly. It also includes a test to validate the value of inline text boxes for PDF with text fields. Bug: 1030242 Change-Id: I4f337ad5459b36239549b40e35ef16a52c5f16d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134092Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758156}
-
Maksim Sisov authored
Actually, I couldn't find the real use of this code. It seems like all the windows we create are aura Windows and this condition never executes. Bug: 1069469 Change-Id: Ic3caebca38769e45b873cbc15f1ef618232be390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144054 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758155}
-
Yoichi Osato authored
Bug: 1066716 Change-Id: I7dfe445604ad6e8556e7f9de462ceed7f0305fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142883Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#758154}
-
arthursonzogni authored
This reland the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2062336 The diff: https://chromium-review.googlesource.com/c/chromium/src/+/2144100/1..5 The previous CL was reverted because if was not compiling reliably. The target: //third_party/blink/common:common was missing: //services/network/public/mojom:mojom_blink However, adding it would creates a dependency cycle: ERROR Dependency cycle: //third_party/blink/public/common:common -> //third_party/blink/common:common -> //services/network/public/mojom:mojom_blink -> //mojo/public/cpp/bindings:wtf_support -> //third_party/blink/public:blink_headers -> //third_party/blink/public/common:common It means we can never #include a generated .mojom-blink.h from //third_party/blink/common:common Fortunately, there are already many .mojom-shared.h there. So we can can include web_sandbox_flags.mojom-shared.h instead. The enum definition is entirely contained in this file anyway. The mojom-shared.h is already a dependency:: /third_party/blink/common:common -> /services/network/public/cpp:cpp -> /services/network/public/mojom:mojom [generated HERE] R=kinuko@chromium.org TBR=thakis@chromium.org,mfoltz@chromium.org,iclelland@chromium.org,mkwst@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org Bug: 1041376 Change-Id: I272d4971920d6d3c04a965f1aa9b90376353b446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144100Reviewed-by:
-
Wei Lee authored
The mojom_bindings_generator.py is refactored again by https://crrev.com/c/2128966 And cause the deploy function of cca.py out of work. This CL fixes the usage accordingly. Bug: None Test: cca deploy works again Change-Id: I55003cf6317c400b1b82df8139d28d6111c0bef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142885Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758152}
-
