GitLab

BUG=373096
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/286993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270897 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayF… (https://codereview.chromium.org/292473002/)

Reason for revert:
Forgot to import DisabledTest

Original issue's description:
> Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo
> 
> The test is still failing on Android Tests (dbg) bots. See:
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29
> 
> BUG=372748,372174
> TBR=boliu
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270889

TBR=boliu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=372748,372174

Review URL: https://codereview.chromium.org/290083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270896 0039d316-1c4b-4281-b951-d872f2087c98

To verify it I ran the following command line:

$ g grep -h "#include \"" ui/surface/ | sort | uniq

Removing unused dependencies will help when converting this target to
GN, specially since media is not yet ported.

BUG=None
TEST=still links + green trybots
R=piman@chromium.org

Review URL: https://codereview.chromium.org/278173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270895 0039d316-1c4b-4281-b951-d872f2087c98

Once all pages are force composited by default, this allows these tests
to not explode when trying to create GraphicsLayers because of a lack of
Platform::compositorSupport.

BUG=none

Review URL: https://codereview.chromium.org/287043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270894 0039d316-1c4b-4281-b951-d872f2087c98

This test consistently fails on Android Tests (dbg). See:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29

BUG=374038
TBR=henrika
NOTRY=true

Review URL: https://codereview.chromium.org/286023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163931

Review URL: https://codereview.chromium.org/288083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270892 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/288163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270891 0039d316-1c4b-4281-b951-d872f2087c98

Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.

Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.

[49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
[49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
[49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362

BUG=368684
TEST=Manual testing as described on http://crbug.com/368684#c1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343

Review URL: https://codereview.chromium.org/266343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270890 0039d316-1c4b-4281-b951-d872f2087c98

Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo

The test is still failing on Android Tests (dbg) bots. See:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29

BUG=372748,372174
TBR=boliu
NOTRY=true

Review URL: https://codereview.chromium.org/292473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270889 0039d316-1c4b-4281-b951-d872f2087c98

WebRtcBrowserTest.CallWithDataAndMedia is flaking on Android Tests (dbg).

BUG=374034
TBR=perkj
NOTRY=true

Review URL: https://codereview.chromium.org/290633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270888 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up some of the trusted plugin logic for requesting a NaCl manifest
and removes some interfaces in PPB_NaCl_Private, providing better
encapsulation.

This code is easier to follow after this change, as well, since more of the
logic is unified in ppb_nacl_private_impl.cc. This is part of a larger effort
to remove the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/288773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/290633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373473

Review URL: https://codereview.chromium.org/285253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270885 0039d316-1c4b-4281-b951-d872f2087c98

There were several places we could crash but not try to get a stack. This should
take care of everything.

BUG=371613, 373385
R=achuith@chromium.org, dtu@chromium.org

Review URL: https://codereview.chromium.org/282223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270884 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/288003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270882 0039d316-1c4b-4281-b951-d872f2087c98

We want to run menus without aura for the mac port of views.
This change allows menus to run with or without aura.
This is accomplished by introducing a MenuMessageLoop interface to abstract
the platform-dependent parts of the menu controller. It is responsible for
running and quitting the nested message loop, and reposting events.

BUG=366007

Review URL: https://codereview.chromium.org/267593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362288

Review URL: https://codereview.chromium.org/291503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270880 0039d316-1c4b-4281-b951-d872f2087c98

Test:
1. run chrome with a metrics enabled and with force-fieldtrials to
  get into a search-term-replacement group
2. enter a query, hit return
3. on the search results page, click in the omnibox and press
  return again (no typing), this reissuing the query while keeping
  the omnibox closed.
4. before this change, the browser would crash.  now it does not.

BUG=370119

Review URL: https://codereview.chromium.org/288073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270879 0039d316-1c4b-4281-b951-d872f2087c98

From the browser-side of things, compositing is always on, except for layout
tests.  The places that do test the compositing state on the browser side are
irrelevant for layout tests and/or redundant with existing state (e.g. whether
we received a frame).

BUG=None

Review URL: https://codereview.chromium.org/274163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270878 0039d316-1c4b-4281-b951-d872f2087c98

- Window manager provided window borders
- Custom shapes specified via views::Widget::SetShape()

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/268673017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373540
TEST=see bug for repro; should not DCHECK.

Review URL: https://codereview.chromium.org/290553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270876 0039d316-1c4b-4281-b951-d872f2087c98

When pthread_create create fails, the content of handle becomes
undefined, but PlatformThreadHandle::platform_handle is initialized to
0, which makes the CHECK_EQ fail.

Fix by resetting handle to 0 if pthread_create fails.

BUG=373905

Review URL: https://codereview.chromium.org/289013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270875 0039d316-1c4b-4281-b951-d872f2087c98

Original patch here: https://codereview.chromium.org/251543003/.
Reverted here: https://codereview.chromium.org/278183002/,
due to memory management issues in tests.

Relanding with a better strategy for cleaning up deleted
GestureProviderAura objects.

This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.

BUG=332418
TEST=GestureRecognizer/GestureRecognizerTest.*
MotionEventUITest.*
TBR=jochen

Review URL: https://codereview.chromium.org/282593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270874 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to cause compile failure on Win Builder:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20401

> Mojo: Internalize ServiceConnector<>
> 
> Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/
> 
> R=viettrungluu@chromium.org, darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/284113009

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/287003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270873 0039d316-1c4b-4281-b951-d872f2087c98

* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.

This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.

BUG=331530
TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/200473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/288003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270871 0039d316-1c4b-4281-b951-d872f2087c98

This prep work will allow the interface in blink to be changed.

Blink change is https://codereview.chromium.org/284143002/.

BUG=360254

Review URL: https://codereview.chromium.org/282073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270870 0039d316-1c4b-4281-b951-d872f2087c98

Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/

R=viettrungluu@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/284113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270867 0039d316-1c4b-4281-b951-d872f2087c98

These methods will be used bisect script to track the status of build.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/284493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270864 0039d316-1c4b-4281-b951-d872f2087c98

While I'm here make it more consistent with the other foo_strings.gyp we have
in the tree.

Some changes:
1) Make it use grit_target.gypi
2) Have a consistent and path oriented grit_out_dir.
3) Prefix the action name with generate_
4) Remove direct_dependent_settings, since that is what grit_target.gypi
is for.

R=jamescook@chromium.org
TBR=thestig@chromium.org # for trivial change in chrome/

Review URL: https://codereview.chromium.org/281183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270863 0039d316-1c4b-4281-b951-d872f2087c98

Upgraded GCC 4.8 for arm with the latest patches from aosp.
Fixes some performance regressions with GCC 4.8

BUG=359106

Review URL: https://codereview.chromium.org/286113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270862 0039d316-1c4b-4281-b951-d872f2087c98

Upstreams AutocompleteController and OmniboxSuggestion on java side.
Upstreams autocomplete_bridge.cc and renames it to
autocomplete_controller_android.cc.

BUG=222130

Review URL: https://codereview.chromium.org/285633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270861 0039d316-1c4b-4281-b951-d872f2087c98

Looks cleaner this way and avoids creating an unnecessary target in a
random place in content.gyp, also helps keeping things self-contained.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/271243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270859 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the new avatar button.
See CL https://codereview.chromium.org/240453006/ for how this will be used
to override the text rendering of the button.  Currently the new avatar menu
override the text rendering but does not do so correctly if the button has
an icon.  This change allows the new avatar menu to override the text render
more cleanly.

BUG=311235

Review URL: https://codereview.chromium.org/284033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270858 0039d316-1c4b-4281-b951-d872f2087c98

The actual validating logic will be in a separate CL.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/273233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270857 0039d316-1c4b-4281-b951-d872f2087c98

Also added default build_type as Release to build method arguments.

BUG=373915
NOTRY=true

Review URL: https://codereview.chromium.org/287063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270853 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=10&start=14755
TBR=
BUG=

Review URL: https://codereview.chromium.org/282323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270852 0039d316-1c4b-4281-b951-d872f2087c98

The env vars are still used in profiling=1 builds, by such
illustrious figures as the deep memory profiler bot and
willchan. Reading from the environment variables uses static
initializers, so this change will eliminate those static
initializers in profiling=0 builds.

As discussed in the chromium-dev thread
"Does anyone use tcmalloc's debugging envvars?".

BUG=94925
NOTRY=true

Review URL: https://codereview.chromium.org/281613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270850 0039d316-1c4b-4281-b951-d872f2087c98