- 13 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51a60d9d8dca..16bc600d527a Created with: gclient setdep -r src-internal@16bc600d527a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If12294a83b54cd421dadba8064d4148be185cc5c Reviewed-on: https://chromium-review.googlesource.com/c/1332830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607506}
-
Nektarios Paisios authored
I tried hard, but I wasn't able to make non-text positions work inside a table. The DOM parser collects all the non-white space text nodes between the table cells and places them in a single text node before the table element. This is not part of the accessibility code, but is how the DOM parser works. The alternative, which I implemented in this patch, is to enhance the table test by adding more selections inside text nodes. <table> ^<tr> <td>column</td> </tr>| </table> Becomes in the DOM tree: Body ++#Text "\n^|\n" ++Table ++++Tr ++++++Td R=dmazzoni@chromium.org Change-Id: I99c4a1f14805f9a0ba4addbaaff9bad1b1a0b86b Reviewed-on: https://chromium-review.googlesource.com/c/1332728Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24bad97f..eb9d3fbd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58bae19089f736c8f54d96929b3a53f0eb10b0a1 Reviewed-on: https://chromium-review.googlesource.com/c/1333125Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607504}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I4a8be4dff14b6921cc2fb04eb34594f759c545df Reviewed-on: https://chromium-review.googlesource.com/c/1333168Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#607503}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b18583285cb..cd47a379f960 git log 0b18583285cb..cd47a379f960 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 jie.a.chen@intel.com Add SH_INIT_SHARED_VARIABLES flag 2018-11-12 timvp@google.com Fix failing dEQP EGL tests. 2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg. 2018-11-12 jmadill@chromium.org Add missing refs.cfg. 2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg. Created with: gclient setdep -r src/third_party/angle@cd47a379f960 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898030,chromium:833848,chromium:833848,chromium:833848 TBR=cwallez@chromium.org Change-Id: I5b67d20c08fdeb6614bca9c7e0f451988f836d27 Reviewed-on: https://chromium-review.googlesource.com/c/1333054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607502}
-
Sam McNally authored
Guest mode profiles do not have a valid account ID key so requesting their DriveFS path is invalid. Such accounts never have Drive enabled and the downloads path should not be within Drive if disabled. Update DriveIntegrationService to avoid paths within Drive when disabling Drive with DriveFS enabled so the above assumption is valid with DriveFS enabled. Bug: 904558 Change-Id: Ic8b64609f3657feae4b1f289e3726a51a871b36c Reviewed-on: https://chromium-review.googlesource.com/c/1333091Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607501}
-
Hayato Ito authored
EventPath: :operator[] can be used. Change-Id: I97a49e26c2903e7966d23594e8283e77b5bd235d Reviewed-on: https://chromium-review.googlesource.com/c/1333170Reviewed-by:
-
Xiaocheng Hu authored
This patch stops a crash in InlineContents previous/next iteration by terminating the iteration at document boundary, so that subsequent operations don't proceed with invalid parameters. Bug: 903723 Change-Id: Iaed2ac1d5d74d3ab59da3a2f0db2d4f8150fb21b Reviewed-on: https://chromium-review.googlesource.com/c/1331571Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607499}
-
Adam Rice authored
It turns out to better to create the MessagePort early in C++ and then pass it to ReadableStreamSerialize. Make ReadableStreamSerialize take a second argument instead of creating its own MessageChannel. This also enables us to remove MessageChannel from the binding object. Also add wrapper methods on ReadableStream to abstract out the V8 Extras implementation. No user-visible changes. BUG=894838 Change-Id: I2616855d34a925915919245ec10338463ac5ef37 Reviewed-on: https://chromium-review.googlesource.com/c/1329813Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607498}
-
Xianzhu Wang authored
We treated only DrawingDisplayItem as cacheable before SlimmingPaintV175 because other display items were all about paint properties which are not feasible to be cached (mostly because they are paired and sometimes don't have unique id). Now we have removed paired display items, thus the remaining types of display items are all eligible to be cached. This prepares for making HitTestDisplayItem not DrawingDisplayItem to reduce its size, etc. Change-Id: I28bd5533d3b85a67fc16e90aea059115b51188e7 Reviewed-on: https://chromium-review.googlesource.com/c/1329805Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ce66d537f0b..51a60d9d8dca Created with: gclient setdep -r src-internal@51a60d9d8dca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29cf19fce446ff4a55f6c40d3c4eae4907a4b42c Reviewed-on: https://chromium-review.googlesource.com/c/1332829Reviewed-by:
-
Xianzhu Wang authored
- Combine CullRect::UpdateCullRect() and CullRect::UpdateCullRectForScrollingContents() into CullRect::ApplyTransform() which accepts a TransformPaintPropertyNode. For SPv2, if the transform node has scroll node, we'll expand the cull rect for composited scrolling. - Rename CullRect::IntersectsCullRect() to CullRect::Intersects() - Change CullRect constructor with offset to mutation methods to keep consistent with ApplyTransform(). Bug: 792577 Change-Id: I306f5c7acacf73d97100c6c863b71e0df41c34af Reviewed-on: https://chromium-review.googlesource.com/c/1319650Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607495}
-
Hiroki Nakagawa authored
To sheriff: Please re-disable the test if it's still flaky. In this test file, some tests start re-registering the second service worker before the first service worker gets activated. In my theory, this sometimes squashes the second registration job into the first registration job, and results in test flakiness. This CL makes sure the second register runs after the first service worker gets activated. Note that it would be the correct behavior that the second registration job isn't squashed when the script type is changed. There is a spec issue about this: https://github.com/w3c/ServiceWorker/issues/1358 Bug: 901317 Change-Id: I7ce379071a35ef9aeb98e4492d651ee6fc4714ec Reviewed-on: https://chromium-review.googlesource.com/c/1328546Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#607494}
-
John Budorick authored
Bug: 861983 Change-Id: Id5cf2ad9525790cc99a0c8da4a8b793bba1e3696 Reviewed-on: https://chromium-review.googlesource.com/c/1317036Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607493}
-
Hayato Ito authored
- EventPath::GetTreeScopeEventContext(TreeScope&) - Node& NodeEventContext::GetNode() - TouchEventContext& TreeScopeEventContext::EnsureTouchEventContext() They never be nullptr. Bug: 874385 Change-Id: I38167ee25dd01113aae7cbbdb97101fce7a07a2e Reviewed-on: https://chromium-review.googlesource.com/c/1332969Reviewed-by:
-
Justin Cohen authored
Enables features to stop loading NTP from within ios/web CRWNativeContent. Instead the NTP is presented directly from the BVC. Also disables a failing pdf test that is already flakey on iOS11. Bug: 826369 Test: Any interactions to navigate to or from, hide or show, an NTP. Change-Id: I61cdcb41b2a09955f6cb994a220cd32ea8a0b602 Reviewed-on: https://chromium-review.googlesource.com/c/1332411 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607491}
-
Nicholas Verne authored
The previous container restart flow would return an error if there was insufficient disk. Free disk size is not relevant if there's an existing disk image. Bug: 891165 Change-Id: I34ed750263182e920ab96befc8b00f1f2b2db89e Reviewed-on: https://chromium-review.googlesource.com/c/1328482Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607490}
-
yoshiki iguchi authored
This CL adds a way to suppress (and un-suppress) picture-in-picture windows. If it is set, picture-in-picture windows can't be crated. If any picture-in-picture windows exist already, they are closed. This CL suppresses only ARC PIP window. Chrome PIP window will be done separately. Summary of change of this CL: - Makes ArcPipBridge observe spoken-feedback pref change - Sends a newly-added mojo message when the spoken feedback en/disables Related CLs: - crrev.com/c/1285253 (chromium/src) - ag/5287718 (vendor/google_arc) - ag/5287717 (frameworks/base) Bug: b/112060145 Test: manual (see pip window is supppressed correctly) Change-Id: I554d74672e4e5136ae21fc0d2440a4150e5b5608 Reviewed-on: https://chromium-review.googlesource.com/c/1285253Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#607489}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: I37428a83f128c03d95d4eb16d6b36fc8c9a272a5 Reviewed-on: https://chromium-review.googlesource.com/c/1333110 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607488}
-
Hajime Hoshi authored
V8 should not be executed on per-thread task runner. Use per-frame (per- execution-context) task runner instead. Bug: 870606 Change-Id: Ibaf9e02bb33eacbf0f29b2bb30645ad8d7a19121 Reviewed-on: https://chromium-review.googlesource.com/c/1331291Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607487}
-
Dmitry Gozman authored
This replaces WebLocalFrameClient::DecidePolicyForNavigation with BeginNavigation, where client may decide how to proceed. Typically, the client would just call CommitNavigation to commit the requested navigation. However, for browser-side navigation, we do instead ask browser to proceed, and temporarily call CreatePlaceholderDocumentLoader. After this patch, we can start removing WebLocalFrameClient callbacks, like {Did,Will}StartProvisionalLoad, since the client now controls the navigation flow and doesn't need a callback. Bug: 855189 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic995073e191a238ac46ae6be2114af596e41425f Reviewed-on: https://chromium-review.googlesource.com/c/1271411 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607486}
-
sangwoo.ko authored
When selected tabs were removed, we must notify that even selection model is unchanged. This is because the old selection model and new one would be same when the newly activated tab was right after prviously active tab. Bug: 842194, 903438 Change-Id: I23fd9d8ba9f1ac10b3daf03088a2c2d974f435d8 Reviewed-on: https://chromium-review.googlesource.com/c/1331098 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607485}
-
Alexandre Courbot authored
Right now the VDA and IP devices are tightly coupled: notably, their buffers follow a 1:1 mapping, and the VDA decides which IP processor buffer to use. This seriously restricts the applicability of the IP interface. In order to remove this constraint, the VDA must not make any assumption about which IP buffer it will receive, the number of buffers it will use, or even their memory type. Doing so means that the VDA will see the IP buffers for the first time as the FrameProcessed() callback is called, and thus that it cannot create an EGLImage for them ahead of time as we used to do. This patch thus delays EGLImage assignment to the first time we meet a given buffer in the FrameProcessed() callback. Thanks to the fact that every picture needs to be cleared on the child thread first, we can schedule the EGLImage creation on the same thread before this happens, thus ensuring that no synchronization issue occur. BUG=792790 TEST=Checked that VDA unittest was passing on Hana, in import and non-import mode, with rendering enabled or not. Change-Id: Ia89b7620fe890fcd4bbd6791fd59660d9bd89f46 Reviewed-on: https://chromium-review.googlesource.com/c/1288498 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607484}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Iffc383f46c75817ac1896642c2705e9c6d1c5009 Reviewed-on: https://chromium-review.googlesource.com/c/1333134Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#607483}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5f26302..24bad97f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic47f6acc920d4ad3402ac528ec0736329e01204b Reviewed-on: https://chromium-review.googlesource.com/c/1332722Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d56676303ac..1ce66d537f0b Created with: gclient setdep -r src-internal@1ce66d537f0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I82df27970b49de90c2a2a30ace1c7c2ada9f6e20 Reviewed-on: https://chromium-review.googlesource.com/c/1332828Reviewed-by:
-
Bruce Dawson authored
The cost of iterator debugging is too great so it should be off by default. It increases build times and sometimes increases run times by multiple orders of magnitude. I am not aware of it finding bugs recently. Bug: 904034 Change-Id: If3d1ea04a6213ed189cbfeb35bc0980283123acb Reviewed-on: https://chromium-review.googlesource.com/c/1330892 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1fd279a353..f04fb3cacbad git log fd1fd279a353..f04fb3cacbad --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Change how GPs configure attributes 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 48f63f90f6f3..298436280db3 (6 commits) 2018-11-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-12 herb@google.com Clean up in, about, and around GrTextBlob::SubRun Created with: gclient setdep -r src/third_party/skia@f04fb3cacbad The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I10b24855c05c992d917eb012161b22e53152fb60 Reviewed-on: https://chromium-review.googlesource.com/c/1333052Reviewed-by:
-
Hayato Ito authored
They never be nullptr. There are still other places which should be a reference, which can be done in another CL. Bug: 874385 Change-Id: I278e022b40a621115d627ac21cdbb9658f98733e Reviewed-on: https://chromium-review.googlesource.com/c/1333167 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/03d1a5ed6cc8..0b18583285cb git log 03d1a5ed6cc8..0b18583285cb --date=short --no-merges --format='%ad %ae %s' 2018-11-12 jmadill@chromium.org Copy configs from infra/config branch. Created with: gclient setdep -r src/third_party/angle@0b18583285cb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:833848 TBR=cwallez@chromium.org Change-Id: If678095e9fb2bd2ece9d49695a4abe5e0b32dd7c Reviewed-on: https://chromium-review.googlesource.com/c/1332349Reviewed-by:
-
Sergey Ulanov authored
In debug builds VulkanInstance::Destroy() was trying to call vkDestroyDebugReportCallbackEXT and it would DCHECK after a failure to find that function. That would happen even if Destroy() is called in after a failed attempt to load Vulkan libs. It doesn't make sense to DCHECK in that case. Also now vkDestroyDebugReportCallbackEXT() is called only if debug callbacks were created successfully. Bug: 861853 Change-Id: I03bbdbb1793ddb74f07352f354d0f70ee739a93a Reviewed-on: https://chromium-review.googlesource.com/c/1332263 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607476}
-
Sam McNally authored
In particular, this fixes Drive virtual folders (Offline, Shared with me) remaining current when Drive is unmounted. Bug: 904298 Change-Id: I54cbb672fdfd6b0538829cd309f9b4425abe8c59 Reviewed-on: https://chromium-review.googlesource.com/c/1333087 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#607475}
-
Devlin Cronin authored
Adjust the chrome.permissions API for use with withheld permissions as a result of the RuntimeHostPermissions feature. This patch allows the permissions API to be used to request withheld or optional host permissions, rather than just optional host permissions. This is important for extensions that want to be able to request permissions at runtime using the chrome.permissions API as a workaround to having required permisssions withheld. Additionally, move requesting optional permissions to looking at the runtime granted permission set, rather than the granted permission set. This greatly simplifies the logic, as now all permission requests are compared to the same permissions set, and we don't need to isolate host permission requests versus API permission requests. This also ensures we avoid granting a permission that was explicitly revoked by the user (as could happen if we just checked granted permissions). As of Chrome 70, all permissions granted through the permissions API are added to the runtime granted set. However, this does mean that optional permissions that were granted prior to M70, and then later removed via permissions.remove(), will re-prompt the user. In practice, this is very rare. This also means that optional permissions will not be granted automatically for permissions that were used by previous versions of the extension (similarly, very rare in practice). This does *not* address the issue of scriptable hosts in requested permissions; that is still an issue. Bug: 889654 Change-Id: I8c20f03ec7b402cd61ae1db04b782447dc39414e Reviewed-on: https://chromium-review.googlesource.com/c/1301851 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607474}
-
Yuichiro Hanada authored
Android IMEs can be disabled in Android side by using 'ime' command. This CL ensures that disabled IMEs are also disabled in Chrome OS's InputMethodManager. Bug: b/119274469 Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1331294Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#607473}
-
Shimi Zhang authored
To avoid PRESUBMIT check for InvocationHandler annotation check. Should be no logic change. Bug: None Change-Id: I91680e54c5b0f0cc692b841a57f7f5b68f724d9b Reviewed-on: https://chromium-review.googlesource.com/c/1323624 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607472}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0cf6ee7f1acb..84f62b6f08e8 git log 0cf6ee7f1acb..84f62b6f08e8 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 cbruni@chromium.org [wprgo] Implement httparchive.go add and addAll command 2018-11-12 erikchen@chromium.org Update computation of load bias to handle CrOS edge cases. Created with: gclient setdep -r src/third_party/catapult@84f62b6f08e8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904492 TBR=sullivan@chromium.org Change-Id: Ic4a8c9f0258bf1183c0f78bb2d996dd2ad94e423 Reviewed-on: https://chromium-review.googlesource.com/c/1333049Reviewed-by:
-
Noel Gordon authored
FilesApp provides the innards of the extension file dialog. Add a test to open the file dialog by clicking on an <input type=file> element in a web page. Bug: 895703 Change-Id: Id6f56e2df4034af66a57f888195bc841a55da2b4 Reviewed-on: https://chromium-review.googlesource.com/c/1331099 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607470}
-
Alexander Alekseev authored
This Cl disables pin input field whan it is displayed in incognito UI. Bug: 900351 Change-Id: I7aae9f08403933f12cae5345075e5e94e775e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1332929 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#607469}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f1ac04ec34e..f1ff631c9f6c git log 7f1ac04ec34e..f1ff631c9f6c --date=short --no-merges --format='%ad %ae %s' 2018-11-12 weidongg@chromium.org Mark four pfq boards as important 2018-11-12 dgarrett@google.com chromeos_config: Adjust postsubmit configs. Created with: gclient setdep -r src/third_party/chromite@f1ff631c9f6c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If4b876c7a0b6136dc6a1fd1b682bee26972e4627 Reviewed-on: https://chromium-review.googlesource.com/c/1333048Reviewed-by:
-
about://newtabJustin Cohen authored
Rather than load chrome://newtab internally and eventually load an error page, internally track the NTP with about://newtab (which is a blank page). Bug: 826369 Change-Id: I2af53f90088ce4f376a4d0d0107eb667d5aa5d48 Reviewed-on: https://chromium-review.googlesource.com/c/1328185 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
-
