- 09 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/515a3a6dd433..fdb64271aae6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: I340e44f5251be150f2b564f38e626cc835ecbaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805213}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/22e5e179fa28..12e97ed6a789 2020-09-09 jiawei.shao@intel.com Transition bind group resource states before dispatch in compute pass 2020-09-09 enga@chromium.org Typeify ColorAttachmentIndex If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie873cb1375c5c73b8b2791dd32221dac850c6a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805212}
-
Alice Wang authored
This CL moves the add account icon from code to xml file to make it easier to reuse the xml file in other places. Bug: 1107423 Change-Id: Id77a69d982b97088e58a7b357993587f05e6025e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377937Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805211}
-
Fumitoshi Ukai authored
add @google.com as owners too. remove sque@ Change-Id: I2f08b67e5b4d2871986ffa0369204f58ae24f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399978 Commit-Queue: Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805210}
-
Hidehiko Abe authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d96f468ef020..e61dd757a8c0 $ git log d96f468ef..e61dd757a --date=short --no-merges --format='%ad %ae %s' 2020-09-09 hidehiko ffmpeg: Update expand is_linux to is_linux || is_chromeos. Created with: roll-dep src/third_party/ffmpeg Bug: 1110266 Change-Id: I485bf68fa184a53f077544a0c99db55704f35009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398443 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805209}
-
jongdeok.kim authored
This reverts commit b23ec565. Bug: 1126001 Change-Id: I611c101b394fdf362932b5625dc195f0386a3a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397995Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#805208}
-
Michael Hansen authored
When checking if Bluetooth is enabled we need to check that it is not just "Present" but also "Powered". Change-Id: Ied15252da507d7b38ecc8622341633e9994c55ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390878Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#805207}
-
Kent Tamura authored
It has a circular dependency with modules/webgl:webgl, and this CL adds allow_circular_includes_from to it. The circular dependency is safe because they are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: If886c85bc1d4e39b7ab259e9efe89057f48d25d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398606 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1e7df19a137f..33792a19b6e2 2020-09-08 tsepez@chromium.org Re-write the loop in CXFA_FWLTheme::LoadCalendarFont() 2020-09-08 tsepez@chromium.org No need to observe garbage-collected CXFA_FFPageView. 2020-09-08 thestig@chromium.org Add unit tests for CFX_DIBitmap::CalculatePitchAndSize(). 2020-09-08 thestig@chromium.org Change CFX_DIBitmap::CalculatePitchAndSize() parameter ordering. 2020-09-08 thestig@chromium.org Redo CFX_DIBitmap::CalculatePitchAndSize(). 2020-09-08 tsepez@chromium.org Make CFGAS_FontMgr a per-process singleton. 2020-09-08 thestig@chromium.org Optimize a tight loop in FX_Number. (try 2) 2020-09-08 thestig@chromium.org Add regression test for FX_Number. 2020-09-08 thestig@chromium.org Add another embedder test for password handling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124998 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia9448ebe8df5c3d96985651ef5b7dda91d8ef73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399273Reviewed-by:
-
Kent Tamura authored
This CL removes some testing code dependencies from production code. - Remove #include ".../core/testing/internal_settings.h", which is not used. - Replace base::TestMockTimeTaskRunner with base::SingleThreadTaskRunner, which is a super class of TestMockTaskRunner. - Replace testing/gtest/include/gtest/gtest_prod.h with base/gtest_prod_util.h This directory depends on 'platform/loader:test_support'. It already depends on 'platform:test_support', so 'platform/loader:test_support' should be exposed via 'platform:test_support'. This CL has no behavior changes. Bug: 800764 Change-Id: I3c5c9ccc00d42d2871727c97b8db6b292f3103d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398074 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
- Remove unnecessary #include for a testonly code from background_fetch_record.h. This CL has no behavior changes. Bug: 800764 Change-Id: I17b7946c08dca0aef888c5c95a436f984bd6b543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398605 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Maksim Sisov (GMT+3) authored
This reverts commit b372dd07. Reason for revert: bug in exo. should fix that first. reverting to recover the bots Original change's description: > Reland "ozone/wayland: Fix drop down menus for touch events." > > This is a reland of 7138b785 > > WaylandPopup didn't allow empty bounds. Fixed by > https://crrev.com/c/2397695 > > Original change's description: > > ozone/wayland: Fix drop down menus for touch events. > > > > In case of touch events, we may not find currently focused windows > > as menu windows might be created on touch up events. Thus, > > GetCurrentFocusedWindow returns nullptr. > > > > To fix that, use a concept of a currently active window. That is, > > Wayland sets a window to "active" state if it has had a focus. > > There can be only one focused window at a time. > > > > Thus, if there is no a focused window, use currently active window > > as a parent. That's the best effort one could make to find a parent > > window for a newly created non-toplevel window. At some point, > > it might be worth reconsidering the design and make aura always pass > > parent widgets for new windows if applicable. > > > > Bug: 1123521 > > Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#804674} > > Bug: 1123521 > Change-Id: I62c6b254bc2e931bc93ac4609290518138aa19b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397715 > Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#804914} TBR=tonikitoo@igalia.com,msisov@igalia.com,nickdiego@igalia.com Change-Id: I44d03c43971481863c14930d01fc1cb1bea2bd12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398724Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#805202}
-
Ye Kuang authored
This is a prerequisite for allowing us to switch the builders to use the Go swarming CLI. This has already been enabled in production. e.g. ci.star: https://crrev.com/c/2397055. Note that adding this property itself does no change to the recipe. We have yet another flag in the recipe to tell these builders to switch to the Go CLI. Bug: 894045 Change-Id: I52d5b4cd2e99c3d3a71e1d3942f90e952ea22360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397998Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#805201}
-
Ye Kuang authored
This is a follow up of https://crrev.com/c/2397055. It fixes failures in 'luci.chromium.try' pool like https://chromium-swarm.appspot.com/task?id=4e89981464fc8310 Bug: 894045, 1126307 Change-Id: I3e80f289c119e237c160a860ba4024f1c80c58dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397981Reviewed-by:
-
Alexander Surkov authored
an application by process id Implement AccessibleTreeFormatter::BuildAccessibilityTreeForWindow on mac, which captures an accessible tree of a running application identified by gfx::AcceleratedWidget, which is HWDN on Windows and PID or Linux/Mac. Bug: 1124366 Change-Id: I6295d65a7273a66ed37966a5bfaf0858fe0d4451 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391469 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805199}
-
Ramin Halavati authored
MemoryFileStreamWriter called some ObfuscatedFileUtilMemoryDelegate functions through IO thread while other functions in OFUMD are called on a threadpool sequence. This could result in races in updating directory structure. To fix the issue, MemoryFileStreamWriter and MemoryFileStreamReader are updated to call all OFUMD on the default task runner of the file system context. This CL was landed in crrev.com/c/2308721 and reverted due to flakiness. The flaky crashes are believed to be because the buffer passed to MemoryFileStreamReader::Read and MemoryFileStreamWrite::Write are not thread safe. Patchset1 is a copy of the previous CL and the issue is fixed in the next patchsets. Bug: 1100136 Change-Id: I619b82c2f4d23a020e9ce7e5e6c16980907b501b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398701Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#805198}
-
Josh Nohle authored
Add support for GetDeviceState RPC in the HTTP client and the HTTP tab of chrome://nearby-internals. The proto was added in a previous CL, and the RPC will be called in a follow-up CL. Bug: b/166115703 Change-Id: Id6965c5e59a1ee892737df398425eb4ece9d5ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399505 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805197}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie7463f8df14047ac76ac654386930cc940b969f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399885Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5d97c42. With Chromium commits locally applied on WPT: 940da0ee "Initial scrollbar-gutter implementation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ie7ecd4f587c365de4fa7ba2f5e4e652b03d76484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399799Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805195}
-
Patti authored
This reverts commit 552c5361. Reason for revert: Breaking "browser_tests" failing on builder "linux-chromeos-rel" (specifically OSSettingsCrostiniPageTest.SubPageSharedPaths). See attached bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1126295). Original change's description: > Convert crostini and plugin VM shared paths settings lists to iron-list > > iron-list provides better focus management for tab/chromevox navigation. > > Bug: 1096143 > Change-Id: Icaf2d27da606c9792a5aef9ac27226a77c63e76a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390939 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805101} TBR=khorimoto@chromium.org,joelhockey@chromium.org Change-Id: I6ada643aa15046f223417a72518269a643221152 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096143, 1126295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398446Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#805194}
-
Xianzhu Wang authored
If a stacking context (including but not limited to foreignObject) contains an svg element which has non-isolated descendants with blend mode, the stacking context should create an isolation to define the backdrop of the blend mode. We already have logic to create an isolation for a stacking context if it has a child with non-isolated descendants with blend mode, but it didn't work for svg root with such descendants because svg roots didn't create layers. Now always create a layer for svg root to make the logic work. Bug: 1102803 Change-Id: Iece3d9b8b8b72c43903dc4899afc95d9bc94ebe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393627Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805193}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I38e33512c6666edf883ef8f829cb3b0abe5ce088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399843Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805192}
-
Rachel Wong authored
There is currently a bug where the privacy notice can be navigated with tab and arrow keys, but not by the ChromeVox controls such as search+right. This is due to ChromeVox being incompatible with nested buttons. This CL does two things: 1) Reassign the outer view to a non-button a11y role, allowing ChromeVox to access the inner views as well. 2) Disable notifications for the outer view to avoid duplicated notifications. Bug: 1112714 Change-Id: Ibe7dca2c9f183f824ec1f410c6511322a307564e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397111Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805191}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72d35030231e..fb6d901df74d 2020-09-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib3de940cbc367ff3ebc61ab74e766c5df3af724a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399267Reviewed-by:
-
Ayu Ishii authored
Bug: 1124891, 1125194 Change-Id: Ia8346f1b68b3f0726662b8dd37de66cce0b9e490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393182Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99396cad183b..515a3a6dd433 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1098447,chromium:1099917,chromium:1123724 Tbr: patricialor@google.com Change-Id: Ia087f19dda05e3835230aa52383162efc59c5a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399266Reviewed-by:
-
Kyle Horimoto authored
BleScanner scans for incoming BLE advertisements but only notifies observers of results once they have been filtered by parameters provided by clients. Before this CL, a filter consisted of a DeviceIdPair and a ConnectionRole. We will be utilizing BleScanner for Phone Hub, so now it must also filter by ConnectionMedium. Since ConnectionAttemptDetails objects consist of a DeviceIdPair, a ConnectionMedium, and a ConnectionRole (i.e., exactly what we need), this CL change the type of the scan filter parameters with ConnectionAttemptDetails. A TODO is added in ble_scanner_impl.cc to reflect the fact that we must now include the medium as part of the filtering process. This is left for a follow-up CL. Bug: 1106937 Change-Id: I251fe812b87145ae9861140af7021dfe2530084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392954 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Joel Hockey authored
Bug: 1125841 Change-Id: I4d86cbd40f00db05a64af390b82fe6f69ec5e781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395904 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805186}
-
James Vecore authored
This add the GetSendPreview() call to the DiscoveryManager interface so the UI can show the correct description and icon when on the discovery page. Follow up CL's will add the icons and handle the multiple file translation string (i.e. 'x and n other files') Change-Id: I5c454e597f6977ba35377e05603a5394a2a80e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394377Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Noel Gordon authored
The variables used to re-write image loader client request URLs do not change. Define them as ImageLoaderClient const properties. No change in behavior, no new tests. Bug: 1126229 Change-Id: Icd3f548164eb98437fbde89117a54a2ef207aec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398602Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805184}
-
chrome://user-actionsMiyoung Shin authored
This fixes a regression of https://crrev.com/c/2335213 that the user actions isn't recorded at chrome://user-actions since Javascript is disallowed in WebUIImpl::MainFrameNavigationObserver::DidFinishNavigation after it is allowed in UserActionsUIHandler::ReadyToCommitNavigation. This CL registers a message called when the page is loaded to allow the JavaScript and adds the user action callback in OnJavascriptAllowed instead of ctor not to access RenderFrameHost too early. Bug: 1122791 Change-Id: I285d62b8fb15ff388c1183e63047efe93705390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387900Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#805183}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599587571-75a79fa48b42004db7f7ebb181ae53e5f370e716.profdata to chrome-mac-master-1599609504-d5a4da8648bee9c45af68f0bedc0e876fcbf0d82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6e3b326a9663518aebad19599430f6e5ec326084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399272Reviewed-by:
-
Peter Kotwicz authored
This CL: - Sets resource_overlay=true in //weblayer:components_java_strings to indicate that the target duplicates resources in //components/strings:components_locale_settings - Renames android_webview/nonembedded/java/res_devui/drawable/ic_search.xml as the resource conflicts with R.drawable.ic_search BUG=1093825 Change-Id: Ica9c2335fdf688bec594f842e617e82e1a826773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389229 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805181}
-
Kent Tamura authored
This directory has a circular dependency with modules/worklet:worklet. Update allow_circular_includes_from in it. This CL has no behavior changes. Bug: 800764 Change-Id: I6a525f8114dce476a7cd3dec5529e48781a47515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398745 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e2d6551..bb481754 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33eaa84361ce01ba013b21113dba43a6b9d8e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805179}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 800764 Change-Id: If9ae82d08aa4b8eac163a19001cbcd6a402f5e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398744 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Sangwoo Ko authored
The property should be interpolable. https://drafts.csswg.org/css-text-3/#tab-size-property Bug: 1124184 Change-Id: Ic298057b17a78717df08dde4f82d8d860e230612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392164Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#805177}
-
manukh authored
When rich autocompleting titles, |fill_into_edit| & |fill_into_edit_additional_text| are swapped (i.e. the former contains the title, and the latter contains the URL). This is consistent with how the suggestion should be displayed. But the shortcut DB must persist the original (i.e. URL) |fill_into_edit|; otherwise the shortcut provider may autocomplete the title even when title autocompletion is inappropriate (e.g. because the input is too short). Therefore, |swapped_fill_into_edit| is set to true when rich autocompleting titles. Bug: 1062446 Change-Id: I925752e60d2529d0fd8f9fac7f51aea169bc678d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399567 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
Bug: b/161658580 Change-Id: Ief273a5a9b1e37177d127251b4bccd491fcf30ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397993 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#805175}
-
David Stevens authored
We want to drop vgem support from minigbm, so filter out the vgem render node before trying to creating the gbm device to prevent the expected unsupported backend failure from being treated as a real error. Bug: b:141278896 Change-Id: Ia68c6fc57cff51cf04d76053026d5ee5ae5c57e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392161Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805174}
-
