- 24 Sep, 2014 40 commits
-
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/1216f1b..3bcf32e TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/602833002 Cr-Commit-Position: refs/heads/master@{#296493}
-
nednguyen authored
Some devices remove cpu related files from /proc when the cores are turned off. We assume the frequency is 0 if it's missing. BUG=417259 Review URL: https://codereview.chromium.org/598093003 Cr-Commit-Position: refs/heads/master@{#296492}
-
oshima authored
Looks like I made an error when I split the CL. I'll add a test in a separate CL. BUG=None TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/602843002 Cr-Commit-Position: refs/heads/master@{#296491}
-
yusufo authored
BUG=415352 Review URL: https://codereview.chromium.org/575253003 Cr-Commit-Position: refs/heads/master@{#296490}
-
mlerman authored
If the most recent profile is locked and the user uses the Windows system tray to access the Task Manager or About Chrome, the user will now first be presented with the User Manager, and only after selecting or unlocking a profile will they be brought automatically to their original destination. BUG=409030 TEST=Enable --new-profile-management. Have at least one background app running under your profile (e.g. Hangouts). Close Chrome. In the system tray, Chrome ->Task Manager or About Chrome. Only after unlocking your profile or opening a new profile, you'll see the original selection. Review URL: https://codereview.chromium.org/564453003 Cr-Commit-Position: refs/heads/master@{#296489}
-
junov authored
BUG=415100 Review URL: https://codereview.chromium.org/601883002 Cr-Commit-Position: refs/heads/master@{#296488}
-
gcasto authored
BUG=318977 Review URL: https://codereview.chromium.org/598743002 Cr-Commit-Position: refs/heads/master@{#296487}
-
jamesr authored
cc::Surface instances in the surface map have raw pointers to the surface holder, so the holder needs to outlive the map. BUG=417325 Review URL: https://codereview.chromium.org/603703002 Cr-Commit-Position: refs/heads/master@{#296486}
-
viettrungluu authored
This eliminates the need for |ProxyMessagePipeEndpoint::Attach()|. R=brettw@chromium.org Review URL: https://codereview.chromium.org/588193004 Cr-Commit-Position: refs/heads/master@{#296485}
-
hanxi authored
BUG=352293 Review URL: https://codereview.chromium.org/595033002 Cr-Commit-Position: refs/heads/master@{#296484}
-
robertocn authored
- Removed redundant output of the test command. - Reduced the number of steps to three and wrote them as succintly as possible. - Added the clarifying notes separately at the end. BUG=404088 Review URL: https://codereview.chromium.org/596963002 Cr-Commit-Position: refs/heads/master@{#296483}
-
gcasto authored
BUG=413846 Review URL: https://codereview.chromium.org/583883003 Cr-Commit-Position: refs/heads/master@{#296482}
-
rtoy authored
BUG=411361 Review URL: https://codereview.chromium.org/589403006 Cr-Commit-Position: refs/heads/master@{#296481}
-
Ken Rockot authored
The old fake taskqueue just discarded all tasks. This of course broke integration tests because refresh tasks never ran and the in-memory memcache never got populated. This changes the fake taskqueue so that it just executes queued tasks immediately and synchronously. BUG=None TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/600073002 Cr-Commit-Position: refs/heads/master@{#296480}
-
andresantoso authored
When we reshow the find bar after dropping a tab into a new window, -[BrowserWindowController layoutSubviews] is called which causes a relayout of the tabs (without animation). In this case, a tab is in the beginning of being animated to a new position and this relayout interrupted it by calling setFrame on the tab view, but the tab frame ended up being the animator's target frame instead of the relayout setFrame. This seems like an AppKit bug because it behaves as expected on 10.9. It is undesirable for layoutSubviews to force tabs relayout when the tap strip's frame did not change, because it will interrupt tab animations in progress. This change compares the old and new tab strip frame and skips tabs relayout if the frame did not change. BUG=415093 Review URL: https://codereview.chromium.org/593223002 Cr-Commit-Position: refs/heads/master@{#296479}
-
avakulenko authored
dbus::ScopedDBusError has inline constructor/destructor and is_set() method that call into libdbus-1. By placing these function calls in a header file, we add implicit link dependency on components that need to use ScopedDBusError. If we move them out to a .cc file, the dependency will be localized to libchrome. BUG=chromium:416628 TEST=dbus_unittests pass Review URL: https://codereview.chromium.org/592793004 Cr-Commit-Position: refs/heads/master@{#296478}
-
xiyuan authored
ExtensionDownloader should be created via its factory so that all parameters needed by the ping URL would be filled out properly. BUG=416648 Review URL: https://codereview.chromium.org/595383002 Cr-Commit-Position: refs/heads/master@{#296477}
-
rsesek authored
R=brettw@chromium.org Review URL: https://codereview.chromium.org/597043002 Cr-Commit-Position: refs/heads/master@{#296476}
-
binjin authored
This CL fixes a bug in commit b2454381 "Add new ExtensionManagement preference". The default value of IndividualSettings are supposed to be |default_settings_| instead of fallback value for each settings. This bug was not exposed in unit tests since IndividualSettings contains only installation mode settings now. BUG=177351 Review URL: https://codereview.chromium.org/593223003 Cr-Commit-Position: refs/heads/master@{#296475}
-
abarth authored
We can't call set_client on the main thread because that determines the thread affinity of the SurfacePtr. Instead, we need to wait for the BindToClient callback so we can bind the SurfacePtr on the impl thread. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/603663002 Cr-Commit-Position: refs/heads/master@{#296474}
-
wjmaclean authored
While moving web_request files, we created web_request_api_utils to allow moving the functionality of web_request_api_helpers a bit at a time. Everything has moved, so it's time to recombine. BUG=352293 Review URL: https://codereview.chromium.org/601843002 Cr-Commit-Position: refs/heads/master@{#296473}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/440c1ed..1216f1b TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/600903002 Cr-Commit-Position: refs/heads/master@{#296472}
-
Brett Wilson authored
Adds simple manifest file parsing to the package downloader, and recursively schedule loading dependencies of a package. R=ben@chromium.org Review URL: https://codereview.chromium.org/600683002 Cr-Commit-Position: refs/heads/master@{#296471}
-
achuith authored
BUG=417248 TEST=login_GaiaLogin Review URL: https://codereview.chromium.org/600523006 Cr-Commit-Position: refs/heads/master@{#296470}
-
mmaliszkiewicz authored
When buffer size is different than kInitialReadBufferSize then intermediate buffer would be reallocated on each Read() operation which is unnecessary. Review URL: https://codereview.chromium.org/594733004 Cr-Commit-Position: refs/heads/master@{#296469}
-
mohan.reddy authored
Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Review URL: https://codereview.chromium.org/589413002 Cr-Commit-Position: refs/heads/master@{#296468}
-
erikchen authored
ServiceProcessStateFileManipulationTest.VerifyLaunchD tests that the user owned launchd process is functioning correctly (it will stop working if /tmp/launchd*/sock is deleted). This is no longer relevant in 10.10. There is no user owned launchd process, and there is no file at /tmp/launchd*/sock. Previously, the test checked that "launchctl list com.apple.launchctl.Aqua" had exit code 0. This doesn't work on 10.10, since that particular launchctl listing is for the user-owned instance of launchd, which no longer exists. I changed the test to check the exit code for "launchctl limit". This fails on 10.9 if /tmp/launchd*/sock is deleted, which is the intended behavior of the test, and it still serves as a useful sanity check on 10.10. I also added a new test to explicitly check that GTMSMJobSubmit and GTMSMJobRemove work correctly. BUG=390276 Review URL: https://codereview.chromium.org/588833002 Cr-Commit-Position: refs/heads/master@{#296467}
-
earthdok authored
There has been a security update in gPrecise which changed the paths somewhat. The previous version of this CL was reverted as it broke on vanilla Precise. This version fixes that. BUG=313751 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/602823002 Cr-Commit-Position: refs/heads/master@{#296466}
-
rdsmith authored
in SdchDictionaryFetcher to DLOG(FATAL). BUG=416639 R=rch@chromium.org Review URL: https://codereview.chromium.org/599143002 Cr-Commit-Position: refs/heads/master@{#296465}
-
mfomitchev authored
Adding split view divider widget which could be dragged to exit the split view. Resubmit of https://codereview.chromium.org/545393002 TBR=mukai@chromium.org BUG=403207, 408691 Review URL: https://codereview.chromium.org/598083002 Cr-Commit-Position: refs/heads/master@{#296464}
-
rdevlin.cronin authored
We were initializing permissions before checking that the extension existed. Fix this. BUG=415986 Review URL: https://codereview.chromium.org/584313002 Cr-Commit-Position: refs/heads/master@{#296463}
-
Paweł Hajdan, Jr authored
BUG=none R=maruel@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/596113002 Cr-Commit-Position: refs/heads/master@{#296462}
-
tfarina authored
BUG=348066 TEST=None R=bruening@chromium.org,dpranke@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/588903002 Cr-Commit-Position: refs/heads/master@{#296461}
-
derat authored
BUG=none Review URL: https://codereview.chromium.org/598033002 Cr-Commit-Position: refs/heads/master@{#296460}
-
thestig authored
Revert of Roll breakpad a513e85:7caf028 (svn 1384:1385) (patchset #1 id:1 of https://codereview.chromium.org/590403003/) Reason for revert: Broke TSANv2 builder: breakpad/src/client/linux/minidump_writer/minidump_writer.cc:554:37: error: use of undeclared identifier 'time' header.get()->time_date_stamp = time(NULL); Original issue's description: > Roll breakpad a513e85:7caf028 (svn 1384:1385) > > r1385: Linux: Call memset() in a couple places in ExceptionHandler. > > BUG=332335 > > Committed: https://crrev.com/ec86bac94da60dc9286bb49b87745570a83a6a55 > Cr-Commit-Position: refs/heads/master@{#296446} TBR=timurrrr@chromium.org NOTREECHECKS=true NOTRY=true BUG=332335 Review URL: https://codereview.chromium.org/595343003 Cr-Commit-Position: refs/heads/master@{#296459}
-
Monica Dinculescu authored
BUG=410946 R=oshima@chromium.org Review URL: https://codereview.chromium.org/594963002 Cr-Commit-Position: refs/heads/master@{#296458}
-
jiayl authored
Revert of Large wallpaper decoding in utility process (patchset #5 id:190001 of https://codereview.chromium.org/482163002/) Reason for revert: Speculative revert for unit_tests failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31845/steps/unit_tests/logs/DecodeImageSizeLimit Original issue's description: > Handle large wallpaper decoding in utility process: > Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. > > BUG=366825 > TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug > > Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24 > Cr-Commit-Position: refs/heads/master@{#296407} TBR=dcheng@chromium.org,bshe@chromium.org,skuhne@chromium.org,sky@chromium.org,tsepez@chromium.org,yoz@chromium.org,glevin@chromium.org NOTREECHECKS=true NOTRY=true BUG=366825 Review URL: https://codereview.chromium.org/600913002 Cr-Commit-Position: refs/heads/master@{#296457}
-
vitalyp authored
R=arv@chromium.org BUG=393873 Review URL: https://codereview.chromium.org/594373002 Cr-Commit-Position: refs/heads/master@{#296456}
-
lazyboy authored
This will zoom in/out the view properly. This CL is dependant on http://crrev.com/597653002 BUG=416332 Test=Load chrome with --enable-mime-handler-view and --out-of-process-pdf Navigate to a pdf file, Ctrl + wheel up and down should zoom in/out the pdf properly. Review URL: https://codereview.chromium.org/591243003 Cr-Commit-Position: refs/heads/master@{#296455}
-
thestig authored
Revert of Instrumented libraries: update the libnspr4 build script. (patchset #1 id:1 of https://codereview.chromium.org/600793002/) Reason for revert: MSAN bots failed. FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libnspr4" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen" "--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit --disable-debug" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=10" "--build-method=destdir" "--run-before-build=scripts/libnspr4.sh" mv: cannot stat `nspr/*': No such file or directory Original issue's description: > Instrumented libraries: update the libnspr4 build script. > > There has been a security update in Precise which changed the paths somewhat. > > BUG=313751 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/91e9dd404b29bcbb847b98530e83f3c40720b890 > Cr-Commit-Position: refs/heads/master@{#296395} TBR=glider@chromium.org,earthdok@chromium.org NOTREECHECKS=true NOTRY=true BUG=313751 Review URL: https://codereview.chromium.org/598983004 Cr-Commit-Position: refs/heads/master@{#296454}
-