GitLab

BUG=401853

Review URL: https://codereview.chromium.org/453673003

Cr-Commit-Position: refs/heads/master@{#289135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289135 0039d316-1c4b-4281-b951-d872f2087c98

In the static build mojo_surfaces_service and some examples were linking
against both mojo_system and mojo_system_impl, which doesn't work.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/468563002

Cr-Commit-Position: refs/heads/master@{#289134}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289134 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/461903002

Cr-Commit-Position: refs/heads/master@{#289133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289133 0039d316-1c4b-4281-b951-d872f2087c98

We have recently removed usage of these deprecated fields from the code. This CL removes them from the protos too.

Review URL: https://codereview.chromium.org/467753002

Cr-Commit-Position: refs/heads/master@{#289130}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289130 0039d316-1c4b-4281-b951-d872f2087c98

Followup from https://codereview.chromium.org/419673004

BUG=397554

Review URL: https://codereview.chromium.org/460583002

Cr-Commit-Position: refs/heads/master@{#289129}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289129 0039d316-1c4b-4281-b951-d872f2087c98

This will match the behavior on ChromeOS and ensure that users without
notifications will not be annoyed by the Chrome notifications center
icon in the status tray.

BUG=401215

Review URL: https://codereview.chromium.org/459123002

Cr-Commit-Position: refs/heads/master@{#289128}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289128 0039d316-1c4b-4281-b951-d872f2087c98

    
This removes the use of memory pressure signals from discardable memory
system and instead introduces an explicit call for reducing emulated
discardable memory that the renderer can call when all widgets are hidden
until we have a better mechanism in place.
    
BUG=398087
TEST=base_unittests,content_browsertests

Review URL: https://codereview.chromium.org/448173002

Cr-Commit-Position: refs/heads/master@{#289127}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402212
TBR=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/468703002

Cr-Commit-Position: refs/heads/master@{#289126}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289126 0039d316-1c4b-4281-b951-d872f2087c98

Sam has been working on chromedriver since Oct. 2013 and he has contributed over 50 CLs and reviewed around 20 CLs.
So I recommend that we add Sam as an owner of chromedriver.

R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/469523002

Cr-Commit-Position: refs/heads/master@{#289120}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289120 0039d316-1c4b-4281-b951-d872f2087c98

calling WebContents, not whatever the "associated" WebContents is.

BUG=402318
R=fsamuel@chromium.org, jamescook@chromium.org

Review URL: https://codereview.chromium.org/458323002

Cr-Commit-Position: refs/heads/master@{#289118}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289118 0039d316-1c4b-4281-b951-d872f2087c98

Start including Checkstyle 5.7 binary to use for Java style presubmit
checks.

BUG=318404
NOTRY=true
R=brettw@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/451313002

Cr-Commit-Position: refs/heads/master@{#289117}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289117 0039d316-1c4b-4281-b951-d872f2087c98

Ash GetLocalProcessWindowAtPointImpl should ignore windows in the
mouse cursor container.

BUG=399309
R=oshima@chromium.org, sky@chromium.org
TBR=sky@chromium.org
TEST=verify that tab merging works with large cursors.

Review URL: https://codereview.chromium.org/468603002

Cr-Commit-Position: refs/heads/master@{#289116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289116 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Cleanup datatype configuration error handling.
> 
> The FailedDataTypeHandler is now informed immediately of failures, including
> datatype errors, and is therefore authoritative source for all errors. As such,
> partial success is no longer tracked and the various ModelTypeSets for error
> types in configure results are removed.
> 
> BUG=368834,403098
> 
> Review URL: https://codereview.chromium.org/420633002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/468643002

Cr-Commit-Position: refs/heads/master@{#289115}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289115 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Use OnSingleDataTypeUnrecoverableError for all errors
> 
> This removes the disable callback from all datatype controllers as well
> as the DisableDataType method from the PSS, in favor of
> OnSingleDataTypeUnrecoverable error (which now accepts a SyncError).
> 
> BUG=368834,403098
> TBR=bauerb@chromium.org
> 
> Review URL: https://codereview.chromium.org/436733002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/465113002

Cr-Commit-Position: refs/heads/master@{#289113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289113 0039d316-1c4b-4281-b951-d872f2087c98

process_file_template would fail when the template argument was a string instead of a list, but the previous behavior (and the documentation) describes it as being able to take a string or a list as an argument.

It would also fail if the result was not an absolute file. This is required for most uses of sources expansions, but not for process_file_template which just returns the strings of whatever the results were. This adds "AsStrings" version of the sources expansions writer.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/462103004

Cr-Commit-Position: refs/heads/master@{#289112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289112 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Don't synchronously stop datatypes that encounter errors
> 
> The datatype logic may be operating unders assumptions that break when
> the type is stopped from under it, possibly triggering crashes.
> 
> BUG=402595,403098
> 
> Review URL: https://codereview.chromium.org/462863002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/467923002

Cr-Commit-Position: refs/heads/master@{#289111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289111 0039d316-1c4b-4281-b951-d872f2087c98

Properly write outputs of actions that have no sources list. Previously this would lead to empty output lists in a build rule because the writer code was trying to apply the sources list to the output substitutions list. However, for actions, the output is the literal file list and should have no substitutions.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/461153002

Cr-Commit-Position: refs/heads/master@{#289109}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289109 0039d316-1c4b-4281-b951-d872f2087c98

This handles nested third_party directories.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/462063002

Cr-Commit-Position: refs/heads/master@{#289106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289106 0039d316-1c4b-4281-b951-d872f2087c98

so that it can handle negative errors (like 0.999)

BUG=None
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/467813002

Cr-Commit-Position: refs/heads/master@{#289105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289105 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289104}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289104 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180014:180090&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/467803002

Cr-Commit-Position: refs/heads/master@{#289103}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289103 0039d316-1c4b-4281-b951-d872f2087c98

The display names are missing for content URI files.
That will cause some upload to fail.
This CL translates the content URI to displayed name and passes them to native code.

BUG=402537

Review URL: https://codereview.chromium.org/450003002

Cr-Commit-Position: refs/heads/master@{#289102}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289102 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289101}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289101 0039d316-1c4b-4281-b951-d872f2087c98

With --google-profile-info or --enable-new-avatar-menu turned on, signed in
profiles can use the account's Gaia image as the profile avatar. The
desktop shortcut shouldn't be surprised about this :)

Screenshot of the badged shortcuts in all their glory:
https://drive.google.com/folderview?id=0B1B1Up4p2NRMUjlTSU1EYUlBVG8&usp=sharing

BUG=402162
TEST=Flip --google-profile-info or --enable-new-avatar-menu. Sign in a profile,
and change the profile's avatar to the account's Gaia image. The desktop shortcut
should update and use the Gaia image correctly.

Review URL: https://codereview.chromium.org/462713002

Cr-Commit-Position: refs/heads/master@{#289100}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289100 0039d316-1c4b-4281-b951-d872f2087c98

Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.

landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.

R=iannucci@chromium.org
BUG=400011

Review URL: https://codereview.chromium.org/457003004

Cr-Commit-Position: refs/heads/master@{#289099}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289099 0039d316-1c4b-4281-b951-d872f2087c98

Changes made to treat @IntegrationTest annotation as a test size annotation
with a timeout greater than @EnormousTest. Changes to test runner also made
to allow new line escapes for the .flags file.

BUG=None

Review URL: https://codereview.chromium.org/462613005

Cr-Commit-Position: refs/heads/master@{#289098}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380961, 380962

Review URL: https://codereview.chromium.org/448273002

Cr-Commit-Position: refs/heads/master@{#289097}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289097 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
- Moves background.js to background.html
- Introduces remoting.appLauncher that allows the caller to launch and close the webapp without knowing the implementation difference between a v1 app and a v2 app.

NOTRY=true
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/450383003

Cr-Commit-Position: refs/heads/master@{#289096}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289096 0039d316-1c4b-4281-b951-d872f2087c98

Analyze exceptions have been centralized, so I can remove the
exceptions from each of the trybot files.
--analyzer2 is no longer used by the recipes.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/463193002

Cr-Commit-Position: refs/heads/master@{#289094}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289094 0039d316-1c4b-4281-b951-d872f2087c98

The inner class needs to be exported in case any uses in inline methods
or vtable of the outer class causes it to potentially be referenced across
a shared library boundary.

On non-Windows, the visibility attribute is already inherited by nested
classes, but on Windows, they must be marked explicitly.

BUG=82385

Review URL: https://codereview.chromium.org/464563004

Cr-Commit-Position: refs/heads/master@{#289093}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289093 0039d316-1c4b-4281-b951-d872f2087c98

No one seems to know why we have BrowserActionView and BrowserActionButton.
Let's combine them for simplicity.

BUG=402526

Review URL: https://codereview.chromium.org/411063003

Cr-Commit-Position: refs/heads/master@{#289092}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289092 0039d316-1c4b-4281-b951-d872f2087c98

The contents_changed_since_last_frame and is_replica fields are not
used. Also removes RenderSurfaceImpl's ContentsChanged() as this method
was only used in determining the value of
contents_changed_since_last_frame.

Unfortunately now RenderPassDrawQuad is only the largest quad type on
64-bit builds. So, adds kLargestQuadType to cc/quads/ and moves the
largest-quad-type unit test there verifying that kLargestQuadType is
the largest now, instead of RenderPassDrawQuad.

R=enne
BUG=401481
NOTRY=true

Review URL: https://codereview.chromium.org/448133002

Cr-Commit-Position: refs/heads/master@{#289091}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403073
R=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/466153002

Cr-Commit-Position: refs/heads/master@{#289090}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402766
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/465083002

Cr-Commit-Position: refs/heads/master@{#289088}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289088 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: UNADDRESSABLE ACCESS reported on memory bot. See crbug.com/403070 for more details.

> Content browsertest for verifying that a black frame is sent on a peerconnection if a track is disabled.
> 
> BUG=398844,403070
> 
> Review URL: https://codereview.chromium.org/442313002

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/466983002

Cr-Commit-Position: refs/heads/master@{#289083}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289083 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (patchset #1 of https://codereview.chromium.org/462083003/)

Reason for revert:
The CL turns out to be innocent. Reverting the revert

Original issue's description:
> Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/)
> 
> Reason for revert:
> Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab
> 
> Original issue's description:
> > site isolation: cross-site transfers should track the RenderFrameHost, not the View
> > 
> > This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap.
> > 
> > 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames.
> > 
> > 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating.
> > 
> > 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state.
> > 
> > BUG=304341, 400850
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867
> 
> TBR=creis@chromium.org,nick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=304341, 400850
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289049

TBR=creis@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=304341, 400850

Review URL: https://codereview.chromium.org/466933003

Cr-Commit-Position: refs/heads/master@{#289082}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289082 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289081}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289081 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary workaround to fix desktop capture with HW encoder
at non-multiple-of-16 resolution without an extra memcpy.

BUG=402151
R=hclam@chromium.org
TBR=sergeyu@chromium.org
TEST=verify that desktop capture works on non-multiple-of-16 resolution

Review URL: https://codereview.chromium.org/469493002

Cr-Commit-Position: refs/heads/master@{#289078}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399696
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/466113002

Cr-Commit-Position: refs/heads/master@{#289076}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289076 0039d316-1c4b-4281-b951-d872f2087c98

b7e5a5c MIPS: detect mips32r6 and disable mips32r1 code
Part of 0524d9e that got missed in previous cherry-pick

BUG=400684,374343

Review URL: https://codereview.chromium.org/460303002

Cr-Commit-Position: refs/heads/master@{#289075}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289075 0039d316-1c4b-4281-b951-d872f2087c98