- 01 Oct, 2019 40 commits
-
-
Manu Cornet authored
Change-Id: I9ba9016fdf48fab67a929cbb49ca380045a0fb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832981 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701409}
-
rbpotter authored
This was removed in https://crrev.com/c/1790641 since there is no more chromium code that uses Templatizer directly. However, Templatizer is still used by iron-list, so this needs to be restored in order to compile pages that use iron-list (e.g. chrome://extensions). This causes a 438 byte increase in size in polymer_bundled.min.js (from 147272 to 147710). Bug: 1004967 Change-Id: I51235bde1daf3155f0951f85d4ae4111af9d7bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832629 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#701408}
-
Alexei Filippov authored
It allows us to evaluate how much memory is unaccounted by heap profiler. Bug: 1007491 Change-Id: Iafd70ddfb65e62a5c038a8b244654ef66c3a795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829739Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#701407}
-
Miyoung Shin authored
This change converts SerialService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482, 1005079 Change-Id: Ia6eb610f76c16f51ced8c5a5d96b3ec3f221e3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821499 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701406}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33217c214665..8c6278001533 Created with: gclient setdep -r src-internal@8c6278001533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43959a59b268785d78b6abc18cdeda729f0a12cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701405}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b79be398f3e..c28e7f784c33 git log 2b79be398f3e..c28e7f784c33 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org cros_build_lib.run: rename error_code_ok to check 2019-09-30 saklein@chromium.org chroot_lib: add USE_GOMA env var. Created with: gclient setdep -r src/third_party/chromite@c28e7f784c33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iee1a1f2381830db38e8ea4972af6b2e97af5d487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832925Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701404}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4aded80e0498..894eb8b0c9ba git log 4aded80e0498..894eb8b0c9ba --date=short --no-merges --format='%ad %ae %s' 2019-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d84c1e7..a9354743 (701137:701308) Created with: gclient setdep -r src/third_party/webrtc@894eb8b0c9ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6faf4c7a9fd90a0923f40bb4f558cc65653e76e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832928Reviewed-by:
-
Manu Cornet authored
The spec is at https://guidelines.googleplex.com/crosux-spec/feature-specs/shelf-tablet.html#shelf-tablet-home (in-app shelf) but should only apply when the hotseat flag is on. Bug: 1009367 Change-Id: If176d7f14a8573f06a5c37c0cb2b5ae95179a761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832654 Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701402}
-
Tsuyoshi Horo authored
This reverts commit 8be89ae0. Reason for revert: Build failure: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/79827 [4142/15096] CXX obj/device/vr/vr/openxr_controller.obj FAILED: obj/device/vr/vr/openxr_controller.obj C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../device/vr/openxr/openxr_controller.cc(204,19): error: no member named 'emulated_position' in 'device::mojom::XRInputSourceDescription' description_->emulated_position = false; ~~~~~~~~~~~~ ^ 1 error generated. Original change's description: > Update emulated position on each XRFrame > > For both the head poses and input poses, send this value through mojo > from the device process to the renderer process on every frame. > > Bug: 969131 > Change-Id: Ie895deb75bddb6dd883d09828cfcb30f335d3793 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825478 > Auto-Submit: Jacob DeWitt <jacde@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701389} TBR=dcheng@chromium.org,wfh@chromium.org,klausw@chromium.org,jacde@chromium.org,alcooper@chromium.org Change-Id: I91ec66842b8f0a14bcb85145843fb4d617847066 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833005Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701401}
-
Julie Jeongeun Kim authored
This CL converts MultiDeviceSetupPtr and MultiDeviceSetupRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I3272aaf011e977fc5272988288df0e1930abac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824735 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701400}
-
Maggie Cai authored
This CL adds the apps query logic for URL intents to the App Service. BUG=853604 Change-Id: Icb39f7be6dccb6c2ca58824d202c3a2650efedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826739 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701399}
-
Julie Jeongeun Kim authored
This CL converts PrerenderDispatcherAssociatedPtr, PrerenderCancelerRequest, and PrerenderCancelerPtr to new mojo types using Remote, AssociatedRemote, PendingReceiver, and Receiver. Bug: 955171 Change-Id: I75a60af8e0477726ce4f19aa0017eb97aea65cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828781Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#701398}
-
Oystein Eftevaag authored
TBR=perezju@chromium.org Bug: 1009838 Change-Id: Iedc2ef8752ffd782ac4ddbf27beff0505ba48af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832468Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701397}
-
Yuwei Huang authored
This CL implements basic notification UI for iOS. It doesn't do with "don't show again" yet. It also makes GstaticJsonFetcher take a |network_task_runner| in its ctor since the request fetcher refuses to fetch on the UI thread. Screenshots: https://screenshot.googleplex.com/JSB0wwGtu9k https://screenshot.googleplex.com/FgGju1yo99D Bug: 1001291 Change-Id: Id25b71a6da729c67e36fc5a8d29db2478497caef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832466Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#701396}
-
Alex Cooper authored
Currently there are two ways to get XRFrame's via the spec. The first is in a rAF callback, and the second is as a result of an XRInputSource event. Currently, if poses are not to be handed out, neither of these methods should fire. However, to be fully spec compliant in the event of future changes (especially from AR) allowing frames to be handed out in other circumstances, the getPose and getViewerPose methods need to throw SecurityError if they should not hand out poses. This adds the second layer of pose protection in that XRFrame's methods will throw if poses cannot or should not be handed out. Due to the fact that frames can only be achieved in the two ways mentioned above, both of which should be blocked when these methods would throw, no test is added for this behavior. Bug: 1008573 Change-Id: If9940b290ad1c352c24d0660100ccbade3f1af59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832486 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#701395}
-
Xida Chen authored
Bug: 900581 Change-Id: I694137d193dcc456034e6ca7dc7d8aadbe68b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832146Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701394}
-
Xida Chen authored
Bug: 900581 Change-Id: I21076e39559d9cc1bf90c567dcab5ac5e7cb6268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832295Reviewed-by:
-
Bo Liu authored
Ideally, during a surface swap, the new view is inserted *below* the existing view in hwui. Then swap chromium compositor to the surface from the new view, and only detach the existing view when chromium compositor has swapped a frame into the surface of the new view. This should in theory avoid flickers of blank frames during surface swaps. This CL does various things to achieve the the above behavior: * Insert new view below old view. New view is inserted at position 0. * For SurfaceView that uses surface control, need retain the EGL surface to keep the surface alive. * Use postOnAnimation to manipulate view tree. It is unsafe to add/remove child views during draw. * Separate SurfaceData.destroy into markForDestroy and destroy. markForDestroy stops surface notifications. destroy will now be called after the first swap to remove the view from the view tree. * Ensure surfaceDestroyed is always called in markForDestroy. surfaceCreated and surfaceDestroyed is not guaranteed to be paired. And a clean up: remove all unused caller args in jni. Note there is still no guarantee there is no flicker. There will probably need to require more manul experimentation and manual testing. Potential more hacks: * TextureView may not have drawn the frame that chromium compositor produced. Can consider listening to TextureView's invalidate. * SurfaceView will teardown its own surface before removing the "hole" it draws into hwui surface, leading to a flicker. May need to either avoid this or cover it up before detaching it. Change-Id: I350f7da1890fdf72253759af00cb9f7f74dff0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830080 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
James Hollyer authored
If there is a device that we see as a gamepad it takes up one of the 4 slots for gamepads on a machine. This causes a large problem when users need all 4 slots especially if that device is built into the machine. This CL replaces unrecognized gamepads with recognized ones if we have more than 4 gamepads. Bug: 991842 Change-Id: I8964294fd50a4a4b941454fc76ee389859859a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759339 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#701391}
-
Roger Tawa authored
Adds checks (enabled via chrome policy) of data dragged and dropped into web pages to make sure it complies with corporate policies before allowing the page to access it. When checks are not enabled, or for non enterprise users, data dropped into a page is always considered accessible. Bug: 999149 Change-Id: I27c1ee5f2f7e5a3054521d6353521965e5f6c221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814619 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701390}
-
Jacob DeWitt authored
For both the head poses and input poses, send this value through mojo from the device process to the renderer process on every frame. Bug: 969131 Change-Id: Ie895deb75bddb6dd883d09828cfcb30f335d3793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825478 Auto-Submit: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701389}
-
Manu Cornet authored
This change has no expected user-visible effect. Change-Id: If3d9e1493d2fb2c0c09d2d7968e4aba064f820d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819887 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701388}
-
Manu Cornet authored
(Regardless of the shelf auto-hide state.) Bug: 1009701 Change-Id: I0578c66e719caa25cee2e15a43acb3883d53946f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832685Reviewed-by:
-
Eric Willigers authored
The Profile pointer is redundant as each LaunchService instance is for a specific profile. AppLaunchParams moves into the apps namespace. TBR=sky@chromium.org Bug: 1003602 Change-Id: I146dee5d6ed94a6282187a4ef9bfa12e26ca7929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829625Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#701386}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d5a9422f32c6..2533afa3f8c6 git log d5a9422f32c6..2533afa3f8c6 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 senorblanco@chromium.org Dawn: implement GrDawnCaps::getYUVAColorTypeFromBackendFormat(). 2019-09-30 reed@google.com restore old (dumb) behavior for filterColor 2019-09-30 bsalomon@google.com Rename GrColorSpaceInfo -> GrColorInfo Created with: gclient setdep -r src/third_party/skia@2533afa3f8c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I7043ccfa0a1d19f2bbfd540d3ffb114ff2f68d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832922Reviewed-by:
-
Tim Song authored
This button will be shown when the number of tray items exceeds what can fit in the shelf normally. Click on it will show/hide the trays. This CL just introduces the button behind a flag and it is not integrated with the rest of the status area. That will come in later CLs. Screenshot: https://screenshot.googleplex.com/no5btxNAAOw TEST=manual + stub unit tests BUG=982511 Change-Id: I813b3f24e1c7172ca6ce0d058cd1376bf22a6bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825921 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701384}
-
Gyuyoung Kim authored
Applies pending_receiver to CreateDecryptor and CreateCdmProxy in InterfaceFactory interface. Major changes are as below, - Convert InterfaceRequest to mojo::PendingReceiver<Interface> - Convert mojo::StrongBindingSet to mojo::UniqueReceiverSet - Convert InterfacePtr to mojo::Remote. Bug: 955171 Change-Id: I9ba94da2ccb4ff82109b30db7a794483d30dd39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828674Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Yuwei Huang authored
Trybot was not catching missing traffic annotations in remoting/client since it's not pulled in by shipped_binaries. //remoting/client is used by remoting Android and iOS clients, which we can't include in shipped_binaries, so I directly include //remoting/client instead. Change-Id: I5ad2a1e69fa2cbc57ca757ec748df002eb249ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829650Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#701382}
-
Chrome Cunningham authored
This reverts commit c4948f05. Reason for revert: Landed too soon (tried to uncheck CQ) Original change's description: > [media] vpx_video_decoder: dynamically update natural size > > This changes the behavior implicit resizing of for VP8/9 video. By > implicit, we mean streams where the dimensions change without a new > MSE init segment that explicitly describes the new size. > > Prior to this CL, we took whatever resolution was specified by the > container metadata and scaled any later differing resolution into an > element of that original size. Many of our decoders worked this way > before https://chromium-review.googlesource.com/c/chromium/src/+/1026992/, > which shifted the consensus is to allow dynamic resize. This CL makes > the libVPX wrapper consistent with those. > > When the size changes we will update videoWidth and videoHeight and > fire a 'resize' event. > > Bug: 992235 > Change-Id: I5bca7a68709594500e6ec9b4e107531b41e20925 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828226 > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701373} TBR=sandersd@chromium.org,chcunningham@chromium.org Change-Id: I80354370bb61189127bb894ba1f7d2da48445bb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832689Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#701381}
-
Julie Jeongeun Kim authored
This CL cleans up CreateMhtmlPageNotifier method from OfflinePageTabHelper. Bug: 955171 Change-Id: Id0ab7104717bb9cf8e485fe1b23952ab9691de78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829634Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#701380}
-
Dmitry Gozman authored
- Merge data_buffer_ and committed_data_buffer_. - Simplify blocked parser logic. Reentrancy protection now accounts for any possible code path leading to appending bytes to the parser: CommitData changes protection flag in_commit_data_, while its only caller ProcessBufferData checks the flag. Bug: none Change-Id: I1b019bf43ab73b0ebc3855169fd8ef075c911e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830068Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701379}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a9354743. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1d1f61e6a05240dbbe8824c124ef84d2d1c77e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832861Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701378}
-
Sunny Sachanandani authored
Support for direct composition pixel tests which do not use overlays has been added, so use that for testing that video overlays are not used when disabled. This would have prevented a recent regression. Bug: 1007055 Change-Id: Ic7fdf5524ca7e85bac8499cdf023c9b13f2c7b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829252 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701377}
-
Manu Cornet authored
(Whoops, forgot to guard with the flag -- again!) Bug: 982511, 1009525 Change-Id: I8f1fba3cb4cca9fdbecb6af6543342b110fd275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832489 Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701376}
-
Ramya Nagarajan authored
The SendTabToSelfShowSendingUI feature has been enabled by default across all platforms since 78.0.3904.0. This cleans up any dependencies on the feature. Bug: 901429 Change-Id: Iaeb320338c786ed173e3fd58b382ed865135b796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803955 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701375}
-
Andrew Xu authored
|icons_size| should contain the padding space on both edges. This CL fixes such an issue. Bug: 1009483 Change-Id: Ibfd44f5e70bd345fe9b623aa4ff2377ddb4c8250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832463 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701374}
-
Chris Cunningham authored
This changes the behavior implicit resizing of for VP8/9 video. By implicit, we mean streams where the dimensions change without a new MSE init segment that explicitly describes the new size. Prior to this CL, we took whatever resolution was specified by the container metadata and scaled any later differing resolution into an element of that original size. Many of our decoders worked this way before https://chromium-review.googlesource.com/c/chromium/src/+/1026992/, which shifted the consensus is to allow dynamic resize. This CL makes the libVPX wrapper consistent with those. When the size changes we will update videoWidth and videoHeight and fire a 'resize' event. Bug: 992235 Change-Id: I5bca7a68709594500e6ec9b4e107531b41e20925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828226 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#701373}
-
rbpotter authored
Split out KeyboardShortcutDelegate into a separate file to break the following circular dependency, created when we migrate to Polymer 3: - shortcut_input.* depends on the KeyboardShortcutDelegate class from keyboard_shortcuts.* - keyboard_shortcuts.* imports shortcut_input.*, since it uses shortcut-input. Bug: 1004967 Change-Id: I9b75267eddea8eb4555b2080a90ba7e8ffca0a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832792Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701372}
-
sczs authored
This flag will be used so ConfirmInfobars use the new Messages UI. It will be enabled by default, but it will only work if the core InfobarUIReboot flag is enabled. This way we'll be able to maintain the same population that has been using Messages the past releases, and we'll also be able to turn off this specific feature in case something goes wrong. Bug: 961343 Change-Id: Ia69664ece14235fcafdf693c9b6e3d193a57e53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827681 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#701371}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/699a19bcc20b..33217c214665 Created with: gclient setdep -r src-internal@33217c214665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0dbeb6ceb3d8c6877c7d037b43b432d84ea3330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831595Reviewed-by:
-
