- 08 Sep, 2020 40 commits
-
-
Sorin Jianu authored
This is an iteration to make the implementation of --install cross-platform. SplashScreen and AppInstallController are injected by MakeAppInstall implementation using two closures. The Windows code has working objects for the two, while the other platforms use do-nothing stubs. There is a small change in the integration test to invoke Wake for the Windows execution path. The tests pass without the change and removing this platform difference in the test execution seems useful. Change-Id: Ie3c75d52742aafc7f2f96e16cc64583f501018f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385896 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804958}
-
Alex Turner authored
Currently in FontMatchingMetrics, the check_type and is_loading_fallback flag are included as part of the output digest. However, these do not represent an output. Instead, they represent different kinds of lookup or a temporary state. By including them in the output digest, we cannot determine if two lookups at different points in the font matching process resulted in the same font or not. We remove check_type and instead split the IdentifiableSurface::Type to account for different kinds of lookup, including splitting lookups that can match only unique font names (i.e. src:local specifiers) and lookups that can also match family names (i.e. font-family specifiers). We adapt FontMatchingMetrics' HashMaps accordingly. We also ensure other lookup values are appropriate by: - including FontFallbackPriority for lookups by fallback character, - handling FontDescription::GenericFamilyType properly, - considering font names to be case-insensitive, and - ignoring any lookups where is_loading_fallback is true. Bug: 1121669 Change-Id: I398ad1359c5c6bae51b8bb8b4f236c1944c3e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376037 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#804957}
-
cfredric authored
SSLErrorAssistantComponentInstaller. Change-Id: Ie7de9cdc89acb05e8d9781d6da3d1706d921fef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392989 Commit-Queue: Chris Fredrickson <cfredric@google.com> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804956}
-
Abigail Klein authored
Screenshots: Chrome accessibility page: https://screenshot.googleplex.com/5vU2bhoKpJvoruY ChromeOS accessibility page: https://screenshot.googleplex.com/ALQB78FPBjvhEqD Captions settings page: https://screenshot.googleplex.com/3LUrCWPny6kv954 AX-Relnotes: Clarified the names of captions strings in settings Bug: 1055150 Change-Id: Ia645b35626b1e5a30e5115882362b7e0c632f60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398980Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#804955}
-
Matt Menke authored
Back in the days when humanity was yet young, and IE roamed the Earth, URLRequestJobManager had a global list of factory functions, one for each scheme. Through the mighty work of the intern shalev, most of these were converted into ProtocolHandlers, which were added to a URLRequestJobFactoryImpl, which sat at the bottom of a stack of URLRequestJobFactories used by various modules to to intercept requests. However, the zombie URLRequestJobManager remained. It called into the top URLRequestJobFactory to give it the first shot at creating a URLRequestJob, and it still had the factory functions for HTTP[S] and WS[S]. There were reasons for this, though I can't quite remember why - URLRequest::IsSupportedScheme (removed a while back) was likely one of those reasons. There may have been others. At this point, we've removed almost all ProtocolHandlers (only FTP and chrome (iOS only)) remain, and the intercepting URLRequestJobFactories that sat on top of it are also gone. This CL finally removes URLRequestJobManager and moves all of its logic down to URLRequestJobFactoryImpl. Fixed: 354158 Change-Id: Ic1f364bd6bf9c37ed6e139a668da1de2bb301bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392995Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804954}
-
Michael Crouse authored
The LiteVideoObserver observes media rebuffering events and sends a stop throttling message to the hints agent. This should only happen if LiteVideos were allowed and a hint sent in the first place. This also removes the dcheck in the hints agent as the design changed so the DCHECK is not needed. Bug: 1125922 Change-Id: I3b65a78acc54bd267ecbabd03e8fd23bea99aad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398958Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804953}
-
Sylvain Defresne authored
base::CancelableTaskTracker is sequence-affine. Since it is not possible to ensure that -dealloc is called at a specific point in time nor on a specific thread for an Objective-C instance, change _largeIconTaskTracker to be heap allocated and stored in a std::unique_ptr<> so that it can be destroyed from -shutdown. Add DCHECK that method accessing _largeIconTaskTracker are not called after -shutdown as been called (as they would otherwise try to dereference null which is Undefined Behaviour). Convert _pendingTasks to a std::set<URL> since the value are never used, and check that the scheduling of the task was a success before storing the object in _pendingTasks (failure probably mean that the sequence has been shutdown which only happen at app shutdown, so it is okay to do nothing in that case). Bug: 1122991 Change-Id: I9f312bf6b8ac844e6a28d4e10042e9b9c1a7b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388061 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804952}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599540720-2c8a746fd34db3cbe60ec0abca5753030633ccf0.profdata to chrome-win32-master-1599551854-84903541b1ee77a3a0a009f1d73fc84d0ed1091a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie4c1c9d42c93e53293a03cb3c0da0956dba107ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397673Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804951}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f67f6444. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes rego@igalia.com: external/wpt/css/css-ui external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ic7b77b71178bdf8a317a01096f528c9f58108420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398858Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804950}
-
Peter E Conn authored
Change-Id: Ifd8bec0b4db3f7ac540b070642250b48f712dacc Bug: 1126040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398680 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804949}
-
David Tseng authored
See go/chromevox-touch-gestures TBR=dtseng@chromium.org AX-Relnotes: Adds four finger swipe for ChromeVox to move among on-screen panes (launcher, status tray, web page, etc). Bug: none Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight* Change-Id: I62d4bd6f2b8e5c63e55c6143b68380ad0c137463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398842Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#804948}
-
Alice Wang authored
This CL batches profile data render tests with and without badges. Bug: 1120258 Change-Id: I779e62ee88efed5acf3d032189c27c36cbbb8e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398478 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0485634fe3f9..2d00262a1459 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from dc1b9762731e to 6a6e311d81dd (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from fd05605bef1c to 1ab52e54abfd (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 4a7362c2b223 to 45f2f18a69eb (1 revision) 2020-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 2c793ba1d0e8 to 4ede8ee6e2ec (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I08740254adb8e845105c27054ca3d9e4cff23b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398801Reviewed-by:
-
Yue Li authored
Bug: 1124321, b/162780582 Test: Manual Test Change-Id: I5020cde15baec511782f26df21ea51a3a426ab89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397323 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804945}
-
Maksim Sisov authored
My observation showed that other bots that run this test suite also experience the flakiness. Bug: 1084469 Change-Id: I3b4262da60fe62e261029c4337c8d66c0494fc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398658Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#804944}
-
Chanyong Moon authored
When keydown event is triggered continuously, mousedown event cause keydown event as not repeating event. This change append check logic to exclude mouse button flags. Bug: 1114281 Change-Id: Ie967e34cbc13c2489ccba4945cb4ae0dcbce0deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368577Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#804943}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9eaf5ce5d81..7e3252b4439a 2020-09-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domDebuggerManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.isolateManager 2020-09-08 tvanderlippe@chromium.org [globals] self.SDK.domModelUndoStack If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b15f2d77180d4f5e3d8cee30eac275e4bcda2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398800Reviewed-by:
-
Miriam Zimmerman authored
BUG=chromium:1125007 TEST=CQ Fixed: chromium:1125007 Change-Id: Ie0317463f0e0b4b5bb602a64229f5ce3486df459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398960 Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#804941}
-
Bruce Dawson authored
tools\win\setenv.bat is a mostly unknown but sometimes useful batch file that adds the VS tools to the path. It respects the value of DEPOT_TOOLS_WIN_TOOLCHAIN and the current toolchain hash. This change updates it to add support for VS 2019, and remove support for VS 2015. It also takes away support for selecting 32-bit versus 64-bit target toolchains because this feature was never used and was too much work to support (since the packaged toolchain and vcvarsall.bat flags are different). This change also fixes a bug where the name of the batch file would be retained in the command-prompt title after this script exits. Using the "call" command fixes that. The retained title is ultimately a Windows command prompt bug which is not going to get fixed. Adding the call command then requires quoting the command path in the Python script. Change-Id: I2b4943dc1e391d9fb4a9e76dd8b592223dc31fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392013 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#804940}
-
Sreeja Kamishetty authored
After enabling H264 which run WPT,the failing blink web_tests should be working with BackForwardCache enabled. Bug: 1103214 Change-Id: I5059bf682f0aa441fd9d5a8237e90057213796d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395236Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#804939}
-
Hiroki Nakagawa authored
This is a follow-up CL for the previous review comment: https://chromium-review.googlesource.com/c/chromium/src/+/2389380/comment/65b648df_f6299bcf/ Bug: 1112515 Change-Id: Ia7ba8b79cb0b60567616773c8240c4c5b446e8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397992Reviewed-by:
-
Laís Minchillo authored
Remove logging of Android.WebView.onReceivedSslError.ErrorCode and mark the enum and histogram as obsolete. Fixed: 1066115 Test: None Change-Id: Ia060aa6c07fad809085c15b037762278d380a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398718 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804937}
-
Mohamed Adel authored
This flag will be used to determine which notification API to run on macOS devices during the introduction of the new API. Bug: None Change-Id: Iddadbec08cea46d99a46cf425466420cdc38347d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396076Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#804936}
-
Matt Jones authored
This is a reland of 3c8430ae This patch adds a check for the currently running animation. Animations on Android M seem to continue for a few updates after cancellation. Original change's description: > Batch BottomSheetControllerTests > > This patch batches all the tests in BottomSheetControllerTest. > Consequently, some new methods to reset the sheet's state were added > to the test support classes and BlankCTATabInitialState was updated to > support any subclass of ChromeActivity. > > Bug: 1122163 > Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803156} Bug: 1122163 Change-Id: I2b562243eb50b7990fa82bd9d353c8d1f16589cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387433Reviewed-by:
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I6b8b702b1e4e335786b365ce4ca00c29195ae191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375285 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#804934}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I397656c55fe211615ae3d1d4cbc167cc2c1feee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396616Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804933}
-
Owen Min authored
Based on the flake-portal, the test SavePageBrowserTest.SaveHTMLOnlyTabDestroy is also flaky on Windows and Linux's release bot. Disable the test on those platforms. Bug: 580766 TBR: qinmin@chromium.org Change-Id: I813fb92b70358da9acee5a88007bb399a3d5e1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397240 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804932}
-
Owen Min authored
The test BackForwardCacheBrowserTest.NavigateBackForwardRepeatedly is flaky on Mac, Linux and ChromeOS. Disable the test on those platforms. Bug: 1099395 TBR: altimin@chromium.org Change-Id: Ib4adf13ffe75fce14b42e9b93b7a2383d60b8a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398899 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
-
Yngve N. Pettersen authored
chrome_public_apk_or_module_tmpl template instantiation for an Android target Additionally, add default values for lint_suppressions_file and lint_baseline_file inside the chrome_public_common_apk_or_module_tmpl template definition when linting is enabled. Change-Id: I2feb9c0b26c133588495c523284b4ef7e9df5120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391077 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804930}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iee4d506b6b2bc47ec552759e29b282e8af663c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398799Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor| to produce |NGInlineItem| with |ShapeResult| having same start and end offset for valid text painting. Before this patch, we see wrong painting, e.g. "AxXX" instead of "AxVX" when insert "x" before "X" of "AVX". This is cause by kerning between "A" and "V". Bug: 1121885, 1124805 Change-Id: If51bd6ed688e909911b55324515cb1ac23d2cb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397989 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd54c8385c31..2b3b35f8381b 2020-09-08 brianosman@google.com Handle function reference expressions in the inliner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ib233327cfda1a531156d2b6ddf2ef502535d21a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398758Reviewed-by:
-
manukh authored
- Images in the omnibox dropdown are decoded in isolated processes created when needed. Especially on windows, this contributes significant delay in displaying them. - Images are cached making the delay most noticeable when first displaying particular entities. - Image fetching and decoding begins as soon as the search response is parsed, before AC completes. Therefore, the time to fetch & decode images is longer than the delay between showing suggestions and showing their images. - Both answer (e.g. weather) and entity suggestions have images. - Decoders are shut down after 5s of idling. This CL reduces this delay by sharing a single decoder among all omnibox suggestion images. Additionally, the shared decoder is woken on user input to reduce the startup delay if they've been unused for at least 5s. Before, with isolated decoders, a sample timeline could look like the below, resulting in a 270 ms (450-180) image latency. AC start search response AC done image fetched image decoded 0 ms 160 180 190 450 With this CL, With a shared decoder, a sample timeline could look like the below, resulting in a 30 ms (210-180) image latency. AC start search response AC done image fetched image decoded 0 ms 160 180 190 210 In addition, this CL adds 4 histograms - BitmapFetcher.Fetch: to help breakdown sources of image latency - BitmapFetcher.Decode: to help breakdown sources of image latency - Omnibox.BitmapFetch: to measure the latency experienced by the user (delay between suggestions displaying and their images displaying) - Omnibox.SuggestRequest.Success.PrefetchImagesCount: to measure the number of images included per search response. Additionally, the existing histogram Omnibox.SuggestRequest.Success.GoogleResponseTime is relevant. Change-Id: Ia8ed2ead9fda6b3893715c3757165d3ebe0ae1f3 Bug: 1115108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348328 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#804926}
-
Robbie Gibson authored
The test is causing the builders to fail. Bug: 1124655 Change-Id: Id808248e6b63c69da8d10a9fe351a8573cf7d588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398681 Commit-Queue: Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804925}
-
Alex Gaynor authored
Previous commits have been at my Mozilla address, but I've also been involved in Chromium in my personal capacity. Change-Id: I1ef97b84bbf947b7e5e957249c8cc01e8410a41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394675Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804924}
-
Richard Knoll authored
We've deprecated an enum value which might still be set in some profiles. This will make sure we're ignoring these invalid enum values instead of hitting a DCHECK further down in sync code. Bug: 1114108 Change-Id: I3fa0800052a0c7d84cdb30ceb3a1486bc7468264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395616Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804923}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c107c7e93630..6b0afc48ae3d 2020-09-08 hjd@google.com Merge "ui: Allow open in catapult from permalinks" 2020-09-08 hjd@google.com Merge "Use const references where possible" 2020-09-08 treehugger-gerrit@google.com Merge "Deobfuscation support for the ui / pprof layers" 2020-09-08 treehugger-gerrit@google.com Merge "Remove unmapped_java_symbols" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia98873ba29363a103ec1acd271d07e6a73d894fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398798Reviewed-by:
-
Alice Wang authored
This CL removes all ChromeActivity usage in AccountPickerDelegate. Bug: 1125068 Change-Id: Ib2afc7f5d8ab1ebe8138e96aff41cdd1c1c8dea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398129Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804921}
-
Peter Boström authored
This removes ButtonListener from BubbleDialogModelHost and adds Button::PressedCallback versions of MdTextButton and LabelButton constructors to support it. Bug: 772945, 1106422 Change-Id: I5a6fc50a714e6ac6701af588d5a428ea291bd008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398321 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Ella Ge authored
When switch on/off dark theme, WebApk splash screen is shown again since browser is initialized again and SplashController#onPreInflationStartup is called. The splash screen is not hidden because the web page is not reloaded. This CL makes the splash screen also hide when the Tab's re-attached to window (intractability state to True), and is not loading. It only hides when TabCreationMode is RESTORED so the real splash screen on webapk launch won't be affected. Bug: 1111880 Change-Id: I4df9490d3dccc375db03ef9b639e8fee74d952e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391387 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804919}
-
