- 01 Jun, 2020 40 commits
-
-
Ben Pastene authored
Will be used by clients that have a vendored copy of the lib: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:chromite/third_party/gn_helpers/ Bug: 937821 Change-Id: I6f2380fe60fe5bdc661bcbf7947bf3e221011e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225264 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#773877}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#773876}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f5ff495681c..11dd7183c4d2 2020-06-01 capn@google.com Remove generation of OpenCLDebugInfo100.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iabd73801b331990f8d3043441fb609422734c498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773875}
-
Zhongyi Shi authored
Bug: 1088100, 1090018 Change-Id: Ie25ffdecabb2bbaa242379b45f28debb0b10c1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223013 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#773874}
-
Thomas Guilbert authored
This is frequently failing on win7 bots. TBR=johnchen@chromium.org Bug: 1088447 Change-Id: Ia1b3778647f01afce6349cab31fedb8a2933713c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225367Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773873}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591026828-08649a6f2f91ff46c0ee4a8534af4c349ceca721.profdata to chrome-mac-master-1591041546-a410a758e06ddb76997f15201c691b94ce14829b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2c4103b81c342c333d9fc6f78942d036588b7247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225315Reviewed-by:
-
haozhe authored
The svg-baseline-shift-interpolation.html test occasionally flakes due to timeout. This patch marks this test as a slow test. The test require inline layout change, making the test slow. https://drafts.csswg.org/css-inline/#propdef-baseline-shift Bug: 1076034 Change-Id: Id1270b20479f3341e7051211bb0c891355bfe0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220349 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#773871}
-
Nathan Zabriskie authored
This is a reland of eeb9431b The change was reverted because it was causing breaks on android-pie-x86-rel. This relands the patch with a fix for those breaking tests. Original change's description: > Move CPU VideoFrame YUV Uploading code into yuv_util > > This patch unifies CPU VideoFrame uploading/conversion code for OOPR > and GPU rasterization. Now clients can call ConvertFromVideoFrameYUV > with CPU backed VideoFrames in addition to wrapped frames. > > Bug: 1058992 > Change-Id: I89c37179b12fe1375fa7a6f7d919f135f77b5857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200084 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770729} Bug: 1058992, 1085516 Change-Id: Ib465428bf72cbf98e69ae19db1e917ebcd32ebb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223325Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773870}
-
Will Harris authored
BUG=1005715 Change-Id: I7b15b4284725e3a8125b4d33dfa5da1dd0309b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225508 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773869}
-
Karandeep Bhatia authored
The removeHeaders action has been removed from the API. BUG=1085326 Change-Id: I533c885d92373ce8fd888a059f8ded0a9acc6337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220831 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773868}
-
Tom Anderson authored
This CL just moves some things around and has no behavior changes. 1. Move response/event processing from X11EventSource to x11::Connection. This is done because X11EventSource can be null in some tests, but we always have an x11::Connection. Needed to fix tests for [1]. Also wanted for [2] which begins migrating events from Xlib to XProto. 2. Move some logic from x11::Future into x11::FutureBase. This is done to avoid including ui/gfx/x/connection.h from xproto_types.h which would otherwise add a circular include. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220686 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2220635 BUG=1066670 R=msisov TBR=sky Change-Id: Ia0710595c6cb6337a8c9b52f31ceaafefaf00cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220524Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/13110bff05b8..0e3c27de6a33 2020-06-01 rharrison@chromium.org Rolling 5 dependencies 2020-06-01 bryan.bernhart@intel.com Roll third_party/shaderc/ 7d2f8c57e..da87b8d8b (3 commits) 2020-06-01 cwallez@chromium.org Fix missing space in an error string. 2020-06-01 enga@chromium.org Fix ValidateEntireSubresourceCopied If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3ae041252f8365a4631f1ea6d2a45c094efcbc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225314Reviewed-by:
-
Tibor Goldschwendt authored
Process-per-site makes all WebUI NTPs share a single renderer process. This is what the local NTP does and has the following performance advantages (measured on my linux machine): * Reduces mean of NewTabPage.LoadTime.WebUINTP (duration from starting the NTP navigation until the most visited items are added to the DOM) from 271ms to 141ms. * Reduces memory overhead of opening a new NTP from ~30MB to ~5MB. NOTE: The aforementioned performance improvements only hold true if another NTP is open to have the process pre-warmed. The WebUI NTP does not seem to use the pre-warmed spare renderer. + Move existing WebUI NTP browser test to //c/b/ui/webui/new_tab_page. Bug: 1075641 Change-Id: Id94294eac41e3ab083e8eece567941ef4d40d08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220634 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773865}
-
David Schinazi authored
This CL changes the test to pretty-print its parameters. R=zhongyi@chromium.org Change-Id: I0542a103b6ff69001bed54e3b6f152fe9a97b19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225473 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773864}
-
Alex Moshchuk authored
This CL fixes a regression introduced by the refactor in https://chromium-review.googlesource.com/c/chromium/src/+/2181973. Apparently, it's possible that a subframe may have neither the old nor the new (target) FrameNavigationEntry during a history navigation. Prior to the refactor above, we returned early and avoided scheduling any loads for such a subframe. After the refactor, we incorrectly attempted to schedule a different-document load, which resulted in calling CreateNavigationRequestFromEntry() with a null frame_entry, which it didn't expect and crashed while deferencing it. Bug: 1088354, 1088175 Change-Id: Iaaa9743b0e897eecb1aa0317fa20d8d042c878f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225267 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773863}
-
Alex Turner authored
This adds the PageLoad.Clients.Ads.AllPages.NonAdNetworkBytes histogram. This will be useful for high-level comparisons of Cluster Telemetry runs, by allowing approximately tracking of AdTagging accuracy over time. While this histogram can be computed from the difference between total bytes and ad bytes (i.e. PageLoad.Experimental.Bytes. NetworkIncludingHeaders - PageLoad.Clients.Ads.Resources.Bytes.Ads2), cluster telemetry's performance dashboard does not support subtraction. Bug: 1084712 Change-Id: Id5853fa0008b854c576e63ef7498dfe42e491283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210666Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#773862}
-
Eric Lawrence authored
Several crash exit codes have duplicate definitions, and showing a textual constant for them in the sad tab page could be misleading to the end user. Remove the contested codes from the switch statement so that the default "Error code: ####" text is shown instead. Bug: 1090040,1076440 Change-Id: Ic1775f58f750b7cd942b2ccf3238314589d622d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225458Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773861}
-
James Vecore authored
The NearbyConnectionsHost mojo interface allows the utility process to query for any browser owned mojo interfaces that it needs. The Bluetooth adapter is the first example of a mojo interface provided for the utility process. Change-Id: Ia8065586f60fad0728cd7bdbd95ead630f9aaac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220711 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773860}
-
Bettina authored
For SafeBrowsing.Pref*, the enhanced protection just launched so we need the histograms to review. For all other histograms by this CL, there is still needed usage. Removed SafeBrowsing.Pref.Scout.Decision* due to it only referring to SBER1. Bug: 1089523,1089425,1089424,1089244,1089238,1089237,1089233 Change-Id: Ibc0e3e65ef32378d9463c34ffd2362de7e9821d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225380Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#773859}
-
David Bienvenu authored
Since this removes a RunUntilIdle, I had to replace an async close of a browser window with a synchronous close. Change-Id: I4428d218c4b4d5fbb218bdeefece4062f0394e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144421 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773858}
-
siashah authored
We update the status of the Done button based on whether the nickname is valid and then call PersonalDataManager.setCreditCard to save the card with the nickname. Video (Googlers only): https://drive.google.com/file/d/1rH_L7gPIiRSjmkoY5oxWEFoU5uUcCGVR/view?usp=sharing Bug: 1082013 Change-Id: Ifab123a53762da03f3c903962a70e431fc8fb78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218987Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#773857}
-
Adrienne Walker authored
This change turns back on (it's explicitly turned off in the test base class) the require appcache origin trial feature for several manifest 404/410 tests. It also adds a 410 gone test for an upgrade scenario. Bug: 1081907 Change-Id: I533f6ddfc6d45b4f73de5a82af159d77479dacbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225385Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#773856}
-
Stephan Hartmann authored
Bug: 957519 Change-Id: I535b3bcf318f98cecbf4be1520ffe4126abcacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214556 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773855}
-
Ana Salazar authored
This is part of the new drag spec in the apps grid. When the user drags an app, the apps grid enters a new cardified state. In this state we scale down items to 84% of its size and add a background card to the apps grid, giving a more modular look to the app pages. We define an array of Layers for the background cards so we are able to manipulate the animations during the cardified state in every step (start, translation across pages, end). When we end the cardified state, we also delete the cards. This functionality is hidden under the app_list_feature kNewDragSpecInLauncher. Bug: 996822 Change-Id: Ic8dcca8cfa2f11ceb52634dbf1206321d924752f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171453 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#773854}
-
James Cook authored
Mustash/mash was shut down over a year ago. Clean up mash references in DEPS files. Remove a few obsolete entries. All the mash bugs referenced in the files were already closed. Bug: none Change-Id: I4205fb880d69f0e1ddaae133458bf9f2c0d8a6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225456Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#773853}
-
Xiaoqian Dai authored
Bug: 1063144 Change-Id: I85379cc2f4aded28ac9eefb09e2086d446f42168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773852}
-
Chris Sharp authored
This histogram is deprecated and no longer need to be recorded. Bug: 1089422 Change-Id: I9c29449b3080535e1451163f1b76c65139df792d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225536Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773851}
-
Sahel Sharify authored
This is a reland of 561f6a86 I reverted the original cl since I wanted to wait for thread safety review of the following two classes: -PaymentDetailsUpdateService.java -PaymentDetailsUpdateServiceHelper.java Original change's description: > [Web Payments][Android] Delegation support for intent based apps [2/3] > > This cl introduces IPaymentDetailsUpdateService.aidl and > IPaymentDetailsUpdateServiceCallback.aidl interfaces so that the invoked > native app can call changePaymentMethod, changeShippingOption, and > changeShippingAddress methods to notify the browser about the user > choosing a different payment method, shipping address, or shipping > option. > > This cl implements the plumbing for sending the change events to the > merchant, but the plumbing for sending the updated payment details from > the merchant to the invoked app will be landed in a follow up cl. > > To test the feature enable "Experimental Web Payments API features" from > chrome:/flags or use the following commandline flag: > enable-features=AndroidAppPaymentUpdateEvents > > Bug: 1026667 > Change-Id: I799c9dfced15fe2fa916b8ca3634b91366cfc32f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168009 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773401} TBR=mthiesse@chromium.org,rsesek@chromium.org Bug: 1026667 Change-Id: I10bfc1778ef950deab59dffef48a027ce7e234bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222899Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773850}
-
Ryan Sleevi authored
Net.CertCommonNameFallbackPrivateCA and Net.CertCommonNameFallback are obsoleted as of r531345, while Net.Cronet.CertVerifierCache.DeserializeTime and Net.Cronet.CertVerifierCache.SerializeTime were removed in r571588. Net.SSLCertVerificationTime and Net.SSLCertVerificationTimeError are extended to M89 as part of the overall cert verification service work. Net.Certificate.TrustAnchor.VerifyOutOfDate is moved to never expire, in line with the other two Net.Certificate.TrustAnchor metrics Bug: 1088988, 1088993 Change-Id: I36482558df69dff2732aff2da27402365c9c2344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224834Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773849}
-
Leonard Grey authored
Currently, in BridgedContentView we "opt out"[1] of BaseView's tracking area to install a different one which: - Specifies `NSTrackingCursorUpdate` - As a consequence, only tracks while app is active, since the docs say that always tracking is incompatible with cursor updates However: - Empirically, cursor updates work fine without this (some test cases: move mouse between Omnibox and other parts of topchrome, move from webcontent links/inputs to topchrome and vice-versa). - Only tracking while app is active means we don't get entered/exited events from app switching. This means: - Switching away from Chrome while showing a topchrome hover tooltip keeps the hover on and makes the tooltip stuck - Under some circumstances, hover stops working on switching back to Chrome (see bug) - Even though we allow mouse clicks to function when Chrome is inactive (that is, we return `YES` from `acceptsFirstMouse:`, we don't process hovers in this case, contrary to other apps on the system. This change removes BridgedContentView's tracking area in favor of the default one and gives BaseView some explicit enable/disables, mostly to make tests happy. [1] By overriding a private method with a no-op! Bug: 841792 Change-Id: Ifb5d65e22299959b8cac25a9e0a0407650a40746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216530Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Yi Gu authored
The resolved scroll source of ScrollTimeline could be null so we should check before dereference it when checking whether it uses composited scrolling. Bug: 1088319 Change-Id: Ib20cceefcd0e1de05cf1d5932a6da6aac37ef8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223995 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773847}
-
Eric Robinson authored
Bug: 1089680,1089681,1089679,1089211,1077807 Change-Id: I1103f31e6b9152007276f7f15e05f8fd9194fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225265Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/394c4a94dbc7..3fb1d569defc 2020-06-01 brucedawson@chromium.org Fix command prompt title after update_depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iee9970e4ba7070b356575e01db14032b9179a528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225310Reviewed-by:
-
Kai Ninomiya authored
Bug: 1069302 Change-Id: Iea10257e35bd11e724241dbc038955cc8a0b47a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222299 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773844}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 378036cd. With Chromium commits locally applied on WPT: bc9a80d4 "Origin isolation: parse the header" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie0770ea924d20b0a3468826131b5256d9dfa33bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224650Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773843}
-
Ian Struiksma authored
updated giftcardmall.test to remove autofill-information reference in xpath. This required update of cipd version in DEPS diff of cipd versions: 265c265 < "selector": "//select[@id=\"statesList\"]", --- > "selector": "//select[@id=\"statesList\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_STATE server type: ADDRESS_HOME_STATE heuristic type: ADDRESS_HOME_STATE label: State parseable name: state section: address_2-default field signature: 1878375253 form signature: 2667380901547437148\"]", 276c276 < "selector": "//input[@id=\"addressZip\"]", --- > "selector": "//input[@id=\"addressZip\" and normalize-space(@autofill-information)=\"overall type: ADDRESS_HOME_ZIP server type: ADDRESS_HOME_ZIP heuristic type: ADDRESS_HOME_ZIP label: Zip parseable name: zip section: address_2-default field signature: 569224803 form signature: 2667380901547437148\"]", Bug: 1088252 Change-Id: I06821a54e0f0e92505e92d31a5b54aef54c951f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224052 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#773842}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0aaf24a2757..ced839500960 2020-06-01 michael.liao@microsoft.com [TreeElement]: null treeOutline exception in TreeElement.select If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1085816 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2840a29f5384df37de70679478af20577c872126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225308Reviewed-by:
-
John Chen authored
Add missing commas in _DISABLED_TESTS. TBR=wenbinzhang@google.com Bug: 1060068, 1088106, 1088447 Change-Id: I7f2ab1e14314237e4d4b466f775c6a7108de9f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225338 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773840}
-
Behnood Momenzadeh authored
Some top domains use a common word for their website name. Office.com and weather.com are examples of such domains. As a result, hostnames embedding these common words might be falsely flagged. We allowlist some common words in this CL that have shown to lead to false positives. There are two types of common word allowlisting. One is allowing the common word to be embedded with all TLDs and two is allowing the common word to be embedded with TLDs other than the TLD of the top domain. For example, weather is a common word for all TLDs. As a result, neither of weather.com-foo.com, and weather.info-foo.com would trigger this heuristic. However, office is a common word just for TLDs other than ".com". So, office.info-foo.com won't trigger the heuristic, but office.com-foo.com would trigger it. Bug: 1087636 Change-Id: Id5b6bc5204254f45429a7d91690af192fcef81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224313 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#773839}
-
Jonathan Backer authored
Sometimes a device driver signals an internal error and we just need to reset. This CL checks for reset more aggressively on all {SharedContextState,SharedImageStub}::MakeCurrent calls. This will hopefully turn some crashes into restarts. Bug: 1079161,1081806 Change-Id: I260f90b4ed2ba63be3cf7ca6759c5aa086f0c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214919 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773838}
-
