- 04 Sep, 2019 40 commits
-
-
Corentin Wallez authored
This flag controls the inclusion of Dawn and the availability of WebGPU which we want to keep limited to Canary for now. TBR=kbr@chromium.org BUG=chromium:985142 Change-Id: I7677ec0571bcf394af4442829ad86e92a87b8a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784611Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#693224}
-
mark a. foltz authored
The upstream API for openscreen::platform::UdpSocket has changed in multiple incompatible ways. Since the Chrome implementation doesn't have any usages yet, it is simpler to just comment it out, rather than devise a complicated sequence of multi-sided patches to revert and re-land the upstream API while migrating the Chrome socket implementation. When the upstream API is fully stabilized, this can be reverted and the Chrome socket re-implemented on top of it. Bug: openscreen:68 Change-Id: I05165a409076df9862aa8309da2ef9152beddf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783879 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#693223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cbdc04e23f6..ed788765ead4 Created with: gclient setdep -r src-internal@ed788765ead4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I29d77d6bf3a6c743b0f6fb7c00991cb6edea2b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783906Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693222}
-
Eric Stevenson authored
Didn't realize that the framework tries to perform JNI registration on some WebView classes. Bug: 1000471, 929661 Change-Id: Ic5f7d75dfdcaf40fe369dd82061333b452ad1327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783642 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#693221}
-
Scott Violet authored
Specifically this adds: NavigationController, Navigation and NavigationObserver. BUG=none TEST=none Change-Id: I2cb562570a86c69ba5d38f98a5656fdb2d0d4d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779438Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693220}
-
Michael Crouse authored
This change makes the engagement score threshold used by the top host provider configurable in order to increase the number of hosts and navigations covered by the HintsFetcher by added a finch parameter. Bug: 999541 Change-Id: I5d5302f8449524158c09420b12b591e071dfb556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783230Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#693219}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types. - Apply mojo::Remote to AppShimHostBootstrapPtr - Apply mojo::PendingReceiver to AppShimHostBootstrapRequest - Replace mojo::Binding with mojo::Receiver Bug: 955171 Change-Id: I9d707ef1f6335d022d249d317b6114ab8cea23cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780094 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693218}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/d8c602586f32..c6a260a763ca git log d8c602586f32..c6a260a763ca --date=short --no-merges --format='%ad %ae %s' 2019-09-04 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@c6a260a763ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-components-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: If26f390a1b56aed31cec1c4354505ec252b7431d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693217}
-
Jeevan Shikaram authored
App Management has been moved to be inside OS Settings. This CL checks if kSettingSplit has been enabled before checking if App Management has been enabled. Bug: 1000104 Change-Id: I3971cde76ab359d5f7e1168318d181818d4c30a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782362 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693216}
-
Chris Harrelson authored
An earlier CL stopped applying mask state, but this is incorrect, as masks need to paint in the correct property tree state to apply. The new CL applies the same logic as for the root <svg> element, which paints in the same way as <foreignObject> Bug: 998553 Change-Id: Ib8cea27e16063f459d9719336d4c0fac63589759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783144Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693215}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1de0c8d6a36..0b32c1e79860 git log b1de0c8d6a36..0b32c1e79860 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 tneda@google.com perfetto-ui: Slices with the same name should be the same colour Created with: gclient setdep -r src/third_party/perfetto@0b32c1e79860 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:140092592 Change-Id: If39968c9f655bfced01762db976b49a5a9b29eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693214}
-
Justin Cohen authored
Special case trusted currentURLWithTrustLevel URLs that have been rewritten to return the URL, and not the virtual URL. This fixes a DCHECK when navigating forward from the NTP to an internal page. Bug: 925776 Change-Id: I8d23b79eecd2f5902c726c7e2d8f9878969b9364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778962 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#693213}
-
Joao da Silva authored
This is mostly an observer of a synced pref, that puts its contents on the clipboard whenever it changes. This feature is currently behind a feature flag and is disabled by default. Change-Id: Id038cd2190cbdb1c1c20b567933274715018cc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781442Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Joao da Silva <joaodasilva@chromium.org> Cr-Commit-Position: refs/heads/master@{#693212}
-
Marijn Kruisselbrink authored
Changes the base::Feature to be default-enabled, and only explicitly enable the runtime feature if the base::Feature was overridden on the command line. So after this CL the feature can be enabled either via the origin trial,with --enable-features=NativeFileSystemAPI or with --enable-experimental-web-platform-features. Draft Intent-to-Experiment: https://docs.google.com/document/d/157R5mH4ZNX5RqWy74nm3kU2ZZl1i0tOMWAYNbj2bKgY/edit Bug: 853326 Change-Id: I2d4f9c69ed012f1d57242b51c849ba0e71970873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783278Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693211}
-
Pavel Shmakov authored
Current api requires clients to warmup the browser and verify the origin before launching ManageTrustedWebActivityDataActivity. This api is clunky, and also had a bug http://crbug.com/923305. In fact, warmup and verification is not needed at all. We can use ClientAppDataRegister to retrieve the origins the app is associated with, and show the settings - the same way as in uninstallation flow. The only thing we need in the intent is a CustomTabSessionToken. This CL simplifies ManageTrustedWebActivityDataActivity. The client-side code will be updated to support both new and legacy api. Bug: 993347 Change-Id: Iff5bfea88ffd8dce3f0381bd6f9e3a484b5727e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768423 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693210}
-
Peter Beverloo authored
Change-Id: Ibd1f7b117e6b466deebad5795548b4a67958ec89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784609 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693209}
-
Craig Hesling authored
The goal of these metrics is simply to gain a high-level understanding of whether the fingerprint firmware updater is succeeding and the boot time impact to the user. The following metrics are introduced: * Overall runtime in milliseconds when an update occurs * Overall runtime in milliseconds when no update occurs * Updater high-level status: Unnecessary, Success, and Failures * Updater reason: All combinations of Mismatched RW, Mismatched RO, and Active Image RO The associated Chrome OS CL is CL:1717436 This CL follows up on metrics added to biod in CL:1175458 Bug: 990518 Change-Id: Ie428454035498b71e1890d663e27d483ea840285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734015Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Craig Hesling <hesling@chromium.org> Cr-Commit-Position: refs/heads/master@{#693208}
-
Francois Doray authored
[PM] Remove PolicyControlledIntervention arg from DocumentCoordinationUnit::SetInterventionPolicy(). There is only one possible value for PolicyControlledIntervention, so the enum argument is not required. This will allow code simplifications in future CLs. Bug: 999594 Change-Id: I47e4844374569fc582b5ba7e613cdb0ab7ed6c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779185 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#693207}
-
chrome://dev-ui-loaderSamuel Huang authored
Visiting the chrome:// URL of a host that's in the DevUI DFM triggers install / load flow through chrome://dev-ui-loader, which then redirects to the original chrome:// URL on completion. Previously the flow suffers from the following: * Bug: The state "installed" should be "ready". * /path?query/fragment of the original URL is discarded. * Redirect to chrome://dev-ui-loader is possible, leading to bizarre redirect chains. This CL fixes the above by replacing "?page=<host>" with "?url=<escaped URL>". This involves escaping the URL in the (C++) URL rendering code and unescaping the URL in the (JS) URL reading code. Invalid "?url=" simply leads to chrome://chrome-urls. Bug: 927131 Change-Id: Ia7c1c7874f76ee6d80b347fc49a73dec50a5c80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783519 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#693206}
-
Roman Aleksandrov authored
Bug: 927331 Change-Id: I10a586393caed0c0dd32aa26f6b81a757e84deb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782816Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#693205}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e1d9ff85e0a..030358ed22a4 git log 2e1d9ff85e0a..030358ed22a4 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 ntfschr@chromium.org Devil: add Q version code constant Created with: gclient setdep -r src/third_party/catapult@030358ed22a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I64fdfa419e921f7329ac4cd02e3a840b63a6aa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693204}
-
Ayu Ishii authored
This change allows this API to be used by same origin iframes in addition to top-level frames. Bug: 989184 Change-Id: I9c402fb4ce3188ebadbc647c9f781a40a8a3b63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762917 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693203}
-
Tom Anderson authored
This is a reland of a752710d Original change's description: > Use shared memory to send images to X server > > When playing back a 1440p 60fps video without hardware acceleration, ~15% of > frames would be dropped. With this change, I'm not getting any dropped frames. > > Background: > The bottleneck is in SoftwareOutputDeviceX11::EndPaint, which (for 4K video) was > taking ~0.06s per frame, which was limiting the output to ~15fps. It was taking > so long because we were sending each frame to the X server over the wire. With > the shared memory approach from the above CL, SoftwareOutputDeviceX11::EndPaint > takes only ~0.00002s. > > Summary of changes: > * Switch usage of XPutImage() to XShmPutImage() when possible. > * Shm segment is recycled across frames. > * Segment has a 1.5x growth policy to give windows room to resize without > having to reallocate for each frame. > * Segment has space for 2 frames. It was experimentally found that bumping > this up to 3 didn't give significant gains. > * X server sends a completion event when XShmPutImage() is finished, so we > cannot recycle the memory until getting this event. > * Event processing happens on the GPU main thread, but processing needs to > happen on the compositor thread, so forwarding the event is necessary. This > is implemented in XShmImagePool. > > BUG=991633 > > Change-Id: Ia7782cb9e21d0a93d3250c118e4ba76025354e40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693737 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691321} R=jorgelo TBR=rjkroege,kbr,kylechar Bug: 991633 Change-Id: Id0533ea8ba4de45ca2242ee979197798a818826d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775500Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#693202}
-
Tomasz Wiszkowski authored
InMemoryImageFetcher invokes callback directly if an image is already in memory. Make sure that icon does not get overwrlitten by the fallback image. Bug: 1000393 Change-Id: I19d85c310b414ba65362b88beb194453fc95e19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782136 Auto-Submit: Ender <ender@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#693201}
-
François Doray authored
This reverts commit fef9e5a5. Reason for revert: Speculative revert for crbug.com/1000686 Original change's description: > Experiment with sending click as PointerEvent > > This CL adds a runtime flag that sends the > click and auxclick events as PointerEvents. > > There are more cases to fix such as context menu > events and click from other paths such as > touch and pointerlock. > > Bug: 989958 > Change-Id: I0e440ceef29e6cad202bc7f07150c7f3b6b35da0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762792 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693152} TBR=dtapuska@chromium.org,mustaq@chromium.org,nzolghadr@chromium.org,eirage@chromium.org Change-Id: Id81618db899ea3dd004d2b5ca882fac31c209e1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989958, 1000686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784839Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693200}
-
Tarun Bansal authored
Add feature to not lower JavaScript priority when DeferAllScript intervention is enabled. Change-Id: I6a2fdc364398c39ae171a1e23b61e2819d4e68b6 Bug: 978490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779167Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693199}
-
Steven Bennetts authored
This also adds a constant to the mojom defining an unset value. Bug: 1000213 Change-Id: Idd3e7239d0142db6b55695ac886f51e562d4e042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783242Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693198}
-
Francois Doray authored
The test times out on Mac DBG bot. TBR=anniesu@google.com,kylixrd@chromium.org Bug: 974349 Change-Id: I816fa2ebbf4a3dabfd78093a737c05c30f1d0a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784837Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693197}
-
Kush Sinha authored
Add a back button in Chrome OS Account Manager's account addition dialog. Please check the attached bug for mocks. Bug: 996829 Change-Id: I20f164754f730a5de443a2af38c7fbbc5d68fb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776033Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#693196}
-
Robert Ma authored
Since https://crrev.com/c/1779543 , `git cl try` now requires the bucket name to always be specified. This change sets "luci.chromium.try" as the default bucket when no bucket is configured in builders.json or passed to `trigger_try_jobs`. Change-Id: I5d12625f49f3a57c852abdcbefe641b1eb17d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783640 Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#693195}
-
Yue Zhang authored
Bug: 999444 Change-Id: I753ea4f5865cb676cd8b34bcd2abc71cc52645c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783061Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693194}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45812a1faa61..c2dc9c864844 git log 45812a1faa61..c2dc9c864844 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 halcanary@google.com experimental/minimal_ios_mtl_skia_app 2019-09-04 fmalita@chromium.org [svgcanvas] Refactor clipping 2019-09-04 halcanary@google.com gn: try again to fix fuchsia 2019-09-04 fmalita@chromium.org [sksg] Fix mask/context overrides interaction Created with: gclient setdep -r src/third_party/skia@c2dc9c864844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I3aefb354e4483fc002a2e414f417ead1d76ca9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693193}
-
Ben Kirchman authored
Create a base class: JavaUploadDataSinkBase extracted from OutputStreamDataSink. The base class defines abstract methods that are called at appropriate times in the base class to be implemented using appropriate output methods. Bug: 669707 Change-Id: Ib38be5bf57d158218aa973f0196d2735b0627cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757314Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#693192}
-
Ivana Zuzic authored
When the visibility icon is clicked, the user needs to reauthenticate and the password unmasks. It becomes if the visibility icon is clicked again. Bug: 377410 Change-Id: I7f7feb17ca5a475c3a5331a715894254c7e51d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781639 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#693191}
-
Evan Stade authored
Also: - fire SessionManagerObserver::OnUserSessionStarted() for secondary users (as was the previous intent), to match NOTIFICATION_SESSION_STARTED. The parameter is_primary_user allows observers to differentiate between user types. TBR=bartfab@chromium.org Bug: 268984 Change-Id: Ia0158fa52910499f4ca6391a2e201dab8cfb1684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779537Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#693190}
-
Ted Choc authored
This reverts commit e82de9ba. Reason for revert: crbug.com/1000677 Original change's description: > Add browser test for TrustableBundledExchangesFile > > Bug: 966753 > Change-Id: If6a23e14c62f5ac1639a7eb9096314c13104f9b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784259 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693091} TBR=horo@chromium.org,ksakamoto@chromium.org Change-Id: Iddbd2794d3bd7d98e76b28c9ac0a7f9b6a62f609 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783644Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#693189}
-
Christian O. Andersson authored
Bug: N/A Test: python depot_tools/watchlists.py weblayer/common/ Change-Id: I4e7e0426d0fcdfb11457fed7216ef2cb4fc65fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784720 Auto-Submit: Christian O. Andersson <cricke@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Christian O. Andersson <cricke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693188}
-
Majid Valipour authored
Extend histogram expiry for Animation Worklet histograms. The feature is expected to launch soon [1] and these histograms will be used to monitor its performance in the wild. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/aRKT0BkrF-8/G-KuTnMBBgAJ Bug: 988713, 988707 Change-Id: I5f81dd8226b7b497d0a80e760a363535e4e4fc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783341Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#693187}
-
Etienne Pierre-doray authored
To avoid having 2 tasks with same queue_time, each PushTask is preceded by a FastForward(). In previous CL 1778925, I put FastForward at the wrong place. This moves it to right before PushTask(). Bug: 998477 Change-Id: Ifb87e46d364b3bc3e4d555f11f09ad3a34ce4b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784627Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#693186}
-
redatawfik authored
-When TableViewTextCell is tapped the background for the cell turned to gray while the background for the textLabel stays white. -Removing the code which sets TableViewTextCell textLabel background solves the problem. Bug: 984545 Change-Id: I615041f21b29e4c93e7d6b98b87d40be02c636e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778043 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#693185}
-