GitLab

unittests

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2334563002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419106}

This icon was incorrectly appearing on the right side of the page,
when it should appear on the left.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342243002
Cr-Commit-Position: refs/heads/master@{#419105}

BUG=643729
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2311473002
Cr-Commit-Position: refs/heads/master@{#419104}

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639

Review-Url: https://codereview.chromium.org/2344473002
Cr-Commit-Position: refs/heads/master@{#419103}

This histogram was added to the source in 2012, but never added to
histograms.xml. So noone ever looked at the data. Remove it.

Also add an obsolete entry to histograms.xml, so noone tries to reuse
the name.

BUG=643551

Review-Url: https://codereview.chromium.org/2345433002
Cr-Commit-Position: refs/heads/master@{#419102}

This property can be replaced with padding at the top of <history-list>,
which simplifies the code and should have a minor performance
improvement.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2333163002
Cr-Commit-Position: refs/heads/master@{#419101}

Revert of Enable whitelisting for targets other than libchrome. (patchset #2 id:90001 of https://codereview.chromium.org/2344063002/ )

Reason for revert:
Still causing GN errors on Google Chrome bots
(Win, Linux, and ChromeOS).

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10926

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:1358:19: Assignment had no effect.
    public_deps = [
                  ^
You set the variable "public_deps" here and it was unused before it went
out of scope.
See //BUILD.gn:211:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1
step returned non-zero exit code: 1

Original issue's description:
> Reland of Enable whitelisting for targets other than libchrome.
>
> Reverted in:
> https://codereview.chromium.org/2348643002/
>
> Reason for revert:
> Fixed gn gen errror
>
> This will allow monochrome to easily define its own set of the same
> targets with a different resource whitelist
>
> TBR=brettw@chromium.org,miu@chromium.org
> BUG=641032
>
> Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece
> Cr-Commit-Position: refs/heads/master@{#419074}

TBR=brettw@chromium.org,miu@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641032

Review-Url: https://codereview.chromium.org/2342243003
Cr-Commit-Position: refs/heads/master@{#419100}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/863250f040be..3d7a0942bcf4

$ git log 863250f04..3d7a0942b --date=short --no-merges --format='%ad %ae %s'
2016-09-15 dtu Fix utils.ServiceAccountHttp().

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2347103002
Cr-Commit-Position: refs/heads/master@{#419099}

Design doc: https://docs.google.com/document/d/14MzxMuUV9e5ZgxbZL3-jCMKa3S-UJGsbYSmRodLh9uc/edit#
PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc

BUG=591606

Review-Url: https://codereview.chromium.org/2344443003
Cr-Commit-Position: refs/heads/master@{#419098}

Additionally parsing 'starred' attribute is necessary in order to implement showing 'starred' icon for Files app.

BUG=646839
TEST=google_apis_unittests --gtest_filter=DriveAPIParserTest.FileListParser

Review-Url: https://codereview.chromium.org/2344113002
Cr-Commit-Position: refs/heads/master@{#419097}

This change adds support for handling pending substitution values to CSS
animations to allow for smooth interpolation between shorthand values
with var() references in them.

BUG=647123

Review-Url: https://codereview.chromium.org/2340893003
Cr-Commit-Position: refs/heads/master@{#419096}

String should be a thin wrapper over StringImpl and other functions.

Review-Url: https://codereview.chromium.org/2337683002
Cr-Commit-Position: refs/heads/master@{#419095}

BUG=647117

Review-Url: https://codereview.chromium.org/2347723002
Cr-Commit-Position: refs/heads/master@{#419094}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/82d4df2ea564..863250f040be

$ git log 82d4df2ea..863250f04 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 nednguyen Fix typo in TimelineBasedMeasurement's comments
2016-09-15 benjhayden Document how to write metrics.
2016-09-15 benjhayden Display zero values in value-set-table

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2341213002
Cr-Commit-Position: refs/heads/master@{#419093}

https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..8b28a8b

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2345763003
Cr-Commit-Position: refs/heads/master@{#419092}

Cr-Commit-Position: refs/heads/master@{#419091}

This prevents the user from seeing the console messages load in as they scroll.

BUG=none

Review-Url: https://codereview.chromium.org/2339293003
Cr-Commit-Position: refs/heads/master@{#419090}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2349533002
Cr-Commit-Position: refs/heads/master@{#419089}

This also fixes the keyboard navigation for network summary items.

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
For trivial comment changes to extensions/common/api
TBR=rdevlin.cronin@chromium.org,

Review-Url: https://codereview.chromium.org/2303093003
Cr-Commit-Position: refs/heads/master@{#419088}

This is a step towards removing global outline-disclosure styles and
improving components isolation.

BUG=none

Review-Url: https://codereview.chromium.org/2347603003
Cr-Commit-Position: refs/heads/master@{#419087}

All narrowPrecisionToFloat does is call clampTo<float>, so lets just
make the callers do that. We use clampTo directly all over so there's no
reason to hide it.

BUG=642096
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2342913003
Cr-Commit-Position: refs/heads/master@{#419086}

BUG=646443

Review-Url: https://codereview.chromium.org/2345583002
Cr-Commit-Position: refs/heads/master@{#419085}

This reduces audio glitches after a stream has skipped (due to
the stream not having enough data).

BUG= internal b/30747742

Review-Url: https://codereview.chromium.org/2344993003
Cr-Commit-Position: refs/heads/master@{#419084}

Currently, the RenderText classes provide access to their private/protected
members for tests using FRIEND_TEST_ALL_PREFIXES. This CL removes the need for
these macros by adding helpers to RenderTextTestApi and the test fixture
classes- RenderTextHarfBuzzTest and RenderTextMacTest.

BUG=none

Review-Url: https://codereview.chromium.org/2346733002
Cr-Commit-Position: refs/heads/master@{#419083}

BUG=633253

Review-Url: https://codereview.chromium.org/2349573002
Cr-Commit-Position: refs/heads/master@{#419082}

R=tsergeant@chromium.org
BUG=638405
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2344893006
Cr-Commit-Position: refs/heads/master@{#419081}

We need more OWNERS... move up some command_buffer OWNERS, and add kbr@

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2348773002
Cr-Commit-Position: refs/heads/master@{#419080}

BUG=646168
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2347063002
Cr-Commit-Position: refs/heads/master@{#419079}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7eb57a183493..82d4df2ea564

$ git log 7eb57a183..82d4df2ea --date=short --no-merges --format='%ad %ae %s'
2016-09-15 benjhayden Rename Composition to RelatedHistogramBreakdown.
2016-09-15 lpy Make runtime call stats table grouping consistent with V8 tools.
2016-09-15 prasadv Modify update_bug_with_results to check bisect job status using buildbucket API.
2016-09-15 benjhayden Move scalar-span#significance emoji after #content.
2016-09-15 ccraik Fix frame end detection
2016-09-15 benjhayden Merge NumericValue into Histogram.
2016-09-15 aiolos Disable testTBM2ForSmoke on mac

BUG=646208

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343043002
Cr-Commit-Position: refs/heads/master@{#419078}

This is a step towards removing SidebarTree and moving all
tree outlines into shadow.

BUG=none

Review-Url: https://codereview.chromium.org/2342193002
Cr-Commit-Position: refs/heads/master@{#419077}

We were previously unable to see the allocation size in the minidump
because it was optimized out. This should keep it around.

BUG=643845
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2349553002
Cr-Commit-Position: refs/heads/master@{#419076}

I had the name of one of the input fields wrong, and I had
an error case not returning output correctly.

R=brettw@chromium.org
BUG=555273

Review-Url: https://codereview.chromium.org/2341683006
Cr-Commit-Position: refs/heads/master@{#419075}

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032

Review-Url: https://codereview.chromium.org/2344063002
Cr-Commit-Position: refs/heads/master@{#419074}

The value of a submit button is appended to a FormData if its activatedSubmit flag
is set.
In a case of form.submit() is called in submit event handler, we did:

1. Set activatedSubmit flag of the submit button
2. Dispatch submit event
2.1. form.submit() builds FormData
3. Build FormData if the submit event was not prevented
4. Clear activatedSubmit flag of the submit button

In step 2.1, we should not include the submit button. So, this CL changes the
process as follows:

1. Dispatch submit event
1.1 form.submit() builds FormData
2. If the submit event was not prevented,
2.1. Set activatedSubmit flag of the submit button
2.2. Build FormData
2.3. Clear activatedSubmit flag of the submit button

Implementation:
We called setActivatedSubmit() before/after prepareForSubmission(). Instead, we
pass a submit button element to prepareForSubmission(), and call
setActivatedSubmit() just before/after building FormData.

BUG=646790

Review-Url: https://codereview.chromium.org/2340213002
Cr-Commit-Position: refs/heads/master@{#419073}

BUG=481588

Review-Url: https://codereview.chromium.org/2280153002
Cr-Commit-Position: refs/heads/master@{#419072}

This CL is a step toward deep linking to site details in the site
settings. This CL adds the c++ handler backend and does show the
exceptions in the UI. The page title is not updated with the subject URL,
but that is not a regression and will be addressed in a future CL.

BUG=635874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338163004
Cr-Commit-Position: refs/heads/master@{#419071}

BUG=646443
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2338333002
Cr-Commit-Position: refs/heads/master@{#419070}

This patch renames createVisiblePosition() (all overloads) to
createVisiblePositionDeprecated() to discourage creating a VisiblePosition
in dirty layout and waiting for layout update lazily. This patch also
introduces new createVisiblePosition() which assumes clean layout.

This patch is a preparation for hoisting the layout update call from the old
createVisiblePosition(). In follow up patches, the callers should ensure
clean layout by themselves and call the new createVisiblePosition() instead.

This patch is a mechanical substitution
's/createVisiblePosition(/createVisiblePositionDeprecated(/g', followed
by the following changes:
- Introduce the new createVisiblePosition() in VisiblePosition.h/cpp.
- Revert the substitution in modules/accessibility/AXLayoutObject.cpp,
  since callers there already ensure clean layout

BUG=647219

Review-Url: https://codereview.chromium.org/2341053002
Cr-Commit-Position: refs/heads/master@{#419069}

These were disabled ~12 months ago for being flaky. 50 runs
through the linux_chromium_rel_ng trybot revealed no flakiness.

BUG=527437

Review-Url: https://codereview.chromium.org/2336903004
Cr-Commit-Position: refs/heads/master@{#419068}

BUG=646323
TESTS=webkit_unit_tests DocumentLoadingRenderingTest.ShouldNotPerformRepeatedLayoutWithPendingImport DocumentLoadingRenderingTest.ShouldClearPlaceholderStyleWhenIgnoringPendingStylesheet

Review-Url: https://codereview.chromium.org/2333263002
Cr-Commit-Position: refs/heads/master@{#419067}