- 14 Jan, 2021 40 commits
-
-
David Black authored
When in tablet mode and in an app, the shelf config changes and the default size for holding space previews is too large. Now, shelf config changes are observed and holding space previews are resized to fit. Resizing previews surfaced a few issues also fixed in this CL: 1. Layers were not being destroyed after shifting outside the viewport. 2. More than 3 previews were visible to the user at a time. Issue 2 resulted in the 4th preview being slightly visible, making it look like paint artifacts of the 3rd preview. Not showing the 4th preview introduced some jank when shifting it in because it would appear out of nowhere before shifting into position. To soften this, added an opacity animation when creating the view. Bug: 1165326 Change-Id: Iae5d00c98b8cb24025d0275c6af49b1a13d48f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628589 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843365}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610560809-8437f20a31feb534d6a6f0fc9839520be075bc3e.profdata to chrome-linux-master-1610582310-441e5d44b17635eb24bffd5edcdc41a0f840e530.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I409d939daa45922b069918cb15f8d301c16451a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626785 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843364}
-
Clark DuVall authored
This should help startup on Monochrome since we can avoid loading splits that will not be used by WebLayer. This will likely have memory benefits in the field. -4.4% weblayer_startup_wall_time: https://pinpoint-dot-chromeperf.appspot.com/job/10843ff4d20000 Bug: 1146438 Change-Id: I1c1dfcda323e9f8c41d05959c580ce050f76bf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843363}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b42c4e7..712b239b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ca4295ce68eff96583d97e65760d25e19929c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628488Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843362}
-
Stefan Zager authored
Change-Id: Ia9e3c44787c081e2495d87f500d429617c7329bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623725 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#843361}
-
Eugene Zemtsov authored
At this point only Opus encoding is supported. Bug: 1094181, 1094179 Change-Id: I05b22bcbd29e96b3823d00dbf85f007936678751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625822Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843360}
-
Mark Schillaci authored
This CL is the seventh part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. ---------- This CL adds the following: - Syncs Regular and Incognito behavior as per new reqs - Corrects unit tests for above - Adds an AXMode observer to watch for screen readers being enabled - Adds TabModelObserver to proactively dismiss dialog on tab close ---------- This CL is expanded upon the original CL here: crrev.com/c/2585587 which was reverted here: crrev.com/c/2589933 Rather than a simple Reland, this CL is the original CL plus improvementss and a bug fix to prevent further issues. AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. Bug: 1057169, 1158342 Change-Id: I92d9dd87081ca9b7efb09be93ca32f9be7050768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596417Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843359}
-
Toni Barzic authored
Adds a way to update holding space icon preview layer without an animation, and utilizes it when the icon previews are first being shown (i.e. when the list of previews is updated from an empty list). In this case, tray icon will have it's own visibility animation, so there's no need for running a separate bounce in animation within the tray icon. Also, updates how tray icon updates are scheduled - instead of updating the tray visibility synchronously, and then scheduling a previews update, the logic is changed to update previews icon synchronously, too. (the throttling became less important now that additions of multiple items to the holding space are done in a batch, instead of one-by-one). BUG=1166014 Change-Id: I3211672072262e9fff75b04a3316c6049099c749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627169 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843358}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: I14ffeabbbfac3321167f735329c0b7b50a2709f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617131 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843357}
-
Xinghui Lu authored
To fully replace the old SBER checkbox with the new enhanced protection message, some tests are removed entirely because the SBER checkbox doesn't exist anymore: SafeBrowsingBlockingPageBrowserTest.VisitWhitePaper SafeBrowsingBlockingPageBrowserTest.ToggleSBEROn SafeBrowsingBlockingPageBrowserTest.ToggleSBEROff Some tests are slightly modified by removing the old extended-reporting-opt-in element: SafeBrowsingBlockingPageBrowserTest. MainFrameBlockedShouldHaveNoDOMDetails SafeBrowsingBlockingPageBrowserTest.ReloadWhileInterstitialShowing SafeBrowsingBlockingPageBrowserTest.VerifyHitReportNotSentOnIncognito For PolicyTest, remove the check of opt-in checkbox in SafeBrowsingExtendedReportingPolicyManaged and add a new test for checking the new enhanced-protection-message message with the kSafeBrowsingProtectionLevel policy. Bug: 1130721 Change-Id: Iaac03d14158d1b207a24b7799ddb8572d22c0d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622057 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843356}
-
Rakina Zata Amni authored
This is a reland of 55f04b52 Original change's description: > Copy attributes of old DocumentLoader on javascript: URL & XSLT commits > > When javascript: URL evaluates into a string, or XSLT document change > happens, we will commit a new document but won't notify the browser of > the change of documents, as no URL/origin change happens, essentially > treating it as just a content update within the previously committed > document. > > However, we actually create a new DocumentLoader and Document for the > commit, and not all attributes of the old document are actually carried > over to the new document. This CL copies most attributes from the > previous document through DocumentLoader::CreateParamsToClone(), to > ensure future navigations within the new document won't result in > confusion in the browser. Some examples of things that are now copied to > the new document: HistoryItem, http_method, http_status_code, > devtools_navigation_token (so XSLT document transformations show up > on devtools), etc. > > Bug: 1151954, 1048106 > Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843047} Bug: 1151954 Bug: 1048106 Change-Id: I045cd84d088999cb903c0899ebc40cb72219ab3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628267 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843355}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77ba8103d34f..af9b58e287b5 2021-01-14 johnstiles@google.com Fix fragment processors and unit tests which mix ints and floats. 2021-01-14 johnstiles@google.com Factor out SPIR-V typecasting helper functions. 2021-01-13 johnstiles@google.com Revert "[svg] Perform colorspace conversions for filter effects" 2021-01-13 brianosman@google.com Support ES2-compliant for loops in SkSL-to-SkVM 2021-01-13 tdenniston@google.com [svg] Perform colorspace conversions for filter effects 2021-01-13 bsalomon@google.com Reland "Push SkYUVAInfo into GrYUVToRGBEffect." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I488f83696ce1b1dffee6083b051e0593aee2e2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628547Reviewed-by:
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/002828690efc..74ae09145aaf $ git log 002828690..74ae09145 --date=short --no-merges --format='%ad %ae %s' 2021-01-12 renjietang Retransmit initial data immediately upon receiving RETRY. 2021-01-12 haoyuewang Internal QUICHE change 2021-01-12 danzh Reset alternative path state after migrating to that path. 2021-01-12 danzh Internal QUICHE change 2021-01-12 fayang Internal QUICHE change 2021-01-12 haoyuewang Remove connection_id added to connection_dispatcher_map_ via either OnConnectionIdRetired or OnConnectionAddedToTimeWaitList in gfe_quic_dispatcher when multiple CIDs are supported. 2021-01-11 quiche-dev Automated g4 rollback of changelist 351231997. 2021-01-11 renjietang Retransmit initial data immediately upon receiving RETRY. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I97d088719240aa28b7cca890136f91fb05bed5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626828Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843353}
-
Prabir Pradhan authored
In ClientControlledShellSurface, when default scale cancellation is disabled, the client will send location values in the display's coordinate space in pixels. The server previously converted the location value into pixels but also expected that it was in the screen coordinates and performed a conversion. The server now assumes the location is already in the display's coordinate when default scale cancellation is disabled, skipping the conversion. BUG=b:177089882 TEST=manual: Try resizing and moving a PIP window on an external display at different scale factors. Change-Id: I10625001d0943c0eaaf1bd6decdb25f714e42b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618910Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#843352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64d94deaa6a4..32f5f4343ba8 2021-01-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8ea6ff6a407d965e7d387e6f8004bc8f9112fe39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628372Reviewed-by:
-
Clark DuVall authored
I wasn't able to repro the flake locally, but this is my best guess at a fix. Bug: 1166286 Change-Id: I2d229d66ea0f16f2c2f959642cdc5baf1598fdef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628016 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#843350}
-
Phillis Tang authored
When in fullscreen mode, In-Product Help for PWA install icon shouldn't been seen because the install icon is not visible. Bug: 1165467 Change-Id: Ia7a680d307b19672afcfad47bb658dc97c7c033e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626028 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#843349}
-
Trevor Perrier authored
This CL adds GetAlwaysTranslateLanguages to TranslateBridge.java and translate_prefs.cc. This will be used by the new language settings page on Android. Some basic tests are added for AlwaysTranslateLanguage related code in translate_prefs.cc. TranslateBridge.java is also cleaned up a little. The biggest cleanup is that the unused function isBlockedLanguage2 is removed from both ends of the bridge. Bug: 1127531 Change-Id: Ia533492b92b7d298f54afcca5b82be033eb6ad71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626910Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Max Curran <curranmax@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#843348}
-
Elaine Chien authored
Bug: 1158427 Change-Id: Ic034139db744d6547439f6235075477e2ccc5933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623838 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843347}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610560809-c13d1dc2d5ece813e7ca3ddf321bf7cfccbb8ffc.profdata to chrome-mac-master-1610582310-1de40dcfb71a8181da946117c9e834cf9a0c7d77.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia7542fd990f4d5abed98abff7966fd131129ee95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626320Reviewed-by:
-
Clark DuVall authored
Chrome, WebView, and CCT all do this, so I think it makes sense for WebLayer to do it as well. Pinpoint run shows time is moved from load to earlier startup (as expected) but this is probably a bigger benefit in the field where renderer processes can take awhile to start. https://pinpoint-dot-chromeperf.appspot.com/job/13506a06d20000 Bug: 1146438 Change-Id: I6f04a04f5b08a21beea9f0295fa9db3ef30c923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628032Reviewed-by:
-
Daniel Hosseinian authored
The function converts the string format described in section 7.9.4 "Dates" of the ISO 32000-1 standard to a base::Time, which will be necessary when localizing dates for display. Bug: 93619 Change-Id: I9c580ca201e6058032778c5d72a1a713478937cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610624 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
-
Alexander Timin authored
Do not delete navigation request which has started upon receiving notification about beforeunload dialog being cancelled, as a) this navigation request is not waiting for beforeunload and b) it might have been this navigation request which canceled this beforeunload dialog. R=alexmos@chromium.org BUG=1161705 Change-Id: I7d385d4326fac6f67d17a003679471806b5ad3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624733 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#843343}
-
Brian Sheedy authored
Adds bsheedy@ and ynovikov@ as owners of //testing/trigger_scripts. Change-Id: I277c8fa0c9be888d56330763f36adefc61aa2153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628493 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843342}
-
James Cook authored
Noticed while I was working on an adjacent CL. Bug: none Change-Id: Id8997601147e24e51e48a7314639a90e4ee865ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625783 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843341}
-
Yue Zhang authored
Bug: 1157892 Change-Id: Ie368637aa8e9d778a80aae248aa7cb05064d285c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625911 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843340}
-
Junji Watanabe authored
run_swarming_xcode_install.py triggers a Swarming task to install Xcode using Isolate server. But Isolate server will be deprecated, soon. I don't see the Xcode install Swarming tasks in BigQuery. (past 1.5 years) http://screen/3SWDKkx69n3U8Hp So should be safe to remove them. Bug: 1163817 Change-Id: Ic52eb284f1209a370f02ebb0383180ab31f555d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626480 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Junji Watanabe <jwata@google.com> Cr-Commit-Position: refs/heads/master@{#843339}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b72695a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I5846180c3bd1e67c6f1128e5533aa6551953e67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628208Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843338}
-
adamta authored
Calls the OmniboxCommand to show the omnibox when tapping the fake omnibox in the refactored NTP. Fixes condition by correctly setting the parent view controller's "isScrolledToTop" property. Bug: 1114792 Change-Id: Iaef7b870c35648ab519380aaa94369e74fc20c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628111 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#843337}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610560659-4ba340836b4bfcb3a336687b253f7e1b1055ef00.profdata to chrome-win32-master-1610571527-a7cc65d6e4dfa3bc4bfeaca916fdc0c69afa5118.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iafa46d084387d0dcb4ae163d96c183655647eaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628320Reviewed-by:
-
Alan Cutter authored
This CL enables parsing and storing the capture_links field in web app manifests while the kWebAppEnableLinkCapturing feature flag is enabled. This CL is implementing the parsing side of this spec: https://github.com/WICG/sw-launch/blob/master/declarative_link_capturing.md#proposal including the following pending pull request to that spec: https://github.com/WICG/sw-launch/pull/26 This CL does not implement the link capturing behaviours, that will come in follow up CLs. Bug: 1163398 Change-Id: I803ad87ea219ebceed35a547695a517020918c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623453Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843335}
-
James Cook authored
The code under test was renamed a while ago. Update the test names to match. Bug: none Test: unit_tests Change-Id: I1a9ccd59b66ea20855edcfc89cf73690e28f98df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625964 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This field will be used for BlockInsecurePrivateNetworkRequests to calculate the frame's SecurityState. Currently this field is not set. So the test sxg-subresource-header-integrity-mismatch.tentative.html fails when BlockInsecurePrivateNetworkRequests is enabled. Bug: 1166050 Change-Id: Icf722e4ea06819daaf3f3c5be91408564871bc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626673Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843333}
-
Esmael El-Moslimany authored
Bug: 1076506 Change-Id: Ifb53f33b23356cc614e2d551007e36bc50b08c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628450 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change hides the help button in the serial port chooser dialog since the help center page it would automatically navigate to is not yet available. Bug: 1085149 Change-Id: I00e2d6523e2a64a28e78675186327afe990fc7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619001 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843331}
-
Anthony Vallee-Dubois authored
Bug: 1166369 Change-Id: I32459ec22d8a4a6bd57d8ae0a17a3850a365fc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625914 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843330}
-
Regan Hsu authored
* Deprecate PhoneHub.InitialConnecting as it is no longer needed, but was not corrected when moving metrics from ash to phonehub * Fix PhoneHub.NotificationOptIn -> PhoneHub.NotificationOptInEvents * Fix PhoneHub.Screen.OnSettingsButtonClicked -> honeHub.Screen.ScreenOnSettingsButtonClicked Note that following metrics currently emit properly on ToT (manually visible from chrome://histograms): PhoneHub.InterstitialScreenEvent.BluetoothOrWifiDisabled PhoneHub.InterstitialScreenEvent.Onboarding.ExistingMultideviceUser PhoneHub.InterstitialScreenEvent.OnboardingDismissPrompt Fixed: 1164584 Bug: 1106937 Change-Id: I977a3e454c9ed0add6e0efc669a45dc6349c5110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625277 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843329}
-
Austin Orion authored
We've received reports from enterprise customers using the browser on a virtual machine that screen sharing (via Teams, Google Meet, etc.) will unexpectedly end. The issue was traced back to the browser receiving a WTS_SESSION_LOCK event, it looked as if the user had locked their screen. In response to this event the browser ends any active screen sharing sessions. The issue is that those lock events were coming from other VMs hosted on the same server. We are not interested in the events caused by other sessions, so we should only register for changes to the current session. The affected customer has verified that this fix has resolved the issue. content::VideoCaptureManager is the only class that observes these events, so there should be no other side effects to this change. Bug: 1163572 Change-Id: Icfa5629eb17298f7150dedfd650b77cb34887cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598389 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#843328}
-
Caitlin Fischer authored
Bug: 1144792 Change-Id: I9563b56493a68dc6f7598c2b08248612575f552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623195Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843327}
-
Christoph Schwering authored
The experiment is not active. Bug: 1007974, 949783 Change-Id: I0ccebe9f54ae927bab0d7a0ca6c53d1e7467bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623287Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#843326}
-
