GitLab

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9488f450ac9e1b5cf503cd1bb76a964dab60fc57 Add WebView Ui Test to chromium.fyi (yolandyan@chromium.org)
  https://crrev.com/3a8bfe4caf559c1126a5761154c778dd7ff887de Support xctests (smut@google.com)
  https://crrev.com/fc06b185bc76c25108800aa40525268d42da6deb Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/284d0f102f55bf7c629a297d89c04b8fde110020 Disable galaxy and new mac perf bots for SOM (martiniss@chromium.org)
  https://crrev.com/b9e5951f09ad926b5cb8e0563c5c56b3f4e678e6 Revert "Support xctests" (smut@google.com)
  https://crrev.com/997541305c3617899e17a76fe9c0e5d9a517bdd0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/1fdfcb63166412adae9361acf85705c5290523c6 Refactoring: Extract helper functions from CMDtry in git_cl.py. (qyearsley@chromium.org)
  https://crrev.com/037edb823f045ca3e6a13217efd0fcbdcfb2a384 Remove SVN support from apply_issue (agable@chromium.org)
  https://crrev.com/83faed04862b6c6b7b2034bb256687afeb9d31c0 Remove unnecessary rev_str variable from gclient_scm (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2447913002
Cr-Commit-Position: refs/heads/master@{#427179}

In Ash, there is logic to close menus then asynchronisly perform an accelerator command. However, the accelerator that opens the context menu itself can and does trigger the close path depending on how a person executes the command.

On Chrome OS, the shortcut to open a context menu is Search+Shift+Volume Up. Any of these keys should leave the menu as is otherwise, the context menu is effectively a no-op when triggered from the keyboard.

TEST=on device, hit search; verify apps list opens. Press Search+Shift+Volume up; verify context menu opens. Press Search+m with ChromeVox on, verify context menu opens.
BUG=621331,616130

Review-Url: https://codereview.chromium.org/2434483003
Cr-Commit-Position: refs/heads/master@{#427178}

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)

Review-Url: https://codereview.chromium.org/2436283002
Cr-Commit-Position: refs/heads/master@{#427177}

Renamed method to reflect what it does, instead of how it's implemented.

BUG=None

Review-Url: https://codereview.chromium.org/2433233005
Cr-Commit-Position: refs/heads/master@{#427176}

Now enable/disable are propagated to browser-side ServiceWorkerRegistration
and the promises are resolved renderer-side. But it doesn't yet
* write to disk
* propagate to ServiceWorkerVersion
* implement NavigationPreloadManager.getState

Tests will be added when getState is implemented.

BUG=649558

Review-Url: https://codereview.chromium.org/2433273003
Cr-Commit-Position: refs/heads/master@{#427175}

BUG=504347

Review-Url: https://codereview.chromium.org/2449533002
Cr-Commit-Position: refs/heads/master@{#427174}

Changes BroadcastChannel::close() to be a no-op if Platform::current()
is null. This can happen because MessageLoop destruction may invoke
this function indirectly, after Blink has been shut down.

TBRing since this precise change was recommended by haraken@ and I'd
like to make sure the fix lands ASAP.

BUG=658726
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2444103002
Cr-Commit-Position: refs/heads/master@{#427173}

When linearly navigating through nodes in the accessibility tree, don't treat
a leaf node with text as interesting if the text is only whitespace.
Also fix an issue where requesting the first "interesting" node
from the root of the tree could sometimes return the root itself, leading to
a cycle.

BUG=656779

Review-Url: https://codereview.chromium.org/2427813002
Cr-Commit-Position: refs/heads/master@{#427172}

Default to always pausing tiny content. Removing fieldtrial config as
well, since it's redundant.

BUG=608886

Review-Url: https://codereview.chromium.org/2434333002
Cr-Commit-Position: refs/heads/master@{#427171}

BUG=555865

Review-Url: https://codereview.chromium.org/2443753003
Cr-Commit-Position: refs/heads/master@{#427170}

https://chromium.googlesource.com/chromium/src/+/e0679d945

BUG=651511
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2448683002 .

Cr-Commit-Position: refs/heads/master@{#427169}

Revert of Remove CFI blacklists entries for the fixed bug. (patchset #1 id:1 of https://codereview.chromium.org/2445033002/ )

Reason for revert:
Broke 'CFI Linux Full' bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/657/steps/blink_heap_unittests/logs/HeapTest.VectorDestructorsWithVtable

Original issue's description:
> Remove CFI blacklists entries for the fixed bug.
>
> BUG=568891
>
> Committed: https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588
> Cr-Commit-Position: refs/heads/master@{#427126}

TBR=pcc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=568891

Review-Url: https://codereview.chromium.org/2446803004
Cr-Commit-Position: refs/heads/master@{#427168}

Record opening downloads in CCT and fix histogram for download counts.

BUG=657542, 657539

Review-Url: https://codereview.chromium.org/2443623002
Cr-Commit-Position: refs/heads/master@{#427167}

Move remaining ui/chromeos/network code to to
ash/common/system/chromeos/network

This includes moving the associated resources to src/ash.

It also eliminates material_design_icon_controller.cc.

BUG=657127

Review-Url: https://codereview.chromium.org/2435903002
Cr-Commit-Position: refs/heads/master@{#427166}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/88592741eef1..39f0ff99d0cc

$ git log 88592741e..39f0ff99d --date=short --no-merges --format='%ad %ae %s'
2016-10-13 hungte cbuildbot: Stop calling make_factory_toolkit.
2016-10-23 akeshet completion_stages: turn a debug log into info
2016-10-17 davidriley cbuildbot: Update constants.py
2016-10-21 davidriley cbuildbot: Do not invoke UploadTestArtifacts with --nobuild or --notests.
2016-10-22 dgarrett Revert "cbuildbot: tie the cache for chrome src per branch"
2016-10-19 achuith cros_vm: Don't use sudo for --disable-kvm.
2016-10-09 akeshet venv: use it for summarize_build_stats
2016-10-21 akeshet completion_stages: debug logging about submitted change metrics
2016-10-19 hungte cbuildbot: Optimize factory branch build time and space.
2016-10-13 yueherngl cbuildbot: tie the cache for chrome src per branch
2016-10-18 sbasi Revert "chromeos_config: temporarily mark guado_moblab-paladin experimental"
2016-10-19 xixuan auto-updater: modify the logic of matching build version.
2016-10-20 nxia Set right dryrun mode in CleanUpStage.CancelObsoleteSlaveBuilds
2016-10-12 cmtice [cbuildbot] update llvm-toolchain config to use bvt-pool.
2016-10-20 akeshet export_to_gcloud: limit batch size to 500
2016-10-19 ayatane [sysmon] Skip virtual network interfaces
2016-10-13 nxia Add scheduled_slaves to metadata in the master build.
2016-10-14 nxia Fix and refactor SearchAllBuilds in Buildbucket_lib.
2016-10-19 dshi gs should retry on SSL handshake timeout
2016-10-17 nxia gs should retry on SSL read-operation-timed-out error.
2016-10-18 akeshet topology: add datastore creds path key
2016-10-18 chrome-bot Update config settings by config-updater.
2016-10-18 hshi chromite: remove nyan_freon board
2016-10-18 chrome-bot Update config settings by config-updater.
2016-10-07 nxia Refactor buildbucket_lib
2016-10-14 aaboagye gs: Add a new SSL error to RetryFilter.
2016-10-12 semenzato chromite: log retries of debug symbol file uploads
2016-09-26 norvez chromeos_config: Enable cyan VM tests, AU tests disabled
2016-09-29 dgarrett chromeos_config: Explicitly assign to trybot waterfall.
2016-10-11 dgarrett binhost_test: Ignore WATERFALL_TRYBOT only boards.
2016-10-13 dgarrett upload_symbols: Report total upload retry attempts.
2016-10-13 dgarrett retry_stats: Expose raw stats numbers.
2016-10-17 stevenjb Revert "deploy_chrome: Remove special handling for mash"
2016-10-13 vapier gs: handle failed compile of crcmod
2016-10-05 pprabhu cbuildbot: Mark skipped and repeated stages clearly.
2016-10-11 agable Remove --transitive flag from gclient invocation
2016-10-12 aaboagye gslib: ignore_no_match ignores NotFoundExceptions.
2016-10-06 sadrul deploy_chrome: Remove special handling for mash
2016-10-11 akeshet venv: use the contents of requirements.txt rather than timestamp
2016-10-04 akeshet lib: move a bunch of libraries to lib/
2016-10-13 nxia Disable cancelling builds via Buildbucket in CleanUp stage.
2016-10-04 nxia Cancel obsolete paladin slave builds.
2016-10-11 achuith cros_vm: Support for --disable-kvm
2016-10-13 cmtice [toolchain waterfall] Make the amd64 gcc builder use 'peppy'.

BUG=

Review-Url: https://codereview.chromium.org/2445813002
Cr-Commit-Position: refs/heads/master@{#427165}

Review-Url: https://codereview.chromium.org/2445073002
Cr-Commit-Position: refs/heads/master@{#427164}

Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay (patchset #1 id:20001 of https://codereview.chromium.org/2379673002/ )

Reason for revert:
http://crbug.com/653330 This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add the shortcut to toggle high contrast mode to the keyboard overlay
>
> Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing
>
> BUG=644758
> TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4
> Cr-Commit-Position: refs/heads/master@{#421587}

TBR=xiyuan@chromium.org,afakhry@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644758

Review-Url: https://codereview.chromium.org/2443303002
Cr-Commit-Position: refs/heads/master@{#427163}

BUG=316738
TEST=tested on device

Review-Url: https://codereview.chromium.org/2442033002
Cr-Commit-Position: refs/heads/master@{#427162}

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2432043007
Cr-Commit-Position: refs/heads/master@{#427161}

Under mash code in chrome cannot directly access the ash aura window hierarchy.
Instead it must pass an ash window container id when a new window is being
opened.

Create a new NetworkConfigView::ShowForType to allow passing a container id.

Also clean up some unnecessary code around static initializers.

BUG=657021
TEST=open "join other" from system tray menu at login screen and after login

Review-Url: https://codereview.chromium.org/2445843002
Cr-Commit-Position: refs/heads/master@{#427160}

WindowServerTestBase already implements the WindowManagerDelegate
interface to be a WM client. Instead of connecting to service:ui as a WM
client, it connects using mojom::WindowTreeHost. This interface is only
used in tests and doesn't exercise the real display codepath in
service:ui.

Change WindowServerTestBase to connect WM client. The first response
that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so
move call QuitRunLoop() to OnWmNewDisplay() as well.

BUG=none

Review-Url: https://codereview.chromium.org/2438193003
Cr-Commit-Position: refs/heads/master@{#427159}

TBR=dgozman
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2440953003
Cr-Commit-Position: refs/heads/master@{#427158}

Cr-Commit-Position: refs/heads/master@{#427157}

Update the commit/update counters for USS

BUG=328606

Review-Url: https://codereview.chromium.org/2420213002
Cr-Commit-Position: refs/heads/master@{#427156}

https://chromium.googlesource.com/skia.git/+log/19b91531e912..3d3a65c48816

$ git log 19b91531e..3d3a65c48 --date=short --no-merges --format='%ad %ae %s'
2016-10-24 scroggo Rename GIFImageReader to SkGifImageReader
2016-10-24 bungeman Add gif sources to public.bzl.
2016-10-24 kjlubick Fix fuzzer's bools to be 0 or 1 only
2016-10-24 msarett Use SK_ALWAYS_INLINE in SkColorSpaceXform
2016-10-24 scroggo Clear background to white in animatedGif GM
2016-10-24 scroggo Include "SkBitmap.h" in CodecAnimTest.cpp
2016-10-24 raftias Refactored SkColorSpace_A2B to allow arbitrary ordering of elements
2016-10-24 mtklein Print what crashed DM on Android too.
2016-10-24 bungeman SkShader* refAs... to sk_sp<SkShader> makeAs...
2016-10-24 benjaminwagner Update trooper doc with chrome-infra chat.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2444923004
Cr-Commit-Position: refs/heads/master@{#427155}

* Includes fixes from recent github commits.
* Chromium fixes for load-balancing and Android build.

BUG=

Review-Url: https://codereview.chromium.org/2443773002
Cr-Commit-Position: refs/heads/master@{#427154}

This CL implements convertToBlob on OffscreenCanvas for both
worker and main threads.

The OffscreenCanvasRenderingContext2D cases are complete.
For the Webgl rendering context, currently convertToBlob()
can only work for PNG image type.

BUG=563830
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2420203002
Cr-Commit-Position: refs/heads/master@{#427153}

User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown.

BUG= 655221, 654300, 655308
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2427073002
Cr-Commit-Position: refs/heads/master@{#427152}

This adds trace entries for loading imports and for blocking on an
import for longer than 20ms. These make gn's tracelog significantly
easier to understand when imported files take a long time to process.
For example, in the Chrome build on Mac //build/toolchain/mac/BUILD.gn
blocks for ~240ms running sdk_info.py because
//build/config/mac/mac_sdk.gni runs that script and //ui/base/BUILD.gn
blocks for ~350ms because it is waiting for the import lock on
mac_sdk.gni to be released. Without these traces, it is not
immediately obvious why //build/toolchain/mac/BUILD.gn is running that
script and it is very unclear why //ui/base/BUILD.gn takes so long.

Review-Url: https://codereview.chromium.org/2424233002
Cr-Commit-Position: refs/heads/master@{#427151}

Also remove an extra 'explicit' qualifier in arc/.

BUG=None
TEST=try

Review-Url: https://codereview.chromium.org/2447773003
Cr-Commit-Position: refs/heads/master@{#427150}

Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2442963002/ )

Reason for revert:
Looks like the tests use --force-gpu-rasterization, which overrides the blacklist. I think we still need this suppression.

See:
https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/2567
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28ATI%29/builds/6394

Original issue's description:
> Remove GpuRasterization.BlueBox suppression for Win/AMD.
>
> GPU rasterization has been disabled on this configuration.
>
> BUG=653538
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=zmo@chromium.org
>
> Committed: https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df
> Cr-Commit-Position: refs/heads/master@{#426972}

TBR=zmo@chromium.org,kbr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=653538

Review-Url: https://codereview.chromium.org/2443283002
Cr-Commit-Position: refs/heads/master@{#427149}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e64d0caf..1f4fc5c8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2445743002
Cr-Commit-Position: refs/heads/master@{#427148}

Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests.
FakeDisplaySnapshot has builder that makes it more readable. Delete an
unncessary build target along with TestDisplaySnapshot.

Tests should be unchanged for the most part. One test was split into two
tests where two very different behaviours were being checked.

Also update tests to use C++11 features where possible. Mostly replacing
raw pointers with unique_ptr<> and NULL with nullptr.

BUG=none

Review-Url: https://codereview.chromium.org/2407153008
Cr-Commit-Position: refs/heads/master@{#427147}

AutoscrollForSelection is triggered when selecting text and dragging mouse out
of the container. However, we don't want selecting text in a fixed-position
element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find
the object is inside a fixed-position element, we should prevent
AutoscrollForSelection from happening.

BUG=655489

Review-Url: https://codereview.chromium.org/2441683002
Cr-Commit-Position: refs/heads/master@{#427146}

Adding rootlayerscrolls-specific test expectations for these test cases

virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-parents.html
virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll-self.html
virtual/rootlayerscrolls/css3/filters/blur-filter-page-scroll.html

BUG=651793

Review-Url: https://codereview.chromium.org/2412013003
Cr-Commit-Position: refs/heads/master@{#427145}

The previous fix depended on ensuring we add hooks to all the code paths that cause the first active WebContents to get added to the tab strip. We're still missing some code paths. So instead restore the old behavior. Even though it did miss navigation starts, fix that by using the time from NavigationHandle for PlzNavigate.

This should restore the metrics for non-PlzNavigate case.
For PlzNavigate, the start timings were already different regardless from non-PlzNavigate because of how navigations are structured very differently. This change shouldn't affects things too much for PlzNavigate though, because the only difference should be the IPC time from the renderer to the browser thread.

BUG=650349

Review-Url: https://codereview.chromium.org/2448553002
Cr-Commit-Position: refs/heads/master@{#427144}

On Macbook Air 2013, letting this be default results in a keyframe every ~5
seconds. This is too often for some applications. This CL changes this limit
so that max keyframe interval is 4 minutes.

BUG=658429
TEST=AppRTC loopback on Mac.

Review-Url: https://codereview.chromium.org/2431223011
Cr-Commit-Position: refs/heads/master@{#427143}

* Moved files video_capture*.* from media/base to media/capture
* Split out video capture related part from media/base/ipc/media_param_traits* into new files media/capture/ipc/capture_param_traits*.
* Added include for newly created file to content/common/view_messages.h

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.7.2pre.

This is in preparation for CL1.7.2, see [2].

BUG=584797
TEST=media_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://codereview.chromium.org/2405423002/

Review-Url: https://codereview.chromium.org/2415703002
Cr-Commit-Position: refs/heads/master@{#427142}

Design doc:
https://docs.google.com/document/d/1691W7yFDI1FJv69N2MEtaSzpnqO2EqkgGD3T0O-pQ08/edit?usp=sharing

This CL introduces support for issuing a range request for just the
first few bytes of an image, and showing a translucent gray box of the
same size as the image in the image's place if the original image's
dimensions can be decoded from the returned range.

Currently, this behavior is only activated via a blink-settings flag. In
the future, features such as Data Saver will activate this functionality
to save data for users.

BUG=605350,605351

Review-Url: https://codereview.chromium.org/2423683002
Cr-Commit-Position: refs/heads/master@{#427141}

before: https://screenshot.googleplex.com/KjwA5O8fX2D.png
after: https://screenshot.googleplex.com/eRH0ibx9yKe.png

BUG=651121

Review-Url: https://codereview.chromium.org/2431553003
Cr-Commit-Position: refs/heads/master@{#427140}