GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8cd0986e..994a66b3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1ed0919cfcaecf57754c7ef58ef4b4b100350225
Reviewed-on: https://chromium-review.googlesource.com/1069029Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560689}

There is some gap at the beginning of
WebViewChromiumFactoryProvider#initialize().

Also, the title 'loadPlatSupportLibrary' is somewhat misleading, so
splitting it up and renaming/refactoring them.

Finally, adding some comment about startup investigation.

Bug: 817644
Change-Id: Id0fa91a46f81c4a4bd43e9dbd8ecbcb70a658608
Reviewed-on: https://chromium-review.googlesource.com/1069248Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560688}

BUG=792308

Change-Id: Iac85f6f2cf2db684b8cddb7926d4a032e154ee41
Reviewed-on: https://chromium-review.googlesource.com/1056472Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560687}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4945d9fec94da964eb19191868d0ea94a5b857ed
Reviewed-on: https://chromium-review.googlesource.com/1067600Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560686}

The EventHandler used to forward events to the right client maintains
state that needs to be reset in certain cases, as otherwise it won't
properly clean up the state. In particular if capture or visibility
changes then EventHandler no longer gets the events.

BUG=837692
TEST=covered by test

Change-Id: I560960ea93462f68c2e252dbd1b5dc9c581ff886
Reviewed-on: https://chromium-review.googlesource.com/1067883
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560685}

Bug: 773295
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I556353286e4ec97544aa9e51d77e102bf78d59ae
Reviewed-on: https://chromium-review.googlesource.com/1054478
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560684}

This cl renames the stub LogoView class to StubLogoView in order to add
the real LogoView class.

Bug: b/79999539
Test: manual.
Change-Id: Ie606143eb73e20f4c44e67f43b5cd132a055f39b
Reviewed-on: https://chromium-review.googlesource.com/1067879Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560683}

The test consistently times out since ToTMacASan build 1089 and
needs investigation.

Bug: 844402
Change-Id: I30c6348f888b5c466fe693831530ec37cdee953c
Reviewed-on: https://chromium-review.googlesource.com/1069122Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560682}

This change:
1) Moves the logic for showing accelerator text into MenuConfig
2) Adds a MenuConfig variable for whether to show accelerator text in
   context menus

Bug: 843703
Change-Id: Iedcef2ba4cdfc2a5390ddc0c9889af339625938d
Reviewed-on: https://chromium-review.googlesource.com/1069035
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560681}

Add a private NSView method, setParentUILayer. Any NSView that can be
drawn using a ui::Compositor (e.g, the WebContentsView) may implement
this method to be informed of the parent ui::Layer that it may draw to
(instead of drawing into its NSView's CALayers).

Prior to this change, BrowserCompositorMac will always allocate its
own ui::Compositor (via RecyclableCompositorMac) for drawing. With
this change, the -[NSView setParentUILayer] method propagates to the
BrowserCompositorMac to allow the BrowserCompositorMac to use the
parent ui::Layer's ui::Compositor.

Add this as a new entry in BrowserCompositorMac::State, and add the
ability to transition between this state and all other states.

Of note is that the previous states are still necessary for two use
cases.
  * When a tab is background but is doing tab capture, the current
    implementation requires that a ui::Compositor be available to
    draw the content for capture. Allow allocating for this use case.
  * Popup windows (e.g, date and time picker) are not embedded in a
    distinct ui::Compositor (they don't even have a parent
    WebContentsViewCocoa), so they must display through their own
    allocated ui::Compositor. Use the existing mechanism in this
    case.

Bug: 840173
Change-Id: I68bbf5da8419c7b1b3ad0edd99faec05bbdc5473
Reviewed-on: https://chromium-review.googlesource.com/1063119
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560680}

This will allow us to evaluate the performance of lifecycles,
determine how often and to which sites they occur, and allow analysis
of the reasons for which they fail most often

BUG=753486

Change-Id: I64884a3314f2170c5e14e5c13dd5a95e5d258a3e
Reviewed-on: https://chromium-review.googlesource.com/1062491
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560679}

This is a follow up of https://crrev.com/c/1043285, which completed the rest of
the migration from 'fetcher' to 'loader' terminology in
c/b/search/one_google_bar.

Bug: 773295
Change-Id: I77b875ffc64f7ce16ea4dfb265bbd73cd92cea0c
Reviewed-on: https://chromium-review.googlesource.com/1068023
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560678}

Controlled by existing origin trial.

Bug: 845187
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I43e4e0d9f303086b50e9dd57ae547bfdcd79f204
Reviewed-on: https://chromium-review.googlesource.com/1065918
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560677}

Set use_lld = false in nacl toolchains and reland "Let lld emit colored diagnostics when invoked from ninja."

This reverts commit 18da5f23.

Reason for revert: The original commit broke the CFI bot with errors like:

  src/native_client/toolchain/linux_x86/pnacl_newlib/bin/../x86_64-nacl/bin/ld:
      unrecognized option '--color-diagnostics'

I do not know why this only happened on the CFI bot (XXX), but since we only add
-fuse-ld=lld if !is_nacl, we should set use_lld to false in the nacl toolchains,
which fixes this, and probably many future issues like it.

Original change's description:
> Revert "Let lld emit colored diagnostics when invoked from ninja."
>
> This reverts commit 00db3ddc.
>
> Reason for revert: Breaks Linux CFI build here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8024
>
> Original change's description:
> > Let lld emit colored diagnostics when invoked from ninja.
> >
> > Bug: 841221
> > Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
> > Reviewed-on: https://chromium-review.googlesource.com/1067460
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560343}
>
> TBR=thakis@chromium.org,rnk@chromium.org
>
> Change-Id: I3811083daa622dca605ca32be5cc4c7098b60b4a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 841221
> Reviewed-on: https://chromium-review.googlesource.com/1067949
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560345}

TBR=thakis@chromium.org,rnk@chromium.org,tommycli@chromium.org

Change-Id: I5d4c9298e3613ab84650f081a59715880d780805
Bug: 841221
Reviewed-on: https://chromium-review.googlesource.com/1068218
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560676}

Change descriptions of PasswordProtectionLoginURLs and
PasswordProtectionChangePasswordURL policies to remove the GSuite
restriction. These two policy settings can be used by Non-GSuite
enterprise users too.

Also push the password protection related settings to M69.

Bug: 845038
Change-Id: I423e24790bda568ac3006b3bb9948a4d12ac271e
Reviewed-on: https://chromium-review.googlesource.com/1067000Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560675}

Log info when the error cases are hit to make it easier to debug
synchronization issues.

BUG=825906

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5c783a68116ca227e1f2b45329f495d07277fb2e
Reviewed-on: https://chromium-review.googlesource.com/1066176Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560674}

https://pdfium.googlesource.com/pdfium.git/+log/b9d556e42823..366df7fd6e6b

$ git log b9d556e42..366df7fd6 --date=short --no-merges --format='%ad %ae %s'
2018-05-22 vmiklos Add FPDFPageObj_GetStrokeWidth() API
2018-05-22 thestig Remove useless CPWL_ListBox::KillFocus().
2018-05-22 hnakashima Fix spaces too wide in XFA Dropdown.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ieeb84784dea15f31e34305f1cafa19393749529d
Reviewed-on: https://chromium-review.googlesource.com/1069111
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560673}

This CL presents Download Manager from _browserContainerViewController,
which means that UI shows up between Web Content and Secondary Toolbar
on z-axe. This is only done if UI Refresh flag is enabled.

Also extended Download Manager coordinator and view controller to support
bottomMarginHeightAnchor property. This property allows adding bottom
margin to download manager UI in order to present Download Manager
UI above Secondary Toolbar on y-axe.

Bug: 818264
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I373ecb6e9892bdc20ba720742d653471ff0a9bad
Reviewed-on: https://chromium-review.googlesource.com/1024641Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560672}

SameDocumentNavigation name better reflects the the type of the
navigation (navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug: 695189
Change-Id: Ifcebdb8e7089cb29a3ecda5413ff882dc8b34082
Reviewed-on: https://chromium-review.googlesource.com/1067893Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560671}

R=thestig
BUG=None

Change-Id: I70ef781f1b4bb6b9f625338942af6c91ee098efe
Reviewed-on: https://chromium-review.googlesource.com/1067760Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560670}

Calling -setEditing:NO on Tab's view has the same effect as calling
-setEditing:NO on WKWebView (keyboard is dismissed). Also inlined
-dismissKeyboard call on CRWNativeContent.

Bug: 620489
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2f77cbf168907ce2ad45300b16469f71b398bbfd
Reviewed-on: https://chromium-review.googlesource.com/1068257Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560669}

Change-Id: I192a4c80c074f0fbb1b34775b2ec6eefa60b46c0
Reviewed-on: https://chromium-review.googlesource.com/1017869Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560668}

Change-Id: I8b254651d85ad27b3b12c78f81a3ee5a493aab6b
Reviewed-on: https://chromium-review.googlesource.com/1060241Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560667}

It really has little to do with SyncService. This allows clients to
only include the thing they need, rather than the whole sync_service.h.

TBRing trivial call site changes.
TBR=sebsg,bcwhite

Bug: none
Change-Id: Icaa165425f50c748904b6f4d4818b552185c4fe5
Reviewed-on: https://chromium-review.googlesource.com/1065820
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560666}

Continue to use old-school layout logic in tab strip.

Bug: 843249
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I475fda4628f6daa68fc030c93151876e42db1531
Reviewed-on: https://chromium-review.googlesource.com/1063148Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560665}

The root-cause was in viz::GLRendererCopier, where the scaler was not
being configured to Y-flip its output when the source texture was not
Y-flipped. The reason this is required is because the next stage of the
copier pipeline assumes all of its textures to already be Y-flipped.

TEST=On all of Win/CrOS/Linux, run src/chrome/common/extensions/docs/examples/api/desktopCapture example, choosing a browser window.

Bug: 845349
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I18b6f1e0c012bd9e87814881f7bfde85305e250b
Reviewed-on: https://chromium-review.googlesource.com/1068614
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560664}

Currently, when the user selects a partial path from an elided URL, we
leave out the elided portion.

For instance, when the user drag selects:
google.com/maps
^^^^^^^^^^

After unelision, the selection becomes:
https://www.google.com/maps
            ^^^^^^^^^^

The user's intent here is to copy the whole first portion of the URL,
so dropping the scheme and subdomain here is undesirable.

This CL makes a guess when the user does a drag select on the whole
first portion of the elided URL that the user wishes to copy the
first portion of the unelided URL as well.

It only applies this logic when the selected text looks like a URL,
according to the OmniboxEditModel::IsPasteAndSearch logic, which we are
renaming to OmniboxEditModel::ClassifiesAsSearch.

TBR=ellyjones@chromium.org

Bug: 843675, 797354
Change-Id: I0ca9aed0fd9886b0442eb5a1e880b13601d82101
Reviewed-on: https://chromium-review.googlesource.com/1068120
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560663}

This CL adds the SessionMonitor that collects WiFi status reported by
receiver, extra tags, and Cast Streaming raw events/stats for an active
mirroring session. The data is assembled and re-packaged as requested
to be included in user feedback report uploads.

Bug: 734672
Change-Id: If3644cb345c3cbe8c1cfbd5474432667f426944a
Reviewed-on: https://chromium-review.googlesource.com/1055789Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560662}

This feature has been launched for several releases.
Also do a small amount of related cleanup due to launch of RLS.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I568cf6d5aaefc5a1200dade5e4b9329cd19195ca
Reviewed-on: https://chromium-review.googlesource.com/1068519Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560661}

This CL adds two static ExtractClientData() functions: one on
PendingConnectionRequest and one on ConnectionAttempt. These functions
extract the feature and ConnectionDelegate passed to the top-level
SecureChannel API functions.

These functions are meant to be called after a successful connection
occurs when the SecureChannel service needs to transfer this data to a
MultiplexedChannel. These functions are static and accept unique_ptr<>s
as parameters to ensure that the associated objects are *not* used
after the extraction is complete, since using these objects after the
extraction occurs would cause undefined behavior.

Bug: 824568, 752273
Change-Id: I6515b11622cf6e807b36feb9e413cdd3cf0f25d4
Reviewed-on: https://chromium-review.googlesource.com/1066970
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560660}

Launches KSV as a mojo app with switch --keyboard-shortcut-viewer-app
(otherwise, use the existing flow via chrome including the library)
Allows development and bug fixing as we bring up the window service.

Add a manifest + mojom, implement Service, register in chrome + utility.
(mostly following the example of the touch_hud application)
Add a switch to run the app, make the app wait for input device listing.

TODO: Fix various bugs before running KSV as an app by default.

Bug: 841020
Change-Id: I13b4f69a049312d87730f686dee26182c3664b13
Reviewed-on: https://chromium-review.googlesource.com/1060163Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560659}

PPP_Printing_Dev_0_6 uses struct PP_PrintSettings_Dev in its Begin
method. r554188 changed the struct to add a new field, and another
pending CL wants to add one more field. These changes may not be safe
because Flash also uses PPP_Printing_Dev_0_6.

To resolve this issue, revert the PP_PrintSettings_Dev changes. In its
place, add a separate struct PP_PdfPrintSettings_Dev, and a separate
PrintBegin method to PPP_Pdf_1_1. When printing, if PPP_Pdf is
available, use its PrintBegin method. Otherwise, use PPP_Printing_Dev's
Begin method.

BUG=775999,835654

Change-Id: Ia489668c301e28eb943270fd1d7e268ede6300c5
Reviewed-on: https://chromium-review.googlesource.com/1065015Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560658}

Bug: 839195
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I20514f612345a16629e5a1370277885b6b2e3ad3
Reviewed-on: https://chromium-review.googlesource.com/1066610Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560657}

This should have been fixed by https://crrev.com/c/1036230. The source
of the memory being leaked (creating the old IPC messages) was removed
by mojoification.

Bug: 838420
Change-Id: I115e390cbd458ee71c7eb679bc2f84fb2ee1d823
Reviewed-on: https://chromium-review.googlesource.com/1069120Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560656}

NewPasswordFormManager::DoesManage matches FormData by their
unique_renderer_id. This ID is unique within one renderer process.

If two frames are hosted by different processes, and each has a form,
those forms can end up with the same ID but still unrelated. The
DoesManage method would not distinguish them alone, leading to not
creating a form manager for the second form.

Therefore, this CL adds a check against a driver in addition to the
ID.

Bug: 831123
Change-Id: I93502d6cfaf0daa58071046e05e8e93b6c6dacbb
Reviewed-on: https://chromium-review.googlesource.com/1069074
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560655}

This way we can reuse the same bindings out of browser process.

Change-Id: I00647371692b665f39120c69a77a9819972309b4
Reviewed-on: https://chromium-review.googlesource.com/1068524
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560654}

My previous change https://chromium-review.googlesource.com/1029733 has
caused several regression on mobile devices. This is because the
|content_background_color| is updated with each new compositor frame in
SubmitCompositorFrame, I forget to check if the newly received
|content_background_color| is same as the existing background color of
the view.

Bug: 843166, 843167, 843168, 843169, 843170


Change-Id: I98a3b8e3bc9f6191871f56e3c1bc7750c119ca7c
Reviewed-on: https://chromium-review.googlesource.com/1067147Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560653}

This CL fixes the issue with accelerated images color conversion by
converting accelerated images to software images. It also moves
color managed canvas layout tests to fast/canvas.

Bug: 695964, 844145
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I115cb30260bffdc6201894089f134cbcfe24bdf6
Reviewed-on: https://chromium-review.googlesource.com/1064566Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560652}

This reverts commit 1d0b7474.
Updates a method call that was renamed in the parent CL.

BUG=843133
TBR=dtrainor@chromium.org,mdjones@chromium.org

Change-Id: I0b9ca1065b226bae2abe115aac383d10fcb49d86
Reviewed-on: https://chromium-review.googlesource.com/1069125Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560651}

Views Textfields do not fire change updates when using SetText(),
breaking any global pasteboard and Find Bar state updates.

This workaround simulates text input, which does fire the events.

BUG=843878,834754

Change-Id: I044e5dbb4961658adf19d509cdf764cdecfbc78c
Reviewed-on: https://chromium-review.googlesource.com/1068266Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560650}